Re: Review Request of 8151282: [TEST_BUG] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails with GTK LnF

2016-03-22 Thread Sergey Bylokhov 

Looks fine.

On 22.03.16 10:38, Avik Niyogi wrote:

Hi All,
Please find webrev with new code fix:
http://cr.openjdk.java.net/~aniyogi/8151282/webrev.02/

With Regards,
Avik Niyogi


On 21-Mar-2016, at 8:07 pm, Sergey Bylokhov
> wrote:

Hi, Avik.
How this test can fail? I do not see any raised exceptions.

On 21.03.16 9:46, Avik Niyogi wrote:

Hi Sergey,
Please review the following code change.
With Regards,
Avik Niyogi

On 19-Mar-2016, at 2:15 am, Alexander Scherbatiy

> wrote:

The fix looks good to me.

Thanks,
Alexandr.

On 14/03/16 16:25, Avik Niyogi wrote:

Hi All,
Please review code changes made as per inputs provided.

http://cr.openjdk.java.net/~aniyogi/8151282/webrev.01/

With Regards,
Avik Niyogi

On 14-Mar-2016, at 10:53 am, Avik Niyogi
<avik.niy...@oracle.com
> wrote:

Hi Sergey,
Seems like it is a delay issue. Will submit test case with a
waitForIdle() fix.

With Regards,
Avik Niyogi

On 10-Mar-2016, at 7:22 pm, Sergey Bylokhov
>
wrote:

Hi, Avik.
A few questions.
- Why webrev contains the new file?
- You marked the test as a mac specific but it is iterates over a
bunch of l It seems it should not be OS specific, but should
check some specific l (which support such icons): Metal, Nimbus,
Aqua, Windows(???). So gtk/motif should be skipped.

On 08.03.16 8:10, Avik Niyogi wrote:

Hi All,

Kindly review the bug fix for JDK 9.

*Bug:*

https://bugs.openjdk.java.net/browse/JDK-8151282

*Webrev:*

_http://cr.openjdk.java.net/~aniyogi/8151282/webrev.00/_
_
_
*Issue:*
The test case failed for GTK LAF.

*Cause:*
The test case was meant to be Mac specific and was missing a jtreg
parameter

*Fix:*
Minor change to test case with @requires tag added to set the fix.

With Regards,
Avik Niyogi



--
Best regards, Sergey.











--
Best regards, Sergey.





--
Best regards, Sergey.

Re: Review Request of 8151282: [TEST_BUG] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails with GTK LnF

2016-03-22 Thread Avik Niyogi 
Hi All,
Please find webrev with new code fix:
http://cr.openjdk.java.net/~aniyogi/8151282/webrev.02/ 


With Regards,
Avik Niyogi

> On 21-Mar-2016, at 8:07 pm, Sergey Bylokhov  
> wrote:
> 
> Hi, Avik.
> How this test can fail? I do not see any raised exceptions.
> 
> On 21.03.16 9:46, Avik Niyogi wrote:
>> Hi Sergey,
>> Please review the following code change.
>> With Regards,
>> Avik Niyogi
>>> On 19-Mar-2016, at 2:15 am, Alexander Scherbatiy
>>> 
>>> >> >> wrote:
>>> 
>>> The fix looks good to me.
>>> 
>>> Thanks,
>>> Alexandr.
>>> 
>>> On 14/03/16 16:25, Avik Niyogi wrote:
 Hi All,
 Please review code changes made as per inputs provided.
 
 http://cr.openjdk.java.net/~aniyogi/8151282/webrev.01/ 
 
 >
 With Regards,
 Avik Niyogi
> On 14-Mar-2016, at 10:53 am, Avik Niyogi
> < >avik.niy...@oracle.com 
> > wrote:
> 
> Hi Sergey,
> Seems like it is a delay issue. Will submit test case with a
> waitForIdle() fix.
> 
> With Regards,
> Avik Niyogi
>> On 10-Mar-2016, at 7:22 pm, Sergey Bylokhov
>>  
>> >> 
>> wrote:
>> 
>> Hi, Avik.
>> A few questions.
>> - Why webrev contains the new file?
>> - You marked the test as a mac specific but it is iterates over a
>> bunch of l It seems it should not be OS specific, but should
>> check some specific l (which support such icons): Metal, Nimbus,
>> Aqua, Windows(???). So gtk/motif should be skipped.
>> 
>> On 08.03.16 8:10, Avik Niyogi wrote:
>>> Hi All,
>>> 
>>> Kindly review the bug fix for JDK 9.
>>> 
>>> *Bug:*
>>> 
>>> https://bugs.openjdk.java.net/browse/JDK-8151282
>>> 
>>> *Webrev:*
>>> 
>>> _http://cr.openjdk.java.net/~aniyogi/8151282/webrev.00/_
>>> _
>>> _
>>> *Issue:*
>>> The test case failed for GTK LAF.
>>> 
>>> *Cause:*
>>> The test case was meant to be Mac specific and was missing a jtreg
>>> parameter
>>> 
>>> *Fix:*
>>> Minor change to test case with @requires tag added to set the fix.
>>> 
>>> With Regards,
>>> Avik Niyogi
>> 
>> 
>> --
>> Best regards, Sergey.
> 
 
>>> 
>> 
> 
> 
> -- 
> Best regards, Sergey.

Re: Review Request of 8151282: [TEST_BUG] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails with GTK LnF

2016-03-21 Thread Sergey Bylokhov 

Hi, Avik.
How this test can fail? I do not see any raised exceptions?

On 21.03.16 9:46, Avik Niyogi wrote:

Hi Sergey,
Please review the following code change.
With Regards,
Avik Niyogi

On 19-Mar-2016, at 2:15 am, Alexander Scherbatiy
> wrote:

The fix looks good to me.

Thanks,
Alexandr.

On 14/03/16 16:25, Avik Niyogi wrote:

Hi All,
Please review code changes made as per inputs provided.

http://cr.openjdk.java.net/~aniyogi/8151282/webrev.01/

With Regards,
Avik Niyogi

On 14-Mar-2016, at 10:53 am, Avik Niyogi
<avik.niy...@oracle.com> wrote:

Hi Sergey,
Seems like it is a delay issue. Will submit test case with a
waitForIdle() fix.

With Regards,
Avik Niyogi

On 10-Mar-2016, at 7:22 pm, Sergey Bylokhov
> wrote:

Hi, Avik.
A few questions.
- Why webrev contains the new file?
- You marked the test as a mac specific but it is iterates over a
bunch of l It seems it should not be OS specific, but should
check some specific l (which support such icons): Metal, Nimbus,
Aqua, Windows(???). So gtk/motif should be skipped.

On 08.03.16 8:10, Avik Niyogi wrote:

Hi All,

Kindly review the bug fix for JDK 9.

*Bug:*

https://bugs.openjdk.java.net/browse/JDK-8151282

*Webrev:*

_http://cr.openjdk.java.net/~aniyogi/8151282/webrev.00/_
_
_
*Issue:*
The test case failed for GTK LAF.

*Cause:*
The test case was meant to be Mac specific and was missing a jtreg
parameter

*Fix:*
Minor change to test case with @requires tag added to set the fix.

With Regards,
Avik Niyogi



--
Best regards, Sergey.











--
Best regards, Sergey.

Re: Review Request of 8151282: [TEST_BUG] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails with GTK LnF

2016-03-21 Thread Sergey Bylokhov 

Hi, Avik.
How this test can fail? I do not see any raised exceptions.

On 21.03.16 9:46, Avik Niyogi wrote:

Hi Sergey,
Please review the following code change.
With Regards,
Avik Niyogi

On 19-Mar-2016, at 2:15 am, Alexander Scherbatiy
> wrote:

The fix looks good to me.

Thanks,
Alexandr.

On 14/03/16 16:25, Avik Niyogi wrote:

Hi All,
Please review code changes made as per inputs provided.

http://cr.openjdk.java.net/~aniyogi/8151282/webrev.01/

With Regards,
Avik Niyogi

On 14-Mar-2016, at 10:53 am, Avik Niyogi
<avik.niy...@oracle.com> wrote:

Hi Sergey,
Seems like it is a delay issue. Will submit test case with a
waitForIdle() fix.

With Regards,
Avik Niyogi

On 10-Mar-2016, at 7:22 pm, Sergey Bylokhov
> wrote:

Hi, Avik.
A few questions.
- Why webrev contains the new file?
- You marked the test as a mac specific but it is iterates over a
bunch of l It seems it should not be OS specific, but should
check some specific l (which support such icons): Metal, Nimbus,
Aqua, Windows(???). So gtk/motif should be skipped.

On 08.03.16 8:10, Avik Niyogi wrote:

Hi All,

Kindly review the bug fix for JDK 9.

*Bug:*

https://bugs.openjdk.java.net/browse/JDK-8151282

*Webrev:*

_http://cr.openjdk.java.net/~aniyogi/8151282/webrev.00/_
_
_
*Issue:*
The test case failed for GTK LAF.

*Cause:*
The test case was meant to be Mac specific and was missing a jtreg
parameter

*Fix:*
Minor change to test case with @requires tag added to set the fix.

With Regards,
Avik Niyogi



--
Best regards, Sergey.











--
Best regards, Sergey.

Re: Review Request of 8151282: [TEST_BUG] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails with GTK LnF

2016-03-21 Thread Avik Niyogi 
Hi Sergey,
Please review the following code change.
With Regards,
Avik Niyogi
> On 19-Mar-2016, at 2:15 am, Alexander Scherbatiy 
>  wrote:
> 
> The fix looks good to me.
> 
> Thanks,
> Alexandr.
> 
> On 14/03/16 16:25, Avik Niyogi wrote:
>> Hi All,
>> Please review code changes made as per inputs provided.
>> 
>> http://cr.openjdk.java.net/~aniyogi/8151282/webrev.01/ 
>> 
>> With Regards,
>> Avik Niyogi
>>> On 14-Mar-2016, at 10:53 am, Avik Niyogi < 
>>> avik.niy...@oracle.com 
>>> > wrote:
>>> 
>>> Hi Sergey,
>>> Seems like it is a delay issue. Will submit test case with a waitForIdle() 
>>> fix.
>>> 
>>> With Regards,
>>> Avik Niyogi
 On 10-Mar-2016, at 7:22 pm, Sergey Bylokhov > wrote:
 
 Hi, Avik.
 A few questions.
 - Why webrev contains the new file?
 - You marked the test as a mac specific but it is iterates over a bunch of 
 l It seems it should not be OS specific, but should check some 
 specific l (which support such icons): Metal, Nimbus, Aqua, 
 Windows(???). So gtk/motif should be skipped.
 
 On 08.03.16 8:10, Avik Niyogi wrote:
> Hi All,
> 
> Kindly review the bug fix for JDK 9.
> 
> *Bug:*
> 
> https://bugs.openjdk.java.net/browse/JDK-8151282 
> 
> 
> *Webrev:*
> 
> _http://cr.openjdk.java.net/~aniyogi/8151282/webrev.00/_ 
> 
> _
> _
> *Issue:*
> The test case failed for GTK LAF.
> 
> *Cause:*
> The test case was meant to be Mac specific and was missing a jtreg 
> parameter
> 
> *Fix:*
> Minor change to test case with @requires tag added to set the fix.
> 
> With Regards,
> Avik Niyogi
 
 
 -- 
 Best regards, Sergey.
>>> 
>> 
>

Re: Review Request of 8151282: [TEST_BUG] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails with GTK LnF

2016-03-14 Thread Avik Niyogi 
Hi All,
Please review code changes made as per inputs provided.

http://cr.openjdk.java.net/~aniyogi/8151282/webrev.01/ 

With Regards,
Avik Niyogi
> On 14-Mar-2016, at 10:53 am, Avik Niyogi  wrote:
> 
> Hi Sergey,
> Seems like it is a delay issue. Will submit test case with a waitForIdle() 
> fix.
> 
> With Regards,
> Avik Niyogi
>> On 10-Mar-2016, at 7:22 pm, Sergey Bylokhov  
>> wrote:
>> 
>> Hi, Avik.
>> A few questions.
>> - Why webrev contains the new file?
>> - You marked the test as a mac specific but it is iterates over a bunch of 
>> l It seems it should not be OS specific, but should check some specific 
>> l (which support such icons): Metal, Nimbus, Aqua, Windows(???). So 
>> gtk/motif should be skipped.
>> 
>> On 08.03.16 8:10, Avik Niyogi wrote:
>>> Hi All,
>>> 
>>> Kindly review the bug fix for JDK 9.
>>> 
>>> *Bug:*
>>> 
>>> https://bugs.openjdk.java.net/browse/JDK-8151282
>>> 
>>> *Webrev:*
>>> 
>>> _http://cr.openjdk.java.net/~aniyogi/8151282/webrev.00/_
>>> _
>>> _
>>> *Issue:*
>>> The test case failed for GTK LAF.
>>> 
>>> *Cause:*
>>> The test case was meant to be Mac specific and was missing a jtreg parameter
>>> 
>>> *Fix:*
>>> Minor change to test case with @requires tag added to set the fix.
>>> 
>>> With Regards,
>>> Avik Niyogi
>> 
>> 
>> -- 
>> Best regards, Sergey.
>

Re: Review Request of 8151282: [TEST_BUG] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails with GTK LnF

2016-03-13 Thread Avik Niyogi 
Hi Sergey,
Seems like it is a delay issue. Will submit test case with a waitForIdle() fix.

With Regards,
Avik Niyogi
> On 10-Mar-2016, at 7:22 pm, Sergey Bylokhov  
> wrote:
> 
> Hi, Avik.
> A few questions.
> - Why webrev contains the new file?
> - You marked the test as a mac specific but it is iterates over a bunch of 
> l It seems it should not be OS specific, but should check some specific 
> l (which support such icons): Metal, Nimbus, Aqua, Windows(???). So 
> gtk/motif should be skipped.
> 
> On 08.03.16 8:10, Avik Niyogi wrote:
>> Hi All,
>> 
>> Kindly review the bug fix for JDK 9.
>> 
>> *Bug:*
>> 
>> https://bugs.openjdk.java.net/browse/JDK-8151282
>> 
>> *Webrev:*
>> 
>> _http://cr.openjdk.java.net/~aniyogi/8151282/webrev.00/_
>> _
>> _
>> *Issue:*
>> The test case failed for GTK LAF.
>> 
>> *Cause:*
>> The test case was meant to be Mac specific and was missing a jtreg parameter
>> 
>> *Fix:*
>> Minor change to test case with @requires tag added to set the fix.
>> 
>> With Regards,
>> Avik Niyogi
> 
> 
> -- 
> Best regards, Sergey.

Re: Review Request of 8151282: [TEST_BUG] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails with GTK LnF

2016-03-10 Thread Sergey Bylokhov 

Hi, Avik.
A few questions.
 - Why webrev contains the new file?
- You marked the test as a mac specific but it is iterates over a bunch 
of l It seems it should not be OS specific, but should check some 
specific l (which support such icons): Metal, Nimbus, Aqua, 
Windows(???). So gtk/motif should be skipped.


On 08.03.16 8:10, Avik Niyogi wrote:

Hi All,

Kindly review the bug fix for JDK 9.

*Bug:*

https://bugs.openjdk.java.net/browse/JDK-8151282

*Webrev:*

_http://cr.openjdk.java.net/~aniyogi/8151282/webrev.00/_
_
_
*Issue:*
The test case failed for GTK LAF.

*Cause:*
The test case was meant to be Mac specific and was missing a jtreg parameter

*Fix:*
Minor change to test case with @requires tag added to set the fix.

With Regards,
Avik Niyogi



--
Best regards, Sergey.

Re: Review Request of 8151282: [TEST_BUG] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails with GTK LnF

2016-03-10 Thread Alexandr Scherbatiy 

The fix looks good to me.

Thanks,
Alexandr.

On 3/7/2016 9:10 PM, Avik Niyogi wrote:

Hi All,

Kindly review the bug fix for JDK 9.

*Bug:*

https://bugs.openjdk.java.net/browse/JDK-8151282

*Webrev:*

_http://cr.openjdk.java.net/~aniyogi/8151282/webrev.00/ 
_

_
_
*Issue:*
The test case failed for GTK LAF.

*Cause:*
The test case was meant to be Mac specific and was missing a jtreg 
parameter


*Fix:*
Minor change to test case with @requires tag added to set the fix.

With Regards,
Avik Niyogi

Review Request of 8151282: [TEST_BUG] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails with GTK LnF

2016-03-07 Thread Avik Niyogi 
Hi All,

Kindly review the bug fix for JDK 9.

Bug:

https://bugs.openjdk.java.net/browse/JDK-8151282 


Webrev:

http://cr.openjdk.java.net/~aniyogi/8151282/webrev.00/ 


Issue:
The test case failed for GTK LAF.

Cause:
The test case was meant to be Mac specific and was missing a jtreg parameter

Fix:
Minor change to test case with @requires tag added to set the fix.

With Regards,
Avik Niyogi