Re: Review request for 8132771: [TEST_BUG][macosx] Test javax/swing/JTree/DnD/LastNodeLowerHalfDrop.java fails for MacOSX

2016-06-03 Thread Rajeev Chamyal 
Looks good to me.

 

Regards,

Rajeev Chamyal

 

From: Avik Niyogi 
Sent: 31 May 2016 13:28
To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net
Subject: Re:  Review request for 8132771: [TEST_BUG][macosx] Test 
javax/swing/JTree/DnD/LastNodeLowerHalfDrop.java fails for MacOSX

 

Hi All,

Please review the code changes with inputs provided.

 

http://cr.openjdk.java.net/~aniyogi/8132771/webrev.01/

 

With Regards,

Avik Niyogi

 

On 31-May-2016, at 1:24 pm, Rajeev Chamyal mailto:rajeev.cham...@oracle.com"rajeev.cham...@oracle.com> wrote:

 

Hello Avik,

 

The frame should be disposed in case of exception also.

 

Regards,

Rajeev Chamyal

 

 

From: Avik Niyogi 
Sent: 31 May 2016 11:14
To: Rajeev Chamyal; Alexander Scherbatiy; HYPERLINK 
"mailto:swing-dev@openjdk.java.net"swing-dev@openjdk.java.net
Subject:  Review request for 8132771: [TEST_BUG][macosx] Test 
javax/swing/JTree/DnD/LastNodeLowerHalfDrop.java fails for MacOSX

 

Hi All,

 

Kindly review the fix for JDK9.

Bug: https://bugs.openjdk.java.net/browse/JDK-8132771

 

Webrev: http://cr.openjdk.java.net/~aniyogi/8132771/webrev.00/

 

Issue: LastNodeLowerHalfDrop Test case throws an exception when the behaviour 
is as expected.

 

Cause: The robot does not have enough delay to run appropriately.

 

Fix: The test case was fixed to have enough delay for the test case.

 

With Regards,

Avik Niyogi

Re: Review request for 8132771: [TEST_BUG][macosx] Test javax/swing/JTree/DnD/LastNodeLowerHalfDrop.java fails for MacOSX

2016-06-01 Thread Alexandr Scherbatiy 


The fix looks good to me.

Thanks,
Alexandr.

On 5/31/2016 10:58 AM, Avik Niyogi wrote:

Hi All,
Please review the code changes with inputs provided.

http://cr.openjdk.java.net/~aniyogi/8132771/webrev.01/ 
<http://cr.openjdk.java.net/%7Eaniyogi/8132771/webrev.01/>


With Regards,
Avik Niyogi

On 31-May-2016, at 1:24 pm, Rajeev Chamyal <rajeev.cham...@oracle.com 
<mailto:rajeev.cham...@oracle.com>> wrote:


Hello Avik,
The frame should be disposed in case of exception also.
Regards,
Rajeev Chamyal
*From:*Avik Niyogi
*Sent:*31 May 2016 11:14
*To:*Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net 
<mailto:swing-dev@openjdk.java.net>
*Subject:* Review request for 8132771: [TEST_BUG][macosx] 
Test javax/swing/JTree/DnD/LastNodeLowerHalfDrop.java fails for MacOSX

Hi All,
Kindly review the fix for JDK9.
*Bug*: https://bugs.openjdk.java.net/browse/JDK-8132771
*Webrev*: http://cr.openjdk.java.net/~aniyogi/8132771/webrev.00/ 
<http://cr.openjdk.java.net/%7Eaniyogi/8132771/webrev.00/>
*Issue*: LastNodeLowerHalfDrop Test case throws an exception when the 
behaviour is as expected.

*Cause*: The robot does not have enough delay to run appropriately.
*Fix*: The test case was fixed to have enough delay for the test case.
With Regards,
Avik Niyogi

Re: Review request for 8132771: [TEST_BUG][macosx] Test javax/swing/JTree/DnD/LastNodeLowerHalfDrop.java fails for MacOSX

2016-05-31 Thread Rajeev Chamyal 
Hello Avik,

 

The frame should be disposed in case of exception also.

 

Regards,

Rajeev Chamyal

 

 

From: Avik Niyogi 
Sent: 31 May 2016 11:14
To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net
Subject:  Review request for 8132771: [TEST_BUG][macosx] Test 
javax/swing/JTree/DnD/LastNodeLowerHalfDrop.java fails for MacOSX

 

Hi All,

 

Kindly review the fix for JDK9.

Bug: https://bugs.openjdk.java.net/browse/JDK-8132771

 

Webrev: http://cr.openjdk.java.net/~aniyogi/8132771/webrev.00/

 

Issue: LastNodeLowerHalfDrop Test case throws an exception when the behaviour 
is as expected.

 

Cause: The robot does not have enough delay to run appropriately.

 

Fix: The test case was fixed to have enough delay for the test case.

 

With Regards,

Avik Niyogi

Review request for 8132771: [TEST_BUG][macosx] Test javax/swing/JTree/DnD/LastNodeLowerHalfDrop.java fails for MacOSX

2016-05-30 Thread Avik Niyogi 
Hi All,

Kindly review the fix for JDK9.
Bug: https://bugs.openjdk.java.net/browse/JDK-8132771 


Webrev: http://cr.openjdk.java.net/~aniyogi/8132771/webrev.00/ 


Issue: LastNodeLowerHalfDrop Test case throws an exception when the behaviour 
is as expected.

Cause: The robot does not have enough delay to run appropriately.

Fix: The test case was fixed to have enough delay for the test case.

With Regards,
Avik Niyogi