Re: [sympy] Implement solvers for symengine

[brijesh vora]

Can someone suggest how to setup development for symengine, so that if I change 
a code in some file I can run the updated symengine easily.

What is the easiest way to do this?

-- 
You received this message because you are subscribed to the Google Groups 
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sympy+unsubscr...@googlegroups.com.
To post to this group, send email to sympy@googlegroups.com.
Visit this group at https://groups.google.com/group/sympy.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sympy/ec0d5c4d-cb19-4a9f-b99a-0628d025ff5e%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [sympy] Implement solvers for symengine

[brijesh vora]

PR-
#16617-https://github.com/sympy/sympy/pull/16617

#16580-https://github.com/sympy/sympy/pull/16580

Can someone please review it.

In the coming days I will send more PR as I couldn't send before the proposal 
time. 

-- 
You received this message because you are subscribed to the Google Groups 
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sympy+unsubscr...@googlegroups.com.
To post to this group, send email to sympy@googlegroups.com.
Visit this group at https://groups.google.com/group/sympy.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sympy/2ef8dd44-8d48-4c32-b97f-e3dc78292414%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [sympy] Implement solvers for symengine

[Ondřej Čertík]

Try to put more details into the timeline, and the section where you describe 
what you want to implement. Also, submit the proposal now, you can still edit 
it afterwards. 

When we review proposals, the patches are very important to show your skills, 
so I suggest you do the modifications above, submit the proposal and then work 
on your patches, you can submit more to sympy, or you can submit some to 
symengine, since your proposal is for that.

On Sun, Apr 7, 2019, at 3:18 PM, brijesh vora wrote:
> I have written a draft proposal, can you please review it.
> https://docs.google.com/document/d/1qLJR_Ojw6M-cqaV8orHun7m7bOhGh1Bjyc7eA_o7Jfc/edit?usp=sharing
>  
> Thanks
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to sympy+unsubscr...@googlegroups.com.
> To post to this group, send email to sympy@googlegroups.com.
> Visit this group at https://groups.google.com/group/sympy.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/sympy/f5809f4f-6363-462c-ae15-fcd612ca4cef%40googlegroups.com
>  
> .
> For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sympy+unsubscr...@googlegroups.com.
To post to this group, send email to sympy@googlegroups.com.
Visit this group at https://groups.google.com/group/sympy.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sympy/341b985a-eabf-4c47-adc6-dc535dfd5ab5%40www.fastmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: [sympy] Implement solvers for symengine

[brijesh vora]

I have written a draft proposal, can you please review it.
https://docs.google.com/document/d/1qLJR_Ojw6M-cqaV8orHun7m7bOhGh1Bjyc7eA_o7Jfc/edit?usp=sharing
 
Thanks

-- 
You received this message because you are subscribed to the Google Groups 
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sympy+unsubscr...@googlegroups.com.
To post to this group, send email to sympy@googlegroups.com.
Visit this group at https://groups.google.com/group/sympy.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sympy/f5809f4f-6363-462c-ae15-fcd612ca4cef%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [sympy] Implement solvers for symengine

[brijesh vora]

In solvers in sympy they have used tuples,list and dict, for returning and 
printing, so whether we have to make 3 separate data structure in c++ which 
functions like tuples,list and dict and can return that. Also once we have 
made it ,it would be easy to use everywhere. 

-- 
You received this message because you are subscribed to the Google Groups 
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sympy+unsubscr...@googlegroups.com.
To post to this group, send email to sympy@googlegroups.com.
Visit this group at https://groups.google.com/group/sympy.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sympy/60fab33f-13e8-475f-8027-5f384c5a7554%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [sympy] Implement solvers for symengine

[brijesh vora]

 So, a user should be given a choice whether he wants to solve a problem 
through sympy or symengine, right? 

-- 
You received this message because you are subscribed to the Google Groups 
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sympy+unsubscr...@googlegroups.com.
To post to this group, send email to sympy@googlegroups.com.
Visit this group at https://groups.google.com/group/sympy.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sympy/7899a72b-7789-43a6-8dc8-7f7d357805e6%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [sympy] Implement solvers for symengine

[brijesh vora]

On Sunday, April 7, 2019 at 9:42:13 PM UTC+5:30, Ondřej Čertík wrote:
>
> Thanks for the PR. I think the first step would be to extend 
> sympy.core.backend to work with solvers and ensure sympy tests pass with 
> symengine on. That way one is using symengine instead of sympy.core, but 
> sympy solvers would still be used.
>
>   : So, a user should be able to use Solvers from symengine or sympy 
depending on his choice, also that choice needs to be added, right? 
 

> The next step would be to rewrite some of the solvers into symengine.
>
> Let me know if you have questions.
>
> On Sun, Apr 7, 2019, at 6:36 AM, brijesh vora wrote:
>
> also can you please can let me know what find of functionality do you want 
> in solvers in symengine , so that I can work on important things first and 
> latter other things
> > 
>
> -- 
> You received this message because you are subscribed to the Google Groups 
> "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to sy...@googlegroups.com.
> To post to this group, send email to sy...@googlegroups.com.
> Visit this group at https://groups.google.com/group/sympy.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/sympy/9ef71528-3eb6-4d58-afe9-9e3735fae010%40googlegroups.com
>  
> <
> https://groups.google.com/d/msgid/sympy/9ef71528-3eb6-4d58-afe9-9e3735fae010%40googlegroups.com?utm_medium=email_source=footer
> >.
> For more options, visit https://groups.google.com/d/optout.
>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sympy+unsubscr...@googlegroups.com.
To post to this group, send email to sympy@googlegroups.com.
Visit this group at https://groups.google.com/group/sympy.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sympy/e9d8fa78-69b6-4d52-a8a2-46bf47227b1b%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [sympy] Implement solvers for symengine

[Ondřej Čertík]

Thanks for the PR. I think the first step would be to extend sympy.core.backend 
to work with solvers and ensure sympy tests pass with symengine on. That way 
one is using symengine instead of sympy.core, but sympy solvers would still be 
used.

The next step would be to rewrite some of the solvers into symengine.

Let me know if you have questions.

On Sun, Apr 7, 2019, at 6:36 AM, brijesh vora wrote:
> also can you please can let me know what find of functionality do you want in 
> solvers in symengine , so that I can work on important things first and 
> latter other things
> > 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to sympy+unsubscr...@googlegroups.com.
> To post to this group, send email to sympy@googlegroups.com.
> Visit this group at https://groups.google.com/group/sympy.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/sympy/9ef71528-3eb6-4d58-afe9-9e3735fae010%40googlegroups.com
>  
> .
> For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sympy+unsubscr...@googlegroups.com.
To post to this group, send email to sympy@googlegroups.com.
Visit this group at https://groups.google.com/group/sympy.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sympy/c416985f-49a7-4201-92ab-72d8f7c75779%40www.fastmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: [sympy] Implement solvers for symengine

[brijesh vora]

also can you please can let me know what find of functionality do you want 
in solvers in symengine , so that I can work on important things first and 
latter other things

>  
>

-- 
You received this message because you are subscribed to the Google Groups 
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sympy+unsubscr...@googlegroups.com.
To post to this group, send email to sympy@googlegroups.com.
Visit this group at https://groups.google.com/group/sympy.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sympy/9ef71528-3eb6-4d58-afe9-9e3735fae010%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [sympy] Implement solvers for symengine

[brijesh vora]

can you please review my PR before 9th april - #16580 


 

-- 
You received this message because you are subscribed to the Google Groups 
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sympy+unsubscr...@googlegroups.com.
To post to this group, send email to sympy@googlegroups.com.
Visit this group at https://groups.google.com/group/sympy.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sympy/91f1f56f-ffcd-4b12-8ec2-3c06bc1b7d5d%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [sympy] Implement solvers for symengine

[Ondřej Čertík]

Per instructions, you have to have at least one PR submitted by April 9.

https://github.com/sympy/sympy/wiki/GSoC-2019-Application-Template#patch-requirement


Ondrej

On Sat, Apr 6, 2019, at 12:31 PM, brijesh vora wrote:
> I was thinking of implementing algebraic and ode solvers. I will upload draft 
> proposal very soon and please do comment about it.
> And regarding the PR Merging ,is it okay if I sent them after 9th april , 
> they will not be written in draft proposal but please do consider it. 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to sympy+unsubscr...@googlegroups.com.
> To post to this group, send email to sympy@googlegroups.com.
> Visit this group at https://groups.google.com/group/sympy.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/sympy/46011082-e72f-4803-96c0-b4c06c05239b%40googlegroups.com
>  
> .
> For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sympy+unsubscr...@googlegroups.com.
To post to this group, send email to sympy@googlegroups.com.
Visit this group at https://groups.google.com/group/sympy.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sympy/046d14fb-d697-42f6-935d-e91ffd17b33f%40www.fastmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: [sympy] Implement solvers for symengine

[brijesh vora]

I was thinking of implementing algebraic and ode solvers. I will upload 
draft proposal very soon and please do comment about it.
And regarding the PR Merging ,is it okay if I sent them after 9th april , 
they will not be written in draft proposal but please do consider it. 

-- 
You received this message because you are subscribed to the Google Groups 
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sympy+unsubscr...@googlegroups.com.
To post to this group, send email to sympy@googlegroups.com.
Visit this group at https://groups.google.com/group/sympy.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sympy/46011082-e72f-4803-96c0-b4c06c05239b%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [sympy] Implement solvers for symengine

[Ondřej Čertík]

Yes, we would like to see such a proposal. Can you write up in details which 
solvers, what algorithms etc? Also don't forget about the patch requirement.

On Sat, Apr 6, 2019, at 8:30 AM, brijesh vora wrote:
> Hi,
> what is the status of this project- Implement solvers for symengine
> 
> I was thinking to implement this in symengine with c++ to improve the 
> performance gain and write tests and bechmark it. 
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to sympy+unsubscr...@googlegroups.com.
> To post to this group, send email to sympy@googlegroups.com.
> Visit this group at https://groups.google.com/group/sympy.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/sympy/15e77b5d-e924-4116-9c1a-010f928b80ee%40googlegroups.com
>  
> .
> For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sympy+unsubscr...@googlegroups.com.
To post to this group, send email to sympy@googlegroups.com.
Visit this group at https://groups.google.com/group/sympy.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sympy/31f9c21c-5403-4a84-9184-39323d563ea4%40www.fastmail.com.
For more options, visit https://groups.google.com/d/optout.

[sympy] Implement solvers for symengine

[brijesh vora]

Hi,
what is the status of this project-  Implement solvers for symengine

I was thinking to implement this in symengine with c++ to improve the 
performance gain and write tests and bechmark it. 

-- 
You received this message because you are subscribed to the Google Groups 
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sympy+unsubscr...@googlegroups.com.
To post to this group, send email to sympy@googlegroups.com.
Visit this group at https://groups.google.com/group/sympy.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sympy/15e77b5d-e924-4116-9c1a-010f928b80ee%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.