[SyncEvolution] Re: Fails to build with boost 1.73.0

[Patrick Ohly]

Milan Crha  writes:

> On Fri, 2020-07-03 at 17:34 +0200, Milan Crha wrote:
>
>> I'd propose a patch, but I do not know a single bit of the boost
>> library.
>
>   Hi,
> it turned out to be a semi-mechanical replace. See the attached
> bind.patch.

Thanks, that looks reasonable. I really should continue my upstream work
on preparing the next release with all of these patches :-/

Bye, Patrick
___
SyncEvolution mailing list -- syncevolution@syncevolution.org
To unsubscribe send an email to syncevolution-le...@syncevolution.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[SyncEvolution] Re: Fails to build with boost 1.73.0

[Milan Crha]

On Fri, 2020-07-03 at 17:34 +0200, Milan Crha wrote:

> I'd propose a patch, but I do not know a single bit of the boost
> library.

Hi,
it turned out to be a semi-mechanical replace. See the attached
bind.patch.

As a bonus, there were these warnings [-Wcatch-value=]:

src/syncevo/SyncContext.cpp: In member function 'SyncEvo::SyncMLStatus 
SyncEvo::SyncContext::doSync()':
src/syncevo/SyncContext.cpp:3816:37: warning: catching polymorphic type 'class 
SyncEvo::TransportException' by value [-Wcatch-value=]
 3816 | } catch (TransportException e) {
src/syncevo/SyncContext.cpp: In member function 'bool 
SyncEvo::SyncContext::checkForScriptAbort(SyncEvo::SharedSession)':
src/syncevo/SyncContext.cpp:4647:14: warning: catching polymorphic type 'class 
SyncEvo::NoSuchKey' by value [-Wcatch-value=]
 4647 | } catch (NoSuchKey) {
src/syncevo/SyncContext.cpp:4651:14: warning: catching polymorphic type 'class 
SyncEvo::BadSynthesisResult' by value [-Wcatch-value=]
 4651 | } catch (BadSynthesisResult) {

for which is attached the catch-value.patch.

Bye,
Milan
diff -up syncevolution-1.5.3/src/backends/activesync/ActiveSyncSource.h.7 syncevolution-1.5.3/src/backends/activesync/ActiveSyncSource.h
--- syncevolution-1.5.3/src/backends/activesync/ActiveSyncSource.h.7	2020-07-07 13:58:12.779492076 +0200
+++ syncevolution-1.5.3/src/backends/activesync/ActiveSyncSource.h	2020-07-07 13:58:30.314408226 +0200
@@ -31,7 +31,7 @@
 #include 
 #include 
 
-#include 
+#include 
 
 #include 
 #include 
@@ -41,6 +41,9 @@
 #include 
 
 #include 
+
+using namespace boost::placeholders;
+
 SE_BEGIN_CXX
 
 
diff -up syncevolution-1.5.3/src/backends/akonadi/akonadisyncsource.cpp.7 syncevolution-1.5.3/src/backends/akonadi/akonadisyncsource.cpp
--- syncevolution-1.5.3/src/backends/akonadi/akonadisyncsource.cpp.7	2018-01-05 16:10:27.0 +0100
+++ syncevolution-1.5.3/src/backends/akonadi/akonadisyncsource.cpp	2020-07-07 13:41:01.828429631 +0200
@@ -41,12 +41,13 @@
 
 #include 
 #include 
-#include 
+#include 
 
 #include 
 
 SE_BEGIN_CXX
 using namespace Akonadi;
+using namespace boost::placeholders;
 
 /**
  * We take over ownership of jobs by storing them in smart pointers
diff -up syncevolution-1.5.3/src/backends/pbap/PbapSyncSource.cpp.7 syncevolution-1.5.3/src/backends/pbap/PbapSyncSource.cpp
--- syncevolution-1.5.3/src/backends/pbap/PbapSyncSource.cpp.7	2018-01-05 16:10:27.0 +0100
+++ syncevolution-1.5.3/src/backends/pbap/PbapSyncSource.cpp	2020-07-07 13:41:01.829429626 +0200
@@ -45,11 +45,14 @@
 #include "gdbus-cxx-bridge.h"
 
 #include 
-#include 
+#include 
 
 #include 
 
 #include 
+
+using namespace boost::placeholders;
+
 SE_BEGIN_CXX
 
 #define OBC_SERVICE "org.openobex.client" // obexd < 0.47
diff -up syncevolution-1.5.3/src/backends/sqlite/SQLiteContactSource.h.7 syncevolution-1.5.3/src/backends/sqlite/SQLiteContactSource.h
--- syncevolution-1.5.3/src/backends/sqlite/SQLiteContactSource.h.7	2014-04-25 09:55:47.0 +0200
+++ syncevolution-1.5.3/src/backends/sqlite/SQLiteContactSource.h	2020-07-07 13:41:01.829429626 +0200
@@ -25,9 +25,12 @@
 #include 
 #include 
 
-#include 
+#include 
 
 #include 
+
+using namespace boost::placeholders;
+
 SE_BEGIN_CXX
 
 #ifdef ENABLE_SQLITE
diff -up syncevolution-1.5.3/src/backends/webdav/CalDAVSource.cpp.7 syncevolution-1.5.3/src/backends/webdav/CalDAVSource.cpp
--- syncevolution-1.5.3/src/backends/webdav/CalDAVSource.cpp.7	2018-01-05 16:10:27.0 +0100
+++ syncevolution-1.5.3/src/backends/webdav/CalDAVSource.cpp	2020-07-07 13:41:01.829429626 +0200
@@ -11,10 +11,13 @@
 
 #include "CalDAVSource.h"
 
-#include 
+#include 
 #include 
 
 #include 
+
+using namespace boost::placeholders;
+
 SE_BEGIN_CXX
 
 /**
diff -up syncevolution-1.5.3/src/backends/webdav/CardDAVSource.cpp.7 syncevolution-1.5.3/src/backends/webdav/CardDAVSource.cpp
--- syncevolution-1.5.3/src/backends/webdav/CardDAVSource.cpp.7	2014-07-23 10:38:16.0 +0200
+++ syncevolution-1.5.3/src/backends/webdav/CardDAVSource.cpp	2020-07-07 13:41:01.830429622 +0200
@@ -7,6 +7,8 @@
 #ifdef ENABLE_DAV
 
 #include 
+
+using namespace boost::placeholders;
 SE_BEGIN_CXX
 
 // TODO: use EDS backend icalstrdup.c
diff -up syncevolution-1.5.3/src/backends/webdav/NeonCXX.cpp.7 syncevolution-1.5.3/src/backends/webdav/NeonCXX.cpp
--- syncevolution-1.5.3/src/backends/webdav/NeonCXX.cpp.7	2015-04-17 11:19:46.0 +0200
+++ syncevolution-1.5.3/src/backends/webdav/NeonCXX.cpp	2020-07-07 13:51:27.319430971 +0200
@@ -15,7 +15,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 
 #include 
@@ -30,6 +30,9 @@
 #include 
 
 #include 
+
+using namespace boost::placeholders;
+
 SE_BEGIN_CXX
 
 namespace Neon {
diff -up syncevolution-1.5.3/src/backends/webdav/WebDAVSource.cpp.7 syncevolution-1.5.3/src/backends/webdav/WebDAVSource.cpp
--- syncevolution-1.5.3/src/backends/webdav/WebDAVSource.cpp.7	2015-04-01 17:14:39.0 +0200
+++