Re: [systemd-devel] [PATCH] travis: Add a travis.yml for doing CI after commits
On Wed, Aug 14, 2013 at 11:15:35PM +0200, Kay Sievers wrote: > I temporarily switched it off now. thanks for the heads up. > Maybe someone has an idea, or an alternative. If David starts to execute "make check && make distcheck" there is probably nothing travis-ci provides that David's setup doesn't. As an alternative I can play catch-up and provide/build additional deps. holger ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] travis: Add a travis.yml for doing CI after commits
On Wed, Aug 14, 2013 at 02:48:07PM -0700, David Strauss wrote: > The CI I maintain [1] for systemd is certainly one alternative that > continues to be in production. I'd like to get more test automation > going, but it's not like TravisCI was running any tests beyond a > successful build. I plan to continue maintaining the Jenkins CI, if Please take a look at the .travis.yml file. It executes make check and make distcheck. Maybe on your jenkins setup you try these two commands as well and check how far you get? holger ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] Hackfest at Linux Plumbers Conference?
On 08/14/2013 11:42 PM, David Strauss wrote: > However, I should ask if we have space formally reserved yet. I'm > willing to go in on costs here if we need that. Linux Foundation is looking into it. Right now they don't have space, but they are trying to find something for us. We should know early/mid next week. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
[systemd-devel] [PATCH 0/3] Z-Shell fixes
Just a redo of the three un-merged patches on the ml at the moment. Nothing really different, just rebased. William Giokas (3): zsh_completion: Allow specifying multiple arguments -- Just rebased. zsh_completion: machinectl properties can be stacked zsh_completion: Remove ctls function from _systemd Makefile.am | 1 + shell-completion/zsh/_machinectl | 2 +- shell-completion/zsh/_systemctl | 16 +++- shell-completion/zsh/_systemd | 174 -- shell-completion/zsh/_systemd-delta | 15 +++ shell-completion/zsh/_systemd-inhibit | 8 +- 6 files changed, 118 insertions(+), 98 deletions(-) create mode 100644 shell-completion/zsh/_systemd-delta -- 1.8.4.rc3.498.g5af1768 ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
[systemd-devel] [PATCH 2/3 v2] zsh_completion: machinectl properties can be stacked
---
shell-completion/zsh/_machinectl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/shell-completion/zsh/_machinectl b/shell-completion/zsh/_machinectl
index aa568e5..abdf46f 100644
--- a/shell-completion/zsh/_machinectl
+++ b/shell-completion/zsh/_machinectl
@@ -35,7 +35,7 @@
_arguments \
{-h,--help}'[Prints a short help text and exits.]' \
'--version[Prints a short version string and exits.]' \
- {-p,--property=}'[Limit output to specified property.]:property:(Name Id
Timestamp TimestampMonotonic Service Scope Leader Class State RootDirectory)' \
+ \*{-p,--property=}'[Limit output to specified property.]:property:(Name Id
Timestamp TimestampMonotonic Service Scope Leader Class State RootDirectory)' \
{-a,--all}'[Show all proerties]' \
(-l,--full)'[Do not ellipsize cgroup members]' \
'--no-pager[Do not pipe output into a pager]' \
--
1.8.4.rc3.498.g5af1768
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] zsh_completion: Remove function from _systemd
On Tue, Aug 13, 2013 at 03:40:01PM -0500, William Giokas wrote: > --- > shell-completion/zsh/_systemd | 163 > -- > 1 file changed, 79 insertions(+), 84 deletions(-) Disregard, in the three patch sent in a bit ago. -- William Giokas | KaiSforza | http://kaictl.net/ GnuPG Key: 0x73CD09CF Fingerprint: F73F 50EF BBE2 9846 8306 E6B8 6902 06D8 73CD 09CF pgpBLZp2FgseG.pgp Description: PGP signature ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
[systemd-devel] [PATCH 3/3 v2] zsh_completion: Remove ctls function from _systemd
The _ctls function in the main _systemd file is not needed.
---
shell-completion/zsh/_systemd | 163 --
1 file changed, 79 insertions(+), 84 deletions(-)
diff --git a/shell-completion/zsh/_systemd b/shell-completion/zsh/_systemd
index fe39de8..e954c3e 100644
--- a/shell-completion/zsh/_systemd
+++ b/shell-completion/zsh/_systemd
@@ -1,88 +1,83 @@
#compdef systemd-cat systemd-ask-password systemd-cgls systemd-cgtop
systemd-detect-virt systemd-machine-id-setup systemd-notify
systemd-tty-ask-password-agent
-_ctls()
-{
-local curcontext="$curcontext" state lstate line
-case "$service" in
-systemd-ask-password)
-_arguments \
-{-h,--help}'[Show this help]' \
-'--icon=[Icon name]' \
-'--timeout=[Timeout in sec]' \
-'--no-tty[Ask question via agent even on TTY]' \
-'--accept-cached[Accept cached passwords]' \
-'--multiple[List multiple passwords if available]'
-;;
-systemd-cat)
-_arguments \
-{-h,--help}'[Show this help]' \
-'--version[Show package version.]' \
-{-t,--identifier=}'[Set syslog identifier.]' \
-{-p,--priority=}'[Set priority value.]:value:({0..7})' \
-'--level-prefix=[Control whether level prefix shall be
parsed.]:boolean:(1 0)' \
-':Message'
-;;
-systemd-cgls)
-_arguments \
-{-h,--help}'[Show this help]' \
-'--version[Show package version]' \
-'--no-pager[Do not pipe output into a pager]' \
-{-a,--all}'[Show all groups, including empty]' \
-'-k[Include kernel threads in output]' \
-':cgroups:(cpuset cpu cpuacct memory devices freezer net_cls
blkio)'
-;;
-systemd-cgtop)
-_arguments \
-{-h,--help}'[Show this help]' \
-'--version[Print version and exit]' \
-'(-c -m -i -t)-p[Order by path]' \
-'(-c -p -m -i)-t[Order by number of tasks]' \
-'(-m -p -i -t)-c[Order by CPU load]' \
-'(-c -p -i -t)-m[Order by memory load]' \
-'(-c -m -p -t)-i[Order by IO load]' \
-{-d,--delay=}'[Specify delay]' \
-{-n,--iterations=}'[Run for N iterations before exiting]' \
-{-b,--batch}'[Run in batch mode, accepting no input]' \
-'--depth=[Maximum traversal depth]'
-;;
-systemd-detect-virt)
-_arguments \
-{-h,--help}'[Show this help]' \
-'--version[Show package version]' \
-{-c,--container}'[Only detect whether we are run in a
container]' \
-{-v,--vm}'[Only detect whether we are run in a VM]' \
-{-q,--quiet}"[Don't output anything, just set return value]"
-;;
-systemd-machine-id-setup)
-_arguments \
-{-h,--help}'[Show this help]' \
-'--version[Show package version]'
-;;
-systemd-notify)
-_arguments \
-{-h,--help}'[Show this help]' \
-'--version[Show package version]' \
-'--ready[Inform the init system about service start-up
completion.]' \
-'--pid=[Inform the init system about the main PID of the
daemon]' \
-'--status=[Send a free-form status string for the daemon to
the init systemd]' \
-'--booted[Returns 0 if the system was booted up with systemd]'
\
-'--readahead=[Controls disk read-ahead
operations]:arguments:(cancel done noreply)'
-;;
-systemd-tty-ask-password-agent)
-_arguments \
-{-h,--help}'[Prints a short help text and exits.]' \
-'--version[Prints a short version string and exits.]' \
-'--list[Lists all currently pending system password
requests.]' \
-'--query[Process all currently pending system password
requests by querying the user on the calling TTY.]' \
-'--watch[Continuously process password requests.]' \
-'--wall[Forward password requests to wall(1).]' \
-'--plymouth[Ask question with plymouth(8).]' \
-'--console[Ask question on /dev/console.]'
-;;
-*) _message 'eh?' ;;
-esac
-}
-
-_ctls "$@"
+local curcontext="$curcontext" state lstate line
+case "$service" in
+systemd-ask-password)
+_arguments \
+{-h,--help}'[Show this help]' \
+'--icon=[Icon name]' \
+'--timeout=[Timeout in sec]' \
+'--no-tty[Ask question via agent even on TTY]' \
+'--accept-cached[Accept cached passwords]' \
+'--multiple[List multiple passwords if available]'
[systemd-devel] [PATCH 1/3 v2] zsh_completion: Allow specifying multiple arguments
Some of the options in systemd can take multiple arguments, such as
systemctl's --type option. Previously, you would only be able to
complete a single type after the -t, but now zsh will continue to
complete the types, separating them by commas.
systemd-inhibit's --what command has colon (:), and that has been taken
into account.
---
Just rebased.
Makefile.am | 1 +
shell-completion/zsh/_systemctl | 16 ++--
shell-completion/zsh/_systemd | 11 +--
shell-completion/zsh/_systemd-delta | 15 +++
shell-completion/zsh/_systemd-inhibit | 8 +++-
5 files changed, 38 insertions(+), 13 deletions(-)
create mode 100644 shell-completion/zsh/_systemd-delta
diff --git a/Makefile.am b/Makefile.am
index 641e92f..5d35993 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -351,6 +351,7 @@ dist_zshcompletion_DATA = \
shell-completion/zsh/_systemd-nspawn \
shell-completion/zsh/_systemd-analyze \
shell-completion/zsh/_sd_hosts_or_user_at_host \
+ shell-completion/zsh/_systemd-delta \
shell-completion/zsh/_systemd
dist_sysctl_DATA = \
diff --git a/shell-completion/zsh/_systemctl b/shell-completion/zsh/_systemctl
index dbe168a..cc2df3c 100644
--- a/shell-completion/zsh/_systemctl
+++ b/shell-completion/zsh/_systemctl
@@ -294,11 +294,23 @@ _outputmodes() {
_describe -t output 'output mode' _output_opts || compadd "$@"
}
+_unit_states() {
+local -a _states
+_states=(loaded failed active inactive not-found listening running waiting
plugged mounted exited dead masked)
+_values -s , "${_states[@]}"
+}
+
+_unit_types() {
+local -a _types
+_types=(automount device mount path service snapshot socket swap target
timer)
+_values -s , "${_types[@]}"
+}
+
_arguments -s \
{-h,--help}'[Show help]' \
'--version[Show package version]' \
-{-t,--type=}'[List only units of a particular type]:unit type:(automount
device mount path service snapshot socket swap target timer)' \
-'--state=[Display units in the specified state]:unit state:(loaded failed
active inactive not-found listening running waiting plugged mounted exited dead
masked)' \
+{-t,--type=}'[List only units of a particular type]:unit type:_unit_types'
\
+'--state=[Display units in the specifyied state]:unit state:_unit_states' \
\*{-p,--property=}'[Show only properties by specific name]:unit property' \
{-a,--all}'[Show all units/properties, including dead/empty ones]' \
'--reverse[Show reverse dependencies]' \
diff --git a/shell-completion/zsh/_systemd b/shell-completion/zsh/_systemd
index 7aab52d..fe39de8 100644
--- a/shell-completion/zsh/_systemd
+++ b/shell-completion/zsh/_systemd
@@ -1,4 +1,4 @@
-#compdef systemd-cat systemd-ask-password systemd-cgls systemd-cgtop
systemd-delta systemd-detect-virt systemd-machine-id-setup systemd-notify
systemd-tty-ask-password-agent
+#compdef systemd-cat systemd-ask-password systemd-cgls systemd-cgtop
systemd-detect-virt systemd-machine-id-setup systemd-notify
systemd-tty-ask-password-agent
_ctls()
{
@@ -45,15 +45,6 @@ _ctls()
{-b,--batch}'[Run in batch mode, accepting no input]' \
'--depth=[Maximum traversal depth]'
;;
-systemd-delta)
-_arguments \
-{-h,--help}'[Show this help]' \
-'--version[Show package version]' \
-'--no-pager[Do not pipe output into a pager]' \
-'--diff=[Show a diff when overridden files differ]:boolean:(1
0)' \
-{-t,--type=}'[Only display a selected set of override
types]:types:(masked equivalent redirected overridden unchanged)' \
-':SUFFIX:(tmpfiles.d sysctl.d systemd/system)'
-;;
systemd-detect-virt)
_arguments \
{-h,--help}'[Show this help]' \
diff --git a/shell-completion/zsh/_systemd-delta
b/shell-completion/zsh/_systemd-delta
new file mode 100644
index 000..6abb6fc
--- /dev/null
+++ b/shell-completion/zsh/_systemd-delta
@@ -0,0 +1,15 @@
+#compdef systemd-delta
+
+_delta_type() {
+local -a _delta_types
+_delta_types=(masked equivalent redirected overridden unchanged)
+_values -s , "${_delta_types[@]}"
+}
+
+_arguments \
+{-h,--help}'[Show this help]' \
+'--version[Show package version]' \
+'--no-pager[Do not pipe output into a pager]' \
+'--diff=[Show a diff when overridden files differ]:boolean:(1 0)' \
+{-t,--type=}'[Only display a selected set of override
types]:types:_delta_type' \
+':SUFFIX:(tmpfiles.d sysctl.d systemd/system)'
diff --git a/shell-completion/zsh/_systemd-inhibit
b/shell-completion/zsh/_systemd-inhibit
index 7953455..1ecb6dc 100644
--- a/shell-completion/zsh/_systemd-inhibit
+++ b/shell-completion/zsh/_systemd-inhibit
@@ -16,10 +16,16 @@ _systemd_inhibit_command(){
fi
}
+_inhibit_what() {
+local _inhibit
+_inhibit=(shutdown sleep i
Re: [systemd-devel] [PATCH] Recognize discard option in /etc/crypttab
On Fri, Aug 09, 2013 at 08:37:52PM +0200, Michael Stapelberg wrote: > Hi, > > forwarding this patch we received in the Debian bugtracker. > > systemd-cryptsetup recognizes option 'allow-discards' in /etc/crypttab > to enable TRIM passthrough to underlying encrypted device. In Debian > this option was changed to 'discard' to avoid hyphen in option name > (see: #648868 and `man crypttab`). > > The attached patch makes “discard” a synonym for “allow-discards” in > /etc/crypttab. Please merge it. Hi, I applied the patch, also making a change in the documentation to prefer "discard" to "allow-discards" (both remain supported of course). I don't think we should care about some script linking dashes or not, but consistency is important, and since various filesystems already use discard, there's no point to differ here. Also "discard" is easier to remember and type than "allow-discards". Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] systemd.unit(5): clarify the Description= contents
On Mon, Aug 12, 2013 at 09:59:41PM +0200, Michael Stapelberg wrote: > Hi, > > Lennart, as discussed during DebConf earlier today, this patch clarifies > what should go into the Description= field. Please merge it :). Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] zsh_completion: Move helper function to autoload
On Mon, Aug 12, 2013 at 12:41:18PM -0500, William Giokas wrote: > _hosts_or_user_at_host was used by 6 different completions, and > previously was in all 6 of those files. I moved it out to its own file, > _sd_hosts_or_user_at_host. This will be autoloaded for use in other > completion functions. It also allows external completions to use this > function by simply calling _sd_hosts_or_user_at_host as in the systemd > completions. Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] fstab-generator: log_oom() if automount_name is null
On Tue, Aug 13, 2013 at 04:38:19PM +0800, WANG Chao wrote: > --- > src/fstab-generator/fstab-generator.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/2] zsh_completion: Allow specifying multiple arguments
On Tue, Aug 13, 2013 at 01:38:28AM -0500, William Giokas wrote: > Some of the options in systemd can take multiple arguments, such as > systemctl's --type option. Previously, you would only be able to > complete a single type after the -t, but now zsh will continue to > complete the types, separating them by commas. Hm, the first one stopped applying. Can you rebase? Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH v3] zsh_completion: Correctly display journal fields
On Wed, Aug 14, 2013 at 01:29:58PM -0500, William Giokas wrote: > Show equals and field values when used with _journal_none, don't show > anything if we're not using _journal_none. Works for me :) Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] Hackfest at Linux Plumbers Conference?
On Wed, Aug 14, 2013 at 11:42 PM, David Strauss wrote: > On Tue, Aug 13, 2013 at 7:36 PM, Zbigniew Jędrzejewski-Szmek > wrote: >> Is this definite? > > With 10 RSVPs, we'll make it happen. I added the G+ event after Kay > said, "The current idea is to do [a hackfest] during the two LinuxCon > days before Plumbers starts." We booked flights today, and will be around from Monday to Friday. The hackfest will be during the LinuxCon days on Monday and Tuesday. Kay ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] travis: Add a travis.yml for doing CI after commits
On Wed, Aug 14, 2013 at 2:15 PM, Kay Sievers wrote: > Maybe someone has an idea, or an alternative. The CI I maintain [1] for systemd is certainly one alternative that continues to be in production. I'd like to get more test automation going, but it's not like TravisCI was running any tests beyond a successful build. I plan to continue maintaining the Jenkins CI, if only to ensure the systemd GitHub mirror is always buildable on the master branch. [1] http://systemd.getpantheon.com/ -- David Strauss | da...@davidstrauss.net | +1 512 577 5827 [mobile] ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] Hackfest at Linux Plumbers Conference?
However, I should ask if we have space formally reserved yet. I'm willing to go in on costs here if we need that. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] Hackfest at Linux Plumbers Conference?
On Tue, Aug 13, 2013 at 7:36 PM, Zbigniew Jędrzejewski-Szmek wrote: > Is this definite? With 10 RSVPs, we'll make it happen. I added the G+ event after Kay said, "The current idea is to do [a hackfest] during the two LinuxCon days before Plumbers starts." -- David Strauss | da...@davidstrauss.net | +1 512 577 5827 [mobile] ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] travis: Add a travis.yml for doing CI after commits
On Thu, Jul 18, 2013 at 7:40 AM, Holger Hans Peter Freyther wrote: > On Wed, Jul 17, 2013 at 05:08:46PM +0200, Kay Sievers wrote: >> >> I did something like that now. Let's see if it works ... > > Thank you, it did[1]. > > [1] https://travis-ci.org/systemd/systemd I temporarily switched it off now. The system it builds on seems to old to have kernel btrfs headers. No idea if that is something that cane be fixed on the travis side, but importing more common things into systemd seems a bit odd, just to make it work on an outdated build system. Maybe someone has an idea, or an alternative. Thanks, Kay ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
[systemd-devel] [PATCH v3] zsh_completion: Correctly display journal fields
Show equals and field values when used with _journal_none, don't show
anything if we're not using _journal_none.
---
This was originally making the -F completion broken, the case statement
below fixes that.
foo@bar:~ % journalctl -F _C
>> possible fields
_CMDLINE _COMM
foo@bar:~ % journalctl -F _COMM
foo@bar:~ % journalctl -F _COMM
foo@bar:~ % journalctl _COMM
foo@bar:~ % journalctl _COMM=
>> possible values
foobarbaz
shell-completion/zsh/_journalctl | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/shell-completion/zsh/_journalctl b/shell-completion/zsh/_journalctl
index 61983d5..212bfdb 100644
--- a/shell-completion/zsh/_journalctl
+++ b/shell-completion/zsh/_journalctl
@@ -19,13 +19,18 @@ _list_fields() {
_KERNEL_{DEVICE,SUBSYSTEM}
_UDEV_{SYSNAME,DEVNODE,DEVLINK}
__CURSOR __{REALTIME,MONOTONIC}_TIMESTAMP)
-_describe 'possible fields' journal_fields
+case $_jrnl_none in
+yes) _values -s '=' 'possible fields' \
+"${journal_fields[@]}:value:_journal_fields
${words[CURRENT]%%=*}" ;;
+*) _describe 'possible fields' journal_fields ;;
+esac
}
_journal_none() {
-local -a _commands _files
+local -a _commands _files _jrnl_none
# Setting use-cache will slow this down considerably
_commands=( ${"$(_call_program commands "$service" -F _EXE 2>/dev/null)"} )
+_jrnl_none='yes'
_alternative : \
'files:/dev files:_files -W /dev -P /dev/' \
"commands:commands:($_commands[@])" \
--
1.8.4.rc3.464.g80e72f1
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH v2] gnome-ask-password-agent: do not double fork spawned process
On Wed, 2013-08-14 at 06:46 +0200, Michael Laß wrote: > pkexec does not like being a lonely child: > "Refusing to render service to dead parents." > > Do not double fork when spawning the process by using the DO_NOT_REAP_CHILD > flag. Clean up manually using a child watch. Pushed, thanks! ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] Impact when not loading ipv6 and autofs kernel module ...
> -Original Message- > From: Lennart Poettering [mailto:lenn...@poettering.net] > Sent: Friday, August 09, 2013 5:49 PM > To: Hoyer, Marko (ADITG/SW2) > Cc: systemd-devel@lists.freedesktop.org > Subject: Re: [systemd-devel] Impact when not loading ipv6 and autofs kernel > module ... > > On Wed, 07.08.13 11:24, Hoyer, Marko (ADITG/SW2) (mho...@de.adit-jv.com) > wrote: > > > Hello systemd developers, > > > > I found that systemd automatically tries to load ipv6 and autofs kernel > modules, when they are not compiled in. > > Could you give me a hint what is not working, when they are neither provided > as kernel modules nor compiled in? > > > > In case of autofs I found that automount units are not working any more (I > would have expected this). Without ipv6 I can't find any problems by now. > > > > So: > > > > > > 1. Is there any other impact but the described one when the > > autofs kernel feature is missing? > > No. .automount units become unavailable, but that's all. > > > 2. What impact do I have to expect in case the kernel does not provide > ipv6 functionality? > > Well, support for IPv6 goes away, of course. The reason we explicitly load the > module at early boot is that we try to configure the loopback device to ::1, > but that can only work if IPv6 is available in the kernel. Doing this kind of > loopback configuration of IPv6 however is not hooked up to the kernel-side > auto-loading of ipv6.ko hence we load it explicitly from usersapce. > > Lennart Thx for the input. For what is systemd using the loopback so that it has to set it up so early? Is there any impact when I'm setting up the loopback later. We are probably in a situation where we need ipv4 for general purposes and ipv6 for only special ones. So we'd like to set up ipv6 later for performance reasons, which concerns especially the module loading. > > -- > Lennart Poettering - Red Hat, Inc. Best regards Marko Hoyer Software Group II (ADITG/SW2) Tel. +49 5121 49 6948 ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] Using the hwdb in external programs
On Wed, Aug 14, 2013 at 1:06 PM, Richard Hughes wrote: > On 14 August 2013 11:41, Kay Sievers wrote: >> An example is here: >> >> http://cgit.freedesktop.org/systemd/systemd/tree/src/test/test-libudev.c#n432 > > Great! Thanks. So I know what to use where, what's the cost of those > functions? It's all in a binary on-disk patricia trie, and all strings are de-duplicated. The lookup cost is almost "free", you should not notice it. > For instance, is udev_hwdb_new() going to use globs of > memory until udev_hwdb_unref() is called, The entire binary database file is mmap()ed into the address space as long as the context exists, no interesting amount of memory is allocated in the calling process or during lookup. > or are any of the functions > especially CPU intensive? The time is spends searching is mostly dependent on the length of the lookup string, and the amount of globs in the database that have common prefixes. None of that should really matter, you can ignore any such issues unless you plan to call it 1000s of time in an inner loop. > I can profile if required, although I'm > hoping the answer is "very little; very little" :) Unless something is wrong, it should be even less than little. :) Kay ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] Using the hwdb in external programs
On 14 August 2013 11:41, Kay Sievers wrote: > An example is here: > > http://cgit.freedesktop.org/systemd/systemd/tree/src/test/test-libudev.c#n432 Great! Thanks. So I know what to use where, what's the cost of those functions? For instance, is udev_hwdb_new() going to use globs of memory until udev_hwdb_unref() is called, or are any of the functions especially CPU intensive? I can profile if required, although I'm hoping the answer is "very little; very little" :) Richard. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] Using the hwdb in external programs
On Wed, Aug 14, 2013 at 12:03 PM, Richard Hughes wrote: > I'm aware of at least half a dozen programs and daemons that read and > parse /usr/share/hwdata/pnp.ids to convert PNP_IDS to actual vendor > names. Although this file will be in hot cache at login, it does seem > a waste of a lot of duplicated parsing and hashing code. I'm aware the > PNP_ID database is used in the hwdb, and hashed in an efficient way. > I'm wondering if external applications (like gnome-settings-daemon) > could use the data there. Sure, that's what the hwdb is there for. Parsing the potentially huge old sequential files over and over is not how things should work today. Just use libudev to lookup the key/value pairs for a given key/string: http://www.freedesktop.org/software/systemd/libudev/libudev-udev-hwdb.html An example is here: http://cgit.freedesktop.org/systemd/systemd/tree/src/test/test-libudev.c#n432 That's what's currently in the db: http://cgit.freedesktop.org/systemd/systemd/tree/hwdb Kay ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
[systemd-devel] Using the hwdb in external programs
Hi all, I'm aware of at least half a dozen programs and daemons that read and parse /usr/share/hwdata/pnp.ids to convert PNP_IDS to actual vendor names. Although this file will be in hot cache at login, it does seem a waste of a lot of duplicated parsing and hashing code. I'm aware the PNP_ID database is used in the hwdb, and hashed in an efficient way. I'm wondering if external applications (like gnome-settings-daemon) could use the data there. Ideas welcome, thanks, Richard. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
[systemd-devel] [PATCH v2] gnome-ask-password-agent: do not double fork spawned process
pkexec does not like being a lonely child:
"Refusing to render service to dead parents."
Do not double fork when spawning the process by using the DO_NOT_REAP_CHILD
flag. Clean up manually using a child watch.
---
src/gnome-ask-password-agent.vala | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/gnome-ask-password-agent.vala
b/src/gnome-ask-password-agent.vala
index 0f6284d..8a5346d 100644
--- a/src/gnome-ask-password-agent.vala
+++ b/src/gnome-ask-password-agent.vala
@@ -213,6 +213,7 @@ public class MyStatusIcon : StatusIcon {
result == ResponseType.DELETE_EVENT)
return;
+Pid child_pid;
int to_process;
try {
@@ -220,12 +221,15 @@ public class MyStatusIcon : StatusIcon {
null,
{ "/usr/bin/pkexec",
"/lib/systemd/systemd-reply-password", result == ResponseType.OK ? "1" : "0",
socket },
null,
-0,
-null,
+SpawnFlags.DO_NOT_REAP_CHILD,
null,
+out child_pid,
out to_process,
null,
null);
+ChildWatch.add(child_pid, (pid, status) => {
+Process.close_pid(pid);
+});
OutputStream stream = new UnixOutputStream(to_process,
true);
#if VALA_0_12
--
1.8.3.4
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
