[systemd-devel] [BUG] 8b255ecd99dfee
Hi, bisect tells me this commit, 8b255ecd99dfee, causes gdm to crash when --enable-kdbus is configured and the kdbus module isn't loaded. Gdm starts but crashes and restarts as you enter your (correct)password. Is this correct? Or am i missing something? ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] udev/net_id: Introduce predictable network names for Linux on System z
Hi Hendrik, On Thu, Jan 9, 2014 at 4:20 PM, Hendrik Brueckner brueck...@redhat.com wrote: Looks good to me (assuming the names are truly stable between boots, as I have no idea about how the internals of this work in the kernel). The bus-IDs do not change across reboots. Great. I pushed the patch just now. Could you also make sure that these things are supported by path_id when you are at it? We use that to reference devices from udev/networkd so makes sense if these things are in sync. Could you provide more information on that. I know that the path_id creates the ID_PATH environment variable for udev. There is already support in path_id for CCW devices used by network devices. I am not sure if that is already sufficient... It is. The only thing I meant to request was that ID_PATH is set whenever ID_NET_NAME_PATH is. The reason for this is that ID_PATH contains the same information, but without e.g. the length restriction that ID_NET_NAME_PATH has. So while using ID_NET_NAME_PATH for the interface name is the right thing to do, it is best to reference it by ID_PATH and not by name, as there are (at least in theory) cases when we are not able to set a persistent interface name despite all our efforts :) So if you have some information, like the output of udevadm test-builtin path_id for a network devices, I can check how s390 behave in this. Anyhow, I would then address this on top of this issue. I have: ID_NET_NAME_PATH=wlp2s0 ID_PATH=pci-:02:00.0-bcma-0 but as long as ID_PATH is being set at all that should be all that's needed. See also Red Hat Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=870859 Would be nice if you could post a summary, as a login is required. The network devices names switched between reboots and the systems where no longer accessible because the ip addresses were configured on the wrong network interface. Thanks, added to the commit message. Cheers, Tom ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] initial sd-dns commit
Hi Daniel, On Mon, Jan 6, 2014 at 12:41 PM, Daniel Buch boogiewasth...@gmail.com wrote: Im hopeing we can continue in-tree since its easier from here, and im unable to get the time i want at the moment. But i will ofcourse continue to help where i can when time permits. I think the file nameing and locations are right? I made a few modifications before pushing, please have a look to see I didn't mess anything up :) We should still update stuff like type/function names to use the sd_dns prefix, but this is a good start. Thanks for your work! Cheers, Tom ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
[systemd-devel] [PATCH] make socket_instantiate_service use cleanup gcc attribute
From: Michael Scherer m...@zarb.org
---
src/core/socket.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/core/socket.c b/src/core/socket.c
index 88599ca..1f2a2c0 100644
--- a/src/core/socket.c
+++ b/src/core/socket.c
@@ -179,7 +179,8 @@ static int socket_arm_timer(Socket *s) {
}
static int socket_instantiate_service(Socket *s) {
-char *prefix, *name;
+_cleanup_free_ char *prefix = NULL;
+_cleanup_free_ char *name = NULL;
int r;
Unit *u;
@@ -199,13 +200,11 @@ static int socket_instantiate_service(Socket *s) {
return -ENOMEM;
r = asprintf(name, %s@%u.service, prefix, s-n_accepted);
-free(prefix);
if (r 0)
return -ENOMEM;
r = manager_load_unit(UNIT(s)-manager, name, NULL, NULL, u);
-free(name);
if (r 0)
return r;
--
1.8.4.2
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [BUG] 8b255ecd99dfee
On Sat, Jan 11, 2014 at 7:49 PM, Daniel Buch boogiewasth...@gmail.com wrote: bisect tells me this commit, 8b255ecd99dfee, causes gdm to crash when --enable-kdbus is configured and the kdbus module isn't loaded. Gdm starts but crashes and restarts as you enter your (correct)password. Is this correct? Or am i missing something? Right, when the variable is exported, the graphical session will not start dbus-dameon anymore, which looks like a crash. On Fedora, the logic is in /etc/X11/xinit/xinitrc.d/00-start-message-bus.sh. I've added a quick check before the export, for kdbus being active, so this should work again. Thanks, Kay ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
[systemd-devel] systemd --user and kdbus
We got systemd git working to be able to run a full GNOME (Fedora 20) user session with kdbus now. Instead of dbus-daemon running and activating applications, they are directly started by the systemd --user instance now. Here is the output of ps: http://people.freedesktop.org/~kay/kdbus-user.txt The automatically activated proxies will go away as soon as glib, and possibly libdbus-1, are ported to connect natively to kdbus instead of the unix socket, The X login session needs to export $DISPLAY to systemd --user. Something like this should take care of that: --- $ cat /etc/X11/xinit/xinitrc.d/systemd-user.sh #!/bin/sh systemctl --user set-environment DISPLAY=$DISPLAY --- Kay ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
[systemd-devel] [PATCH] keymap: Add Toshiba Satellite P75-A7200
--- hwdb/60-keyboard.hwdb | 8 1 file changed, 8 insertions(+) diff --git a/hwdb/60-keyboard.hwdb b/hwdb/60-keyboard.hwdb index 0119568..0907955 100644 --- a/hwdb/60-keyboard.hwdb +++ b/hwdb/60-keyboard.hwdb @@ -1015,6 +1015,14 @@ keyboard:name:Toshiba*input*device:dmi:bvn*:bvr*:bd*:svnTOSHIBA*:pnSATELLITEU940 KEYBOARD_KEY_13e=switchvideomode KEYBOARD_KEY_13f=f21 # Touchpad toggle +# Satellite P75-A7200 +keyboard:name:Toshiba*input*device:dmi:bvn*:bvr*:bd*:svnTOSHIBA*:pnSatellite*P75-A:pvr* + KEYBOARD_KEY_13c=brightnessdown + KEYBOARD_KEY_13d=brightnessup + KEYBOARD_KEY_13e=switchvideomode + KEYBOARD_KEY_13f=touchpad_toggle + KEYBOARD_KEY_9e=wlan + ### # VIA ### -- 1.8.4.2 ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] keymap: Add Toshiba Satellite P75-A7200
I didn't realize that the patch I upload to RedHat's bugzilla was already adapted and commited. My apologies. On Sat, Jan 11, 2014 at 8:53 PM, Unai Uribarri una...@gmail.com wrote: --- hwdb/60-keyboard.hwdb | 8 1 file changed, 8 insertions(+) diff --git a/hwdb/60-keyboard.hwdb b/hwdb/60-keyboard.hwdb index 0119568..0907955 100644 --- a/hwdb/60-keyboard.hwdb +++ b/hwdb/60-keyboard.hwdb @@ -1015,6 +1015,14 @@ keyboard:name:Toshiba*input*device:dmi:bvn*:bvr*:bd*:svnTOSHIBA*:pnSATELLITEU940 KEYBOARD_KEY_13e=switchvideomode KEYBOARD_KEY_13f=f21 # Touchpad toggle +# Satellite P75-A7200 +keyboard:name:Toshiba*input*device:dmi:bvn*:bvr*:bd*:svnTOSHIBA*:pnSatellite*P75-A:pvr* + KEYBOARD_KEY_13c=brightnessdown + KEYBOARD_KEY_13d=brightnessup + KEYBOARD_KEY_13e=switchvideomode + KEYBOARD_KEY_13f=touchpad_toggle + KEYBOARD_KEY_9e=wlan + ### # VIA ### -- 1.8.4.2 ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [Patch 0/2] logind: make sure that closed sessions will be cleaned
On Fri, Jan 03, 2014 at 02:19:19PM +0100, Djalal Harouni wrote: On logout pam_systemd should ensures the following: If the last concurrent session of a user ends, the $XDG_RUNTIME_DIR directory and all its contents are removed, too. from manpage. Using git HEAD, and a simple systemd-nspawn test will show that the above is not ensured and the sessions will stay! I can't reproduce this (with todays git). In the examples below, I understand that you're logging in through getty. Can you test with current git and/or provide a complete recipe to reproduce this? Zbyszek A simple systemd-nspawn test: 1) login as user X 2) logout 3) login as user Y 4) loginctl (will list session of user X) In this example we are session c4: -bash-4.2# loginctl list-sessions SESSIONUID USER SEAT 1 1000 tixxdz seat0 c1 1000 tixxdz seat0 c2 0 root seat0 c3 1000 tixxdz seat0 c4 0 root seat0 ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] systemd --user and kdbus
Waa, all of these tenthousand bus proxies ... ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] gpt-auto-generator: skip nonexistent devices
On Tue, Jan 07, 2014 at 03:00:22PM +0100, Łukasz Stelmach wrote: Hi, The devices we work with have eMMC chips for storage. The chips provide four hardware partitions. The first is /dev/mmcblk0, it takes almost whole space and holds a GPT with several real partitions (/dev/mmcblk0p?). Then there are three block devices (mmcblk0boot0, mmcblk0boot1, rpmb) that are part of the same hardware as mmcblk0 that are presented by the kernel as children of the latter. That relationship makes gpt-auto-generator try to peek them but since they are not GPT partitions blkid_do_safeprobe() returns -2 making verify_gpt_parition() function return -ENODEV. Applied, after fixing to work with current git :) I am not sure both -1 and -2 returned by blkid_do_safeprobe() should result in -ENODEV in verify_gpt_parition(), however, -ENODEV does not mean IMHO we should stop iterating udev results in enumerate_partitions(). It's +1 and -2, which have the same meaning for us. I changed this to EBADSLT because ENODEV is misleading. Signed-off-by: Łukasz Stelmach l.stelm...@samsung.com No need for that. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] systemd --user and kdbus
On Sat, Jan 11, 2014 at 6:04 PM, Kay Sievers k...@vrfy.org wrote: We got systemd git working to be able to run a full GNOME (Fedora 20) user session with kdbus now. Instead of dbus-daemon running and activating applications, they are directly started by the systemd --user instance now. Here is the output of ps: http://people.freedesktop.org/~kay/kdbus-user.txt The automatically activated proxies will go away as soon as glib, and possibly libdbus-1, are ported to connect natively to kdbus instead of the unix socket, The X login session needs to export $DISPLAY to systemd --user. Something like this should take care of that: --- $ cat /etc/X11/xinit/xinitrc.d/systemd-user.sh #!/bin/sh systemctl --user set-environment DISPLAY=$DISPLAY Nice stuff, works for me. Cheers, Tom ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [Patch 0/2] logind: make sure that closed sessions will be cleaned
On Sat, Jan 11, 2014 at 10:26:13PM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Fri, Jan 03, 2014 at 02:19:19PM +0100, Djalal Harouni wrote: On logout pam_systemd should ensures the following: If the last concurrent session of a user ends, the $XDG_RUNTIME_DIR directory and all its contents are removed, too. from manpage. Using git HEAD, and a simple systemd-nspawn test will show that the above is not ensured and the sessions will stay! I can't reproduce this (with todays git). In the examples below, I understand that you're logging in through getty. Can you test with current git and/or provide a complete recipe to reproduce this? Yes through getty, and I guess this issue will also be visible for ssh/remote sessions, or sessions where TerminateSession() is not called. Ok, testing both a fedora 20 systemd and git! Using the Testing in a Container from: www.freedesktop.org/wiki/Software/systemd/VirtualizedTesting/ On a fedora 19 system, I installed a Fedora 20: yum --releasever=20 --installroot=$HOME/fedora-tree-20 ... $ cat /home/tixxdz/fedora-tree-20/etc/redhat-release Fedora release 20 (Heisenbug) I set the root password, disable pam_loginuid.so and boot as shown in the Testing in a Container doc 1) login as root 2) logout 3) login as root (again) -bash-4.2# loginctl SESSIONUID USER SEAT 1 0 root seat0 c1 0 root seat0 2 sessions listed. As you can see the closed sessions are not cleaned. So I confirm the bug from testing a Fedora 20 container. Now from git 8042e377b8bb8f:! I just do: $ ./autogen.sh ./configure --disable-kdbus --libdir=/usr/lib64 $ make -j8 # DESTDIR=/home/tixxdz/fedora-tree make install # systemd-nspawn -bD /home/tixxdz/fedora-tree/ 3 Please note that: /usr/lib64 is needed since it will not be set automatically. It will be set by distributions and packagers of systemd So I make sure that pam_systemd modules are in /usr/lib64/security instead of /usr/lib/security, since only the ones that are in /usr/lib64/security are loaded. Hmm a guess, perhaps the old pam_systemd that got installed by the systemd rpm package is being loaded instead of the new compiled one! *Coupled* with graphical display managers who perhaps kill this bug by forcing a TerminateSession() vs getty logins! So using today git 8042e377b8 I also confirm the same bug. Please Zbyszek let me know if the pervious Testing in a Container using a Fedora 20 (a new systemd version), shows something for you? or perhaps check the timestamp of your *assumed right* /usr/lib64/security/pam_systemd.so after make install ? Thanks Zbyszek! -- Djalal Harouni http://opendz.org ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
