Re: [systemd-devel] [212] systemd-networkd crashes with simple network config

2014-04-01 Thread Tom Gundersen 
On Tue, Apr 1, 2014 at 8:41 AM, Kai Krakow hurikha...@gmail.com wrote:
 Tom Gundersen t...@jklm.no schrieb:

 Thanks, that's useful. I'll have a look.

 Steven's patch should have fixed this issue (the invalid read/write,
 no idea about Conditional jump or move depends on uninitialised
 value(s).

 Care to try again?

 Yeah, it does. Thanks!

 Looks like you pushed a few other commits fixing valgrind issues?

Yeah, this issue made me play a bit more with valgrind and found a
couple of other issues.

-t
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] Requiring hardware device and escaping device names

2014-04-01 Thread Andrey Borzenkov 
On Tue, Apr 1, 2014 at 6:45 AM, Kai Hendry hen...@webconverger.com wrote:
 On 31 March 2014 09:54, Kai Hendry hen...@webconverger.com wrote:
 Not sure what to try next? If I start it manually `sudo systemctl
 start shkd@-dev-input-event0.service`, it starts working again. Is
 http://www.freedesktop.org/software/systemd/man/systemd.service.html#TimeoutSec=
 the right way to proceed? Not sure.

 RestartSec=5 did the trick! Not sure why systemd gives up trying to
 restart a process, despite Restart=always
 http://ix.io/bog


Using Bind on device name would be more logical. In this case systemd
would stop service when deviced disappeared and restart when it
appears again. This avoids permanent restart loop when device is not
present.


 Still don't understand where

 [hendry@alarmpi ~]$ systemctl status
 shkd@sys-devices-platform-bcm2708_usb-usb1-1\x2d1-1\x2d1.2-1\x2d1.2.2-1\x2d1.2.2:1.0-input-input1.service
 shkd@sys-devices-platform-bcm2708_usb-usb1-1x2d1-1x2d1.2-1x2d1.2.2-1x2d1.2.2:1.0-input-input1.service
 - Simple HotKey Daemon
Loaded: loaded (/etc/systemd/system/shkd@.service; disabled)
Active: inactive (dead)

 Comes from.



From systemctl status. As soon as unit is mentioned anywhere the
stub for it is internally created by systemd (it resolves actual unit
on-disk definition lazily). So your own command creates it :)
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH] build-sys: workaround scan-build bug to fix ./autogen.sh s

2014-04-01 Thread Daniel Buch 
It seems to be a clang-analyzer problem since it don't behave like
clang-compiler regarding -std={c99,gnu99}
---
 autogen.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/autogen.sh b/autogen.sh
index 9b4781c..449a2e6 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -72,7 +72,7 @@ elif [ x$1 = xl ]; then
 $topdir/configure CC=clang CFLAGS='-g -O0 -ftrapv -Wno-gnu' 
--enable-compat-libs --enable-kdbus $args
 make clean
 elif [ x$1 = xs ]; then
-scan-build $topdir/configure CFLAGS='-g -O0 -ftrapv' 
--enable-compat-libs --enable-kdbus $args
+scan-build $topdir/configure CFLAGS='-std=gnu99 -g -O0 -ftrapv' 
--enable-compat-libs --enable-kdbus $args
 scan-build make
 else
 echo
-- 
1.9.1

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] seat 0 provided by standalone X server (Xspice, xvnc)

2014-04-01 Thread David Jaša 

Hi,

I'm looking at clean solution how to create additional seat for
standalone, self-contained X server (one X server per seat, X server
does not rely on any physical hardware). Such X server are xvnc or
Xspice. I could find a dated howto for such a configuration:
http://zeusville.wordpress.com/2012/01/27/setting-up-vncserver-on-fedora-16/
and two oldish related bugs from time of logind transition:
https://bugzilla.redhat.com/show_bug.cgi?id=896648
https://bugzilla.redhat.com/show_bug.cgi?id=988030
some 1ft overview of multi-seat with systemd-logind:
http://www.freedesktop.org/wiki/Software/systemd/multiseat/
and it's detailed dbus interface:
http://www.freedesktop.org/wiki/Software/systemd/logind/

What I miss is a general overview of how should things work together.
More specifically:

1) How to define other seat that uses another X server? IMO it should be
necessary to define that just in .service file because X servers like
Xspice don't need other inputs or outputs than those they do provide for
themselves

2) How can *dm fit for servers running in such seat  0? If they are
seat-aware, can they learn their seat information just from the
environment?

3) (not sure if in systemd (logind?) scope) is it possible to block
multiple graphical logins for a single user? I'm afraid that DE's and
desktop applications arent written generally in a way that would allow
concurrent sessions of the same user so it should be blocked

4) could systemd somehow allocate DISPLAY variables and/or network
ports? It would make sense to run these services instantiated and
systemd as a service manager seems to be the natural fit

This would be just a beginning but let's see if it is possible to create
such network seats using systemd

David

PS: please keep me, Jeremy and Alon in CC, we're not subscribed to the
list.

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] build-sys: workaround scan-build bug to fix ./autogen.sh s

2014-04-01 Thread Thomas H.P. Andersen 
On Tue, Apr 1, 2014 at 3:00 PM, Daniel Buch boogiewasth...@gmail.com wrote:
 It seems to be a clang-analyzer problem since it don't behave like
 clang-compiler regarding -std={c99,gnu99}
 ---
  autogen.sh | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/autogen.sh b/autogen.sh
 index 9b4781c..449a2e6 100755
 --- a/autogen.sh
 +++ b/autogen.sh
 @@ -72,7 +72,7 @@ elif [ x$1 = xl ]; then
  $topdir/configure CC=clang CFLAGS='-g -O0 -ftrapv -Wno-gnu' 
 --enable-compat-libs --enable-kdbus $args
  make clean
  elif [ x$1 = xs ]; then
 -scan-build $topdir/configure CFLAGS='-g -O0 -ftrapv' 
 --enable-compat-libs --enable-kdbus $args
 +scan-build $topdir/configure CFLAGS='-std=gnu99 -g -O0 -ftrapv' 
 --enable-compat-libs --enable-kdbus $args
  scan-build make
  else
  echo
 --
 1.9.1

Applied. This also fixed the same problem with clang 3.4 on rawhide.

Thanks.
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH] networkd: drop routes when lease expires

2014-04-01 Thread Umut Tezduyar Lindskog 
---
 src/network/networkd-link.c |   22 ++
 1 file changed, 22 insertions(+)

diff --git a/src/network/networkd-link.c b/src/network/networkd-link.c
index 973755a..4e0fe0a 100644
--- a/src/network/networkd-link.c
+++ b/src/network/networkd-link.c
@@ -579,8 +579,11 @@ static int link_set_mtu(Link *link, uint32_t mtu) {
 
 static int dhcp_lease_lost(Link *link) {
 _cleanup_address_free_ Address *address = NULL;
+_cleanup_route_free_ Route *route_gw = NULL;
+_cleanup_route_free_ Route *route = NULL;
 struct in_addr addr;
 struct in_addr netmask;
+struct in_addr gateway;
 unsigned prefixlen;
 int r;
 
@@ -593,8 +596,27 @@ static int dhcp_lease_lost(Link *link) {
 if (r = 0) {
 sd_dhcp_lease_get_address(link-dhcp_lease, addr);
 sd_dhcp_lease_get_netmask(link-dhcp_lease, netmask);
+sd_dhcp_lease_get_router(link-dhcp_lease, gateway);
 prefixlen = net_netmask_to_prefixlen(netmask);
 
+r = route_new_dynamic(route_gw);
+if (r = 0) {
+route_gw-family = AF_INET;
+route_gw-dst_addr.in = gateway;
+route_gw-dst_prefixlen = 32;
+route_gw-scope = RT_SCOPE_LINK;
+
+route_drop(route_gw, link, route_drop_handler);
+}
+
+r = route_new_dynamic(route);
+if (r = 0) {
+route-family = AF_INET;
+route-in_addr.in = gateway;
+
+route_drop(route, link, route_drop_handler);
+}
+
 address-family = AF_INET;
 address-in_addr.in = addr;
 address-prefixlen = prefixlen;
-- 
1.7.10.4

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel