Re: [systemd-devel] [PATCH][Resend][RFC] core: Fix wrong timestamps in rtc-in-local time mode.
Thanks David! Yes, I missed Lennart's reply. Thanks Lennart! Yes, I agree rtc-in-local-time is a compatibility hack. But I think similar issues in other components is orthogonal to this bug. The key is that systemd records _inconsistent_ timestamps. It's surely a logic _error_ introduced in commit 3a170f3d3358135a39ac6eafe66f18aef0bd67d, even though this bug appears in compatibility hack. rtc-in-utc is orthogonal too. In contrast, using rtc-in-utc is a workaround in this situation. Since we provide the compatibility, we have to fix it. Best Regards, Chunhui He On 12/23/2014 09:28 PM, David Herrmann wrote: Hi On Thu, Dec 18, 2014 at 3:33 PM, Chunhui He hchun...@mail.ustc.edu.cn wrote: Hi all, When the system is configured to read the RTC time in the local time zone, some timestamps recorded by systemd are wrong. Apparently, you never received Lennart's reply on your original mail. Below, you can find his original comment. Thanks David Quoting Lennart: I am not really convinced that we really should try to make this work. rtc-in-local-time has so many issues, it really doesn't stop here. If people make use of this, then this is what they get really, and I am not sure we really should work around it. I mean, systemd really isn't the only component which might query the clock this early, in the initrd there might be a ton of other components too, and it's not realistic to add similar kludges to them all. In general: rtc-in-local-time is a compatibility hack, and we only want to support it to the minimal level necessary for compatibility, but not more. The proper fix for this problem I guess is to use rtc-in-utc instead! Sorry if that's disappointing, Lennart ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] Variable expansion in ConditionPathExists
On Wed, Dec 24, 2014 at 10:37:50AM -0200, Marcos Felipe Rasia de Mello wrote: Hi, I have a system service that runs with a normal user account ([Service] User=bla). I tried [Unit] ConditionPathExists=$HOME/config.xml but it does not work: systemd[1]: [/etc/systemd/system/bla.service:4] Path in condition not absolute, ignoring: $HOME/config.xml %h also does not work (expand to /root). I am running systemd-216-12.fc21.x86_64. It is not crucial to my service, still can be useful perhaps? Hi, unfortunately %h is not really supported anymore. Man page should be updated, since it's rather misleading at the moment. It was removed in systemd 209: * %h, %s, %U specifier support is not available anymore when used in unit files for PID 1. This is because NSS calls are not safe from PID 1. They stay available for --user instances of systemd, and as special case for the root user. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] Variable expansion in ConditionPathExists
On Thu, Dec 25, 2014 at 03:36:15PM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Dec 24, 2014 at 10:37:50AM -0200, Marcos Felipe Rasia de Mello wrote: Hi, I have a system service that runs with a normal user account ([Service] User=bla). I tried [Unit] ConditionPathExists=$HOME/config.xml but it does not work: systemd[1]: [/etc/systemd/system/bla.service:4] Path in condition not absolute, ignoring: $HOME/config.xml %h also does not work (expand to /root). I am running systemd-216-12.fc21.x86_64. It is not crucial to my service, still can be useful perhaps? Hi, unfortunately %h is not really supported anymore. Man page should be updated, since it's rather misleading at the moment. It was removed in systemd 209: * %h, %s, %U specifier support is not available anymore when used in unit files for PID 1. This is because NSS calls are not safe from PID 1. They stay available for --user instances of systemd, and as special case for the root user. The manpage *did* already say that %h does not work, but it a somewhat roundabout way. I now added a seperate paragraph which describes why it shouldn't be used. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 0/9] capabilities: remove include of sys/capability.h where possible
On Tue, Dec 23, 2014 at 10:45:07AM -0800, Filipe Brandenburger wrote: On Tue, Dec 23, 2014 at 5:23 AM, David Herrmann dh.herrm...@gmail.com wrote: I cannot find these patches on systemd-devel@lists.freedesktop.org. This might be due to fdo mail-server issues, or me just being incapable of searching through my emails... Anyway, would you mind resending those? Yeah, it seems I was having trouble... Looks like I fixed it, at least I can see the messages I just resent on the mailing list archive. While at it, they look like you can merge all this into a single patch. I see. The main reason for it was that I used the commit description to document that it is safe to remove from every place. If you'd really like I can squash them all myself or feel free to squash them while applying, that's certainly fine with me. I pushed the patches as is. I like the commit messages describing why each change is OK. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCHv2] test: do not use last cap from kernel in test-cap-list
On Tue, Dec 23, 2014 at 01:51:40PM -0800, Filipe Brandenburger wrote: The new test-cap-list introduced in commit 2822da4fb7f891 uses the included table of capabilities. However, it uses cap_last_cap() which probes the kernel for the last available capability. On an older kernel (e.g. 3.10 from RHEL 7) that causes the test to fail with the following message: Assertion '!capability_to_name(cap_last_cap()+1)' failed at src/test/test-cap-list.c:30, function main(). Aborting. Fix it by exporting the size of the static table and using it in the test instead of the dynamic one from the current kernel. Tested by successfully running ./test-cap-list and the whole `make check` test suite with this patch on a RHEL 7 host. --- v2: Updated the patch to also consider the changes introduced in commit 4b7c1d5d6a0060 (test-cap-list: always check libcap comes to the same names...) Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCHv2] update .gitignore to include test-lldp
On Tue, Dec 23, 2014 at 10:51:54AM -0800, Filipe Brandenburger wrote: --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 1b5d60f..078fd9a 100644 --- a/.gitignore +++ b/.gitignore @@ -207,6 +207,7 @@ /test-libudev-sym* /test-list /test-unaligned +/test-lldp /test-locale-util /test-local-addresses /test-log -- This was already fixed independnently by Lennart. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] doc: os-release: mention all shell characters that must be escaped
On Wed, Dec 24, 2014 at 02:46:20PM +0200, Mantas Mikulėnas wrote: Since the manpage already talks about shell-compatibility, it should be more accurate about what needs to be escaped and how. --- Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCHv2 2/2] build-sys: remove references to dbusinterfacedir
On Tue, Dec 23, 2014 at 10:59:15AM -0800, Filipe Brandenburger wrote: This directory is not used by systemd. Tested by running a full build, running `make install` and comparing the file list in the target trees and making sure that `make distcheck` still works. --- configure.ac | 7 --- 1 file changed, 7 deletions(-) Both applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] timesync: remove square(), use pow instead
On Tue, Dec 23, 2014 at 05:52:51PM -0300, Cristian Rodríguez wrote: In any case, the compiler generates the same code inline and never actually calls the library function. Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/3] machined: add org.freedesktop.machine1.policy.in to POTFILES.in
On Tue, Dec 23, 2014 at 03:02:14PM -0800, Filipe Brandenburger wrote: The new polkit file was introduced in commit d04c1fb8e21560 (machined: introduce polkit for OpenLogin() call). Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 2/3] build-sys: update path in reference to sd-lldp.h
On Tue, Dec 23, 2014 at 03:03:21PM -0800, Filipe Brandenburger wrote: The file was moved from src/libsystemd-network to src/systemd in commit 7a6f1457462840 (sd-lldp: minor header cleanup). This fixes make distcheck. Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 2/2] udev: fix another strict aliasing issue
On Tue, Dec 23, 2014 at 03:04:37PM -0800, Shawn Paul Landden wrote: --- src/udev/ata_id/ata_id.c | 62 +++- 1 file changed, 30 insertions(+), 32 deletions(-) Both applied. I made a follow up commit to remove an uint64_t* temp variable. The compiler was complaining about the cast, though I don't really understand why. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 2/2] test: wait for cloned thread to exit
On Tue, Dec 23, 2014 at 10:15:49AM -0800, Filipe Brandenburger wrote: In test_raw_clone, make sure the cloned thread calls _exit() and in the parent thread call waitpid(..., __WCLONE) to wait for the child thread to terminate, otherwise there is a race condition where the child thread will log to the console after the test process has already exited and the assertion from the child thread might not be enforced. The absence of this patch might also create problems for other tests that would be added after this one, since potentially both parent and child would run those tests as the child would continue running. Tested by confirming that the logs from the child are printed before the test terminates and that a false assertion in the child aborts the test with a core dump. Applied 2/2. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/2] test: only use assert_se in test_raw_clone
On Tue, Dec 23, 2014 at 10:14:46AM -0800, Filipe Brandenburger wrote: The asserts used in the tests should never be allowed to be optimized away. Applied 1/2 too. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] Variable expansion in ConditionPathExists
2014-12-25 14:18 GMT-02:00 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl: On Thu, Dec 25, 2014 at 03:36:15PM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Dec 24, 2014 at 10:37:50AM -0200, Marcos Felipe Rasia de Mello wrote: Hi, I have a system service that runs with a normal user account ([Service] User=bla). I tried [Unit] ConditionPathExists=$HOME/config.xml but it does not work: systemd[1]: [/etc/systemd/system/bla.service:4] Path in condition not absolute, ignoring: $HOME/config.xml %h also does not work (expand to /root). I am running systemd-216-12.fc21.x86_64. It is not crucial to my service, still can be useful perhaps? Hi, unfortunately %h is not really supported anymore. Man page should be updated, since it's rather misleading at the moment. It was removed in systemd 209: * %h, %s, %U specifier support is not available anymore when used in unit files for PID 1. This is because NSS calls are not safe from PID 1. They stay available for --user instances of systemd, and as special case for the root user. The manpage *did* already say that %h does not work, but it a somewhat roundabout way. I now added a seperate paragraph which describes why it shouldn't be used. Thank you. It is clarified now. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
[systemd-devel] Delegate=yes and user instance's resource controlling
Hi! Judging from commit a931ad47a8623163a29d898224d8a8c1177ffdaf, the systemd user instance is intentionally restricted from touching !systemd hierarchies. So, things like systemctl --user set-property foo.service MemoryLimit=XYZ do not work. Is this restriction going to be lifted in the future? If not, are there any alternative ways to achieve resource controlling per-user-service? Thanks in advance. -- Ivan Shapovalov / intelfx / signature.asc Description: This is a digitally signed message part. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] gummiboot: freeing the wrong variable
On Mon, Dec 22, 2014 at 9:44 PM, David Härdeman da...@hardeman.nu wrote: The error path in efivar_get free's what would have been the copy of the string if the strcpy had succeeded, which it did not (or we wouldn't be in the error path). Applied. Thanks, Kay ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 0/5] Enhancements to libabc template project
On Sat, Dec 6, 2014 at 11:46 PM, Josh Triplett j...@joshtriplett.org wrote: I went to use libabc as the basis for a new library, and found a few issues; rather than just correcting them in my own library, I'd like to push the changes back into libabc. Josh Triplett (5): Makefile.am: Don't add abc subdirectory to include path Makefile.am: Don't define LIBEXECDIR autogen.sh: set -e separately, rather than putting -e in the shebang line m4/.gitignore: Remove stray blank line. Remove FSF mailing address All five patches applied. Thanks, Kay ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 1/4] path-lookup, systemctl: export lookup_paths_init_from_scope() from shared/install.c and use it
On Friday 19 December 2014 at 17:08:07, Ivan Shapovalov wrote: --- src/shared/install.c | 16 src/shared/path-lookup.c | 16 src/shared/path-lookup.h | 4 src/systemctl/systemctl.c | 6 +- 4 files changed, 21 insertions(+), 21 deletions(-) [...] Ping? -- Ivan Shapovalov / intelfx / signature.asc Description: This is a digitally signed message part. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 0/5] Enhancements to libabc template project
On Thu, Dec 25, 2014 at 10:20:14PM +0100, Kay Sievers wrote: On Sat, Dec 6, 2014 at 11:46 PM, Josh Triplett j...@joshtriplett.org wrote: I went to use libabc as the basis for a new library, and found a few issues; rather than just correcting them in my own library, I'd like to push the changes back into libabc. Josh Triplett (5): Makefile.am: Don't add abc subdirectory to include path Makefile.am: Don't define LIBEXECDIR autogen.sh: set -e separately, rather than putting -e in the shebang line m4/.gitignore: Remove stray blank line. Remove FSF mailing address All five patches applied. Thanks! - Josh Triplett ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
