Re: [systemd-devel] [PATCH v2] logind: add standard gpio power button support

2015-08-02 Thread systemd github import bot 
Patchset imported to github.
To create a pull request, one of the main developers has to initiate one via:


--
Generated by https://github.com/haraldh/mail2git
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH v2] logind: add standard gpio power button support

2015-08-02 Thread Kefeng Wang 
Many boards like hisilicon D02 board use standard gpio key to power down system.
A description of gpio-key in dts shown below,

gpio_keys {
compatible = "gpio-keys";
#address-cells = <1>;
#size-cells = <0>;

pwrbutton {
label = "Power Button";
gpios = <&porta 8 1>;
linux,code = <116>;  // KEY_POWER, used by SC System Power Down
};
};

-bash-4.3# udevadm info -a /dev/input/event3

Udevadm info starts with the device specified by the devpath and then
walks up the chain of parent devices. It prints for every device
found, all possible attributes in the udev rules key format.
A rule to match, can be composed by the attributes of the device
and the attributes from one single parent device.

  looking at device '/devices/platform/gpio_keys/input/input3/event3':
KERNEL=="event3"
SUBSYSTEM=="input"
DRIVER==""

  looking at parent device '/devices/platform/gpio_keys/input/input3':
KERNELS=="input3"
SUBSYSTEMS=="input"
DRIVERS==""
ATTRS{name}=="gpio_keys"
ATTRS{phys}=="gpio-keys/input0"
ATTRS{uniq}==""
ATTRS{properties}=="0"

  looking at parent device '/devices/platform/gpio_keys':
KERNELS=="gpio_keys"
SUBSYSTEMS=="platform"
DRIVERS=="gpio-keys"
ATTRS{keys}=="116"
ATTRS{switches}==""
ATTRS{driver_override}=="(null)"
ATTRS{disabled_keys}==""
ATTRS{disabled_switches}==""

  looking at parent device '/devices/platform':
KERNELS=="platform"
SUBSYSTEMS==""
DRIVERS==""
---
 src/login/70-power-switch.rules |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/login/70-power-switch.rules b/src/login/70-power-switch.rules
index 695d246..71f9fe6 100644
--- a/src/login/70-power-switch.rules
+++ b/src/login/70-power-switch.rules
@@ -11,5 +11,7 @@ SUBSYSTEM=="input", KERNEL=="event*", SUBSYSTEMS=="acpi", 
TAG+="power-switch"
 SUBSYSTEM=="input", KERNEL=="event*", KERNELS=="thinkpad_acpi", 
TAG+="power-switch"
 SUBSYSTEM=="input", KERNEL=="event*", ATTRS{name}=="twl4030_pwrbutton", 
TAG+="power-switch"
 SUBSYSTEM=="input", KERNEL=="event*", ATTRS{name}=="tps65217_pwr_but", 
TAG+="power-switch"
+SUBSYSTEM=="input", KERNEL=="event*", \
+  SUBSYSTEMS=="platform", DRIVERS=="gpio-keys", ATTRS{keys}=="116", 
TAG+="power-switch"
 
 LABEL="power_switch_end"
-- 
1.7.1


___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] Failed at step RUNTIME_DIRECTORY spawning /usr/bin/true: File exists

2015-08-02 Thread Reindl Harald 


Am 27.07.2015 um 21:39 schrieb Lennart Poettering:

On Wed, 15.07.15 16:24, Reindl Harald (h.rei...@thelounge.net) wrote:


why does systemd *randomly* try to create "RuntimeDirectory"
for "ExecStartPost" and so terminates a perfectly up and running service
because the "file exists" error?

Fedora 21 as well as Fedora 22
https://bugzilla.redhat.com/show_bug.cgi?id=1226509#c3

Jul 15 16:19:43 rawhide systemd: Stopping Test Unit...
Jul 15 16:19:43 rawhide systemd: Stopped Test Unit.
Jul 15 16:19:43 rawhide systemd: Starting Test Unit...
Jul 15 16:19:43 rawhide systemd: Failed at step RUNTIME_DIRECTORY spawning
/usr/bin/true: File exists
Jul 15 16:19:43 rawhide systemd: test2.service: control process exited,
code=exited status=233
Jul 15 16:19:43 rawhide systemd: Failed to start Test Unit.
Jul 15 16:19:43 rawhide systemd: Unit test2.service entered failed state.
Jul 15 16:19:43 rawhide systemd: test2.service failed.


Can you file an issue about this on github with a reproducer for v221
or v222? Thanks!


the reproducer is in 
https://bugzilla.redhat.com/show_bug.cgi?id=1226509#c3 just a few lines 
of a systemd-unit


dunno if this affects v221 and v222 too - Fedora user
but it is very likely since it exists from v216 to v219

why not just dig in the code and remove that completly useless "file 
exists" check instead be happy that the folder is already there?




signature.asc
Description: OpenPGP digital signature
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] I have installed systemd

2015-08-02 Thread noisyb 

Hello,

I have installed systemd and must say I am impressed with the speed of a 
reboot.
I did actually reboot my machine just to see how fast that goes. Nice 
work. Thank you.


I heard that there is a little controversy going on. Mostly messages 
from haters who are not as impressed by systemd as I am. So I don't care 
about that. systemd is great.


But what really amazes me is how you guys are willing to take 
/responsibility/ for almost everything except the kernel and the user 
actions. I mean systemd does /everything/.


So with Lennart Poettering being the most visible. I would want to 
address him personally:


Ich hoffe du guckst dir jede Aenderung in systemd persoenlich an.
Denn mit all den Abhaengigkeiten hast du da eine Menge Verantwortung auf 
dich geladen.

Ist dir das bewusst? Wolltest du das? Denkst du an diese Verantwortung?
Wenn es irgendeine Sicherheitsluecke gibt die mit systemd zu tun hat 
wird dein Name wahrscheinlich als erstes fallen.


I don't care about an answer. I am fine that this will /probably/ be 
read by the right people. Their reactions or answers don't matter to me 
and no further communication is necessary.



Dirk
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel