Re: [systemd-devel] [PATCH] hwdb: Add Thinkpad X1 carbon 3rd gen to 70-pointingstick.hwdb

[Hans de Goede]

Hi,

On 14-09-15 14:28, Daniel Mack wrote:

On 09/14/2015 02:16 PM, Hans de Goede wrote:

Like many other recent thinkpads the factory default pointingstick
sensitivity on these devices is quite low, making the pointingstick
very slow in moving the cursor.

This extends the existing hwdb rules for tweaking the sensitivity to
also apply to the X1 carbon 3rd gen model.

BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1200717


Care to open a GitHub PR for this?


I know systemd has moved to github, but requesting a pullreq for
any trivial fix ? That introduces a large obstacle for casual contributors
to systemd.

Sorry, but I'm not going to do this, but due to -ENOTIME and because I
believe that requesting people who take the time to submit a patch to
take yet another step, rather then welcoming the patch, sends a completely
wrong signal.

Regards,

Hans






Thanks,
Daniel




---
  hwdb/70-pointingstick.hwdb | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/hwdb/70-pointingstick.hwdb b/hwdb/70-pointingstick.hwdb
index 8e674b1..9d288e3 100644
--- a/hwdb/70-pointingstick.hwdb
+++ b/hwdb/70-pointingstick.hwdb
@@ -100,6 +100,8 @@ evdev:name:TPPS/2 IBM 
TrackPoint:dmi:bvn*:bvr*:bd*:svnLENOVO:pn*:pvrThinkPadT440
  evdev:name:TPPS/2 IBM 
TrackPoint:dmi:bvn*:bvr*:bd*:svnLENOVO:pn*:pvrThinkPadT540p:*
  # Lenovo Thinkpad T550 / W550s
  evdev:name:TPPS/2 IBM 
TrackPoint:dmi:bvn*:bvr*:bd*:svnLENOVO:pn*:pvrThinkPadT550:*
+# Lenovo Thinkpad X1 Carbon 3rd gen
+evdev:name:TPPS/2 IBM 
TrackPoint:dmi:bvn*:bvr*:bd*:svnLENOVO:pn*:pvrThinkPadX1Carbon3rd:*
POINTINGSTICK_SENSITIVITY=200
POINTINGSTICK_CONST_ACCEL=1.0





___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] hwdb: Add Thinkpad X1 carbon 3rd gen to 70-pointingstick.hwdb

[systemd github import bot]

Patchset imported to github.
To create a pull request, one of the main developers has to initiate one via:


--
Generated by https://github.com/haraldh/mail2git
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] hwdb: Add Thinkpad X1 carbon 3rd gen to 70-pointingstick.hwdb

[Daniel Mack]

On 09/14/2015 02:16 PM, Hans de Goede wrote:
> Like many other recent thinkpads the factory default pointingstick
> sensitivity on these devices is quite low, making the pointingstick
> very slow in moving the cursor.
> 
> This extends the existing hwdb rules for tweaking the sensitivity to
> also apply to the X1 carbon 3rd gen model.
> 
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1200717

Care to open a GitHub PR for this?


Thanks,
Daniel



> ---
>  hwdb/70-pointingstick.hwdb | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hwdb/70-pointingstick.hwdb b/hwdb/70-pointingstick.hwdb
> index 8e674b1..9d288e3 100644
> --- a/hwdb/70-pointingstick.hwdb
> +++ b/hwdb/70-pointingstick.hwdb
> @@ -100,6 +100,8 @@ evdev:name:TPPS/2 IBM 
> TrackPoint:dmi:bvn*:bvr*:bd*:svnLENOVO:pn*:pvrThinkPadT440
>  evdev:name:TPPS/2 IBM 
> TrackPoint:dmi:bvn*:bvr*:bd*:svnLENOVO:pn*:pvrThinkPadT540p:*
>  # Lenovo Thinkpad T550 / W550s
>  evdev:name:TPPS/2 IBM 
> TrackPoint:dmi:bvn*:bvr*:bd*:svnLENOVO:pn*:pvrThinkPadT550:*
> +# Lenovo Thinkpad X1 Carbon 3rd gen
> +evdev:name:TPPS/2 IBM 
> TrackPoint:dmi:bvn*:bvr*:bd*:svnLENOVO:pn*:pvrThinkPadX1Carbon3rd:*
>POINTINGSTICK_SENSITIVITY=200
>POINTINGSTICK_CONST_ACCEL=1.0
>  
> 

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH] hwdb: Add Thinkpad X1 carbon 3rd gen to 70-pointingstick.hwdb

[Hans de Goede]

Like many other recent thinkpads the factory default pointingstick
sensitivity on these devices is quite low, making the pointingstick
very slow in moving the cursor.

This extends the existing hwdb rules for tweaking the sensitivity to
also apply to the X1 carbon 3rd gen model.

BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1200717
---
 hwdb/70-pointingstick.hwdb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hwdb/70-pointingstick.hwdb b/hwdb/70-pointingstick.hwdb
index 8e674b1..9d288e3 100644
--- a/hwdb/70-pointingstick.hwdb
+++ b/hwdb/70-pointingstick.hwdb
@@ -100,6 +100,8 @@ evdev:name:TPPS/2 IBM 
TrackPoint:dmi:bvn*:bvr*:bd*:svnLENOVO:pn*:pvrThinkPadT440
 evdev:name:TPPS/2 IBM 
TrackPoint:dmi:bvn*:bvr*:bd*:svnLENOVO:pn*:pvrThinkPadT540p:*
 # Lenovo Thinkpad T550 / W550s
 evdev:name:TPPS/2 IBM 
TrackPoint:dmi:bvn*:bvr*:bd*:svnLENOVO:pn*:pvrThinkPadT550:*
+# Lenovo Thinkpad X1 Carbon 3rd gen
+evdev:name:TPPS/2 IBM 
TrackPoint:dmi:bvn*:bvr*:bd*:svnLENOVO:pn*:pvrThinkPadX1Carbon3rd:*
   POINTINGSTICK_SENSITIVITY=200
   POINTINGSTICK_CONST_ACCEL=1.0
 
-- 
2.4.3

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] tmp.mount inactive => /tmp not mounted

[Aaron_Wright]

Andrei Borzenkov  wrote on 09/12/2015 12:37:03 AM:
> 12.09.2015 03:51, aaron_wri...@selinc.com пишет:
> > I recently switched to using systemd in my initrd, and nearly 
everything
> > works fine, expect now the system comes up without /tmp being mounted
> > correctly. I'm not sure where to start looking. Can anyone nudge me in 
the
> > right direction?
> >
> 
> Yes, that's possible. Why do you include tmp.mount in initrd in the 
> first place? Did you try to skip it? What initrd implementation do you 
use?

I'm rolling my own initrd for an embedded product. I install the same 
systemd in rootfs and in initrd, and it didn't occur to me remove some 
units from the initrd install, but you were absolutely correct; I just 
needed to remove the tmp.mount unit from initrd and the whole boot started 
working correctly. Thank you so much for getting me on the right track.
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] Incorrect use return value of mount_one in mount_setup_early/mount_setup?

[cee1]

Hi all,

mount_one will return 1 if a mount action is performed; 0 for no mount
performed; and <0 for an error occurred. Right?

In mount_setup, we have the following logic:
"""
for (i = 0; i < ELEMENTSOF(mount_table); i ++) {
int j;

j = mount_one(mount_table + i, loaded_policy);

if (r == 0)
r = j;

}

if (r < 0)
return r;
"""

That means the first non-zero return value determines the return value
of mount_setup - If a mount is performed successfully in
mount_one(which set r to 1), an error in next call of mount_one will
*NOT* be detected(since r == 1). Is this the expected behavior?



-- 
Regards,

- cee1
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel