Re: [systemd-devel] [PATCH][V2] rpcbind.service: Not pulling the rpcbind.target

2017-12-15 Thread Steve Dickson


On 12/15/2017 09:52 AM, Lennart Poettering wrote:
> On Fr, 15.12.17 08:00, Steve Dickson (ste...@redhat.com) wrote:
> 
>> According to systemd.special(7) manpage:
>>
>> rpcbind.target
>> The portmapper/rpcbind pulls in this target and orders itself
>> before it, to indicate its availability. systemd automatically
>> adds dependencies of type After= for this target unit to
>> all SysV init script service units with an LSB header
>> referring to the "$portmap" facility.
>>
>> Signed-off-by: Steve Dickson 
>> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1431574
>> ---
>>  systemd/rpcbind.service.in | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/systemd/rpcbind.service.in b/systemd/rpcbind.service.in
>> index f8cfa9f..9dbc82c 100644
>> --- a/systemd/rpcbind.service.in
>> +++ b/systemd/rpcbind.service.in
>> @@ -6,8 +6,8 @@ RequiresMountsFor=@statedir@
>>  
>>  # Make sure we use the IP addresses listed for
>>  # rpcbind.socket, no matter how this unit is started.
>> -Wants=rpcbind.socket
>> -After=rpcbind.socket
>> +Requires=rpcbind.socket
>> +Before=rpcbind.target
> 
> You should still pull in rpcbind.target as the man page
> says. i.e. "Wants=rpcbind.target" really should be there.
Duly noted... and changed!

thanks!

steved.
> 
> Lennart
> 
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] [PATCH][V2] rpcbind.service: Not pulling the rpcbind.target

2017-12-15 Thread Lennart Poettering
On Fr, 15.12.17 08:00, Steve Dickson (ste...@redhat.com) wrote:

> According to systemd.special(7) manpage:
> 
> rpcbind.target
> The portmapper/rpcbind pulls in this target and orders itself
> before it, to indicate its availability. systemd automatically
> adds dependencies of type After= for this target unit to
> all SysV init script service units with an LSB header
> referring to the "$portmap" facility.
> 
> Signed-off-by: Steve Dickson 
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1431574
> ---
>  systemd/rpcbind.service.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/systemd/rpcbind.service.in b/systemd/rpcbind.service.in
> index f8cfa9f..9dbc82c 100644
> --- a/systemd/rpcbind.service.in
> +++ b/systemd/rpcbind.service.in
> @@ -6,8 +6,8 @@ RequiresMountsFor=@statedir@
>  
>  # Make sure we use the IP addresses listed for
>  # rpcbind.socket, no matter how this unit is started.
> -Wants=rpcbind.socket
> -After=rpcbind.socket
> +Requires=rpcbind.socket
> +Before=rpcbind.target

You should still pull in rpcbind.target as the man page
says. i.e. "Wants=rpcbind.target" really should be there.

Lennart

-- 
Lennart Poettering, Red Hat
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] "bootctl install" on mdadm raid 1 fails

2017-12-15 Thread Andrei Borzenkov
On Thu, Dec 14, 2017 at 2:11 PM, Lennart Poettering
 wrote:
> On Do, 14.12.17 11:55, D.S. Ljungmark (spi...@aanstoot.se) wrote:
>
>> Right, and _that_ causes a far less interesting output from blkid.
>>
>> /dev/md0: UUID="1492-1FE7" VERSION="FAT32" TYPE="vfat"
>> USAGE="filesystem"
>
> uh, why does it output "/dev/md0" as device for this? did you invoke
> it for /dev/md0p1 or for /dev/md0?
>

This thread is about pure software MD RAID over partitions.
Partitioned MD RAID usually is associated with firmware array and
likely is handled correctly by firmware as single logical disk, so
should for practical purposes be fine.
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel


[systemd-devel] [PATCH][V2] rpcbind.service: Not pulling the rpcbind.target

2017-12-15 Thread Steve Dickson
According to systemd.special(7) manpage:

rpcbind.target
The portmapper/rpcbind pulls in this target and orders itself
before it, to indicate its availability. systemd automatically
adds dependencies of type After= for this target unit to
all SysV init script service units with an LSB header
referring to the "$portmap" facility.

Signed-off-by: Steve Dickson 
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1431574
---
 systemd/rpcbind.service.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/systemd/rpcbind.service.in b/systemd/rpcbind.service.in
index f8cfa9f..9dbc82c 100644
--- a/systemd/rpcbind.service.in
+++ b/systemd/rpcbind.service.in
@@ -6,8 +6,8 @@ RequiresMountsFor=@statedir@
 
 # Make sure we use the IP addresses listed for
 # rpcbind.socket, no matter how this unit is started.
-Wants=rpcbind.socket
-After=rpcbind.socket
+Requires=rpcbind.socket
+Before=rpcbind.target
 
 [Service]
 Type=notify
-- 
2.14.3

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] sdbus-c++, an open source C++ library on top of sd-bus

2017-12-15 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Dec 14, 2017 at 11:09:02AM +, Stanislav Angelovic wrote:
> Hi all,
> 
> I would like to let you know that sdbus-c++, our in-house C++ binding for 
> sd-bus library, has been published open-source at 
> https://github.com/Kistler-Group/sdbus-cpp in hope that it will be useful.

Cool. I added a link in
https://www.freedesktop.org/wiki/Software/systemd/#relatedpackages

Zbyszek
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel