Re: [systemd-devel] [PATCH] [RFC] umount: reduce verbosity
On Fri, 24.04.15 12:37, Jonathan Boulle (jonathanbou...@gmail.com) wrote: Naive question, perhaps, but why does systemd even need to umount when being run in a mount namespace? Can't we let the kernel tear them down when it exits? Well, so far our intention there was to ensure that the codepaths we use inside a container and on bare-metal are as as close as possible, and only deviate where there's really no other sensible way. I mean, let's not forget that nspawn originally was created as a testing ground for our pid 1 code, so that we didn't have to physically reboot all the time just to test it. Hence: unless there's a really good reason to do something different inside a container than on the host we will always opt for the same codepaths. (Also, if there's some code that readlly needs to be different inside a container, we'll try to avoid conditionalizing on the fact wether things are in a container or not, but much rather on the actual feature that is missing/different in a container, for example a missing capability or such) When rkt is started with --debug, the systemd logs are printed. When rkt is started without --debug, systemd is started with --log-target=null in order to mute the logs. That generally sounds a bit extreme... do you have another suggestion? :-) Log the output but redirect it somewhere useful so that the user can look at it if he wants, but so that it isn't shown all the time? Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] [RFC] umount: reduce verbosity
Naive question, perhaps, but why does systemd even need to umount when being run in a mount namespace? Can't we let the kernel tear them down when it exits? When rkt is started with --debug, the systemd logs are printed. When rkt is started without --debug, systemd is started with --log-target=null in order to mute the logs. That generally sounds a bit extreme... do you have another suggestion? :-) ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] [RFC] umount: reduce verbosity
On Mon, 13.04.15 13:13, Alban Crequy (alban.cre...@gmail.com) wrote: From: Alban Crequy al...@endocode.com When a systemd-nspawn container terminates, systemd umounts all bind mounts that were mounted in the container and generates a log for each umount. This additional log_info was added by bce93b7ac7642426039863493694d8c12812e2a7 for debugging shutdown. But surely log_debug is enough. I don't want to see them when when systemd is started with --log-target=null. There are other log_info that I would like to mute on --log-target=null. Is changing log_info to log_debug the correct approach? Hmm, I kinda like these messages I must say, because they actually help users if the shutdown hangs. Hmm, if you specify --log-target=null then then the messages should go nowhere anyway. We actually pass the log target setting from systemd to the shutdown binary via a command line. Are you suggesting that this doesn't work correctly? That#s something to debug first, I figure? This patch is useful for: https://github.com/coreos/rkt/issues/690 When rkt is started with --debug, the systemd logs are printed. When rkt is started without --debug, systemd is started with --log-target=null in order to mute the logs. That generally sounds a bit extreme... Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
[systemd-devel] [PATCH] [RFC] umount: reduce verbosity
From: Alban Crequy al...@endocode.com
When a systemd-nspawn container terminates, systemd umounts all bind
mounts that were mounted in the container and generates a log for each
umount.
This additional log_info was added by
bce93b7ac7642426039863493694d8c12812e2a7 for debugging shutdown. But
surely log_debug is enough.
I don't want to see them when when systemd is started with --log-target=null.
There are other log_info that I would like to mute on --log-target=null.
Is changing log_info to log_debug the correct approach?
This patch is useful for:
https://github.com/coreos/rkt/issues/690
When rkt is started with --debug, the systemd logs are printed. When rkt
is started without --debug, systemd is started with --log-target=null in
order to mute the logs.
---
src/core/umount.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/core/umount.c b/src/core/umount.c
index bee267a..b5a466c 100644
--- a/src/core/umount.c
+++ b/src/core/umount.c
@@ -401,7 +401,7 @@ static int mount_points_list_umount(MountPoint **head, bool
*changed, bool log_e
/* Trying to umount. We don't force here since we rely
* on busy NFS and FUSE file systems to return EBUSY
* until we closed everything on top of them. */
-log_info(Unmounting %s., m-path);
+log_debug(Unmounting %s., m-path);
if (umount2(m-path, 0) == 0) {
if (changed)
*changed = true;
--
2.1.4
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
