Re: [systemd-devel] [PATCH] build-sys: make hibernation support configure option also handle hybrid-sleep; fix indentation

2014-10-22 Thread Lennart Poettering
On Tue, 09.09.14 01:40, Ivan Shapovalov (intelfx...@gmail.com) wrote:

 The patch by Umut did miss at least hybrid-sleep -- it involves hibernation
 as well (hybrid sleep is a hibernation followed by S3 rather than S4 
 powerdown).
 
 Also, it messed up indentation a bit (Makefile.am seems to use tabs), which I
 fixed as well.

This patch was applied a while back by Tom. Thanks!

 And I wonder, maybe it makes sense to conditionalize sleep (suspend) support 
 as well
 as hibernation? Or are there use-cases when suspend is possible, but not 
 hibernation?

Yes, suspend is much better supported thatn hibernation, usually.

I'd take a patch to make it optional too, I guess.

Lennart

-- 
Lennart Poettering, Red Hat
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] [PATCH] build-sys: make hibernation support configure option also handle hybrid-sleep; fix indentation

2014-09-11 Thread Ivan Shapovalov
On Tuesday 09 September 2014 at 01:40:51, Ivan Shapovalov wrote:
 ---
 The patch by Umut did miss at least hybrid-sleep -- it involves hibernation
 as well (hybrid sleep is a hibernation followed by S3 rather than S4 
 powerdown).
 
 Also, it messed up indentation a bit (Makefile.am seems to use tabs), which I
 fixed as well.
 
 And I wonder, maybe it makes sense to conditionalize sleep (suspend) support 
 as well
 as hibernation? Or are there use-cases when suspend is possible, but not 
 hibernation?
 
  Makefile.am | 27 +--
  1 file changed, 13 insertions(+), 14 deletions(-)
 
 diff --git a/Makefile.am b/Makefile.am
 [...]

Ping.

-- 
Ivan Shapovalov / intelfx /

signature.asc
Description: This is a digitally signed message part.
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


[systemd-devel] [PATCH] build-sys: make hibernation support configure option also handle hybrid-sleep; fix indentation

2014-09-08 Thread Ivan Shapovalov
---
The patch by Umut did miss at least hybrid-sleep -- it involves hibernation
as well (hybrid sleep is a hibernation followed by S3 rather than S4 powerdown).

Also, it messed up indentation a bit (Makefile.am seems to use tabs), which I
fixed as well.

And I wonder, maybe it makes sense to conditionalize sleep (suspend) support as 
well
as hibernation? Or are there use-cases when suspend is possible, but not 
hibernation?

 Makefile.am | 27 +--
 1 file changed, 13 insertions(+), 14 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 35c877f..de40043 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -459,7 +459,6 @@ dist_systemunit_DATA = \
units/network-online.target \
units/nss-lookup.target \
units/nss-user-lookup.target \
-   units/hybrid-sleep.target \
units/poweroff.target \
units/reboot.target \
units/rescue.target \
@@ -523,7 +522,6 @@ nodist_systemunit_DATA = \
units/emergency.service \
units/rescue.service \
units/user@.service \
-   units/systemd-hybrid-sleep.service \
units/systemd-suspend.service \
units/systemd-halt.service \
units/systemd-poweroff.service \
@@ -579,7 +577,6 @@ EXTRA_DIST += \
units/systemd-fsck-root.service.in \
units/u...@.service.in \
units/debug-shell.service.in \
-   units/systemd-hybrid-sleep.service.in \
units/systemd-suspend.service.in \
units/quotaon.service.in \
units/initrd-parse-etc.service.in \
@@ -2159,17 +2156,17 @@ systemd_system_update_generator_LDADD = \
 # 
--
 if ENABLE_HIBERNATE
 systemgenerator_PROGRAMS += \
-systemd-hibernate-resume-generator
+   systemd-hibernate-resume-generator
 
 rootlibexec_PROGRAMS += \
-systemd-hibernate-resume
+   systemd-hibernate-resume
 
 systemd_hibernate_resume_SOURCES = \
-src/hibernate-resume/hibernate-resume.c
+   src/hibernate-resume/hibernate-resume.c
 
 systemd_hibernate_resume_LDADD = \
-libsystemd-internal.la \
-libsystemd-shared.la
+   libsystemd-internal.la \
+   libsystemd-shared.la
 
 systemd_hibernate_resume_generator_SOURCES = \
src/hibernate-resume/hibernate-resume-generator.c
@@ -2179,16 +2176,18 @@ systemd_hibernate_resume_generator_LDADD = \
libsystemd-shared.la
 
 EXTRA_DIST += \
-units/systemd-hibernate.service.in \
-units/systemd-hibernate-res...@.service.in
+   units/systemd-hibernate.service.in \
+   units/systemd-hibernate-res...@.service.in \
+   units/systemd-hybrid-sleep.service.in
 
 dist_systemunit_DATA += \
-units/hibernate.target
+   units/hibernate.target \
+   units/hybrid-sleep.target
 
 nodist_systemunit_DATA += \
-units/systemd-hibernate.service \
-units/systemd-hibernate-resume@.service
-
+   units/systemd-hibernate.service \
+   units/systemd-hibernate-resume@.service \
+   units/systemd-hybrid-sleep.service
 endif
 
 # 
--
-- 
2.1.0

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel