Re: [systemd-devel] [PATCH] libsystemd-login.so: fix undefined reference to 'cg_create'

2013-09-11 Thread Lennart Poettering
On Wed, 11.09.13 13:28, Yang Chengwei (chengwei.y...@intel.com) wrote:

 On Tue, Sep 10, 2013 at 06:02:55PM +0200, Lennart Poettering wrote:
  On Mon, 26.08.13 13:48, Chengwei Yang (chengwei.y...@intel.com) wrote:
  
  Hmm, can you elaborate on this one? libsystemd-login should be mostly
 
 This error occurs while building dbus with systemd support like below
 
 $ make
 make  all-recursive
 make[1]: Entering directory `/home/chengwei/Upstream/dbus.git'
 Making all in dbus
 make[2]: Entering directory `/home/chengwei/Upstream/dbus.git/dbus'
 make  all-am
 make[3]: Entering directory `/home/chengwei/Upstream/dbus.git/dbus'
   CCLD   dbus-test
   /usr/lib/libsystemd-login.so: undefined reference to `cg_create'
   collect2: ld returned 1 exit status
   make[3]: *** [dbus-test] Error 1
   make[3]: Leaving directory `/home/chengwei/Upstream/dbus.git/dbus'
   make[2]: *** [all] Error 2
   make[2]: Leaving directory `/home/chengwei/Upstream/dbus.git/dbus'
   make[1]: *** [all-recursive] Error 1
   make[1]: Leaving directory `/home/chengwei/Upstream/dbus.git'
   make: *** [all] Error 2
 
 and cg_create referenced by libsystemd-login.so like below
 
 $ grep cg_create src/login/ -r
 Binary file src/login/systemd_logind-logind-session.o matches
 Binary file src/login/systemd_logind-logind-user.o matches

But these files are not linked into libsystemd-login, but only into
logind (the daemon)...

Lennart

-- 
Lennart Poettering - Red Hat, Inc.
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] [PATCH] libsystemd-login.so: fix undefined reference to 'cg_create'

2013-09-11 Thread Kay Sievers
On Wed, Sep 11, 2013 at 1:27 PM, Lennart Poettering
lenn...@poettering.net wrote:
 On Wed, 11.09.13 13:28, Yang Chengwei (chengwei.y...@intel.com) wrote:

 On Tue, Sep 10, 2013 at 06:02:55PM +0200, Lennart Poettering wrote:
  On Mon, 26.08.13 13:48, Chengwei Yang (chengwei.y...@intel.com) wrote:
 
  Hmm, can you elaborate on this one? libsystemd-login should be mostly

 This error occurs while building dbus with systemd support like below

 $ make
 make  all-recursive
 make[1]: Entering directory `/home/chengwei/Upstream/dbus.git'
 Making all in dbus
 make[2]: Entering directory `/home/chengwei/Upstream/dbus.git/dbus'
 make  all-am
 make[3]: Entering directory `/home/chengwei/Upstream/dbus.git/dbus'
   CCLD   dbus-test
   /usr/lib/libsystemd-login.so: undefined reference to `cg_create'
   collect2: ld returned 1 exit status
   make[3]: *** [dbus-test] Error 1
   make[3]: Leaving directory `/home/chengwei/Upstream/dbus.git/dbus'
   make[2]: *** [all] Error 2
   make[2]: Leaving directory `/home/chengwei/Upstream/dbus.git/dbus'
   make[1]: *** [all-recursive] Error 1
   make[1]: Leaving directory `/home/chengwei/Upstream/dbus.git'
   make: *** [all] Error 2

 and cg_create referenced by libsystemd-login.so like below

 $ grep cg_create src/login/ -r
 Binary file src/login/systemd_logind-logind-session.o matches
 Binary file src/login/systemd_logind-logind-user.o matches

 But these files are not linked into libsystemd-login, but only into
 logind (the daemon)...

Does this print something when executed in the build tree?
  $ nm -D .libs/libsystemd-login.so | grep cg

Kay
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] [PATCH] libsystemd-login.so: fix undefined reference to 'cg_create'

2013-09-11 Thread Yang Chengwei
On Wed, Sep 11, 2013 at 01:27:03PM +0200, Lennart Poettering wrote:
 On Wed, 11.09.13 13:28, Yang Chengwei (chengwei.y...@intel.com) wrote:
 
  On Tue, Sep 10, 2013 at 06:02:55PM +0200, Lennart Poettering wrote:
   On Mon, 26.08.13 13:48, Chengwei Yang (chengwei.y...@intel.com) wrote:
   
   Hmm, can you elaborate on this one? libsystemd-login should be mostly
  
  This error occurs while building dbus with systemd support like below
  
  $ make
  make  all-recursive
  make[1]: Entering directory `/home/chengwei/Upstream/dbus.git'
  Making all in dbus
  make[2]: Entering directory `/home/chengwei/Upstream/dbus.git/dbus'
  make  all-am
  make[3]: Entering directory `/home/chengwei/Upstream/dbus.git/dbus'
CCLD   dbus-test
/usr/lib/libsystemd-login.so: undefined reference to `cg_create'
collect2: ld returned 1 exit status
make[3]: *** [dbus-test] Error 1
make[3]: Leaving directory `/home/chengwei/Upstream/dbus.git/dbus'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/chengwei/Upstream/dbus.git/dbus'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/chengwei/Upstream/dbus.git'
make: *** [all] Error 2
  
  and cg_create referenced by libsystemd-login.so like below
  
  $ grep cg_create src/login/ -r
  Binary file src/login/systemd_logind-logind-session.o matches
  Binary file src/login/systemd_logind-logind-user.o matches
 
 But these files are not linked into libsystemd-login, but only into
 logind (the daemon)...

Yeah, just found that from Makefile.am, it's weird why the above error
happen.

--
Thanks,
Chengwei

 
 Lennart
 
 -- 
 Lennart Poettering - Red Hat, Inc.
 ___
 systemd-devel mailing list
 systemd-devel@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/systemd-devel


signature.asc
Description: Digital signature
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] [PATCH] libsystemd-login.so: fix undefined reference to 'cg_create'

2013-09-11 Thread Yang Chengwei
On Wed, Sep 11, 2013 at 02:09:58PM +0200, Kay Sievers wrote:
 On Wed, Sep 11, 2013 at 1:27 PM, Lennart Poettering
 lenn...@poettering.net wrote:
  On Wed, 11.09.13 13:28, Yang Chengwei (chengwei.y...@intel.com) wrote:
 
  On Tue, Sep 10, 2013 at 06:02:55PM +0200, Lennart Poettering wrote:
   On Mon, 26.08.13 13:48, Chengwei Yang (chengwei.y...@intel.com) wrote:
  
   Hmm, can you elaborate on this one? libsystemd-login should be mostly
 
  This error occurs while building dbus with systemd support like below
 
  $ make
  make  all-recursive
  make[1]: Entering directory `/home/chengwei/Upstream/dbus.git'
  Making all in dbus
  make[2]: Entering directory `/home/chengwei/Upstream/dbus.git/dbus'
  make  all-am
  make[3]: Entering directory `/home/chengwei/Upstream/dbus.git/dbus'
CCLD   dbus-test
/usr/lib/libsystemd-login.so: undefined reference to `cg_create'
collect2: ld returned 1 exit status
make[3]: *** [dbus-test] Error 1
make[3]: Leaving directory `/home/chengwei/Upstream/dbus.git/dbus'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/chengwei/Upstream/dbus.git/dbus'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/chengwei/Upstream/dbus.git'
make: *** [all] Error 2
 
  and cg_create referenced by libsystemd-login.so like below
 
  $ grep cg_create src/login/ -r
  Binary file src/login/systemd_logind-logind-session.o matches
  Binary file src/login/systemd_logind-logind-user.o matches
 
  But these files are not linked into libsystemd-login, but only into
  logind (the daemon)...
 
 Does this print something when executed in the build tree?
   $ nm -D .libs/libsystemd-login.so | grep cg

$ nm -D /usr/lib/libsystemd-login.so | grep cg
 U tcgetattr

Seems irrelative with the problem.

--
Thanks,
Chengwei

 
 Kay
 ___
 systemd-devel mailing list
 systemd-devel@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/systemd-devel


signature.asc
Description: Digital signature
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] [PATCH] libsystemd-login.so: fix undefined reference to 'cg_create'

2013-09-10 Thread Lennart Poettering
On Mon, 26.08.13 13:48, Chengwei Yang (chengwei.y...@intel.com) wrote:

Hmm, can you elaborate on this one? libsystemd-login should be mostly
passive, why would it need to change labels? What's the missing link
here precisely?

 ---
  Makefile.am |1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/Makefile.am b/Makefile.am
 index 5654ad3..dc5170a 100644
 --- a/Makefile.am
 +++ b/Makefile.am
 @@ -3870,6 +3870,7 @@ libsystemd_login_la_LDFLAGS = \
   -Wl,--version-script=$(top_srcdir)/src/login/libsystemd-login.sym
  
  libsystemd_login_la_LIBADD = \
 + libsystemd-label.la \
   libsystemd-shared.la \
   libsystemd-daemon-internal.la \
   $(RT_LIBS)


Lennart

-- 
Lennart Poettering - Red Hat, Inc.
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] [PATCH] libsystemd-login.so: fix undefined reference to 'cg_create'

2013-09-10 Thread Yang Chengwei
On Tue, Sep 10, 2013 at 06:02:55PM +0200, Lennart Poettering wrote:
 On Mon, 26.08.13 13:48, Chengwei Yang (chengwei.y...@intel.com) wrote:
 
 Hmm, can you elaborate on this one? libsystemd-login should be mostly

This error occurs while building dbus with systemd support like below

$ make
make  all-recursive
make[1]: Entering directory `/home/chengwei/Upstream/dbus.git'
Making all in dbus
make[2]: Entering directory `/home/chengwei/Upstream/dbus.git/dbus'
make  all-am
make[3]: Entering directory `/home/chengwei/Upstream/dbus.git/dbus'
  CCLD   dbus-test
  /usr/lib/libsystemd-login.so: undefined reference to `cg_create'
  collect2: ld returned 1 exit status
  make[3]: *** [dbus-test] Error 1
  make[3]: Leaving directory `/home/chengwei/Upstream/dbus.git/dbus'
  make[2]: *** [all] Error 2
  make[2]: Leaving directory `/home/chengwei/Upstream/dbus.git/dbus'
  make[1]: *** [all-recursive] Error 1
  make[1]: Leaving directory `/home/chengwei/Upstream/dbus.git'
  make: *** [all] Error 2

and cg_create referenced by libsystemd-login.so like below

$ grep cg_create src/login/ -r
Binary file src/login/systemd_logind-logind-session.o matches
Binary file src/login/systemd_logind-logind-user.o matches

--
Thanks,
Chengwei

 passive, why would it need to change labels? What's the missing link
 here precisely?
 
  ---
   Makefile.am |1 +
   1 file changed, 1 insertion(+)
  
  diff --git a/Makefile.am b/Makefile.am
  index 5654ad3..dc5170a 100644
  --- a/Makefile.am
  +++ b/Makefile.am
  @@ -3870,6 +3870,7 @@ libsystemd_login_la_LDFLAGS = \
  -Wl,--version-script=$(top_srcdir)/src/login/libsystemd-login.sym
   
   libsystemd_login_la_LIBADD = \
  +   libsystemd-label.la \
  libsystemd-shared.la \
  libsystemd-daemon-internal.la \
  $(RT_LIBS)
 
 
 Lennart
 
 -- 
 Lennart Poettering - Red Hat, Inc.


signature.asc
Description: Digital signature
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


[systemd-devel] [PATCH] libsystemd-login.so: fix undefined reference to 'cg_create'

2013-08-25 Thread Chengwei Yang
---
 Makefile.am |1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile.am b/Makefile.am
index 5654ad3..dc5170a 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -3870,6 +3870,7 @@ libsystemd_login_la_LDFLAGS = \
-Wl,--version-script=$(top_srcdir)/src/login/libsystemd-login.sym
 
 libsystemd_login_la_LIBADD = \
+   libsystemd-label.la \
libsystemd-shared.la \
libsystemd-daemon-internal.la \
$(RT_LIBS)
-- 
1.7.9.5

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel