Re: [systemd-devel] [PATCH v2] Added test for unit file state returned by unit_file_get_state and unit_file_get_list. Made test-enabled units more basic, removing superfluous fields. Cleaned up test p

2014-10-11 Thread Ken Sedgwick
> It looks like newlines at the end of the new files are inconsistent
> ("No newline at end of file").

David,

I investigated this; I think all files have consistent newlines at the end;
these complaints are associated with the symbolic links.

Ken

On Thu, Oct 9, 2014 at 6:35 AM, David Timothy Strauss <
da...@davidstrauss.net> wrote:

> It looks like newlines at the end of the new files are inconsistent
> ("No newline at end of file").
>
> Other than that +1. It's great to add tests, have them pass on master,
> optimize master (the next patch), and then still have them pass.
>



-- 
Ken Sedgwick
Bonsai Software, Inc.
http://www.bonsai.com/ken/
(510) 269-7334
k...@bonsai.com
Public Key: http://www.bonsai.com/ken/ken.asc
GPG Fingerprint: 851E 3B07 E586 0843 9434  5CC7 4033 3B9B 3F3F 9640
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] [PATCH v2] Added test for unit file state returned by unit_file_get_state and unit_file_get_list. Made test-enabled units more basic, removing superfluous fields. Cleaned up test p

2014-10-09 Thread David Timothy Strauss
It looks like newlines at the end of the new files are inconsistent
("No newline at end of file").

Other than that +1. It's great to add tests, have them pass on master,
optimize master (the next patch), and then still have them pass.
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel