Re: [systemd-devel] PATCH: add missing header include
2011/8/19 Lennart Poettering lenn...@poettering.net: On Thu, 18.08.11 16:18, Frederic Crozat (fcro...@suse.com) wrote: Le jeudi 18 août 2011 à 16:00 +0200, Lennart Poettering a écrit : On Thu, 18.08.11 15:50, Frederic Crozat (fcro...@suse.com) wrote: Hi, MS_REC is not always defined in sys/mount.h. linux/fs.h should be included, since it is always defined there. Not always? Can you be more specific please? Which version of glibc is that? Well, I haven't found it on glibc 2.11.3, shipped in latest openSUSE (it was added by Ulrich in 02/2010, see http://sources.redhat.com/bugzilla/show_bug.cgi?id=11235 ie for glib 2.12). Another solution could be to add it to missing.h. I wasn't sure which one was best, since namespace.c is including linux/fs.h, because of MS_REC and MS_MS_UNBINDABLE. I merged your first patch, looks fine. I was just curious whether this was some compatibility hack for a non-glibc libc. usually my recommendation for those is to ask the libc to be fixed, not systemd... Thanks for the patch, Lennart Hi. mount-setup.c in systemd-184 have the same problem with old glibc: CC src/core/mount-setup.o src/core/mount-setup.c:64:92: error: 'MS_STRICTATIME' undeclared here (not in a function) src/core/mount-setup.c: In function 'mount_setup_early': src/core/mount-setup.c:161:9: error: duplicate case value src/core/mount-setup.c:161:9: error: previously used here make[2]: *** [src/core/mount-setup.o] Error 1 rpm -q glibc glibc-2.11.3-alt7 -- Alexey Shabalin ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] PATCH: add missing header include
On Fri, 01.06.12 20:35, Alexey Shabalin (a.shaba...@gmail.com) wrote: mount-setup.c in systemd-184 have the same problem with old glibc: CC src/core/mount-setup.o src/core/mount-setup.c:64:92: error: 'MS_STRICTATIME' undeclared here (not in a function) src/core/mount-setup.c: In function 'mount_setup_early': src/core/mount-setup.c:161:9: error: duplicate case value src/core/mount-setup.c:161:9: error: previously used here make[2]: *** [src/core/mount-setup.o] Error 1 rpm -q glibc glibc-2.11.3-alt7 I have added MS_STRICTATIME to missing.h now. This should fix your problem. Please test! Lennart -- Lennart Poettering - Red Hat, Inc. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
[systemd-devel] PATCH: add missing header include
Hi, MS_REC is not always defined in sys/mount.h. linux/fs.h should be included, since it is always defined there. -- Frederic Crozat fcro...@suse.com SUSE From 9f8a50decf45aaa4436b9fb3a0ab360f238b7d96 Mon Sep 17 00:00:00 2001 From: Frederic Crozat fcro...@suse.com Date: Thu, 18 Aug 2011 15:42:29 +0200 Subject: [PATCH] nspawn: add missing include header for MS_REC. --- src/nspawn.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/nspawn.c b/src/nspawn.c index 2c1144a..19d95b2 100644 --- a/src/nspawn.c +++ b/src/nspawn.c @@ -37,6 +37,7 @@ #include termios.h #include sys/signalfd.h #include grp.h +#include linux/fs.h #include log.h #include util.h -- 1.7.3.4 ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] PATCH: add missing header include
On Thu, 18.08.11 15:50, Frederic Crozat (fcro...@suse.com) wrote: Hi, MS_REC is not always defined in sys/mount.h. linux/fs.h should be included, since it is always defined there. Not always? Can you be more specific please? Which version of glibc is that? Lennart -- Lennart Poettering - Red Hat, Inc. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] PATCH: add missing header include
On Thu, 18.08.11 16:18, Frederic Crozat (fcro...@suse.com) wrote: Le jeudi 18 août 2011 à 16:00 +0200, Lennart Poettering a écrit : On Thu, 18.08.11 15:50, Frederic Crozat (fcro...@suse.com) wrote: Hi, MS_REC is not always defined in sys/mount.h. linux/fs.h should be included, since it is always defined there. Not always? Can you be more specific please? Which version of glibc is that? Well, I haven't found it on glibc 2.11.3, shipped in latest openSUSE (it was added by Ulrich in 02/2010, see http://sources.redhat.com/bugzilla/show_bug.cgi?id=11235 ie for glib 2.12). Another solution could be to add it to missing.h. I wasn't sure which one was best, since namespace.c is including linux/fs.h, because of MS_REC and MS_MS_UNBINDABLE. I merged your first patch, looks fine. I was just curious whether this was some compatibility hack for a non-glibc libc. usually my recommendation for those is to ask the libc to be fixed, not systemd... Thanks for the patch, Lennart -- Lennart Poettering - Red Hat, Inc. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
