Re: [Tails-dev] [review'n'merge:1.3] feature/6880-torsocks-2, aka. drop Polipo and install torsocks 2.0

2014-12-25 Thread intrigeri
Alan wrote (25 Dec 2014 16:39:02 GMT) :
> I only did manual test of the modified applications
> and random other internet applications as I still don't have a reliable
> automated testing setup. If someone wants to run the automated test
> suite on current devel taht would be awesome.

Tails 1.3 is scheduled to be released on 2015-02-24. Maybe you'll find
time to get yourself an automated testing setup by then?

Cheers,
-- 
intrigeri
___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.


Re: [Tails-dev] [review'n'merge:1.3] feature/6880-torsocks-2, aka. drop Polipo and install torsocks 2.0

2014-12-25 Thread intrigeri
Alan wrote (25 Dec 2014 16:39:02 GMT) :
>> [Please don't start the very same discussion in two places at the same
>> time, it becomes really confusing as soon as someone replies in one
>> place, and someone (possibly else) replies in the other. Thanks!]
>> 
> Do you prefer email or the ticket?

Until we've finally taken the needed steps so that people can easily
follow pull requests on Redmine (and know that it's happening there),
I think we should stick to email.

I think it's also OK to discuss on Redmine, and drop a note on the
email thread to make it clear where the discussion is happening.

Cheers,
-- 
intrigeri
___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.


Re: [Tails-dev] fix-committed issues [was: Git/Redmine integration: fixing a regression with new goodies?]

2014-12-25 Thread intrigeri
Alan wrote (25 Dec 2014 16:50:58 GMT) :
> and "QA Check" should be set to "fix committed".

I guess you mean to "Pass". Anyway, that's the same limitation I've
just described in this thread. Sorry.

Anyone who wants to look into the Redmine codebase (and maybe the
Redmine Gitolite plugin), and/or file a ticket about that *upstream*?
___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.


Re: [Tails-dev] fix-committed issues [was: Git/Redmine integration: fixing a regression with new goodies?]

2014-12-25 Thread intrigeri
hi,

Alan wrote (25 Dec 2014 16:45:58 GMT) :
> I tried this for #5379 and found a few annoying things:

>  - it doesn't remove me from "assignee"

Unfortunately, as far as I can tell, Redmine only knows how to change
the ticket's status and %done.

>  - it doesn't mark subtickets as fix-committed.

Not implemented either.

>Should I add the fix-commited keyword with every subticket id?

Yes.

Cheers,
-- 
intrigeri
___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.


Re: [Tails-dev] fix-committed issues [was: Git/Redmine integration: fixing a regression with new goodies?]

2014-12-25 Thread Alan
> >  * "fix-committed: #" will flag # as "Fix committed"
> > 
> >This keyword MAY be used in the commit message when merging
> >a branch with --no-ff. It MUST not be used anywhere else. If the
> >reviewer+merger chooses not to use it, then they MUST manually
> > flag the ticket as "Fix committed", just like we've been doing
> >until now.
> > 
> I tried this for #5379 and found a few annoying things:
> 
>  - it doesn't remove me from "assignee"
>  - it doesn't mark subtickets as fix-committed. Should I add the
>fix-commited keyword with every subticket id?
> 
and "QA Check" should be set to "fix committed".

I'm excited to get this!
___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.


[Tails-dev] fix-committed issues [was: Git/Redmine integration: fixing a regression with new goodies?]

2014-12-25 Thread Alan
Hi,

>  * "fix-committed: #" will flag # as "Fix committed"
> 
>This keyword MAY be used in the commit message when merging
>a branch with --no-ff. It MUST not be used anywhere else. If the
>reviewer+merger chooses not to use it, then they MUST manually flag
>the ticket as "Fix committed", just like we've been doing
>until now.
> 
I tried this for #5379 and found a few annoying things:

 - it doesn't remove me from "assignee"
 - it doesn't mark subtickets as fix-committed. Should I add the
   fix-commited keyword with every subticket id?

Cheers
___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.


Re: [Tails-dev] [review'n'merge:1.3] feature/6880-torsocks-2, aka. drop Polipo and install torsocks 2.0

2014-12-25 Thread Alan
Hi,

> Alan wrote (23 Dec 2014 16:45:22 GMT) :
> > I checked the diff and tested wget, APT, Totem and GnuPG that all
> > work fine under experimental. Tickets and design doc liiks fine too.
> 
> Cool, thanks for the review!
> 
> Please test the branch once merged into devel before pushing the final
> merge, as various unrelated stuff has started accumulating
> in experimental.
> 
Done and pushed.

I only did manual test of the modified applications
and random other internet applications as I still don't have a reliable
automated testing setup. If someone wants to run the automated test
suite on current devel taht would be awesome.

> > The only issue blocking the merge are useless unset lines in wget
> > wrapper: [...]
> 
> Answered on the ticket, reassigned to you.
> 
> [Please don't start the very same discussion in two places at the same
> time, it becomes really confusing as soon as someone replies in one
> place, and someone (possibly else) replies in the other. Thanks!]
> 
Do you prefer email or the ticket?
___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.


Re: [Tails-dev] Review and merge doc/8480-skip-obsolete

2014-12-25 Thread intrigeri
merged, thanks!
___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.