Re: [Tails-dev] Tor Browser 6.0.6 is ready for testing
Hi, On Thu, Nov 10, 2016 at 05:50:00PM +, Georg Koppen wrote: > > Tor Browser 6.0.6 is ready for testing. Bundles can be found on > > https://people.torproject.org/~boklm/builds/6.0.6-build5 Thanks! I see there's 6.0.6-build6 now, which seems to contain only minor changes related to the donation campaign. Should we rather include this build in Tails now? bert. ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] Adding "look at test suite results" to our reviewing guidelines
anonym: > IMHO those of us with access to jenkins should also make sure to > check the tests before asking for a review. Clearly I failed at that > this time (but I have done it at other times, so it was just a slip!), > so the blame is on me, really! :S Feel free to add this to our branch submission checklist :) Still, between a branch submission and when it's reviewed, things may change and break, so IMO the burden of checking test suite results should primarily lie on the gatekeeper, that is the person who makes the decision of merging or not. ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] Adding "look at test suite results" to our reviewing guidelines
intrigeri: > Hi! > > Recently a branch was merged, that introduced a regression in our test > suite, which Jenkins was able to spot. But for some reason, we noticed > that regression only *after* the branch was merged into stable & devel. > > I think that one of the key features of our test suite, by design [1], > is to allow us to notice such issues *before* we merge topic branches. > > [1] > https://tails.boum.org/blueprint/automated_builds_and_tests/automated_tests_specs/ > > So, until we have Jenkins results integrate with Redmine somehow, > IMO we should add to our reviewing guidelines [2] something like > "look at automated tests results on Jenkins for the proposed branch, > and make sure it introduces no regression; but our Jenkins setup does > not run 100% of the test suite, so bonus points if you feel like doing > a complete test suite run locally". +1. IMHO those of us with access to jenkins should also make sure to check the tests before asking for a review. Clearly I failed at that this time (but I have done it at other times, so it was just a slip!), so the blame is on me, really! :S Cheers! ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
[Tails-dev] Adding "look at test suite results" to our reviewing guidelines
Hi! Recently a branch was merged, that introduced a regression in our test suite, which Jenkins was able to spot. But for some reason, we noticed that regression only *after* the branch was merged into stable & devel. I think that one of the key features of our test suite, by design [1], is to allow us to notice such issues *before* we merge topic branches. [1] https://tails.boum.org/blueprint/automated_builds_and_tests/automated_tests_specs/ So, until we have Jenkins results integrate with Redmine somehow, IMO we should add to our reviewing guidelines [2] something like "look at automated tests results on Jenkins for the proposed branch, and make sure it introduces no regression; but our Jenkins setup does not run 100% of the test suite, so bonus points if you feel like doing a complete test suite run locally". [2] https://tails.boum.org/contribute/merge_policy/review/ Thoughts? Cheers, -- intrigeri ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
