Re: [Tails-dev] [review'n'merge:1.1.1] bugfix/7691-fix-ftbfs-with-apt-get-source-syslinux [Was: dpkg-dev / libdpkg-perl errors during build]
Hi, On Thu, 31 Jul 2014 11:46:35 +0200 intrigeri intrig...@boum.org wrote: Kill Your TV wrote (30 Jul 2014 21:58:27 GMT) : Your suggested changes seem to have worked. (without apt-cacher-ng privoxy it passed. If I back out your suggested change, it fails) Thanks for confirming! Please review'n'merge bugfix/7691-fix-ftbfs-with-apt-get-source-syslinux into stable and devel. Candidate for 1.1.1. The code and APT review passes, but: - I don't know how to reproduce the bug that this is supposed to fix. I thus trust Kill Your TV's test - the branch was actually already merged in stable by 554c3c3 Merge remote-tracking branch 'kytv/feature/i2p-bootparam' into stable because that branch was based on the one I'm supposed to merge. Dear reviewer of kytv/feature/i2p-bootparam, please check twice what you merge next time! Anyway, it's merged and I see no reason to unmerge it. Cheers ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] [review'n'merge:1.1.1] bugfix/7691-fix-ftbfs-with-apt-get-source-syslinux [Was: dpkg-dev / libdpkg-perl errors during build]
Alan wrote (14 Aug 2014 10:12:20 GMT) : - the branch was actually already merged in stable by 554c3c3 Merge remote-tracking branch 'kytv/feature/i2p-bootparam' into stable because that branch was based on the one I'm supposed to merge. Dear reviewer of kytv/feature/i2p-bootparam, please check twice what you merge next time! Sorry, you're right. Still, no harm done, and I think it was good to merge it: it's a shame that we need 2 full weeks to merge trivial fixes for build failures that were hindering many new contributors' ability to get involved. ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] [review'n'merge:1.1.1] bugfix/7691-fix-ftbfs-with-apt-get-source-syslinux [Was: dpkg-dev / libdpkg-perl errors during build]
On Thu, 14 Aug 2014 10:19:56 + (UTC) Alan a...@boum.org wrote: reviewer of kytv/feature/i2p-bootparam, please check twice what you merge next time! Crap. Sorry about letting that slip in. :( I usually don't keep 'test patches' in my tree but I did keep this one in order to be able to build. I intended to rebase it away before pushing my branchbut alas, I forgot to. For the last couple of weeks I've been working/building from transient branches (which I'll never push) to make these (and other) slip-ups harder to make. Anyway, it's merged and I see no reason to unmerge it. Thankfully in this case it worked out, but with my current workflow I can't mistakenly add a 'test patch' to my own branch-to-be-pushed-and-reviewed. signature.asc Description: PGP signature ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
[Tails-dev] [review'n'merge:1.1.1] bugfix/7691-fix-ftbfs-with-apt-get-source-syslinux [Was: dpkg-dev / libdpkg-perl errors during build]
Hi, Kill Your TV wrote (30 Jul 2014 21:58:27 GMT) : Your suggested changes seem to have worked. (without apt-cacher-ng privoxy it passed. If I back out your suggested change, it fails) Thanks for confirming! Please review'n'merge bugfix/7691-fix-ftbfs-with-apt-get-source-syslinux into stable and devel. Candidate for 1.1.1. Cheers, -- intrigeri ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] [review'n'merge:1.1.1] bugfix/7691-fix-ftbfs-with-apt-get-source-syslinux [Was: dpkg-dev / libdpkg-perl errors during build]
On Thu, 31 Jul 2014 09:47:25 + (UTC) intrigeri intrig...@boum.org wrote: Please review'n'merge bugfix/7691-fix-ftbfs-with-apt-get-source-syslinux into stable and devel. Candidate for 1.1.1. +1 on merging. -- GPG ID: 0x5BF72F42D0952C5A Fingerprint: BD12 65FD 4954 C40A EBCB F5D7 5BF7 2F42 D095 2C5A signature.asc Description: PGP signature ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] [review'n'merge:1.1.1] bugfix/7691-fix-ftbfs-with-apt-get-source-syslinux [Was: dpkg-dev / libdpkg-perl errors during build]
Kill Your TV wrote (31 Jul 2014 17:53:44 GMT) : +1 on merging. Thanks. It would be good if some of the other people who were reporting this bug on IRC did test the proposed fix, and confirmed it works for them... even if the patch does look right :) Cheers, -- intrigeri ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
