Re: [Tails-dev] [review'n'merge:1.2.1] bugfix/7678-Tails-Installer-crashes-on-upgrade
Hi, this branch was obviously not tested in its proposed form, as it breaks at least the Clone and upgrade feature that it's supposed to improve = postponed to Tails 1.3. See details on Redmine. Cheers, -- intrigeri ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] [review'n'merge:1.2.1] bugfix/7678-Tails-Installer-crashes-on-upgrade
Hi, this branch was obviously not tested in its proposed form, as it breaks at least the Clone and upgrade feature that it's supposed to improve = postponed to Tails 1.3. See details on Redmine. Sorry for the very dummy error, I tested and it works now. Cheers, Kurono ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] [review'n'merge:1.2.1] bugfix/7678-Tails-Installer-crashes-on-upgrade
Hi! On Wed, 7 Jan 2015 18:58:22 +0100 kurono andres.go...@cern.ch wrote: pre -toplevels = config['liveos_toplevel_files'] - for f in toplevels: +for f in config['liveos_toplevel_files']: /pre Ok the new version is in http://git.tails.boum.org/kurono/liveusb-creator/ the branch is the same bugfix/7678-Tails-Installer-crashes-on-upgrade. Thanks! I'm not sure to have time to take care of that in the next few days thought. If someone else feels like it, don't hesitate. Cheers ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] [review'n'merge:1.2.1] bugfix/7678-Tails-Installer-crashes-on-upgrade
Hi, I confirm the patch fixes the issue. A tiny comment though: as @toplevels@ is only used once, so why not to write one less line: pre -toplevels = config['liveos_toplevel_files'] - for f in toplevels: +for f in config['liveos_toplevel_files']: /pre Ok the new version is in http://git.tails.boum.org/kurono/liveusb-creator/ the branch is the same bugfix/7678-Tails-Installer-crashes-on-upgrade. Cheers. ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] [review'n'merge:1.2.1] bugfix/7678-Tails-Installer-crashes-on-upgrade
Hi, Ticket: https://labs.riseup.net/code/issues/7678 I don't have yet a liveusb-creator repo yet, (If I remember correctly already sent the requirement). So I am attaching the patch. Thanks for the patch which I imported into liveusb-creator repository in the feature branch. I confirm the patch fixes the issue. A tiny comment though: as @toplevels@ is only used once, so why not to write one less line: pre -toplevels = config['liveos_toplevel_files'] -for f in toplevels: +for f in config['liveos_toplevel_files']: /pre Cheers ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
[Tails-dev] [review'n'merge:1.2.1] bugfix/7678-Tails-Installer-crashes-on-upgrade
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, Ticket: https://labs.riseup.net/code/issues/7678 I don't have yet a liveusb-creator repo yet, (If I remember correctly already sent the requirement). So I am attaching the patch. Cheers, kurono -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF0EAREIAAYFAlR3hMQACgkQ94rPTJlzoM5NawD2Po5iGFlDVEeDQSJBhyyyZZL/ 2NcVcRqI1UQzIcR6vQD+PAwhiLFebeA5j2eDat23JXq15OhCnQdHkryZzhLXWlM= =TXwo -END PGP SIGNATURE- From 3d3dabddc765592c9ff01d74cd6c31dad9b01625 Mon Sep 17 00:00:00 2001 From: Tails developers ta...@boum.org Date: Thu, 27 Nov 2014 20:50:30 +0100 Subject: [PATCH] bugfix/7678-Tails-Installer-crashes-on-upgrade --- liveusb/source.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/liveusb/source.py b/liveusb/source.py index 3f93c1e..fba0843 100644 --- a/liveusb/source.py +++ b/liveusb/source.py @@ -7,6 +7,7 @@ import subprocess from stat import ST_SIZE from liveusb import _ from liveusb.releases import releases +from liveusb.config import config from liveusb.utils import (_to_unicode, _dir_size, iso_is_live_system, unicode_to_utf8, _set_liberal_perms_recursive, underlying_physical_device) @@ -85,7 +86,8 @@ class RunningLiveSystemSource(Source): self.size = _dir_size(self.path) self.dev = underlying_physical_device(self.path) def clone(self, destination): -for f in os.listdir(self.path): +toplevels = config['liveos_toplevel_files'] +for f in toplevels: src = os.path.join(self.path, f) dst = os.path.join(destination, f) if os.path.isfile(src): -- 1.8.3.2 7678-Tails-Installer-crashes-on-upgrade.patch.sig Description: PGP signature ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] [review'n'merge:1.2.1] bugfix/7678-Tails-Installer-crashes-on-upgrade
kurono wrote (27 Nov 2014 20:08:36 GMT) : I don't have yet a liveusb-creator repo yet, (If I remember correctly already sent the requirement). Now you have one :) Don't hesitate pinging tails-sysad...@boum.org in this kind of situations. We're not perfect, and sometimes stuff is forgotten. ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] [review'n'merge:1.2.1] bugfix/7678-Tails-Installer-crashes-on-upgrade
Now you have one :) Don't hesitate pinging tails-sysad...@boum.org in this kind of situations. We're not perfect, and sometimes stuff is forgotten. Ok cool, no problem :) ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
