Re: [Tails-dev] Tor Monitor: don't show duplicate streams with the same destination in the same circuit

2015-09-15 Thread intrigeri
Alan wrote (14 Sep 2015 11:06:58 GMT) :
> After checking how this could be done, I'm really unsure.

Replied on the ticket (where you've posted basically the same text).

Cheers,
-- 
intrigeri
___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.


[Tails-dev] Tor Monitor: don't show duplicate streams with the same destination in the same circuit

2015-09-14 Thread Alan
Hi,

sajolida  wrote:
> Done in #10183.
> 
After checking how this could be done, I'm really unsure. I currently
display the stream Tor has. Deduplicating streams would mean to create
another list of streams, which would not ma to Tor streams. Then, how
should we update the status of the stream group? A stream (with the
same destination) could be "Succeeded" while another is "Sentconnect"
and another "Closing". This proposal means we should invent another
concept, that Tor dosn't provide, and that makes few sense.

I checked also what vidalia does, and it does not deduplicate streams
with the same destination. So I don't think this should be a
requirement to replace Vidalia.

Cheers
___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.


Re: [Tails-dev] Tor Monitor: don't show duplicate streams with the same destination in the same circuit

2015-09-12 Thread sajolida
Alan:
> sajolida  wrote:
>> Alan:
>>> intrigeri  wrote:
 sajolida wrote (27 Aug 2015 16:48:14 GMT) :
> C. Duplicate information

> In the list of circuits I sometimes see duplicated lines.

 Technical nitpicking: these are streams, not circuits :)

> For example when connecting to heavy websites like YouTube.
> See duplicates.png in attachment. Why not deduplicate these lines?

 I'm not sure what's the value of the "there are multiple streams to
 this IP:PORT going on that circuit" information. At first glance,
 I would say let's deduplicate, but perhaps I'm missing a use case
 or three?

>>> If I display duplicates, either I have a bug or there are multiple
>>> streams to this IP:port in that circuit... I can deduplicate them if
>>> requested but I fail to see the interest to complexify the
>>> code to simplify the reality.
>>
>> The interest is to have a more compact view displayed to the user and
>> reduce noise. Did you see my screenshot? To me it looks pretty awful. I
>> fail to see the interest in complexifying so much the interface to
>> simplify a bit the code :)
> 
> Please file a ticket for that then.

Done in #10183.

> I'd suggest we don't consider it as a blocker thought.

I'm fine with releasing a first version of Tor Monitor with this bug,
but I still want this to be on the roadmap regarding Tor Monitor in 2016
otherwise it'll never get done.
___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.


[Tails-dev] Tor Monitor: don't show duplicate streams with the same destination in the same circuit

2015-09-11 Thread Alan
Hi,

sajolida  wrote:
> Alan:
> > intrigeri  wrote:
> >> sajolida wrote (27 Aug 2015 16:48:14 GMT) :
> >>> C. Duplicate information
> >>
> >>> In the list of circuits I sometimes see duplicated lines.
> >>
> >> Technical nitpicking: these are streams, not circuits :)
> >>
> >>> For example when connecting to heavy websites like YouTube.
> >>> See duplicates.png in attachment. Why not deduplicate these lines?
> >>
> >> I'm not sure what's the value of the "there are multiple streams to
> >> this IP:PORT going on that circuit" information. At first glance,
> >> I would say let's deduplicate, but perhaps I'm missing a use case
> >> or three?
> >>
> > If I display duplicates, either I have a bug or there are multiple
> > streams to this IP:port in that circuit... I can deduplicate them if
> > requested but I fail to see the interest to complexify the
> > code to simplify the reality.
> 
> The interest is to have a more compact view displayed to the user and
> reduce noise. Did you see my screenshot? To me it looks pretty awful. I
> fail to see the interest in complexifying so much the interface to
> simplify a bit the code :)

Please file a ticket for that then. I'd suggest we don't consider it as
a blocker thought.

Cheers
___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.