Re: [Tails-dev] Upstreaming yelp patch
hi, Ague Mill wrote (12 Oct 2012 20:44:31 GMT) : On Fri, Oct 12, 2012 at 05:52:50PM +0200, intrigeri wrote: to anyone who pushed commit 64de544 (Fix Yelp crashing on internal links): [...] 2. Please open a ticket about upstreaming this fix. I don't see the need: [...] * Yelp has been heavily rewritten since Squeeze. I have not tested, but I doubt the bug is still in the version in Wheezy. If the bug was fixed upstream since then (== is not present in Wheezy), then I agree, the effort is not worth it, let's forget about it. If the bug is still present in Wheezy, then I still think we should report it to Debian and/or GNOME, and contribute our existing patch. Perhaps they'll ignore it, but at least, let's make upstream aware of the problem and possible solution. Our contribute/relationship_with_upstream page contains plenty of reasons to do. ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Upstreaming yelp patch
On Sat, Oct 13, 2012 at 11:11:11AM +0200, intrigeri wrote: hi, Ague Mill wrote (12 Oct 2012 20:44:31 GMT) : On Fri, Oct 12, 2012 at 05:52:50PM +0200, intrigeri wrote: to anyone who pushed commit 64de544 (Fix Yelp crashing on internal links): [...] 2. Please open a ticket about upstreaming this fix. I don't see the need: [...] * Yelp has been heavily rewritten since Squeeze. I have not tested, but I doubt the bug is still in the version in Wheezy. If the bug was fixed upstream since then (== is not present in Wheezy), then I agree, the effort is not worth it, let's forget about it. My look at the code was right: everything is different. Except there is yet another bug in the code affecting internal links... See https://bugzilla.gnome.org/show_bug.cgi?id=686095 for details. That patch also applies to the version currently in Wheezy. -- Ague pgpEyEuSpWN1i.pgp Description: PGP signature ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Upstreaming yelp patch
On Fri, Oct 12, 2012 at 05:52:50PM +0200, intrigeri wrote: to anyone who pushed commit 64de544 (Fix Yelp crashing on internal links): 1. Congrats! 2. Please open a ticket about upstreaming this fix. I don't see the need: * GNOME documentation is not affected as far as I have seen, * Yelp has been heavily rewritten since Squeeze. I have not tested, but I doubt the bug is still in the version in Wheezy. What we could do is to try to push a fix in the next Debian Squeeze point release, but I don't think the bug is severe enough, as it does not show up when browsing GNOME documentation. I'd be happy to be convinced otherwise, though. -- Ague pgpjwC4XeDfuH.pgp Description: PGP signature ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
