Re: [Tails-dev] Scripts for importing Transifex translations, please review
winterfa...@riseup.net wrote (02 Dec 2013 19:50:44 GMT) : Do you think it is enough to resolve the ticket (#6207)? Replied on #6207. Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Scripts for importing Transifex translations, please review
intrigeri wrote: winterfairy wrote: For the other repositories: The bug says something about Makefile targets, but it is okay that it is a script, right? And that the user must manually invoke the script to pull translations, just like in the tails repo right now? I think it's a very good first step. Do you think it is enough to resolve the ticket (#6207)? For the Perl software, I'll probably integrate running this script into the automated Dist::Zilla release workflow, but I guess it's fine to require the person doing the release to run an additional command here and there. It is easier for me to just add the script (and adjust it for this repository and po-style). If that is enough to resolve the ticket, I will not spend much work on trying to integrate it with any automated release workflows, unless it is somewhat obvious to me how to integrate it. ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Scripts for importing Transifex translations, please review
intrigeri wrote: winterfairy at riseup.net wrote (30 Nov 2013 19:00:56 GMT) : There was a purpose of the code in import-translations that was removed by commit: e76059cd74bec591d7104b65e3f188e43a36ef7f Commits b2a3952 and d62bf4c (directly pushed to devel, sorry) should restore the intended behavior back, with a slightly different implementation (factorized functionality from refresh-translations into our shell library). Does this achieve the result you intended? It seems so, yes. If you wait with reviewing the greeter repository, I can rebase it with an import-translations script that more closely resembles the one now in the tails repo. Would this be good? For the other repositories: The bug says something about Makefile targets, but it is okay that it is a script, right? And that the user must manually invoke the script to pull translations, just like in the tails repo right now? Sorry if many questions, but I don't want to redo the work again just because it should have been done differently, since it is many repositories. ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Scripts for importing Transifex translations, please review
winterfa...@riseup.net wrote (01 Dec 2013 17:57:12 GMT) : If you wait with reviewing the greeter repository, I can rebase it with an import-translations script that more closely resembles the one now in the tails repo. Would this be good? Yes, please :) For the other repositories: The bug says something about Makefile targets, but it is okay that it is a script, right? And that the user must manually invoke the script to pull translations, just like in the tails repo right now? I think it's a very good first step. For the Perl software, I'll probably integrate running this script into the automated Dist::Zilla release workflow, but I guess it's fine to require the person doing the release to run an additional command here and there. Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Scripts for importing Transifex translations, please review
Hi, winterfa...@riseup.net wrote (29 Nov 2013 14:14:46 GMT) : Please review and merge: - repo winterfairy/tails, branch import-translations (based on devel) Merged and pushed some refactoring commits on top. bertagaz should be reviewing my own changes soonish. Works fine, thanks! - repo winterfairy/greeter, branch import-translations (based on master) The ticket is assigned to me, so I should think of reviewing this shortly. Else, feel free to nag me. Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Scripts for importing Transifex translations, please review
On Sat, Nov 30, 2013 at 04:08:35PM +0100, intrigeri wrote: Hi, winterfa...@riseup.net wrote (29 Nov 2013 14:14:46 GMT) : Please review and merge: - repo winterfairy/tails, branch import-translations (based on devel) Merged and pushed some refactoring commits on top. bertagaz should be reviewing my own changes soonish. Works fine, thanks! That sounds good to me, so I think I won't merge it anywhere, since it's already done. :) Thanks winterfairy for your quality contributions! bert. ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Scripts for importing Transifex translations, please review
intrigeri wrote: winterfairy at riseup.net wrote (29 Nov 2013 14:14:46 GMT) : Please review and merge: - repo winterfairy/tails, branch import-translations (based on devel) Merged and pushed some refactoring commits on top. There was a purpose of the code in import-translations that was removed by commit: e76059cd74bec591d7104b65e3f188e43a36ef7f The purpose was, if one run import-translations and then commits (without running refresh-translations), there will show up much changes in all po-files, even if no changes really was made. That makes it harder to track how the content in the po-files have changed. Running intltool-update is fast, so it being run twice is not a big problem for that reason. And I believe it should be run in import-translations too, just to make the logs more clean in those cases someone commit immediately after import. ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Scripts for importing Transifex translations, please review
winterfa...@riseup.net wrote (30 Nov 2013 19:00:56 GMT) : There was a purpose of the code in import-translations that was removed by commit: e76059cd74bec591d7104b65e3f188e43a36ef7f OK, got it. I'm not excessively convinced by the if someone commits without running refresh-translations first part, but OK. Commits b2a3952 and d62bf4c (directly pushed to devel, sorry) should restore the intended behavior back, with a slightly different implementation (factorized functionality from refresh-translations into our shell library). Does this achieve the result you intended? Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
