Re: [OSM-talk] Invisible character LRM in some website values

2014-05-02 Thread Glenn Plas

On 01-05-14 21:51, John Packer wrote:

Solved!
At least for now...

Changeset: http://www.openstreetmap.org/changeset/22071440

I suppose I hit the same problem as you, Glenn: JOSM wasn't 
recognizing that the data was changed.
But that was because I removed these characters in the OSM file 
itself, not inside JOSM.
The solution was to add the attribute action=modify to each object 
in the file before opening it in JOSM. (I did this with a VIM macro)


I tried both methods, in josm itself and manually, but I lacked the 
knowledge on that action attribute.  I'm still strugling with getting 
josm to recognise it.  It's probably down to the java flavour (oracle vs 
openjdk).  I'll verify on a VM this weekend to know for sure what is 
causing it.


See followup: https://josm.openstreetmap.de/ticket/9960

Tx for information

Glenn
___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] Invisible character LRM in some website values

2014-05-01 Thread John Packer
Solved!
At least for now...

Changeset: http://www.openstreetmap.org/changeset/22071440

I suppose I hit the same problem as you, Glenn: JOSM wasn't recognizing
that the data was changed.
But that was because I removed these characters in the OSM file itself, not
inside JOSM.
The solution was to add the attribute action=modify to each object in the
file before opening it in JOSM. (I did this with a VIM macro)



2014-04-29 11:22 GMT-03:00 John Packer john.pack...@gmail.com:

 Bryce,

 As far as I know, Keepright will simply flag this as an invalid/dead
 website, which might mislead people into removing perfectly fine websites
 that were corrupted by this character.

 Glenn,
 In my case, JOSM noticed the difference and uploaded the changes. I am
 using JOSM 7000 on Linux. (though it seems there was a node that wasn't
 corrected; but I am not sure whether I failed to correct it or JOSM didn't
 perceive it).


 Em 29/04/2014 07:11, Glenn Plas gl...@byte-consult.be escreveu:


  I tried fixing some in Josm, and I can confirm the LRM char is in the
 URL, but to make josm realise that there was a change I had to had a note
 tag, josm doesn't account for those special chars to determine changes and
 allow an upload.


 I opened a ticket with JOSM in this regard as it's not seeing the
 differences.  see  https://josm.openstreetmap.de/ticket/9960

 Glenn



___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] Invisible character LRM in some website values

2014-04-29 Thread Bryce Nesbitt
Keepright and/or Maproulette are fine tools for crowfixing such things.
Keepright is probably already picking them up, at it loads website tags and
matches them to the other tags in the same OSM primitive.
___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] Invisible character LRM in some website values

2014-04-29 Thread Glenn Plas

On 29-04-14 04:33, John Packer wrote:

Today I found out a /funny/ thing.
It seems some values for the keys 'website' and 'contact:website' have 
a LRM character at it's end.

That's not something good because it corrupts the URL. (example)

On taginfo: http://taginfo.openstreetmap.org/search?q=website%3D%E2%80%8E
Example of an overpass to find this: http://overpass-turbo.eu/s/3bW

I manually fixed these things on Brazil, could someone fix this on the 
rest of the world?


I tried fixing some in Josm, and I can confirm the LRM char is in the 
URL, but to make josm realise that there was a change I had to had a 
note tag, josm doesn't account for those special chars to determine 
changes and allow an upload.


Glenn
___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] Invisible character LRM in some website values

2014-04-29 Thread Glenn Plas


I tried fixing some in Josm, and I can confirm the LRM char is in the 
URL, but to make josm realise that there was a change I had to had a 
note tag, josm doesn't account for those special chars to determine 
changes and allow an upload.


I opened a ticket with JOSM in this regard as it's not seeing the 
differences.  see  https://josm.openstreetmap.de/ticket/9960


Glenn

___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


[OSM-talk] Invisible character LRM in some website values

2014-04-28 Thread John Packer
Today I found out a *funny* thing.
It seems some values for the keys 'website' and 'contact:website' have a
LRM character at it's end.
That's not something good because it corrupts the URL. (example)

On taginfo: http://taginfo.openstreetmap.org/search?q=website%3D%E2%80%8E
Example of an overpass to find this: http://overpass-turbo.eu/s/3bW

I manually fixed these things on Brazil, could someone fix this on the rest
of the world?
You will most likely need an automated solution, because there are around
400 cases of this left.

It seems this also affect other keys (like
phonehttp://taginfo.openstreetmap.org/search?q=phone%3D%E2%80%8E),
but the problem is not as bad as in the keys 'website' and
'contact:website'.

Cheers,
John
___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk