Re: [OSM-talk] undiscussed (?) mechanical edit on diet:vegan and diet:vegetarian

2014-05-21 Thread John Packer

 I would question whether vegan or vegetarian are types of cuisine. You
 can have vegetarian restaurants serving very different cuisines, tagging
 such as cuisine=indian diet=vegetarian, cuisine=british diet=vegetarian.
 If you use cuisine=vegetarian then you loose that important information.

 Phil (trigpoint)


The tags cuisine=vegetarian and cuisine=vegan are already explicitly
deprecated.
That's why BuganiniQ added the documented keys diet:vegetarian and
diet:vegan to them.

Cheers, John
___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] undiscussed (?) mechanical edit on diet:vegan and diet:vegetarian

2014-05-21 Thread SomeoneElse

John Packer wrote:


The tags cuisine=vegetarian and cuisine=vegan are already explicitly 
deprecated.




Says who?  People who edit the wiki or people who edit the map?

Any change to previously-used keys needs to be talked about in public so 
that someone who's got a map that depends on the old keys doesn't see 
things disappearing off it.  That's not to say that change isn't 
sometimes necessary (highway=ford to ford=yes on ways comes to mind), 
but people need to know that it is happening.


Cheers,

Andy


___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


[OSM-talk] undiscussed (?) mechanical edit on diet:vegan and diet:vegetarian

2014-05-21 Thread John Packer
Andy wrote:

 John Packer wrote:

 The tags cuisine=vegetarian and cuisine=vegan are already explicitly
 deprecated.


 Says who?  People who edit the wiki or people who edit the map?

 Any change to previously-used keys needs to be talked about in public so
 that someone who's got a map that depends on the old keys doesn't see
 things disappearing off it.  That's not to say that change isn't
 sometimes necessary (highway=ford to ford=yes on ways comes to mind),
 but people need to know that it is happening.


I was not around at that time, but according to the wiki, the key diet:*=*
was proposed in early 2011, aprooved (explicitly deprecating
cuisine=vegetarian/vegan), and is now translated to 6 other languages.

Cheers, John
___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


[OSM-talk] undiscussed (?) mechanical edit on diet:vegan and diet:vegetarian

2014-05-20 Thread Michael Reichert
Hi,

I have discovered a mechanical edit of 100 restaurants worldwide by user
BuganiniQ.

https://www.openstreetmap.org/changeset/22303143
comment=update diet:vegen/diet:vegetarian: set to only according to
cuisine; remove redundant tags
created_by=osmapi/0.2.24

Has this edit been discussed before? (Maybe I have missed the
discussion) I have not found anything browsing through the archives of
talk and imports mailing list back to March 2014. There are also no
results when I look for user BuganiniQ in OSM forum.

About the edit: He has removed diet:vegetarian=* if the object was
tagged diet:vegan=yes or diet:vegan=only.
If it was tagged cuisine=vegetarian, diet:vegetarian=yes, he changed it
to cuisine=vegetarian, diet:vegetarian=only. If it was tagged
cuisine=vegan, he removed diet:vegetarian=*.

You can see the full tag diff at
http://osmhv.openstreetmap.de/changeset.jsp?id=22303143

There is a wiki page about it. http://wiki.openstreetmap.org/wiki/Key:diet
The wiki page has been saying (N.B. it may be helpful to tag
diet:vegetarian=only and diet:vegan=yes) since the first version of
this page on May 5, 2011.

Best regards

Michael


-- 
Per E-Mail kommuniziere ich bevorzugt GPG-verschlüsselt.



signature.asc
Description: OpenPGP digital signature
___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] undiscussed (?) mechanical edit on diet:vegan and diet:vegetarian

2014-05-20 Thread SomeoneElse

Michael Reichert wrote:

Hi,

I have discovered a mechanical edit of 100 restaurants worldwide by user
BuganiniQ.

https://www.openstreetmap.org/changeset/22303143
comment=update diet:vegen/diet:vegetarian: set to only according to
cuisine; remove redundant tags
created_by=osmapi/0.2.24

Has this edit been discussed before? (Maybe I have missed the
discussion) I have not found anything browsing through the archives of
talk and imports mailing list back to March 2014. There are also no
results when I look for user BuganiniQ in OSM forum.


I've not seen any discussion anywhere of this one.

In practice, there are _lots_ of these sorts of well-meaning tidying 
up edits; relatively few of which are ever discussed. Most are entirely 
sensible (for example, see 
http://www.openstreetmap.org/way/24991952/history , which is in the most 
recent such changeset that crosses where I live).


Should all such changesets be cleared as mechanical edits first? The 
current guidelines suggest yes, but in practice this isn't done in 
changesets that are obviously correct such as the maxspeed one above.  
The tricky bit is to tell where the person doing the edit doesn't 
understand the nuances present in the keys and values concerned (as I'm 
sure that I don't with vegan etc.).


Cheers,

Andy


___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] undiscussed (?) mechanical edit on diet:vegan and diet:vegetarian

2014-05-20 Thread Michael Reichert
Hi,

Am 20.05.2014 12:26, schrieb SomeoneElse:
 Michael Reichert wrote:
 Hi,

 I have discovered a mechanical edit of 100 restaurants worldwide by user
 BuganiniQ.

 https://www.openstreetmap.org/changeset/22303143
 comment=update diet:vegen/diet:vegetarian: set to only according to
 cuisine; remove redundant tags
 created_by=osmapi/0.2.24

 Has this edit been discussed before? (Maybe I have missed the
 discussion) I have not found anything browsing through the archives of
 talk and imports mailing list back to March 2014. There are also no
 results when I look for user BuganiniQ in OSM forum.

 I've not seen any discussion anywhere of this one.

I always ask or look properly before I report someone to DWG.

 In practice, there are _lots_ of these sorts of well-meaning tidying
 up edits; relatively few of which are ever discussed. Most are entirely
 sensible (for example, see
 http://www.openstreetmap.org/way/24991952/history , which is in the most
 recent such changeset that crosses where I live).
 
 Should all such changesets be cleared as mechanical edits first? The
 current guidelines suggest yes, but in practice this isn't done in
 changesets that are obviously correct such as the maxspeed one above. 
 The tricky bit is to tell where the person doing the edit doesn't
 understand the nuances present in the keys and values concerned (as I'm
 sure that I don't with vegan etc.).

No, not every mechanical edit. There is no sharp border. The example you
gave correct errors. Such edits should not have to be discussed. But the
changeset I gave changed tagging and IMHO did not fix errors (see the
linked wiki page).

OT: If you want, you can report this (max_speed - maxspeed) to user
Oli-Wan the maintainer of the bot Wall·E [2]. This bot operates at the
moment only in Germany and Austria but can be extended to other
countries if the local community wants it.

Best regards

Michael


[1] http://wiki.openstreetmap.org/wiki/User:Oli-Wan
[2] http://wiki.openstreetmap.org/wiki/User:Oli-Wan/Wall-E


-- 
Per E-Mail kommuniziere ich bevorzugt GPG-verschlüsselt.



signature.asc
Description: OpenPGP digital signature
___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] undiscussed (?) mechanical edit on diet:vegan and diet:vegetarian

2014-05-20 Thread Martin Koppenhoefer
2014-05-20 12:42 GMT+02:00 Michael Reichert naka...@gmx.net:

 No, not every mechanical edit. There is no sharp border. The example you
 gave correct errors. Such edits should not have to be discussed. But the
 changeset I gave changed tagging and IMHO did not fix errors (see the
 linked wiki page).



+1, well-meaning tag-normalization should not be tolerated without
discussion, not even if the wiki proposes different tags, while fixing
typos should.

cheers,
Martin
___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] undiscussed (?) mechanical edit on diet:vegan and diet:vegetarian

2014-05-20 Thread colliar
Am 20.05.2014 13:04, schrieb Martin Koppenhoefer:
 
 2014-05-20 12:42 GMT+02:00 Michael Reichert naka...@gmx.net
 mailto:naka...@gmx.net:
 
 No, not every mechanical edit. There is no sharp border. The example you
 gave correct errors. Such edits should not have to be discussed. But the
 changeset I gave changed tagging and IMHO did not fix errors (see the
 linked wiki page).
 
 
 
 +1, well-meaning tag-normalization should not be tolerated without
 discussion, not even if the wiki proposes different tags, while fixing
 typos should.

+1

but please be friendly and explain the difference to the user. IMHO we
should add this information to the wiki.

colliar




signature.asc
Description: OpenPGP digital signature
___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


[OSM-talk] undiscussed (?) mechanical edit on diet:vegan and diet:vegetarian

2014-05-20 Thread John Packer
For a more complete picture:
This user (BuganiniQ) first added diet:vegetarian=yes and diet:vegan=yes to
places with cuisine=vegan, and diet:vegetarian=yes to places with
cuisine=vegetarian.
It does not seem too much of a stretch to do that.

Then later he corrected these tags to diet:vegan=only to places with
cuisine=vegan (without diet:vegetarian=yes) and diet:vegetarian=only to
places with cuisine=vegetarian.
The question really is whether he removed/changed tags only from the
objects he added these tags, or if he just selected all of them.

Cheers,
John

2014-05-20 12:42 GMT+02:00 Michael Reichert nakaner at gmx.net:

 No, not every mechanical edit. There is no sharp border. The example you
 gave correct errors. Such edits should not have to be discussed. But the
 changeset I gave changed tagging and IMHO did not fix errors (see the
 linked wiki page).



+1, well-meaning tag-normalization should not be tolerated without
discussion, not even if the wiki proposes different tags, while fixing
typos should.

cheers,
Martin
___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] undiscussed (?) mechanical edit on diet:vegan and diet:vegetarian

2014-05-20 Thread Philip Barnes
On Tue, 2014-05-20 at 13:25 -0300, John Packer wrote:
 For a more complete picture:
 
 This user (BuganiniQ) first added diet:vegetarian=yes and
 diet:vegan=yes to places with cuisine=vegan, and diet:vegetarian=yes
 to places with cuisine=vegetarian.
 
 It does not seem too much of a stretch to do that.
 
 
 Then later he corrected these tags to diet:vegan=only to places with
 cuisine=vegan (without diet:vegetarian=yes) and diet:vegetarian=only
 to places with cuisine=vegetarian.
 
 The question really is whether he removed/changed tags only from the
 objects he added these tags, or if he just selected all of them.
 
I would question whether vegan or vegetarian are types of cuisine. You
can have vegetarian restaurants serving very different cuisines, tagging
such as cuisine=indian diet=vegetarian, cuisine=british diet=vegetarian.
If you use cuisine=vegetarian then you loose that important information.

Phil (trigpoint)



___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk