[rt.cpan.org #125597] Compilation problem applying Makefile.PL --tclconfig

[SJ Luo via RT]

https://rt.cpan.org/Ticket/Display.html?id=125597 >

Hi,

   My patch for Cygwin as well as needed libtclstub8.4.a are attached. It makes 
Cygwin build method much more like Linux: No longer forcing --telconfig and no 
tcl-devel package necessary to compile it.
   Note that the directory structure and names in tclstub84_cyg.tar.gz have to 
be kept.

   Though the stub lib is 8.4, they are well compiled on both 32/64bit Cygwin 
2.10 with tcl-8.6 pre-installed and passed all 'make test' items.

SJ

--- Tcl-1.05-UjbRn3/Makefile.PL	2016-06-29 00:48:16.0 +0800
+++ Tcl-1.05-SJ/Makefile.PL	2018-06-22 22:50:36.943227700 +0800
@@ -45,7 +45,8 @@
 $arch = "$^O-ia64" if ($Config{archname} =~ /ia64/i);
 $arch = "$^O-x86_64" if ($Config{archname} =~ /x86_64/);
 } elsif ($^O eq "cygwin") {
-$tclconfig = '/usr/lib/tclConfig.sh';
+$arch = "$^O-i686" if ($Config{archname} =~ /i\d86/);
+$arch = "$^O-x86_64" if ($Config{archname} =~ /x86_64/);
 }
 
 sub _die ($) {


tclstub84_cyg.tar.gz
Description: application/gzip

[rt.cpan.org #125597] Compilation problem applying Makefile.PL --tclconfig

[Vadim Konovalov via RT]

https://rt.cpan.org/Ticket/Display.html?id=125597 >

I even made change more like this:

diff --git a/Makefile.PL b/Makefile.PL
index 0529e13..3d14db0 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -38,12 +38,10 @@ if ($^O eq "MSWin32") {
 } elsif ($^O eq "hpux") {
 $arch = "$^O-ia64" if ($Config{archname} =~ /ia64/i);
 $arch = "$^O-parisc" if ($Config{archname} =~ /pa-risc/i);
-} elsif ($^O eq "linux") {
+} elsif ($^O eq "linux" or $^O eq "cygwin") {
 $arch = "$^O-i686" if ($Config{archname} =~ /i\d86/);
 $arch = "$^O-ia64" if ($Config{archname} =~ /ia64/i);
 $arch = "$^O-x86_64" if ($Config{archname} =~ /x86_64/);
-} elsif ($^O eq "cygwin") {
-$tclconfig = '/usr/lib/tclConfig.sh';
 }

 sub _die ($) {

thank you!
soon to release

[rt.cpan.org #125597] Compilation problem applying Makefile.PL --tclconfig

[SJ Luo via RT]

https://rt.cpan.org/Ticket/Display.html?id=125597 >

I've checked the head branch on github. There is no problem compiling on my 
Cygwin with default configuration now. Thanks for the apply.

SJ

[rt.cpan.org #125597] Compilation problem applying Makefile.PL --tclconfig

[Vadim Konovalov via RT]

https://rt.cpan.org/Ticket/Display.html?id=125597 >

I even made change more like this:

diff --git a/Makefile.PL b/Makefile.PL
index 0529e13..3d14db0 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -38,12 +38,10 @@ if ($^O eq "MSWin32") {
 } elsif ($^O eq "hpux") {
 $arch = "$^O-ia64" if ($Config{archname} =~ /ia64/i);
 $arch = "$^O-parisc" if ($Config{archname} =~ /pa-risc/i);
-} elsif ($^O eq "linux") {
+} elsif ($^O eq "linux" or $^O eq "cygwin") {
 $arch = "$^O-i686" if ($Config{archname} =~ /i\d86/);
 $arch = "$^O-ia64" if ($Config{archname} =~ /ia64/i);
 $arch = "$^O-x86_64" if ($Config{archname} =~ /x86_64/);
-} elsif ($^O eq "cygwin") {
-$tclconfig = '/usr/lib/tclConfig.sh';
 }

 sub _die ($) {

thank you!
soon to release

[rt.cpan.org #125597] Compilation problem applying Makefile.PL --tclconfig

[Vadim Konovalov via RT]

https://rt.cpan.org/Ticket/Display.html?id=125597 >

nice. makefile.pl even became a bit shorter.
closing the ticket

what is sub-makefile and when it is used?

[Konovalov, Vadim]

Hi,

In Tcl, Makefile.PL reads:

# This is to allow propagation of this value to sub-Makefile.PLs
$ENV{'TCLSH_PROG'} = $tclsh;

Going to get rid of this;

Does Tkx somehow depend on this?

Same thing for these lines in Tcl::Tk's Makefile.PL :

# Allow the tclsh prog to be provided by env var or arg
if ($tclshArg) {
$tclsh = $tclshArg;
} elsif (defined($ENV{'TCLSH_PROG'})) {
$tclsh = $ENV{'TCLSH_PROG'};
}

Going to get rid of this as well; who use this?

TIA, 
Vadim