Re: Missing check in ftp(1)
On Sun, Jun 27, 2010 at 02:04:27AM +0200, Peter Hessler wrote: Hi Alexander This diff had some issues for me, namely the chunk below. :+ if (line == NULL); However I did adjust it and came up with this instead, does it also fix the issue for you? Ugh, that was real sloppy of me. Yes that actually fixes the issue. The fix i intended didn't. Now it just does nothing, like it is supposed to (The second is with your fix applied): $ echo 'mget -r . ' | ftp ftp://ftp.cs.cmu.edu Segmentation fault (core dumped) $ echo 'mget -r . ' | ./ftp ftp://ftp.cs.cmu.edu $
cwm autogroup fix
Hi tech@,
the autogroup code in xenocara/app/cwm/group.c mixes up windowname and
windowclass.
At least the code doesn't match the man page cwmrc(5).
Below is a proposed fix. I hope that alpine doesn't eat the tabs ...
Regards,
Holger
Index: group.c
===
RCS file: /cvs/xenocara/app/cwm/group.c,v
retrieving revision 1.44
diff -u -r1.44 group.c
--- group.c 11 Apr 2010 16:51:26 - 1.44
+++ group.c 27 Jun 2010 17:17:01 -
@@ -188,12 +188,11 @@
if ((p = strchr(class, ',')) == NULL) {
aw-name = NULL;
- aw-class = xstrdup(class);
} else {
*(p++) = '\0';
- aw-name = xstrdup(class);
- aw-class = xstrdup(p);
+ aw-name = xstrdup(p);
}
+ aw-class = xstrdup(class);
aw-num = no;
TAILQ_INSERT_TAIL(conf-autogroupq, aw, entry);
Re: Missing check in ftp(1)
On 2010 Jun 27 (Sun) at 12:41:21 +0200 (+0200), Alexander Schrijver wrote: :Now it just does nothing, like it is supposed to (The second is with your fix applied): : :$ echo 'mget -r . ' | ftp ftp://ftp.cs.cmu.edu :Segmentation fault (core dumped) :$ echo 'mget -r . ' | ./ftp ftp://ftp.cs.cmu.edu :$ : This fix was just committed. Many thanks for the report! -- Katz' Law: Man and nations will act rationally when all other possibilities have been exhausted.
