Re: [PATCH] [src] usr.bin/sendbug/sendbug.c - update categories
On Tue, Mar 29 2022, Theo Buehler wrote:
> On Tue, Mar 29, 2022 at 08:51:25PM +0200, Jeremie Courreges-Anglas wrote:
>> On Tue, Mar 29 2022, Raf Czlonka wrote:
>> > Hello,
>> >
>> > sparc and vax ports have been retired a while back; add riscv64
>> > while there.
>>
>> Committed, thanks.
>>
>> There are more missing entries I think. If I follow the existing
>> pattern, naming the cpu architectures and not the platforms:
>> - aarch64 is missing
>> - powerpc64 is missing
>> - mips64el is missing
>
> Perhaps we can ditch the architectures list that seems to have been out
> of sync more often than not
For now I have synced the architectures list.
> and reduce categories to something like
> these?
>
> documentation userland kernel
>
> If somebody is smart enough to narrow a bug down to something
> arch-specific, they're hopefully smart enough to mention that in their
> bug report.
I think such a move would make sense but I'm unsure about the details.
Removing "library" may not be a problem. But removing "system" means
that users have to think hard whether the problem lies in kernel or
userland, when the problem may lie between both, or generally be hard to
classify.
Thoughts?
>> and after folding the line because of line wrapping:
>>
>> ok?
>>
>>
>> Index: sendbug.c
>> ===
>> RCS file: /cvs/src/usr.bin/sendbug/sendbug.c,v
>> retrieving revision 1.79
>> diff -u -p -r1.79 sendbug.c
>> --- sendbug.c29 Mar 2022 18:44:12 - 1.79
>> +++ sendbug.c29 Mar 2022 18:49:41 -
>> @@ -44,7 +44,8 @@ void template(FILE *);
>> voidusbdevs(FILE *);
>>
>> const char *categories = "system user library documentation kernel "
>> -"alpha amd64 arm hppa i386 m88k mips64 powerpc riscv64 sh sparc64";
>> +"alpha aarch64 amd64 arm hppa i386 m88k mips64 mips64el powerpc
>> powerpc64 "
>> +"riscv64 sh sparc64";
>> const char *comment[] = {
>> "",
>> "",
>>
>> --
>> jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
>>
>
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
Re: [PATCH] [src] usr.bin/sendbug/sendbug.c - update categories
On 2022/03/29 21:05, Theo Buehler wrote:
> On Tue, Mar 29, 2022 at 08:51:25PM +0200, Jeremie Courreges-Anglas wrote:
> > On Tue, Mar 29 2022, Raf Czlonka wrote:
> > > Hello,
> > >
> > > sparc and vax ports have been retired a while back; add riscv64
> > > while there.
> >
> > Committed, thanks.
> >
> > There are more missing entries I think. If I follow the existing
> > pattern, naming the cpu architectures and not the platforms:
> > - aarch64 is missing
> > - powerpc64 is missing
> > - mips64el is missing
>
> Perhaps we can ditch the architectures list that seems to have been out
> of sync more often than not and reduce categories to something like
> these?
>
> documentation userland kernel
+1
> If somebody is smart enough to narrow a bug down to something
> arch-specific, they're hopefully smart enough to mention that in their
> bug report.
>
> > and after folding the line because of line wrapping:
> >
> > ok?
> >
> >
> > Index: sendbug.c
> > ===
> > RCS file: /cvs/src/usr.bin/sendbug/sendbug.c,v
> > retrieving revision 1.79
> > diff -u -p -r1.79 sendbug.c
> > --- sendbug.c 29 Mar 2022 18:44:12 - 1.79
> > +++ sendbug.c 29 Mar 2022 18:49:41 -
> > @@ -44,7 +44,8 @@ void template(FILE *);
> > void usbdevs(FILE *);
> >
> > const char *categories = "system user library documentation kernel "
> > -"alpha amd64 arm hppa i386 m88k mips64 powerpc riscv64 sh sparc64";
> > +"alpha aarch64 amd64 arm hppa i386 m88k mips64 mips64el powerpc
> > powerpc64 "
> > +"riscv64 sh sparc64";
> > const char *comment[] = {
> > "",
> > "",
> >
> > --
> > jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
> >
>
Re: [PATCH] [src] usr.bin/sendbug/sendbug.c - update categories
On Tue, Mar 29, 2022 at 08:05:25PM BST, Theo Buehler wrote:
> On Tue, Mar 29, 2022 at 08:51:25PM +0200, Jeremie Courreges-Anglas wrote:
> > On Tue, Mar 29 2022, Raf Czlonka wrote:
> > > Hello,
> > >
> > > sparc and vax ports have been retired a while back; add riscv64
> > > while there.
> >
> > Committed, thanks.
> >
> > There are more missing entries I think. If I follow the existing
> > pattern, naming the cpu architectures and not the platforms:
> > - aarch64 is missing
> > - powerpc64 is missing
> > - mips64el is missing
>
> Perhaps we can ditch the architectures list that seems to have been out
> of sync more often than not and reduce categories to something like
> these?
>
> documentation userland kernel
>
> If somebody is smart enough to narrow a bug down to something
> arch-specific, they're hopefully smart enough to mention that in their
> bug report.
Hi Theo,
My initial thought was to simply remove the whole second line leaving only:
const char *categories = "system user library documentation kernel"
Regards,
Raf
Index: usr.bin/sendbug/sendbug.c
===
RCS file: /cvs/src/usr.bin/sendbug/sendbug.c,v
retrieving revision 1.78
diff -u -p -r1.78 sendbug.c
--- usr.bin/sendbug/sendbug.c 21 Aug 2017 21:41:13 - 1.78
+++ usr.bin/sendbug/sendbug.c 29 Mar 2022 21:21:28 -
@@ -43,8 +43,7 @@ int sendmail(const char *);
void template(FILE *);
void usbdevs(FILE *);
-const char *categories = "system user library documentation kernel "
-"alpha amd64 arm hppa i386 m88k mips64 powerpc sh sparc sparc64 vax";
+const char *categories = "system user library documentation kernel"
const char *comment[] = {
"",
"",
>
> > and after folding the line because of line wrapping:
> >
> > ok?
> >
> >
> > Index: sendbug.c
> > ===
> > RCS file: /cvs/src/usr.bin/sendbug/sendbug.c,v
> > retrieving revision 1.79
> > diff -u -p -r1.79 sendbug.c
> > --- sendbug.c 29 Mar 2022 18:44:12 - 1.79
> > +++ sendbug.c 29 Mar 2022 18:49:41 -
> > @@ -44,7 +44,8 @@ void template(FILE *);
> > void usbdevs(FILE *);
> >
> > const char *categories = "system user library documentation kernel "
> > -"alpha amd64 arm hppa i386 m88k mips64 powerpc riscv64 sh sparc64";
> > +"alpha aarch64 amd64 arm hppa i386 m88k mips64 mips64el powerpc
> > powerpc64 "
> > +"riscv64 sh sparc64";
> > const char *comment[] = {
> > "",
> > "",
> >
> > --
> > jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
> >
Re: [PATCH] [src] usr.bin/sendbug/sendbug.c - update categories
On Tue, Mar 29, 2022 at 08:51:25PM +0200, Jeremie Courreges-Anglas wrote:
> On Tue, Mar 29 2022, Raf Czlonka wrote:
> > Hello,
> >
> > sparc and vax ports have been retired a while back; add riscv64
> > while there.
>
> Committed, thanks.
>
> There are more missing entries I think. If I follow the existing
> pattern, naming the cpu architectures and not the platforms:
> - aarch64 is missing
> - powerpc64 is missing
> - mips64el is missing
Perhaps we can ditch the architectures list that seems to have been out
of sync more often than not and reduce categories to something like
these?
documentation userland kernel
If somebody is smart enough to narrow a bug down to something
arch-specific, they're hopefully smart enough to mention that in their
bug report.
> and after folding the line because of line wrapping:
>
> ok?
>
>
> Index: sendbug.c
> ===
> RCS file: /cvs/src/usr.bin/sendbug/sendbug.c,v
> retrieving revision 1.79
> diff -u -p -r1.79 sendbug.c
> --- sendbug.c 29 Mar 2022 18:44:12 - 1.79
> +++ sendbug.c 29 Mar 2022 18:49:41 -
> @@ -44,7 +44,8 @@ voidtemplate(FILE *);
> void usbdevs(FILE *);
>
> const char *categories = "system user library documentation kernel "
> -"alpha amd64 arm hppa i386 m88k mips64 powerpc riscv64 sh sparc64";
> +"alpha aarch64 amd64 arm hppa i386 m88k mips64 mips64el powerpc
> powerpc64 "
> +"riscv64 sh sparc64";
> const char *comment[] = {
> "",
> "",
>
> --
> jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
>
Re: [PATCH] [src] usr.bin/sendbug/sendbug.c - update categories
On Tue, Mar 29, 2022 at 07:51:25PM BST, Jeremie Courreges-Anglas wrote:
> On Tue, Mar 29 2022, Raf Czlonka wrote:
> > Hello,
> >
> > sparc and vax ports have been retired a while back; add riscv64
> > while there.
>
> Committed, thanks.
>
> There are more missing entries I think. If I follow the existing
> pattern, naming the cpu architectures and not the platforms:
> - aarch64 is missing
> - powerpc64 is missing
> - mips64el is missing
Hi Jeremie,
Yeah, I though about but wasn't sure which way to go - in the end,
I followed each link under supported platform from plat.html[0] and
used the descriptions found there.
A small comment in sendbug.c might help I guess.
Either way, whichever works best :^)
[0] https://www.openbsd.org/plat.html
Regards,
Raf
> and after folding the line because of line wrapping:
>
> ok?
>
>
> Index: sendbug.c
> ===
> RCS file: /cvs/src/usr.bin/sendbug/sendbug.c,v
> retrieving revision 1.79
> diff -u -p -r1.79 sendbug.c
> --- sendbug.c 29 Mar 2022 18:44:12 - 1.79
> +++ sendbug.c 29 Mar 2022 18:49:41 -
> @@ -44,7 +44,8 @@ voidtemplate(FILE *);
> void usbdevs(FILE *);
>
> const char *categories = "system user library documentation kernel "
> -"alpha amd64 arm hppa i386 m88k mips64 powerpc riscv64 sh sparc64";
> +"alpha aarch64 amd64 arm hppa i386 m88k mips64 mips64el powerpc
> powerpc64 "
> +"riscv64 sh sparc64";
> const char *comment[] = {
> "",
> "",
>
> --
> jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
Re: [PATCH] [src] usr.bin/sendbug/sendbug.c - update categories
On Tue, Mar 29 2022, Raf Czlonka wrote:
> Hello,
>
> sparc and vax ports have been retired a while back; add riscv64
> while there.
Committed, thanks.
There are more missing entries I think. If I follow the existing
pattern, naming the cpu architectures and not the platforms:
- aarch64 is missing
- powerpc64 is missing
- mips64el is missing
and after folding the line because of line wrapping:
ok?
Index: sendbug.c
===
RCS file: /cvs/src/usr.bin/sendbug/sendbug.c,v
retrieving revision 1.79
diff -u -p -r1.79 sendbug.c
--- sendbug.c 29 Mar 2022 18:44:12 - 1.79
+++ sendbug.c 29 Mar 2022 18:49:41 -
@@ -44,7 +44,8 @@ void template(FILE *);
void usbdevs(FILE *);
const char *categories = "system user library documentation kernel "
-"alpha amd64 arm hppa i386 m88k mips64 powerpc riscv64 sh sparc64";
+"alpha aarch64 amd64 arm hppa i386 m88k mips64 mips64el powerpc powerpc64 "
+"riscv64 sh sparc64";
const char *comment[] = {
"",
"",
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
[PATCH] [src] usr.bin/sendbug/sendbug.c - update categories
Hello,
sparc and vax ports have been retired a while back; add riscv64
while there.
Regards,
Raf
Index: usr.bin/sendbug/sendbug.c
===
RCS file: /cvs/src/usr.bin/sendbug/sendbug.c,v
retrieving revision 1.78
diff -u -p -r1.78 sendbug.c
--- usr.bin/sendbug/sendbug.c 21 Aug 2017 21:41:13 - 1.78
+++ usr.bin/sendbug/sendbug.c 29 Mar 2022 17:39:38 -
@@ -44,7 +44,7 @@ void template(FILE *);
void usbdevs(FILE *);
const char *categories = "system user library documentation kernel "
-"alpha amd64 arm hppa i386 m88k mips64 powerpc sh sparc sparc64 vax";
+"alpha amd64 arm hppa i386 m88k mips64 powerpc riscv64 sh sparc64";
const char *comment[] = {
"",
"",
