Re: Grammatical changes to httpd.conf(5)

2016-03-08 Thread Sevan Janiyan


On 08/03/2016 07:04, Jason McIntyre wrote:
> i think it's better to submit changes where there is a clear
> improvement, or where we can definitely say what's there now is
> incorrect.

Ok, no worries.


Sevan



Re: Grammatical changes to httpd.conf(5)

2016-03-07 Thread Jason McIntyre
On Tue, Mar 08, 2016 at 12:01:45AM +, Sevan Janiyan wrote:
> 
> 
> On 07/03/2016 19:14, Jason McIntyre wrote:
> > all of your changes appear to be for the sake of preference, rather than
> > that what's there is incorrect. it would be better then to state why you
> > think your change is neccessary. i don;t feel any of these changes are
> > improvements.
> > 
> > language is flexible, that's all. i'm not generally in favour of
> > changing something just because we can.
> 

morning.

> Sure thing.
> 1) An interface is not a type of address, referencing the interface
> triggers the system to look up the address associated with the interface.

the text does not say that it is a type of address. it means if the
contents of the "address" argument is an interface name... it also says
"If `*' is given as an address" without implying that. your text makes
it less clear, i'd say.

> 2) you reference in a particular syntax, not of a particular syntax

the text that is there is not incorrect, as i said. nor is it ambiguous,
or unclear.

> 3) I agree for the changes in the last paragraph doesn't add anything
> but changes style. twice is succinct :)
> 

yes, twice is nicer. but what's there is another way of saying twice,
and not wrong. why change it? i might, if i were making other changes i
guess.

i think it's better to submit changes where there is a clear
improvement, or where we can definitely say what's there now is
incorrect.

jmc

> 
> Regards
> 
> 
> Sevan
> 



Re: Grammatical changes to httpd.conf(5)

2016-03-07 Thread Sevan Janiyan


On 07/03/2016 19:14, Jason McIntyre wrote:
> all of your changes appear to be for the sake of preference, rather than
> that what's there is incorrect. it would be better then to state why you
> think your change is neccessary. i don;t feel any of these changes are
> improvements.
> 
> language is flexible, that's all. i'm not generally in favour of
> changing something just because we can.

Sure thing.
1) An interface is not a type of address, referencing the interface
triggers the system to look up the address associated with the interface.
2) you reference in a particular syntax, not of a particular syntax
3) I agree for the changes in the last paragraph doesn't add anything
but changes style. twice is succinct :)


Regards


Sevan



Grammatical changes to httpd.conf(5)

2016-03-07 Thread Sevan Janiyan
Hi,
Attached diff makes some grammatical adjustments to httpd.conf(5)



Sevan
Index: src/usr.sbin/httpd/httpd.conf.5
===
RCS file: /cvs/src/usr.sbin/httpd/httpd.conf.5,v
retrieving revision 1.68
diff -u -p -u -r1.68 httpd.conf.5
--- src/usr.sbin/httpd/httpd.conf.5 19 Jul 2015 05:17:27 -  1.68
+++ src/usr.sbin/httpd/httpd.conf.5 7 Mar 2016 18:43:12 -
@@ -45,7 +45,7 @@ a host
 .Ar address
 can be specified by IPv4 address, IPv6 address, interface name,
 interface group, or DNS hostname.
-If the address is an interface name,
+If an interface name is referenced,
 .Xr httpd 8
 will look up the first IPv4 address and any other IPv4 and IPv6
 addresses of the specified network interface.
@@ -501,7 +501,7 @@ and
 .Pp
 The
 .Ic types
-section must include one or more lines of the following syntax:
+section must include one or more lines in the following syntax:
 .Bl -tag -width Ds
 .It Ar type/subtype Ar name Op Ar name ...
 Set the media
@@ -517,9 +517,9 @@ Include types definitions from an extern
 .Pa /usr/share/misc/mime.types .
 .El
 .Sh EXAMPLES
-The following example will start one server that is pre-forked two
-times and is listening on all local IP addresses.
-It additionally defines some media types overriding the defaults.
+The following example will start one server that is pre-forked twice
+and is listening on all local IP addresses.
+Additionally, it defines some media types, overriding the defaults.
 .Bd -literal -offset indent
 prefork 2
 


Re: Grammatical changes to httpd.conf(5)

2016-03-07 Thread Jason McIntyre
On Mon, Mar 07, 2016 at 06:53:50PM +, Sevan Janiyan wrote:
> Hi,
> Attached diff makes some grammatical adjustments to httpd.conf(5)
> 
> 
> 
> Sevan

hi.

all of your changes appear to be for the sake of preference, rather than
that what's there is incorrect. it would be better then to state why you
think your change is neccessary. i don;t feel any of these changes are
improvements.

language is flexible, that's all. i'm not generally in favour of
changing something just because we can.

jmc

> Index: src/usr.sbin/httpd/httpd.conf.5
> ===
> RCS file: /cvs/src/usr.sbin/httpd/httpd.conf.5,v
> retrieving revision 1.68
> diff -u -p -u -r1.68 httpd.conf.5
> --- src/usr.sbin/httpd/httpd.conf.5   19 Jul 2015 05:17:27 -  1.68
> +++ src/usr.sbin/httpd/httpd.conf.5   7 Mar 2016 18:43:12 -
> @@ -45,7 +45,7 @@ a host
>  .Ar address
>  can be specified by IPv4 address, IPv6 address, interface name,
>  interface group, or DNS hostname.
> -If the address is an interface name,
> +If an interface name is referenced,
>  .Xr httpd 8
>  will look up the first IPv4 address and any other IPv4 and IPv6
>  addresses of the specified network interface.
> @@ -501,7 +501,7 @@ and
>  .Pp
>  The
>  .Ic types
> -section must include one or more lines of the following syntax:
> +section must include one or more lines in the following syntax:
>  .Bl -tag -width Ds
>  .It Ar type/subtype Ar name Op Ar name ...
>  Set the media
> @@ -517,9 +517,9 @@ Include types definitions from an extern
>  .Pa /usr/share/misc/mime.types .
>  .El
>  .Sh EXAMPLES
> -The following example will start one server that is pre-forked two
> -times and is listening on all local IP addresses.
> -It additionally defines some media types overriding the defaults.
> +The following example will start one server that is pre-forked twice
> +and is listening on all local IP addresses.
> +Additionally, it defines some media types, overriding the defaults.
>  .Bd -literal -offset indent
>  prefork 2
>