Re: rpki-client sync output at end of run with output file

2021-10-28 Thread Claudio Jeker
On Thu, Oct 28, 2021 at 08:27:40PM +0200, Theo Buehler wrote:
> On Thu, Oct 28, 2021 at 08:21:12PM +0200, Claudio Jeker wrote:
> > As in $SUBJECT said, sync the output at the end of a rpki-client run with
> > outputheader() -- the function used to dump this info into the openbgpd
> > output file.
> > 
> > OK?
> > -- 
> > :wq Claudio
> > 
> > Index: main.c
> > ===
> > RCS file: /cvs/src/usr.sbin/rpki-client/main.c,v
> > retrieving revision 1.156
> > diff -u -p -r1.156 main.c
> > --- main.c  26 Oct 2021 16:59:19 -  1.156
> > +++ main.c  28 Oct 2021 13:52:27 -
> > @@ -1173,8 +1173,13 @@ main(int argc, char *argv[])
> > rc = 1;
> >  
> >  
> > +   logx("Processing time %lld seconds (%lld seconds user, "
> > +   "%lld seconds system)", stats.elapsed_time.tv_sec,
> > +   stats.user_time.tv_sec, stats.system_time.tv_sec);
> 
> This needs (long long) casts for -portable on systems with 32 bit time_t
> (the other output functions also have them).
> 
> otherwise ok
> 

Indeed, will fix and then commit.

-- 
:wq Claudio



Re: rpki-client sync output at end of run with output file

2021-10-28 Thread Theo Buehler
On Thu, Oct 28, 2021 at 08:21:12PM +0200, Claudio Jeker wrote:
> As in $SUBJECT said, sync the output at the end of a rpki-client run with
> outputheader() -- the function used to dump this info into the openbgpd
> output file.
> 
> OK?
> -- 
> :wq Claudio
> 
> Index: main.c
> ===
> RCS file: /cvs/src/usr.sbin/rpki-client/main.c,v
> retrieving revision 1.156
> diff -u -p -r1.156 main.c
> --- main.c26 Oct 2021 16:59:19 -  1.156
> +++ main.c28 Oct 2021 13:52:27 -
> @@ -1173,8 +1173,13 @@ main(int argc, char *argv[])
>   rc = 1;
>  
>  
> + logx("Processing time %lld seconds (%lld seconds user, "
> + "%lld seconds system)", stats.elapsed_time.tv_sec,
> + stats.user_time.tv_sec, stats.system_time.tv_sec);

This needs (long long) casts for -portable on systems with 32 bit time_t
(the other output functions also have them).

otherwise ok

>   logx("Route Origin Authorizations: %zu (%zu failed parse, %zu invalid)",
>   stats.roas, stats.roas_fail, stats.roas_invalid);
> + logx("BGPsec Router Certificates: %zu (%zu invalid)",
> + stats.brks, stats.brks_invalids);
>   logx("Certificates: %zu (%zu failed parse, %zu invalid)",
>   stats.certs, stats.certs_fail, stats.certs_invalid);
>   logx("Trust Anchor Locators: %zu", stats.tals);
> @@ -1182,8 +1187,6 @@ main(int argc, char *argv[])
>   stats.mfts, stats.mfts_fail, stats.mfts_stale);
>   logx("Certificate revocation lists: %zu", stats.crls);
>   logx("Ghostbuster records: %zu", stats.gbrs);
> - logx("BGPsec Router Certificates: %zu (%zu invalid)",
> - stats.brks, stats.brks_invalids);
>   logx("Repositories: %zu", stats.repos);
>   logx("Cleanup: removed %zu files, %zu directories",
>   stats.del_files, stats.del_dirs);
>