Re: Uninitialised variable in sys/arch/armv7/exynos/crosec.c

[Jonathan Gray]

On Wed, Jun 08, 2016 at 08:51:28PM +0100, Tom Cosgrove wrote:
> Hi
> 
> I can't test this :) but it might bite someone who was trying to hack
> in this area.
> 
> Thanks
> 
> Tom

Thanks, committed.  I'm not aware of anyone with a working exynos setup
so this can't break anything.

> 
> 
> Index: sys/arch/armv7/exynos/crosec.c
> ===
> RCS file: /home/OpenBSD/cvs/src/sys/arch/armv7/exynos/crosec.c,v
> retrieving revision 1.1
> diff -u -p -u -r1.1 crosec.c
> --- sys/arch/armv7/exynos/crosec.c26 Jan 2015 02:48:24 -  1.1
> +++ sys/arch/armv7/exynos/crosec.c8 Jun 2016 19:52:58 -
> @@ -222,7 +222,7 @@ cros_ec_command_inptr(struct cros_ec_sof
>   int ret;
>  
>   delay(5);
> - cros_ec_send_command(sc, EC_CMD_GET_COMMS_STATUS, 0,
> + ret = cros_ec_send_command(sc, EC_CMD_GET_COMMS_STATUS, 
> 0,
>   NULL, 0,
>   (uint8_t **), sizeof(*resp));
>   if (ret < 0)
> 

Uninitialised variable in sys/arch/armv7/exynos/crosec.c

[Tom Cosgrove]

Hi

I can't test this :) but it might bite someone who was trying to hack
in this area.

Thanks

Tom


Index: sys/arch/armv7/exynos/crosec.c
===
RCS file: /home/OpenBSD/cvs/src/sys/arch/armv7/exynos/crosec.c,v
retrieving revision 1.1
diff -u -p -u -r1.1 crosec.c
--- sys/arch/armv7/exynos/crosec.c  26 Jan 2015 02:48:24 -  1.1
+++ sys/arch/armv7/exynos/crosec.c  8 Jun 2016 19:52:58 -
@@ -222,7 +222,7 @@ cros_ec_command_inptr(struct cros_ec_sof
int ret;
 
delay(5);
-   cros_ec_send_command(sc, EC_CMD_GET_COMMS_STATUS, 0,
+   ret = cros_ec_send_command(sc, EC_CMD_GET_COMMS_STATUS, 
0,
NULL, 0,
(uint8_t **), sizeof(*resp));
if (ret < 0)