Re: bnx(4): enable checksum offload

[mxb]

This is

bnx0 at pci3 dev 4 function 0 "Broadcom BCM5706" rev 0x02

On 8 okt 2013, at 22:34, mxb  wrote:

> 
> I have it spinning now. 
> 
> bnx0: 
> flags=28b43 
> mtu 1500
>hwfeatures=36 hardmtu 
> 1500
>lladdr 00:14:c2:5d:31:a8
>priority: 0
>trunk: trunkdev trunk0
>media: Ethernet autoselect (1000baseT 
> full-duplex,master,rxpause,txpause)
>status: active
> 
> So far - no problems.
> 
> //mxb
> 
> On 9 sep 2013, at 21:46, Brad Smith  wrote:
> 
>> Here is a diff to enable the checksum offload support for bnx(4).
>> 
>> Looking for any testing.
>> 
>> 
>> Index: if_bnx.c
>> ===
>> RCS file: /home/cvs/src/sys/dev/pci/if_bnx.c,v
>> retrieving revision 1.101
>> diff -u -p -r1.101 if_bnx.c
>> --- if_bnx.c 28 Mar 2013 17:21:44 -  1.101
>> +++ if_bnx.c 9 Sep 2013 18:43:07 -
>> @@ -884,11 +884,8 @@ bnx_attachhook(void *xsc)
>>  bcopy(sc->eaddr, sc->arpcom.ac_enaddr, ETHER_ADDR_LEN);
>>  bcopy(sc->bnx_dev.dv_xname, ifp->if_xname, IFNAMSIZ);
>> 
>> -ifp->if_capabilities = IFCAP_VLAN_MTU;
>> -
>> -#ifdef BNX_CSUM
>> -ifp->if_capabilities |= IFCAP_CSUM_TCPv4 | IFCAP_CSUM_UDPv4;
>> -#endif  
>> +ifp->if_capabilities = IFCAP_VLAN_MTU | IFCAP_CSUM_TCPv4 |
>> +IFCAP_CSUM_UDPv4;
>> 
>> #if NVLAN > 0
>>  ifp->if_capabilities |= IFCAP_VLAN_HWTAGGING;
>> 
>> -- 
>> This message has been scanned for viruses and
>> dangerous content by MailScanner, and is
>> believed to be clean.
>> 
> 

Re: bnx(4): enable checksum offload

[mxb]

I have it spinning now. 

bnx0: 
flags=28b43 
mtu 1500
hwfeatures=36 hardmtu 
1500
lladdr 00:14:c2:5d:31:a8
priority: 0
trunk: trunkdev trunk0
media: Ethernet autoselect (1000baseT 
full-duplex,master,rxpause,txpause)
status: active

So far - no problems.

//mxb

On 9 sep 2013, at 21:46, Brad Smith  wrote:

> Here is a diff to enable the checksum offload support for bnx(4).
> 
> Looking for any testing.
> 
> 
> Index: if_bnx.c
> ===
> RCS file: /home/cvs/src/sys/dev/pci/if_bnx.c,v
> retrieving revision 1.101
> diff -u -p -r1.101 if_bnx.c
> --- if_bnx.c  28 Mar 2013 17:21:44 -  1.101
> +++ if_bnx.c  9 Sep 2013 18:43:07 -
> @@ -884,11 +884,8 @@ bnx_attachhook(void *xsc)
>   bcopy(sc->eaddr, sc->arpcom.ac_enaddr, ETHER_ADDR_LEN);
>   bcopy(sc->bnx_dev.dv_xname, ifp->if_xname, IFNAMSIZ);
> 
> - ifp->if_capabilities = IFCAP_VLAN_MTU;
> -
> -#ifdef BNX_CSUM
> - ifp->if_capabilities |= IFCAP_CSUM_TCPv4 | IFCAP_CSUM_UDPv4;
> -#endif   
> + ifp->if_capabilities = IFCAP_VLAN_MTU | IFCAP_CSUM_TCPv4 |
> + IFCAP_CSUM_UDPv4;
> 
> #if NVLAN > 0
>   ifp->if_capabilities |= IFCAP_VLAN_HWTAGGING;
> 
> -- 
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.
> 

bnx(4): enable checksum offload

[Brad Smith]

Here is a diff to enable the checksum offload support for bnx(4).

Looking for any testing.


Index: if_bnx.c
===
RCS file: /home/cvs/src/sys/dev/pci/if_bnx.c,v
retrieving revision 1.101
diff -u -p -r1.101 if_bnx.c
--- if_bnx.c28 Mar 2013 17:21:44 -  1.101
+++ if_bnx.c9 Sep 2013 18:43:07 -
@@ -884,11 +884,8 @@ bnx_attachhook(void *xsc)
bcopy(sc->eaddr, sc->arpcom.ac_enaddr, ETHER_ADDR_LEN);
bcopy(sc->bnx_dev.dv_xname, ifp->if_xname, IFNAMSIZ);
 
-   ifp->if_capabilities = IFCAP_VLAN_MTU;
-
-#ifdef BNX_CSUM
-   ifp->if_capabilities |= IFCAP_CSUM_TCPv4 | IFCAP_CSUM_UDPv4;
-#endif 
+   ifp->if_capabilities = IFCAP_VLAN_MTU | IFCAP_CSUM_TCPv4 |
+   IFCAP_CSUM_UDPv4;
 
 #if NVLAN > 0
ifp->if_capabilities |= IFCAP_VLAN_HWTAGGING;

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.