ipv6 atomic draft - rfc6946 diff
Hi, The draft is now an RFC. Perhaps the code should reflect those changes as well ? Index: sys/netinet6/frag6.c === RCS file: /cvs/src/sys/netinet6/frag6.c,v retrieving revision 1.47 diff -u -p -r1.47 frag6.c --- sys/netinet6/frag6.c11 Jun 2013 18:15:54 - 1.47 +++ sys/netinet6/frag6.c22 Aug 2013 06:36:35 - @@ -236,7 +236,7 @@ frag6_input(struct mbuf **mp, int *offp, offset += sizeof(struct ip6_frag); /* -* draft-gont-6man-ipv6-atomic-fragments-00: A host that receives an +* RFC6946: A host that receives an * IPv6 packet which includes a Fragment Header with the Fragment * Offset equal to 0 and the M bit equal to 0 MUST process such * packet in isolation from any other packets/fragments.
Re: ipv6 atomic draft - rfc6946 diff
Have you verified that we follow the RFC, and not just -00 of the draft? On 2013 Aug 21 (Wed) at 23:40:12 -0700 (-0700), Loganaden Velvindron wrote: :Hi, : :The draft is now an RFC. :Perhaps the code should reflect those changes as well ? : : :Index: sys/netinet6/frag6.c :=== :RCS file: /cvs/src/sys/netinet6/frag6.c,v :retrieving revision 1.47 :diff -u -p -r1.47 frag6.c :--- sys/netinet6/frag6.c11 Jun 2013 18:15:54 - 1.47 :+++ sys/netinet6/frag6.c22 Aug 2013 06:36:35 - :@@ -236,7 +236,7 @@ frag6_input(struct mbuf **mp, int *offp, :offset += sizeof(struct ip6_frag); : :/* :-* draft-gont-6man-ipv6-atomic-fragments-00: A host that receives an :+* RFC6946: A host that receives an : * IPv6 packet which includes a Fragment Header with the Fragment : * Offset equal to 0 and the M bit equal to 0 MUST process such : * packet in isolation from any other packets/fragments. : -- It's better to be wanted for murder than not to be wanted at all. -- Marty Winch
Re: ipv6 atomic draft - rfc6946 diff
On Thu, Aug 22, 2013 at 08:53:50AM +0200, Peter Hessler wrote:
Have you verified that we follow the RFC, and not just -00 of the draft?
The table of OSes were updated and some terms were changed:
A host that receives an IPv6 packet that includes a Fragment
Header with the Fragment Offset equal to 0 and the M flag
equal to 0 MUST process that packet in isolation from any other
packets/fragments, even if such packets/fragments contain the same
set {IPv6 Source Address, IPv6 Destination Address, Fragment
Identification}. A received atomic fragment should be
reassembled from the contents of that sole fragment.
bit-flag, and some clarifications added.
On 2013 Aug 21 (Wed) at 23:40:12 -0700 (-0700), Loganaden Velvindron wrote:
:Hi,
:
:The draft is now an RFC.
:Perhaps the code should reflect those changes as well ?
:
:
:Index: sys/netinet6/frag6.c
:===
:RCS file: /cvs/src/sys/netinet6/frag6.c,v
:retrieving revision 1.47
:diff -u -p -r1.47 frag6.c
:--- sys/netinet6/frag6.c11 Jun 2013 18:15:54 - 1.47
:+++ sys/netinet6/frag6.c22 Aug 2013 06:36:35 -
:@@ -236,7 +236,7 @@ frag6_input(struct mbuf **mp, int *offp,
:offset += sizeof(struct ip6_frag);
:
:/*
:-* draft-gont-6man-ipv6-atomic-fragments-00: A host that receives an
:+* RFC6946: A host that receives an
: * IPv6 packet which includes a Fragment Header with the Fragment
: * Offset equal to 0 and the M bit equal to 0 MUST process such
: * packet in isolation from any other packets/fragments.
:
--
It's better to be wanted for murder than not to be wanted at all.
-- Marty Winch
Re: ipv6 atomic draft - rfc6946 diff
On Thu, Aug 22, 2013 at 08:53:50AM +0200, Peter Hessler wrote: Have you verified that we follow the RFC, and not just -00 of the draft? The RFC actually mentions that OpenBSD-current as of 2012 is following the specification so I think this is OK. On 2013 Aug 21 (Wed) at 23:40:12 -0700 (-0700), Loganaden Velvindron wrote: :Hi, : :The draft is now an RFC. :Perhaps the code should reflect those changes as well ? : : :Index: sys/netinet6/frag6.c :=== :RCS file: /cvs/src/sys/netinet6/frag6.c,v :retrieving revision 1.47 :diff -u -p -r1.47 frag6.c :--- sys/netinet6/frag6.c11 Jun 2013 18:15:54 - 1.47 :+++ sys/netinet6/frag6.c22 Aug 2013 06:36:35 - :@@ -236,7 +236,7 @@ frag6_input(struct mbuf **mp, int *offp, :offset += sizeof(struct ip6_frag); : :/* :-* draft-gont-6man-ipv6-atomic-fragments-00: A host that receives an :+* RFC6946: A host that receives an : * IPv6 packet which includes a Fragment Header with the Fragment : * Offset equal to 0 and the M bit equal to 0 MUST process such : * packet in isolation from any other packets/fragments. : -- It's better to be wanted for murder than not to be wanted at all. -- Marty Winch -- :wq Claudio
