Re: loongson/macppc default and staff login class limits coherency

[Theo de Raadt]

Lucas  wrote:

> Hello tech@,
> 
> While using my macppc to try a port I noticed there is a discrepancy
> between login classes limits: default datasize-cur is defined to 2048M
> while staff datasize-cur is 512M. This happened in
> /src/etc/etc.macppc/login.conf 1.12 as "grow limits a bit because clang
> is a pig." A similar change was introduced for loongson in that commit
> too.
> 
> I checked all the arch-specific login.conf for similar discrepancy just
> between default and staff classes. Only these are affected, and only
> datasize-cur is below default's. Find a diff for bumping it.
> 
> Out of curiosity, what is the rationale for bumping limits in one arch
> but not the others? For example, default class' datasize-cur in amd64
> is only 768MB, despite them being more beefy in general than most of
> macppc devices, yet this ship a 2048MB datasize-cur.

Your diff is proposing cranking the amount of memory 1 process can use,
to 3/4 of what the machine physical maxes out to.

I think that is unreasonable.

Our maximums are intended to be functional and reasonable, while yours
are not reasonable.  At that point we might as well remove all limits,
no?

loongson/macppc default and staff login class limits coherency

[Lucas]

Hello tech@,

While using my macppc to try a port I noticed there is a discrepancy
between login classes limits: default datasize-cur is defined to 2048M
while staff datasize-cur is 512M. This happened in
/src/etc/etc.macppc/login.conf 1.12 as "grow limits a bit because clang
is a pig." A similar change was introduced for loongson in that commit
too.

I checked all the arch-specific login.conf for similar discrepancy just
between default and staff classes. Only these are affected, and only
datasize-cur is below default's. Find a diff for bumping it.

Out of curiosity, what is the rationale for bumping limits in one arch
but not the others? For example, default class' datasize-cur in amd64
is only 768MB, despite them being more beefy in general than most of
macppc devices, yet this ship a 2048MB datasize-cur.

-Lucas

PD: is there a easy way in CVS to look at all the affected files by
one commit, very much like Git? for this I used `cvs log -d` and a AWK
script)


Index: etc.loongson/login.conf
===
RCS file: /home/cvs/src/etc/etc.loongson/login.conf,v
retrieving revision 1.13
diff -u -p -r1.13 login.conf
--- etc.loongson/login.conf 12 Mar 2020 15:32:21 -  1.13
+++ etc.loongson/login.conf 31 May 2020 20:45:30 -
@@ -71,7 +71,7 @@ daemon:\
 # Staff have fewer restrictions and can login even when nologins are set.
 #
 staff:\
-   :datasize-cur=768M:\
+   :datasize-cur=1024M:\
:datasize-max=infinity:\
:maxproc-max=512:\
:maxproc-cur=128:\
Index: etc.macppc/login.conf
===
RCS file: /home/cvs/src/etc/etc.macppc/login.conf,v
retrieving revision 1.13
diff -u -p -r1.13 login.conf
--- etc.macppc/login.conf   23 May 2020 13:16:03 -  1.13
+++ etc.macppc/login.conf   31 May 2020 20:45:50 -
@@ -70,7 +70,7 @@ daemon:\
 # Staff have fewer restrictions and can login even when nologins are set.
 #
 staff:\
-   :datasize-cur=512M:\
+   :datasize-cur=2048M:\
:datasize-max=infinity:\
:maxproc-max=512:\
:maxproc-cur=128:\