Re: openssl.pc version

2017-01-09 Thread Sebastien Marie
On Sun, Jan 08, 2017 at 12:29:50PM +0100, Sebastien Marie wrote:
> Hi,
> 
> The "OpenSSL bindings for Rust" checks, using pkg-config, the version of
> openssl installed, and target 1.0.1 as minimal version.
> 
> Under OpenBSD, /usr/lib/pkgconfig/openssl.pc is generated by
> src/lib/libcrypto/generate_pkgconfig.sh, and the "version" is taken from
> SHLIB_VERSION_NUMBER in src/lib/libcrypto/opensslv.h , which is "1.0.0"
> from ages (Oct-2010).
> 
> Does the file should be updated in some way ? I saw LibreSSL -portable
> ship a openssl.pc file with different content (Name: LibreSSL / Version:
> 2.5.0) instead of "Name: OpenSSL" and "Version: 1.0.0" as on OpenBSD.
> 

As LibreSSL forked from 1.0.1g OpenSSL version, I think it makes sens to
report it as 1.0.1 instead of 1.0.0.

Thanks for your comments.
-- 
Sebastien Marie


Index: opensslv.h
===
RCS file: /cvs/src/lib/libcrypto/opensslv.h,v
retrieving revision 1.38
diff -u -p -r1.38 opensslv.h
--- opensslv.h  31 Oct 2016 04:17:17 -  1.38
+++ opensslv.h  9 Jan 2017 17:55:10 -
@@ -12,6 +12,6 @@
 #define OPENSSL_VERSION_PTEXT  " part of " OPENSSL_VERSION_TEXT
 
 #define SHLIB_VERSION_HISTORY ""
-#define SHLIB_VERSION_NUMBER "1.0.0"
+#define SHLIB_VERSION_NUMBER "1.0.1"
 
 #endif /* HEADER_OPENSSLV_H */



openssl.pc version

2017-01-08 Thread Sebastien Marie
Hi,

The "OpenSSL bindings for Rust" checks, using pkg-config, the version of
openssl installed, and target 1.0.1 as minimal version.

Under OpenBSD, /usr/lib/pkgconfig/openssl.pc is generated by
src/lib/libcrypto/generate_pkgconfig.sh, and the "version" is taken from
SHLIB_VERSION_NUMBER in src/lib/libcrypto/opensslv.h , which is "1.0.0"
from ages (Oct-2010).

Does the file should be updated in some way ? I saw LibreSSL -portable
ship a openssl.pc file with different content (Name: LibreSSL / Version:
2.5.0) instead of "Name: OpenSSL" and "Version: 1.0.0" as on OpenBSD.

Thanks.
-- 
Sebastien Marie