Re: ospf6d: remove F_IFACE_AVAIL

2020-05-17 Thread Remi Locherer
On Sat, May 16, 2020 at 08:17:28PM +0200, Denis Fondras wrote:
> This information is never used/checked.
> 

ok remi@

> Index: kroute.c
> ===
> RCS file: /cvs/src/usr.sbin/ospf6d/kroute.c,v
> retrieving revision 1.63
> diff -u -p -r1.63 kroute.c
> --- kroute.c  16 May 2020 15:54:12 -  1.63
> +++ kroute.c  16 May 2020 18:11:51 -
> @@ -761,7 +761,6 @@ kif_update(u_short ifindex, int flags, s
>   return (NULL);
>   if ((iface = if_new(ifindex, ifname)) == NULL)
>   return (NULL);
> - iface->cflags |= F_IFACE_AVAIL;
>   }
>  
>   if_update(iface, ifd->ifi_mtu, flags, ifd->ifi_type,
> @@ -1019,7 +1018,6 @@ if_announce(void *msg)
>   case IFAN_ARRIVAL:
>   if ((iface = if_new(ifan->ifan_index, ifan->ifan_name)) == NULL)
>   fatal("if_announce failed");
> - iface->cflags |= F_IFACE_AVAIL;
>   break;
>   case IFAN_DEPARTURE:
>   iface = if_find(ifan->ifan_index);
> Index: ospf6d.h
> ===
> RCS file: /cvs/src/usr.sbin/ospf6d/ospf6d.h,v
> retrieving revision 1.48
> diff -u -p -r1.48 ospf6d.h
> --- ospf6d.h  16 May 2020 15:54:12 -  1.48
> +++ ospf6d.h  16 May 2020 18:11:51 -
> @@ -330,7 +330,6 @@ struct iface {
>   u_int8_t cflags;
>  #define F_IFACE_PASSIVE  0x01
>  #define F_IFACE_CONFIGURED   0x02
> -#define F_IFACE_AVAIL0x04
>  };
>  
>  struct ifaddrchange {
> 



ospf6d: remove F_IFACE_AVAIL

2020-05-16 Thread Denis Fondras
This information is never used/checked.

Index: kroute.c
===
RCS file: /cvs/src/usr.sbin/ospf6d/kroute.c,v
retrieving revision 1.63
diff -u -p -r1.63 kroute.c
--- kroute.c16 May 2020 15:54:12 -  1.63
+++ kroute.c16 May 2020 18:11:51 -
@@ -761,7 +761,6 @@ kif_update(u_short ifindex, int flags, s
return (NULL);
if ((iface = if_new(ifindex, ifname)) == NULL)
return (NULL);
-   iface->cflags |= F_IFACE_AVAIL;
}
 
if_update(iface, ifd->ifi_mtu, flags, ifd->ifi_type,
@@ -1019,7 +1018,6 @@ if_announce(void *msg)
case IFAN_ARRIVAL:
if ((iface = if_new(ifan->ifan_index, ifan->ifan_name)) == NULL)
fatal("if_announce failed");
-   iface->cflags |= F_IFACE_AVAIL;
break;
case IFAN_DEPARTURE:
iface = if_find(ifan->ifan_index);
Index: ospf6d.h
===
RCS file: /cvs/src/usr.sbin/ospf6d/ospf6d.h,v
retrieving revision 1.48
diff -u -p -r1.48 ospf6d.h
--- ospf6d.h16 May 2020 15:54:12 -  1.48
+++ ospf6d.h16 May 2020 18:11:51 -
@@ -330,7 +330,6 @@ struct iface {
u_int8_t cflags;
 #define F_IFACE_PASSIVE0x01
 #define F_IFACE_CONFIGURED 0x02
-#define F_IFACE_AVAIL  0x04
 };
 
 struct ifaddrchange {