Re: plug mem leak in ldapd/btree.c

2016-11-30 Thread Mike Belopuhov 
On Wed, Nov 30, 2016 at 22:11 +0100, Tim Kuijsten wrote:
> Plug a memory leak in btree_close.
> 
> From 
> https://github.com/OrangeTide/btree/commit/e186331494b213286934bcc03a1d8c4650836e3b
>

Hi Tim,

This looks correct, indeed.

> Index: btree.c
> ===
> RCS file: /cvs/src/usr.sbin/ldapd/btree.c,v
> retrieving revision 1.36
> diff -u -p -r1.36 btree.c
> --- btree.c 20 Mar 2016 00:01:22 -  1.36
> +++ btree.c 30 Nov 2016 21:05:14 -
> @@ -1176,6 +1176,8 @@ btree_close(struct btree *bt)
> DPRINTF("ref is zero, closing btree %p", bt);
> close(bt->fd);
> mpage_flush(bt);
> +   free(bt->lru_queue);
> +   free(bt->path);
> free(bt->page_cache);
> free(bt);
> } else
>

plug mem leak in ldapd/btree.c

2016-11-30 Thread Tim Kuijsten 

Plug a memory leak in btree_close.

From 
https://github.com/OrangeTide/btree/commit/e186331494b213286934bcc03a1d8c4650836e3b


Index: btree.c
===
RCS file: /cvs/src/usr.sbin/ldapd/btree.c,v
retrieving revision 1.36
diff -u -p -r1.36 btree.c
--- btree.c 20 Mar 2016 00:01:22 -  1.36
+++ btree.c 30 Nov 2016 21:05:14 -
@@ -1176,6 +1176,8 @@ btree_close(struct btree *bt)
DPRINTF("ref is zero, closing btree %p", bt);
close(bt->fd);
mpage_flush(bt);
+   free(bt->lru_queue);
+   free(bt->path);
free(bt->page_cache);
free(bt);
} else