quiet ftp

2012-09-02 Thread Ted Unangst
Does anyone else find it weird that -V doesn't turn off the progress
bar?

Index: main.c
===
RCS file: /cvs/src/usr.bin/ftp/main.c,v
retrieving revision 1.85
diff -u -p -r1.85 main.c
--- main.c  26 Aug 2012 02:16:02 -  1.85
+++ main.c  3 Sep 2012 02:10:20 -
@@ -292,6 +292,7 @@ main(volatile int argc, char *argv[])
 
case 'V':
verbose = 0;
+   progress = 0;
break;
 
default:



Re: quiet ftp

2012-09-02 Thread Theo de Raadt
This is intentional.  Look in distrib/miniroot:

install.sub:FTPOPTS=-V

We want the progress bar -- we just don't want any of the other noise.

I suppose with this change, and then using -Vm it could work.  But that
would need testing.  Especially since ftp(1) is compiled with -DSMALL.

grep SMALL /usr/src/*/ftp/*.[ch] | wc -l
 265

 Does anyone else find it weird that -V doesn't turn off the progress
 bar?
 
 Index: main.c
 ===
 RCS file: /cvs/src/usr.bin/ftp/main.c,v
 retrieving revision 1.85
 diff -u -p -r1.85 main.c
 --- main.c26 Aug 2012 02:16:02 -  1.85
 +++ main.c3 Sep 2012 02:10:20 -
 @@ -292,6 +292,7 @@ main(volatile int argc, char *argv[])
  
   case 'V':
   verbose = 0;
 + progress = 0;
   break;
  
   default: