Re: riscv64: drop unused WEAK_REFERENCE macro

2022-12-05 Thread Philip Guenther
On Fri, Dec 2, 2022 at 3:17 PM Jeremie Courreges-Anglas 
wrote:

>
> WEAK_REFERENCE seems to come from FreeBSD, it's not used in our tree.
> (WEAK_ALIAS is defined a few lines above).
>
> ok?
>

ok guenther@


Re: riscv64: drop unused WEAK_REFERENCE macro

2022-12-05 Thread Mike Larkin
On Sat, Dec 03, 2022 at 12:16:43AM +0100, Jeremie Courreges-Anglas wrote:
> 
> WEAK_REFERENCE seems to come from FreeBSD, it's not used in our tree.
> (WEAK_ALIAS is defined a few lines above).
> 
> ok?
> 

ok mlarkin if you didnt get to it already

> 
> Index: sys/arch/riscv64/include/asm.h
> ===
> RCS file: /cvs/src/sys/arch/riscv64/include/asm.h,v
> retrieving revision 1.6
> diff -u -p -r1.6 asm.h
> --- sys/arch/riscv64/include/asm.h2 Dec 2022 12:27:08 -   1.6
> +++ sys/arch/riscv64/include/asm.h2 Dec 2022 23:13:38 -
> @@ -104,10 +104,6 @@
>   .weak alias;\
>   alias = sym
>  
> -#define  WEAK_REFERENCE(sym, alias)  \
> - .weak alias;\
> - .set alias,sym
> -
>  #define  SWAP_FAULT_HANDLER(handler, tmp0, tmp1) \
>   ld  tmp0, CI_CURPCB(tp);/* Load the pcb */  \
>   ld  tmp1, PCB_ONFAULT(tmp0);/* Save old handler */  \
> 
> 
> -- 
> jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE
> 



riscv64: drop unused WEAK_REFERENCE macro

2022-12-02 Thread Jeremie Courreges-Anglas


WEAK_REFERENCE seems to come from FreeBSD, it's not used in our tree.
(WEAK_ALIAS is defined a few lines above).

ok?


Index: sys/arch/riscv64/include/asm.h
===
RCS file: /cvs/src/sys/arch/riscv64/include/asm.h,v
retrieving revision 1.6
diff -u -p -r1.6 asm.h
--- sys/arch/riscv64/include/asm.h  2 Dec 2022 12:27:08 -   1.6
+++ sys/arch/riscv64/include/asm.h  2 Dec 2022 23:13:38 -
@@ -104,10 +104,6 @@
.weak alias;\
alias = sym
 
-#defineWEAK_REFERENCE(sym, alias)  \
-   .weak alias;\
-   .set alias,sym
-
 #defineSWAP_FAULT_HANDLER(handler, tmp0, tmp1) \
ld  tmp0, CI_CURPCB(tp);/* Load the pcb */  \
ld  tmp1, PCB_ONFAULT(tmp0);/* Save old handler */  \


-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE