Re: smtpd: Use IPPORT_HILASTAUTO not 0xffff

2019-07-23 Thread Gilles Chehade
On Tue, Jul 23, 2019 at 12:20:04AM +0200, Klemens Nanni wrote:
> More mnemonic and readable.
> 

indeed, I didn't know about IPPORT_HILASTAUTO :-)

> OK?

yes, ok


> Index: to.c
> ===
> RCS file: /cvs/src/usr.sbin/smtpd/to.c,v
> retrieving revision 1.35
> diff -u -p -r1.35 to.c
> --- to.c  30 Dec 2018 23:09:58 -  1.35
> +++ to.c  22 Jul 2019 22:16:29 -
> @@ -385,7 +385,7 @@ text_to_relayhost(struct relayhost *rela
>   /* finally, we extract the port */
>   p = beg + len;
>   if (*p == ':') {
> - relay->port = strtonum(p+1, 1, 0x, );
> + relay->port = strtonum(p+1, 1, IPPORT_HILASTAUTO, );
>   if (errstr)
>   return 0;
>   }
> 

-- 
Gilles Chehade @poolpOrg

https://www.poolp.orgpatreon: https://www.patreon.com/gilles



smtpd: Use IPPORT_HILASTAUTO not 0xffff

2019-07-22 Thread Klemens Nanni
More mnemonic and readable.

OK?

Index: to.c
===
RCS file: /cvs/src/usr.sbin/smtpd/to.c,v
retrieving revision 1.35
diff -u -p -r1.35 to.c
--- to.c30 Dec 2018 23:09:58 -  1.35
+++ to.c22 Jul 2019 22:16:29 -
@@ -385,7 +385,7 @@ text_to_relayhost(struct relayhost *rela
/* finally, we extract the port */
p = beg + len;
if (*p == ':') {
-   relay->port = strtonum(p+1, 1, 0x, );
+   relay->port = strtonum(p+1, 1, IPPORT_HILASTAUTO, );
if (errstr)
return 0;
}