Re: usbdevs: small addition
On Sun, Feb 23, 2020 at 11:14:37AM +0100, Jasper Lievisse Adriaanse wrote: > On Sun, Feb 23, 2020 at 11:52:10AM +1100, Jonathan Gray wrote: > > On Sat, Feb 22, 2020 at 04:22:25PM +0100, Jasper Lievisse Adriaanse wrote: > > > Hi, > > > > > > - add an AMD product found on the APU2 > > > > I would not consider 0x7900 a root hub as it attaches to another hub > > > > uhub2 at uhub1 port 1 configuration 1 interface 0 "Advanced Micro Devices > > product 0x7900" rev 2.00/0.18 addr 2 > I'll change it to 'Hub' then. > > > > - add vendor id for "Synaptics, Inc. > > > > I'd just go with "Synaptics" > Okey. > > > > - add synaptics fingerprint reader found on recent thinkpads; I couldn't > > > find a proper > > > name for this device in the Linux usb.ids repository so I went with the > > > generic > > > 'Fingerprint Reader" that's also used elsewhere in this file. > > > > does it not supply a string itself? > How would I get the device to do this? If the device has a string it won't show as "product 0x00bd" in dmesg. Going by a dmesg I found it doesn't have a string so adding it is fine. > > > the lenovo windows driver matches on 0x06cb:0x00bd and 0x06cb:0x00c2 > > and calls itself "Synaptics UWP WBDI" which isn't very helpful. > I've added the 0x00c2 to the diff below, re-using the original description > for now. ok jsg@ > > > Index: usbdevs > === > RCS file: /cvs/src/sys/dev/usb/usbdevs,v > retrieving revision 1.710 > diff -u -p -r1.710 usbdevs > --- usbdevs 27 Jan 2020 15:41:42 - 1.710 > +++ usbdevs 23 Feb 2020 10:12:02 - > @@ -262,6 +262,7 @@ vendor AGFA 0x06bd AGFA-Gevaert > vendor ASIAMD0x06be Asia Microelectronic Development > vendor PHIDGETS 0x06c2 Phidgets > vendor BIZLINK 0x06c4 Bizlink International > +vendor SYNAPTICS 0x06cb Synaptics > vendor KEYSPAN 0x06cd Keyspan > vendor AASHIMA 0x06d6 Aashima Technology > vendor LIEBERT 0x06da Liebert > @@ -888,6 +889,9 @@ product ALTI2 NEPTUNE30x6001 Neptune 3 > product AMBIT WLAN 0x0302 WLAN > product AMBIT NTL_2500x6098 NTL 250 cable modem > > +/* Advanced Micro Devices products */ > +product AMD HUB 0x7900 Hub > + > /* Amigo Technology products */ > product AMIGO RT2870_1 0x9031 RT2870 > product AMIGO RT2870_2 0x9041 RT2870 > @@ -4167,6 +4171,10 @@ product SWEEX2 LW153 0x0153 LW153 > product SWEEX2 LW154 0x0154 LW154 > product SWEEX2 LW303 0x0302 LW303 > product SWEEX2 LW313 0x0313 LW313 > + > +/* Synaptics products */ > +product SYNAPTICS FPRINT 0x00bd Fingerprint Reader > +product SYNAPTICS FPRINT_2 0x00c2 Fingerprint Reader > > /* Syntech Information products */ > product SYNTECH SERIAL 0x0001 Serial > > -- > jasper > >
Re: usbdevs: small addition
On Sun, Feb 23, 2020 at 11:52:10AM +1100, Jonathan Gray wrote: > On Sat, Feb 22, 2020 at 04:22:25PM +0100, Jasper Lievisse Adriaanse wrote: > > Hi, > > > > - add an AMD product found on the APU2 > > I would not consider 0x7900 a root hub as it attaches to another hub > > uhub2 at uhub1 port 1 configuration 1 interface 0 "Advanced Micro Devices > product 0x7900" rev 2.00/0.18 addr 2 I'll change it to 'Hub' then. > > - add vendor id for "Synaptics, Inc. > > I'd just go with "Synaptics" Okey. > > - add synaptics fingerprint reader found on recent thinkpads; I couldn't > > find a proper > > name for this device in the Linux usb.ids repository so I went with the > > generic > > 'Fingerprint Reader" that's also used elsewhere in this file. > > does it not supply a string itself? How would I get the device to do this? > the lenovo windows driver matches on 0x06cb:0x00bd and 0x06cb:0x00c2 > and calls itself "Synaptics UWP WBDI" which isn't very helpful. I've added the 0x00c2 to the diff below, re-using the original description for now. Index: usbdevs === RCS file: /cvs/src/sys/dev/usb/usbdevs,v retrieving revision 1.710 diff -u -p -r1.710 usbdevs --- usbdevs 27 Jan 2020 15:41:42 - 1.710 +++ usbdevs 23 Feb 2020 10:12:02 - @@ -262,6 +262,7 @@ vendor AGFA 0x06bd AGFA-Gevaert vendor ASIAMD 0x06be Asia Microelectronic Development vendor PHIDGETS0x06c2 Phidgets vendor BIZLINK 0x06c4 Bizlink International +vendor SYNAPTICS 0x06cb Synaptics vendor KEYSPAN 0x06cd Keyspan vendor AASHIMA 0x06d6 Aashima Technology vendor LIEBERT 0x06da Liebert @@ -888,6 +889,9 @@ product ALTI2 NEPTUNE3 0x6001 Neptune 3 product AMBIT WLAN 0x0302 WLAN product AMBIT NTL_250 0x6098 NTL 250 cable modem +/* Advanced Micro Devices products */ +product AMD HUB0x7900 Hub + /* Amigo Technology products */ product AMIGO RT2870_1 0x9031 RT2870 product AMIGO RT2870_2 0x9041 RT2870 @@ -4167,6 +4171,10 @@ product SWEEX2 LW153 0x0153 LW153 product SWEEX2 LW154 0x0154 LW154 product SWEEX2 LW303 0x0302 LW303 product SWEEX2 LW313 0x0313 LW313 + +/* Synaptics products */ +product SYNAPTICS FPRINT 0x00bd Fingerprint Reader +product SYNAPTICS FPRINT_2 0x00c2 Fingerprint Reader /* Syntech Information products */ product SYNTECH SERIAL 0x0001 Serial -- jasper
Re: usbdevs: small addition
Jonathan Gray wrote: > > - add vendor id for "Synaptics, Inc. > > I'd just go with "Synaptics" It is critical to be as terse as possible, since these tables go into many kernels, some of which are space constrained.
Re: usbdevs: small addition
On Sat, Feb 22, 2020 at 04:22:25PM +0100, Jasper Lievisse Adriaanse wrote: > Hi, > > - add an AMD product found on the APU2 I would not consider 0x7900 a root hub as it attaches to another hub uhub2 at uhub1 port 1 configuration 1 interface 0 "Advanced Micro Devices product 0x7900" rev 2.00/0.18 addr 2 > - add vendor id for "Synaptics, Inc. I'd just go with "Synaptics" > - add synaptics fingerprint reader found on recent thinkpads; I couldn't find > a proper > name for this device in the Linux usb.ids repository so I went with the > generic > 'Fingerprint Reader" that's also used elsewhere in this file. does it not supply a string itself? the lenovo windows driver matches on 0x06cb:0x00bd and 0x06cb:0x00c2 and calls itself "Synaptics UWP WBDI" which isn't very helpful. > > OK? > > Index: usbdevs > === > RCS file: /cvs/src/sys/dev/usb/usbdevs,v > retrieving revision 1.710 > diff -u -p -r1.710 usbdevs > --- usbdevs 27 Jan 2020 15:41:42 - 1.710 > +++ usbdevs 22 Feb 2020 15:21:41 - > @@ -262,6 +262,7 @@ vendor AGFA 0x06bd AGFA-Gevaert > vendor ASIAMD0x06be Asia Microelectronic Development > vendor PHIDGETS 0x06c2 Phidgets > vendor BIZLINK 0x06c4 Bizlink International > +vendor SYNAPTICS 0x06cb Synaptics, Inc. > vendor KEYSPAN 0x06cd Keyspan > vendor AASHIMA 0x06d6 Aashima Technology > vendor LIEBERT 0x06da Liebert > @@ -888,6 +889,9 @@ product ALTI2 NEPTUNE30x6001 Neptune 3 > product AMBIT WLAN 0x0302 WLAN > product AMBIT NTL_2500x6098 NTL 250 cable modem > > +/* Advanced Micro Devices products */ > +product AMD HUB 0x7900 Root Hub > + > /* Amigo Technology products */ > product AMIGO RT2870_1 0x9031 RT2870 > product AMIGO RT2870_2 0x9041 RT2870 > @@ -4167,6 +4171,9 @@ product SWEEX2 LW1530x0153 LW153 > product SWEEX2 LW154 0x0154 LW154 > product SWEEX2 LW303 0x0302 LW303 > product SWEEX2 LW313 0x0313 LW313 > + > +/* Synaptics, Inc. products */ > +product SYNAPTICS FPRINT 0x00bd Fingerprint Reader > > /* Syntech Information products */ > product SYNTECH SERIAL 0x0001 Serial > >
usbdevs: small addition
Hi, - add an AMD product found on the APU2 - add vendor id for "Synaptics, Inc. - add synaptics fingerprint reader found on recent thinkpads; I couldn't find a proper name for this device in the Linux usb.ids repository so I went with the generic 'Fingerprint Reader" that's also used elsewhere in this file. OK? Index: usbdevs === RCS file: /cvs/src/sys/dev/usb/usbdevs,v retrieving revision 1.710 diff -u -p -r1.710 usbdevs --- usbdevs 27 Jan 2020 15:41:42 - 1.710 +++ usbdevs 22 Feb 2020 15:21:41 - @@ -262,6 +262,7 @@ vendor AGFA 0x06bd AGFA-Gevaert vendor ASIAMD 0x06be Asia Microelectronic Development vendor PHIDGETS0x06c2 Phidgets vendor BIZLINK 0x06c4 Bizlink International +vendor SYNAPTICS 0x06cb Synaptics, Inc. vendor KEYSPAN 0x06cd Keyspan vendor AASHIMA 0x06d6 Aashima Technology vendor LIEBERT 0x06da Liebert @@ -888,6 +889,9 @@ product ALTI2 NEPTUNE3 0x6001 Neptune 3 product AMBIT WLAN 0x0302 WLAN product AMBIT NTL_250 0x6098 NTL 250 cable modem +/* Advanced Micro Devices products */ +product AMD HUB0x7900 Root Hub + /* Amigo Technology products */ product AMIGO RT2870_1 0x9031 RT2870 product AMIGO RT2870_2 0x9041 RT2870 @@ -4167,6 +4171,9 @@ product SWEEX2 LW153 0x0153 LW153 product SWEEX2 LW154 0x0154 LW154 product SWEEX2 LW303 0x0302 LW303 product SWEEX2 LW313 0x0313 LW313 + +/* Synaptics, Inc. products */ +product SYNAPTICS FPRINT 0x00bd Fingerprint Reader /* Syntech Information products */ product SYNTECH SERIAL 0x0001 Serial
