Re: what.1: remove BUGS section

2019-01-20 Thread Fabio Scotoni
On 1/20/19 3:11 PM, Ingo Schwarze wrote:
> Hi Fabio,
> 
> Fabio Scotoni wrote on Sun, Jan 20, 2019 at 12:52:18PM +0100:
> 
>> The what(1) man page has a BUGS section,
>> which mdoc(7) says is discouraged in OpenBSD.
> 
> What?  Using BUGS sections is perfectly fine.
> 
> The mdoc(7) manual page does not intend to say that using BUGS
> sections is discouraged in OpenBSD.
> 
> Why do you think it says that?

That's my mistake. I misinterpreted this part in mdoc(7):
160 \&.\e\(dq .Sh BUGS
161 \&.\e\(dq .Sh SECURITY CONSIDERATIONS
162 \&.\e\(dq Not used in OpenBSD.

I mistook the list of section headings near the end to all fall
through to SECURITY CONSIDERATIONS, which says "Not used in OpenBSD."
I should've noticed that assessment being inaccurate because the
STANDARDS section is clearly not discouraged and it's part of the same list.

>> The contents of the BUGS section is mostly unhelpful anyway.
> 
> Indeed, thanks for reporting the weird text.
> It doesn't mention any BUGS, so it's in the wrong section.
> 
>> Talking about BSD not being able to distribute SCCS doesn't help
>> anyone;
>> not behaving like the original SCCS is obvious considering the
>> STANDARDS section specifically notes OpenBSD extensions and
>> compliance with POSIX.
> 
> I almost felt like proposing to delete the utility outright.
> We stopped embedding identifier strings into binaries many years ago.
>> Then again, who knows whether some scripts somewhere still call it.
> Keeping it costs almost nothing, and it is not dangerous.

what(1) *is* in an odd spot, being the only part of SCCS that actually
got rewritten for BSD.

CSSC and Schily SCCS would theoretically also provide what(1) and the
rest of SCCS.



Re: what.1: remove BUGS section

2019-01-20 Thread Paul de Weerd
Hi Ingo,

On Sun, Jan 20, 2019 at 03:11:55PM +0100, Ingo Schwarze wrote:
| > Talking about BSD not being able to distribute SCCS doesn't help
| > anyone;
| > not behaving like the original SCCS is obvious considering the
| > STANDARDS section specifically notes OpenBSD extensions and
| > compliance with POSIX.
| 
| I almost felt like proposing to delete the utility outright.
| We stopped embedding identifier strings into binaries many years ago.
| 
| Then again, who knows whether some scripts somewhere still call it.
| Keeping it costs almost nothing, and it is not dangerous.

It's not completely useless:

[weerd@pom] $ doas what /bsd
/bsd
OpenBSD 6.4-current (GENERIC.MP) #597: Thu Jan 10 21:47:25 MST 2019
[weerd@pom] $ what `which ksh`
/bin/ksh
PD KSH v5.2.14 99/07/13.2

Cheers,

Paul 'WEiRD' de Weerd

-- 
>[<++>-]<+++.>+++[<-->-]<.>+++[<+
+++>-]<.>++[<>-]<+.--.[-]
 http://www.weirdnet.nl/ 



Re: what.1: remove BUGS section

2019-01-20 Thread Ingo Schwarze
Hi Fabio,

Fabio Scotoni wrote on Sun, Jan 20, 2019 at 12:52:18PM +0100:

> The what(1) man page has a BUGS section,
> which mdoc(7) says is discouraged in OpenBSD.

What?  Using BUGS sections is perfectly fine.

The mdoc(7) manual page does not intend to say that using BUGS
sections is discouraged in OpenBSD.

Why do you think it says that?

> The contents of the BUGS section is mostly unhelpful anyway.

Indeed, thanks for reporting the weird text.
It doesn't mention any BUGS, so it's in the wrong section.

> Talking about BSD not being able to distribute SCCS doesn't help
> anyone;
> not behaving like the original SCCS is obvious considering the
> STANDARDS section specifically notes OpenBSD extensions and
> compliance with POSIX.

I almost felt like proposing to delete the utility outright.
We stopped embedding identifier strings into binaries many years ago.

Then again, who knows whether some scripts somewhere still call it.
Keeping it costs almost nothing, and it is not dangerous.

So i only removed the BUGS section with the following commit.

Yours,
  Ingo



CVSROOT:/cvs
Module name:src
Changes by: schwa...@cvs.openbsd.org2019/01/20 07:03:19

Modified files:
usr.bin/what   : what.1 

Log message:
merge weird BUGS section into HISTORY;
issue reported by Fabio Scotoni 


Index: what.1
===
RCS file: /cvs/src/usr.bin/what/what.1,v
retrieving revision 1.19
diff -u -r1.19 what.1
--- what.1  22 Jan 2015 19:10:17 -  1.19
+++ what.1  20 Jan 2019 14:00:44 -
@@ -92,16 +92,6 @@
 .Sh HISTORY
 The
 .Nm
-command appeared in
-.Bx 4.0 .
-.Sh BUGS
-As
-.Bx
-is not licensed to distribute
-.Tn SCCS ,
-this is a rewrite of the
-.Nm
-command which is part of
-.Tn SCCS .
-As such it may not behave exactly the same as that
-command does.
+command first appeared in the SCCS package and was rewritten for
+.Bx 4.0
+for licensing reasons.



what.1: remove BUGS section

2019-01-20 Thread Fabio Scotoni
The what(1) man page has a BUGS section,
which mdoc(7) says is discouraged in OpenBSD.

The contents of the BUGS section is mostly unhelpful anyway.
Talking about BSD not being able to distribute SCCS doesn't help
anyone;
not behaving like the original SCCS is obvious considering the
STANDARDS section specifically notes OpenBSD extensions and
compliance with POSIX.

Index: usr.bin/what/what.1
===
RCS file: /cvs/src/usr.bin/what/what.1,v
retrieving revision 1.19
diff -u -p -r1.19 what.1
--- usr.bin/what/what.1 22 Jan 2015 19:10:17 -  1.19
+++ usr.bin/what/what.1 20 Jan 2019 10:04:41 -
@@ -94,14 +94,3 @@ The
 .Nm
 command appeared in
 .Bx 4.0 .
-.Sh BUGS
-As
-.Bx
-is not licensed to distribute
-.Tn SCCS ,
-this is a rewrite of the
-.Nm
-command which is part of
-.Tn SCCS .
-As such it may not behave exactly the same as that
-command does.