Re: cvs commit: httpd-test/flood config.h.in flood_round_robin.c
On Sun, 7 Sep 2003 [EMAIL PROTECTED] wrote:
+if (apr_procattr_create(procattr, rp-pool) != APR_SUCCESS) {
+apr_file_printf(local_stderr,
+apr_procattr_create failed for '%s'\n,
+rp-url[rp-current_url].responsescript);
+return APR_EGENERAL;
+}
Why do all of these return APR_EGENERAL rather than catching the
apr_status_t from the function that was called (apr_procattr_create in
this case) and returning that? Is this just a flood thing I don't know
about?
--Cliff
flood 1.1 TR
I think we're *really* ready to release flood 1.1. I would like to tag the tree in a day or two. We don't have that many commits daily, so I think we can simply test HEAD, without any temporary candidate tag (like those on httpd repo). I would also like to be RM for this release, unless there's somebody more experienced to take this job. Anyway I'll need some help. First, my public key schould be added to KEYS file (see attached patch), so I can sign the tarballs. Second, in order to obey new mirroring rules, I need to have +w to www.apache.org/dist/httpd/flood, or somebody has to put release tarballs for me. In addition, I would like to put flood manual on-line. This requires also some privileges (only for manual subdir), or a person that would put them on-line for me. regards, Jacek Prucia P.S. Once 1.1 is released, we might consider moving 0.4 to archive, since we don't want anybody to use when 1.1 is out. --- KEYS.orig 2003-09-05 14:27:37.0 +0200 +++ KEYS2003-09-05 14:30:02.0 +0200 @@ -2539,3 +2539,38 @@ 7JDHKkJmLFKQAJ4/oORquEdlf3G5KxtLSYuyGEqemg== =4lbY -END PGP PUBLIC KEY BLOCK- +pub 1024D/7EFFAEB0 2003-09-05 Jacek Prucia [EMAIL PROTECTED] + Key fingerprint = 07FE 0F5B 4DA5 D43A 7765 BCFA F694 FBF1 7EFF AEB0 +sig 3 7EFFAEB0 2003-09-05 Jacek Prucia [EMAIL PROTECTED] +uidJacek Prucia [EMAIL PROTECTED] +sig 3 7EFFAEB0 2003-09-05 Jacek Prucia [EMAIL PROTECTED] +sub 1024g/7DFCDBC1 2003-09-05 +sig 7EFFAEB0 2003-09-05 Jacek Prucia [EMAIL PROTECTED] + +-BEGIN PGP PUBLIC KEY BLOCK- +Version: GnuPG v1.2.2 (GNU/Linux) + +mQGiBD9YaeARBACCzmLnOVl9OJma0QE6R4FUqKb/aPZbZm4kmsLbGC13kJm+QGp8 +47eL9bLVTfF4wBLthtluCUzz3/f+OLzhwzPX4sEobrqxonKCkCjbNYVjzne09oZe +Ww/uWJffc+sGMG3Cw012KnzwzcjsPMzppWKQEq8lS45N7qKePJJaXjJ8cwCg3zsR +cYtVrGVqouQS/IhBEnazdTED/22Pve0Bc43DzF4kdEcHdVE1GRLcjPCtcJLqjhLu +xs4NuoNAUU1ITIj574r0L3CnVreDqjoEJxiq2qns363wVuUAWzRTpfQ/DIojOC0J +nkYPtHhzCLVPFM4ElTXFDQ1P+QRf5NscKrhYooaa6WRMkXdoD+4+nmfa7ky9YEP5 +oAY/A/9bOPaxY01sEKslP+IZD5kp0NlNH/49sT9/1GXWmEXpkZvBPsjMi/eTOsjr +dQ7ehaoh44t1dSyLBt8NrAhN1Boy5da3AZdxEICxlY/buDBASBuq4cgeTHOI4nXK +xPc5PeJnEQ/jV2jZccxx5gQ6u2UdXe3lGbADDsiX4kPk2H8JSrQgSmFjZWsgUHJ1 +Y2lhIDxqYWNla3BAYXBhY2hlLm9yZz6IWwQTEQIAGwUCP1hp4AYLCQgHAwIDFQID +AxYCAQIeAQIXgAAKCRD2lPvxfv+usFGMAJ47s0rDI83SPOOMLxhiyXB514kHQgCf +UnNRyAk6b7of3rv1VkkLZY4Et9q0JkphY2VrIFBydWNpYSA8amFjZWsucHJ1Y2lh +QGFjbi53YXcucGw+iF4EExECAB4FAj9Ya4UCGwMGCwkIBwMCAxUCAwMWAgECHgEC +F4AACgkQ9pT78X7/rrA+CQCeMERG3+9VgMGQXqjdL3pduz3MpMgAn0ICgt7f2VvG +4pEOYu+DcOWbmc3CuQENBD9YaeQQBACXmGQrEbtPO0A8bA02YF4u9o57EcG/IjBC +WxUIdIYFi/4W5xUVjK0cKrzu9WLznmizf0kisCCm6mg6hZgu1j+D89cC2APoAf4D +hqEsh+QLVa7k53Zz9D8oT0XMyXIfszLJgUaURZsyWs55UdGEaknI5qwnZiZyQh/+ +ulL5ZVraswADBQP+IHk7S+agvzP3jCnko4RbbDBFPINkEnLvxoooBJgQgjTKP3Tr +/D7+dYZy7DDsM+aJwqMDcMQD+XWkdiezps7mtDo5+Xn+4+Qmx7ttcJqyqFb8/Qq6 ++26Vug8Bau1l9Wgyb4I+UE67w9Mwdh8cGGBpQ0dwpsoLBVbHowttCRa56j2IRgQY +EQIABgUCP1hp5AAKCRD2lPvxfv+usGtfAJ9ua/4DCUBvaezsV6SB5XJjUSEHrgCg +ztzUT6KsFJmyBHwo1PeP9qBgjGg= +=XInH +-END PGP PUBLIC KEY BLOCK-
RE: cvs commit: httpd-test/flood config.h.in flood_round_robin.c
From: Jacek Prucia [mailto:[EMAIL PROTECTED]
Sent: Monday, September 08, 2003 2:41 AM
On Sun, 7 Sep 2003 20:06:09 -0400 (EDT)
Cliff Woolley [EMAIL PROTECTED] wrote:
On Sun, 7 Sep 2003 [EMAIL PROTECTED] wrote:
+if (apr_procattr_create(procattr, rp-pool) != APR_SUCCESS) {
+apr_file_printf(local_stderr,
+apr_procattr_create failed for '%s'\n,
+rp-url[rp-current_url].responsescript);
+return APR_EGENERAL;
+}
Why do all of these return APR_EGENERAL rather than catching the
apr_status_t from the function that was called (apr_procattr_create in
this case) and returning that? Is this just a flood thing I don't know
about?
Nope. I'm not so familliar with APR, so a message to stderr plus APR_EGENERAL
is a safe bet. If this looks really obscure considering APR concepts, then
please feel free to commit a fix.
Basically do something like this:
apr_status_t rv;
...
rv = apr_procattr_create(procattr, rp-pool);
if (rv) { /* Or in full: if (rv != APR_SUCCESS) */
apr_file_printf(local_stderr,
apr_procattr_create failed for '%s'\n,
rp-url[rp-current_url].responsescript);
return rv;
}
IOW, preserve the error and pass it down back the calling chain.
Sander
RE: cvs commit: httpd-test/flood config.h.in flood_round_robin.c
is a safe bet. If this looks really obscure considering APR concepts, then please feel free to commit a fix. Fix commited. Please test, since I didn't. :) PS: I also fixed a buglet or two. --Cliff
Re: cvs commit: httpd-test/flood config.h.in flood_round_robin.c
On Sun, 7 Sep 2003 22:22:44 -0400 (EDT) Cliff Woolley [EMAIL PROTECTED] wrote: is a safe bet. If this looks really obscure considering APR concepts, then please feel free to commit a fix. Fix commited. Thanks for the fix! Please test, since I didn't. :) Fix seems to be OK and error messages are more descriptive than 'Error string not specified yet'. :) regards, Jacek Prucia
Re: flood 1.1 TR
On Mon, 08 Sep 2003 00:15:27 -0700 Justin Erenkrantz [EMAIL PROTECTED] wrote: [...] My only concern is that we make sure flood 1.1 compiles against APR 1.0 (which should have a 1.0 RC out this week). Try checking out the HEAD of apr and apr-util and ensuring that flood still compiles. All of the deprecated functions in APR are now removed in HEAD of those repositories. If you look at the CHANGES in apr, you'll see the mappings of old to new functions. You were right. Compilation barfed on socket API changes. However it turned out to be a trival to fix (adding one extra argument and renaming few functions). I have patch ready and I'll be commiting it later this day. [...] Yup, you should be RM. ;-) :) I would first say that you should create 'candidate' tarballs on your own. Then, we'll have to get 3 +1s before calling it 1.1, so it's fine if there is a little latency between you creating the tarball and posting it on the site. We'll have to wait for the 3 +1s anyway. Yeah, dev/release.html rules apply. Once you have the 3 +1s, you can then tag it 'officially' in CVS (which you can already do). Yes. I've just decided to use intermediate tag (FLOOD_1_1_RC), see below. At that point, I can ensure that you have the right permissions and stuff to upload and distribute it. But, I'd recommend getting the tarball right and having a 'solid' release, then we can figure out the other stuff first. Make sense? -- justin Yes. This is my current release plan (please yell if it violates something): 1. tag repo with FLOOD_1_1_RC (probably later this day), 2. prepare RC tarball and announce availability here, 3. test and see if eventual bugs must be fixed, 4. move FLOOD_1_1_RC tag on files containing fixes, 5. create new RC tarball and start all over again (3). When we have 3 +1s for GA, then: 1. create FLOOD_1_1 tag using existing FLOOD_1_1_RC, 2. remove old FLOOD_1_1_RC tag, 3. sign the tarball and move it to dist/httpd/flood, 4. wait 48 hours ;) 5. send announcement. So like you said: we can postpone most of the stuff until we get stable RC tarball. regards, Jacek Prucia
RE: flood 1.1 TR
From: Jacek Prucia [mailto:[EMAIL PROTECTED] Sent: Monday, September 08, 2003 3:28 PM Yes. This is my current release plan (please yell if it violates something): 1. tag repo with FLOOD_1_1_RC (probably later this day), 2. prepare RC tarball and announce availability here, 3. test and see if eventual bugs must be fixed, 4. move FLOOD_1_1_RC tag on files containing fixes, 5. create new RC tarball and start all over again (3). Please do not move tags. Instead create RC1, RC2, etc. After the release is done, remove all RCx tags. When we have 3 +1s for GA, then: 1. create FLOOD_1_1 tag using existing FLOOD_1_1_RC, 2. remove old FLOOD_1_1_RC tag, 3. sign the tarball and move it to dist/httpd/flood, 4. wait 48 hours ;) 5. send announcement. So like you said: we can postpone most of the stuff until we get stable RC tarball. Sander
example configs
I have found few minor issues in current example config files. 1. round-robin-ssl.xml We have only one url working -- modssl.org SSL connection test is working again (although HTML is broken). The other URL is dead for a lng time, so we might consider removing it at all. I've found another SSL check: https://www.freessl.com/test/freessl.html If nobody has any problems with commercial site in example URLs, I can contact them and see if such inclusion is possible. 2. round-robin-keepalive.xml This just looks like a great place to use baseurl. 3. round-robin-dynamic.xml apachelabs.org is a redirect to apache.org, so first three urls are sure to fail. Google stuff is commented out, so we need to exchange apachelabs.org with something else. Something like retrieving some static page, and using a first link found. Those fixes are ok for purpose of this release, but this whole issue looks like a good showstopper for 1.2. We schould provide a bunch of CGI/PHP/JSP scripts to simulate some functionality and drop remote servers for good. All example configs could be rewritten to have baseurlhttp://www.example.com/baseurl, so they are harmless by default.
Patch to Apache::TestConfig for Mandrake
I've created the following patch to help TestConfig.pm find the proper
mod_perl httpd on Mandrake machines. Mandrake installs both a
/usr/sbin/httpd and /usr/sbin/httpd-perl, and includes configuration for
mod_perl acceleration with a standard (e.g. non-mod_perl) httpd in front of
it.
However, when Apache::Test is used, it finds /usr/sbin/httpd instead of the
-perl one. I've fixed this for my site, but so I don't run into this later
(nor for others), I'm sending this patch to the list.
If you want to reply, please CC me, since I'm not on the list.
RCS file:
/home/cvspublic/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfig.pm,v
retrieving revision 1.171
diff -u -3 -p -r1.171 TestConfig.pm
--- TestConfig.pm 13 Aug 2003 19:02:51 - 1.171
+++ TestConfig.pm 8 Sep 2003 21:14:36 -
@@ -310,7 +310,13 @@ sub configure_httpd {
for my $dir (map { $vars-{$_} } qw(sbindir bindir)) {
next unless defined $dir;
my $httpd = catfile $dir, $vars-{target};
-next unless -x $httpd;
+unless (-x $httpd) {
+if (-x $httpd . '-perl') {
+$vars-{httpd} = $httpd . '-perl';
+} else {
+next;
+}
+}
$vars-{httpd} = $httpd;
last;
}
--
/* Michael A. Nachbaur [EMAIL PROTECTED]
* http://nachbaur.com/pgpkey.asc
*/
Rome wasn't burned in a day.
Re: Patch to Apache::TestConfig for Mandrake
Just after I sent the message, I saw the bug. Just change:
$vars-{httpd} = $httpd . -perl
to say instead:
$httpd = $httpd . -perl
On Monday 08 September 2003 02:53 pm, Michael A Nachbaur wrote:
I've created the following patch to help TestConfig.pm find the proper
mod_perl httpd on Mandrake machines. Mandrake installs both a
/usr/sbin/httpd and /usr/sbin/httpd-perl, and includes configuration for
mod_perl acceleration with a standard (e.g. non-mod_perl) httpd in front of
it.
However, when Apache::Test is used, it finds /usr/sbin/httpd instead of the
-perl one. I've fixed this for my site, but so I don't run into this later
(nor for others), I'm sending this patch to the list.
If you want to reply, please CC me, since I'm not on the list.
RCS file:
/home/cvspublic/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfig
.pm,v retrieving revision 1.171
diff -u -3 -p -r1.171 TestConfig.pm
--- TestConfig.pm 13 Aug 2003 19:02:51 - 1.171
+++ TestConfig.pm 8 Sep 2003 21:14:36 -
@@ -310,7 +310,13 @@ sub configure_httpd {
for my $dir (map { $vars-{$_} } qw(sbindir bindir)) {
next unless defined $dir;
my $httpd = catfile $dir, $vars-{target};
-next unless -x $httpd;
+unless (-x $httpd) {
+if (-x $httpd . '-perl') {
+$vars-{httpd} = $httpd . '-perl';
+} else {
+next;
+}
+}
$vars-{httpd} = $httpd;
last;
}
--
/* Michael A. Nachbaur [EMAIL PROTECTED]
* http://nachbaur.com/pgpkey.asc
*/
Ford, he said, how many escape capsules are there?
None, said Ford.
Zaphod gibbered.
Did you count them? he yelled.
Twice, said Ford
