[twdev] Re: Weird behavior of File Backups with TWc

[Ton Gerner]

Hi Yakov,

Thanks for your information

>
> you may also be interested in Timimi for TWC 
> , 
> it's quite handy with FF, although the Timimi's advanced backups system is 
> not supported yet for TWC.
>
 
I am aware of File Backups, Timini, Savetiddlers, TiddlyDesktop, ...
When File Backups had problems with TWc my fallback was TiddlyDesktop. 
Since that workrd with TWc I did not try the others.
Luckily Mario found a solution for File Backups so it does 'work' again.
 

>
> As for your initial problem, try to disable 
> security.fileuri.strict_origin_policy option in your FF's about:config. I 
> suspect that the culprit is recreateOriginal 
>  
> which doesn't take into account some aspects of saver plugins; current 
> Timimi implementation has a similar issue 
> , which I haven't 
> reproduced yet but I'll check my guess too.
>
> I will keep this info in mind for the future; you never know ;-)

Cheers,

Ton

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/affa7b56-3920-4ea9-b303-a474e66dc9b1%40googlegroups.com.

[twdev] Re: Weird behavior of File Backups with TWc

[Yakov]

Hi Mario,

thanks for the Unix path fix tip, I'll add it to the next update of Timimi 
too.

I'll have a closer look at other info too; a quick note for now: could you 
fix the url calculation to support non-ASCII paths like I've introduced in 
Timimi 
?
 
(note encodeURIComponent instead of escape there, in my tests limited to 
Windows that fixed loading from paths containing non-ASCII symbols and 
didn't broke anything) Yeah, those bugs and fixes are scattered among 
various solutions.. that reminds me again that we need docs 
/common 
codebase for this, I'll definitely return to that at some point.

Best regards,
Yakov.

четверг, 29 августа 2019 г., 10:47:06 UTC+3 пользователь PMario написал:
>
> On Wednesday, August 28, 2019 at 10:29:42 PM UTC+2, Yakov wrote:
> ...
>
>> As for your initial problem, try to disable 
>> security.fileuri.strict_origin_policy option in your FF's about:config. 
>>
>
> Not everyone is comfortable disabling "security" related settings, since 
> there is a reason for them, as BJ pointed out: 
> https://www.mozilla.org/en-US/security/advisories/mfsa2019-21/#CVE-2019-11730
>  
>
>> I suspect that the culprit is recreateOriginal 
>>  
>> which doesn't take into account some aspects of saver plugins;
>>
>
> With the fix, that I implemented this workaround is not called anymore, 
> since the intended function 
> 
>  
> is called and succeeds. 
>
> And yes. It seems recreateOriginal causes a backwards compatibility 
> problem, with every TiddlyFox compatible saver addOn. ... The original 
> TiddlyFox addOn did create a DOM element named: tiddlyfox-message-box
>
> At the init-phase of the AddOn startup, we check for the existence of this 
> element and add a marker. So other AddOns, that know about it, can print a 
> message, that only 1 saver addOn can be active at the same time. If an 
> other SW is detected, the add-on disables itself. ... see my addOn code 
> .
>  
> BJ has a similar function.
>
> *This DOM element should not be saved to the file*. ... It seems if 
> "recreateOriginal" is called, it is saved and breaks the file, so it can 
> only be fixed with a text editor, removing the element. 
>
> The problem I had to fix, was a difference between unix file paths and 
> windows file paths. see line 51 and 54 
> .
>  
> The "old" code was windows compatible, but caused a problem for unix 
> systems with the security.fileuri  setting activated. ... So there 
> may be a similar fix for timimi. 
>
>
> current Timimi implementation has a similar issue 
>> , which I haven't 
>> reproduced yet but I'll check my guess too.
>>
>
> I'll have a closer look, maybe I can help there. The "old" code was 
> windows compatible, but caused a problem for unix systems with the 
> security.fileuri  setting activated. ... So there may be a similar 
> fix for timimi. 
>
>
> have fun!
> mario
>

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/2fc05a37-e1ea-403c-b34a-d6e09652779a%40googlegroups.com.

[twdev] Re: Weird behavior of File Backups with TWc

[PMario]

On Wednesday, August 28, 2019 at 10:29:42 PM UTC+2, Yakov wrote:
...

> As for your initial problem, try to disable 
> security.fileuri.strict_origin_policy option in your FF's about:config. 
>

Not everyone is comfortable disabling "security" related settings, since 
there is a reason for them, as BJ pointed out: 
https://www.mozilla.org/en-US/security/advisories/mfsa2019-21/#CVE-2019-11730
 

> I suspect that the culprit is recreateOriginal 
>  
> which doesn't take into account some aspects of saver plugins;
>

With the fix, that I implemented this workaround is not called anymore, 
since the intended function 

 
is called and succeeds. 

And yes. It seems recreateOriginal causes a backwards compatibility 
problem, with every TiddlyFox compatible saver addOn. ... The original 
TiddlyFox addOn did create a DOM element named: tiddlyfox-message-box

At the init-phase of the AddOn startup, we check for the existence of this 
element and add a marker. So other AddOns, that know about it, can print a 
message, that only 1 saver addOn can be active at the same time. If an 
other SW is detected, the add-on disables itself. ... see my addOn code 
.
 
BJ has a similar function.

*This DOM element should not be saved to the file*. ... It seems if 
"recreateOriginal" is called, it is saved and breaks the file, so it can 
only be fixed with a text editor, removing the element. 

The problem I had to fix, was a difference between unix file paths and 
windows file paths. see line 51 and 54 
.
 
The "old" code was windows compatible, but caused a problem for unix 
systems with the security.fileuri  setting activated. ... So there may 
be a similar fix for timimi. 


current Timimi implementation has a similar issue 
> , which I haven't 
> reproduced yet but I'll check my guess too.
>

I'll have a closer look, maybe I can help there. The "old" code was windows 
compatible, but caused a problem for unix systems with the security.fileuri 
 setting activated. ... So there may be a similar fix for timimi. 


have fun!
mario

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/cfdba26c-361a-4d97-9ee4-c80ba1d173ba%40googlegroups.com.

[twdev] Re: Weird behavior of File Backups with TWc

[Yakov]

Hi Ton,

you may also be interested in Timimi for TWC 
, 
it's quite handy with FF, although the Timimi's advanced backups system is 
not supported yet for TWC.

As for your initial problem, try to disable 
security.fileuri.strict_origin_policy option in your FF's about:config. I 
suspect that the culprit is recreateOriginal 
 
which doesn't take into account some aspects of saver plugins; current 
Timimi implementation has a similar issue 
, which I haven't reproduced 
yet but I'll check my guess too.

Best regards,
Yakov.

вторник, 6 августа 2019 г., 21:38:45 UTC+3 пользователь Ton Gerner написал:
>
> Hi all (and especially Mario),
>
> System in use:
> Linux Mint 19.2
> Firefox 68.01 & Firefox dev 69.0b10
> TWc 2.8.1
>
> I am a very satisfied user of Mario's File Backups; I use it for a lot of 
> TW5 wikis. I use it for a few TWc wikis as well and there started a problem 
> a few days ago. I saved a (big and heavily modified) TWc wiki. After 
> refreshing the browser tab I got the following error message:
>
> [image: File-backups.png]
>
>
> After clicking OK the TWc wiki did not load anymore. Comparing the wikis 
> before and after saving showed differences at 15 places (only the first and 
> last change important); see the P.S.
>
> Thereafter I did some tests with a Minimal Test Case (empty TWc 2.8.1; 
> closing/restarting FF in between tests)
>
> Test 1: standard FF (all add-ons enabled) => error message after 
> saving/refreshing but wiki reloads normally
> Test 2: standard FF (all add-ons disabled except File Backups) => error 
> message after saving/refreshing but wiki reloads normally
> Test 3: standard FF (reinstalled FB, other add-ons disabled) => error 
> message after saving/refreshing but wiki reloads normally
> Test 4: FF dev (all add-ons disabled except File Backups) => error message 
> after saving/refreshing but wiki reloads normally
> Test 5: empty 2.9.2 standard FF (all add-ons disabled except File Backups) 
> => error message after saving/refreshing but wiki reloads normally
>
> Comparing the TWc wikis before and after saving showes differences at 3 
> places:
>
> *empty 281 before save:*
>
> 
> 
>
> 
>
> ...
>
> 
>
> ...
>
> 
> 
> 
>
>
> *empty281 after save:*
>
> 
>  My TiddlyWiki - a reusable non-linear personal web notebook 
> 
>
> ...
>
> 
>
> 
>
> ...
>
>
> !--POST-SCRIPT-END-->
>
>
>  data-message-box-creator="file-backups">
>
>
> The same differences can be seen with TWc 2.9.2.
>
> What strikes me most is the fact that it does not happen with Windows 10 
> and FF 68.01! Even the heavily modified TWc saves/reloads without 
> message/problems!
>
> File Backups works perfectly with TW5!
>
> Questions:
>
> 1) Is it possible that FF 68.01 behaves different under Windows 10 then 
> under Linux Mint?
> 2) Can someboy confirm my findings with Linux Mint (Ubuntu/Debian) & FF?
>
> Thanks in advance,
>
> Ton
>
> P.S. In the heavily modified TWc 15 changes were found after saving:
>
> 1) Some code had been deleted after the head section:
>
>
> 
>
> 2) ..14) Unimportantant changes (order of items; mainly plugin headings)
> 15) The added div at the end:
>
>
>  data-message-box-creator="file-backups">
>
> Removing the div and adding the deleted code (in a text editor) created a 
> working TWc again.
>
>
>
>
>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/c2c9860c-07bf-4df1-a8fb-20691ad95da1%40googlegroups.com.

[twdev] Re: Weird behavior of File Backups with TWc

[PMario]

On Wednesday, August 28, 2019 at 10:04:08 AM UTC+2, Ton Gerner wrote:
>
> Hi Mario,
>
> I think I did find the real problem and fixed it. ... There is a new beta 
>> version. Please try it: 
>> https://github.com/pmario/file-backups/issues/28#issuecomment-525451252 
>>
>
> Bingo! Version 0.3.10 works for me.
>

That's great. 

Since it was quiet in the groups about saving TWc with File Backups I 
> thought: 'Am I the only one? Something wrong with my system?'
> But I see now that at Github the same behavior was reported (and also that 
> it was still working under Windows 10).
>

Yea, the problem is a little bit strange and has to do with the differences 
in the file system "path" handling. 
 

>  The following tests (added new tiddler, saved and reloaded) were all 
> succesful for:
>
> Linux Mint 19.2
> Firefox 68.02
>
>
>- various TW5s
>- empty 2.8.1
>- empty 2.9.2
>- heavily modified TWc 2.8.1
>- heavily modified TWc upgraded to 2.9.2 
>
> Thanks a lot.
>

You are welcome. 

For the records: 

I did my testes with Windows 10, ubuntu 18.04. ... TW 2.6.5 and TW 2.9.2

have fun!
mario

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/6a44ab38-2883-4156-bdac-c5ffe0c4aac9%40googlegroups.com.

[twdev] Re: Weird behavior of File Backups with TWc

[Ton Gerner]

Hi Mario,

I think I did find the real problem and fixed it. ... There is a new beta 
> version. Please try it: 
> https://github.com/pmario/file-backups/issues/28#issuecomment-525451252 
>

Bingo! Version 0.3.10 works for me.
Since it was quiet in the groups about saving TWc with File Backups I 
thought: 'Am I the only one? Something wrong with my system?'
But I see now that at Github the same behavior was reported (and also that 
it was still working under Windows 10).
 
The following tests (added new tiddler, saved and reloaded) were all 
succesful for:

Linux Mint 19.2
Firefox 68.02


   - various TW5s
   - empty 2.8.1
   - empty 2.9.2
   - heavily modified TWc 2.8.1
   - heavily modified TWc upgraded to 2.9.2 

Thanks a lot.

Ton

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/ab76f92a-8deb-4c0b-bcde-14f743784d4c%40googlegroups.com.

[twdev] Re: Weird behavior of File Backups with TWc

[PMario]

Hi BJ, 

There seems to be a problem in TWc, which is there for a long time already. 
.. As you pointed out, it causes a problem now. ... I'll open a new issue 
at: https://github.com/TiddlyWiki/TiddlyWiki/issues once I'm sure I did 
fully understand what's going on. 

It would be nice, if you could join in. ... Can you point me to the fixes, 
you had to make to your plugin?
-mario

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/93291e49-890f-4fe1-8e42-6ac956e5e870%40googlegroups.com.

[twdev] Re: Weird behavior of File Backups with TWc

[PMario]

Hi Ton, 

I think I did find the real problem and fixed it. ... There is a new beta 
version. Please try it: 
https://github.com/pmario/file-backups/issues/28#issuecomment-525451252 

have fun!
mario

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/889791bc-32b3-44e6-803c-c1a989a9dfa8%40googlegroups.com.

[twdev] Re: Weird behavior of File Backups with TWc

[@TiddlyTweeter]

Does it interfere with TWC default saving to the "downloads" folder?

I'm interested in TWC saving.

Josiah

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/65b71f1e-d0a9-48a6-a3ef-bf191f225de6%40googlegroups.com.

[twdev] Re: Weird behavior of File Backups with TWc

[BJ]

in firefox they fixed a serurity issue, (which now prohibits downloading 
local files)

https://www.mozilla.org/en-US/security/advisories/mfsa2019-21/#CVE-2019-11730

I modified savetiddlers get around this but, now only the latest 
tiddlyclassics with work (those that have the html5 download modifications)

all the best

BJ


On Wednesday, August 7, 2019 at 8:34:19 AM UTC+2, PMario wrote:
>
>  Hi Ton, 
>
> I'll have a closer look. 
>
> -m
>

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/33750857-bf25-4230-b66a-32e98fb99836%40googlegroups.com.

[twdev] Re: Weird behavior of File Backups with TWc

[Ton Gerner]

Hi Mario,

On Wednesday, August 7, 2019 at 8:37:56 AM UTC+2, PMario wrote:
>
> On Tuesday, August 6, 2019 at 8:38:45 PM UTC+2, Ton Gerner wrote:
>  
>
>> 15) The added div at the end:
>>
>>
>> > data-message-box-creator="file-backups">
>>
>> Removing the div and adding the deleted code (in a text editor) created a 
>> working TWc again.
>>
>
> As you found out, we added a marker at the end of the TW internal DOM, to 
> identify the browser addOn that first added it. ... This DOM element 
> shouldn't be saved. ... So removing it with a text editor should do no harm 
> and really fix the problem as a workaround. 
>
> Yeah,
As I wrote: Removing the div and adding the deleted code (in a text editor) 
created a working TWc again.

Cheers,

Ton

 

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/6e189e76-236c-4304-8817-74e2180a94bf%40googlegroups.com.

[twdev] Re: Weird behavior of File Backups with TWc

[Ton Gerner]

Hi Mario,

Thanks

Ton

On Wednesday, August 7, 2019 at 8:34:19 AM UTC+2, PMario wrote:
>
>  Hi Ton, 
>
> I'll have a closer look. 
>
> -m
>

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/37e38818-8283-4c0f-a13d-744ca101f3fa%40googlegroups.com.

[twdev] Re: Weird behavior of File Backups with TWc

[PMario]

On Tuesday, August 6, 2019 at 8:38:45 PM UTC+2, Ton Gerner wrote:
 

> 15) The added div at the end:
>
>
>  data-message-box-creator="file-backups">
>
> Removing the div and adding the deleted code (in a text editor) created a 
> working TWc again.
>

As you found out, we added a marker at the end of the TW internal DOM, to 
identify the browser addOn that first added it. ... This DOM element 
shouldn't be saved. ... So removing it with a text editor should do no harm 
and really fix the problem as a workaround. 

-m

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/799dbc6e-7ecd-4eaa-9d13-492aa2531038%40googlegroups.com.

[twdev] Re: Weird behavior of File Backups with TWc

[PMario]

 Hi Ton, 

I'll have a closer look. 

-m

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/cb77171b-ca6e-4ba8-a9bb-a94a62e9380c%40googlegroups.com.