Re: [Tigervnc-devel] [Tigervnc-users] Some issues found with Tiger VNC 0.0.90 (Windows XP)

2009-08-27 Thread Adam Tkac 
On Tue, Aug 25, 2009 at 08:27:39AM +0200, Peter Åstrand wrote:
 On Mon, 6 Jul 2009, Peter Åstrand wrote:

 2. vnc viewer's About dialog box title About VNC Viewer for Windows
 (should be about TigerVNC ...) [minor]

 I agree. A patch that corrects this is attached.

 If there are no objections, I'll commit this patch.

Patch looks fine.


 Regards, ---
 Peter Åstrand ThinLinc Chief Developer
 Cendio AB http://www.cendio.com
 Wallenbergs gata 4
 583 30 Linköping  Phone: +46-13-21 46 00

 Index: unix/vncviewer/AboutDialog.h
 ===
 --- unix/vncviewer/AboutDialog.h  (revision 3864)
 +++ unix/vncviewer/AboutDialog.h  (arbetskopia)
 @@ -35,7 +35,7 @@
  class AboutDialog : public TXMsgBox {
  public:
AboutDialog(Display* dpy)
 -: TXMsgBox(dpy, aboutText, MB_OK, _(About VNC Viewer)) {
 +: TXMsgBox(dpy, aboutText, MB_OK, _(About TigerVNC Viewer)) {
}
  };
  
 Index: unix/vncviewer/CConn.cxx
 ===
 --- unix/vncviewer/CConn.cxx  (revision 3864)
 +++ unix/vncviewer/CConn.cxx  (arbetskopia)
 @@ -454,7 +454,7 @@
menu.addEntry(_(New connection...), ID_NEWCONN);
menu.addEntry(_(Options...), ID_OPTIONS);
menu.addEntry(_(Connection info...), ID_INFO);
 -  menu.addEntry(_(About VNCviewer...), ID_ABOUT);
 +  menu.addEntry(_(About TigerVNC viewer...), ID_ABOUT);
menu.addEntry(0, 0);
menu.addEntry(_(Dismiss menu), ID_DISMISS);
menu.toplevel(_(VNC Menu), this);
 Index: unix/po/tigervnc.pot
 ===
 --- unix/po/tigervnc.pot  (revision 3864)
 +++ unix/po/tigervnc.pot  (arbetskopia)
 @@ -16,7 +16,7 @@
  Content-Type: text/plain; charset=CHARSET\n
  Content-Transfer-Encoding: 8bit\n
  
 -msgid About VNC Viewer
 +msgid About TigerVNC Viewer
  msgstr 
  
  msgid VNC authentication
 Index: unix/po/pl.po
 ===
 --- unix/po/pl.po (revision 3864)
 +++ unix/po/pl.po (arbetskopia)
 @@ -13,7 +13,7 @@
  Content-Type: text/plain; charset=UTF-8\n
  Content-Transfer-Encoding: 8bit\n
  
 -msgid About VNC Viewer
 +msgid About TigerVNC Viewer
  msgstr O Przeglądarce VNC
  
  msgid VNC authentication
 Index: unix/po/sk.po
 ===
 --- unix/po/sk.po (revision 3864)
 +++ unix/po/sk.po (arbetskopia)
 @@ -15,7 +15,7 @@
  Content-Type: text/plain; charset=utf-8\n
  Content-Transfer-Encoding: 8bit\n
  
 -msgid About VNC Viewer
 +msgid About TigerVNC Viewer
  msgstr O aplikácií VNC Viewer
  
  msgid VNC authentication
 Index: unix/po/de.po
 ===
 --- unix/po/de.po (revision 3864)
 +++ unix/po/de.po (arbetskopia)
 @@ -18,7 +18,7 @@
  Content-Transfer-Encoding: 8bit\n
  Plural-Forms: nplurals=2; plural=(n != 1);\n
  
 -msgid About VNC Viewer
 +msgid About TigerVNC Viewer
  msgstr Über VNC-Viewer
  
  msgid VNC authentication
 Index: unix/po/sv.po
 ===
 --- unix/po/sv.po (revision 3864)
 +++ unix/po/sv.po (arbetskopia)
 @@ -17,7 +17,7 @@
  Content-Transfer-Encoding: 8bit\n
  Plural-Forms: nplurals=2; plural=(n != 1);\n
  
 -msgid About VNC Viewer
 +msgid About TigerVNC Viewer
  msgstr Om VNC-visaren
  
  msgid VNC authentication
 Index: win/winvnc/winvnc.rc
 ===
 --- win/winvnc/winvnc.rc  (revision 3864)
 +++ win/winvnc/winvnc.rc  (arbetskopia)
 @@ -135,7 +135,7 @@
  IDD_ABOUT DIALOG DISCARDABLE  0, 0, 249, 92
  STYLE DS_MODALFRAME | DS_SETFOREGROUND | DS_CENTER | WS_POPUP | WS_CAPTION | 
  WS_SYSMENU
 -CAPTION About VNC Server for Windows
 +CAPTION About TigerVNC Server for Windows
  FONT 8, MS Sans Serif
  BEGIN
  DEFPUSHBUTTON   OK,IDOK,195,70,47,15
 Index: win/vncviewer/vncviewer.rc
 ===
 --- win/vncviewer/vncviewer.rc(revision 3864)
 +++ win/vncviewer/vncviewer.rc(arbetskopia)
 @@ -155,7 +155,7 @@
  IDD_ABOUT DIALOG DISCARDABLE  0, 0, 249, 92
  STYLE DS_MODALFRAME | DS_SETFOREGROUND | DS_CENTER | WS_POPUP | WS_CAPTION | 
  WS_SYSMENU
 -CAPTION About VNC Viewer for Windows
 +CAPTION About TigerVNC Viewer for Windows
  FONT 8, MS Sans Serif
  BEGIN
  DEFPUSHBUTTON   OK,IDOK,195,70,47,15
 Index: win/vncconfig/vncconfig.rc
 ===
 --- win/vncconfig/vncconfig.rc(revision 3864)
 +++ win/vncconfig/vncconfig.rc(arbetskopia)
 @@ -211,7 +211,7 @@
  IDD_ABOUT DIALOG DISCARDABLE  0, 0, 249, 92
  STYLE DS_MODALFRAME | DS_SETFOREGROUND | DS_CENTER | WS_POPUP | WS_CAPTION | 
  WS_SYSMENU
 -CAPTION About VNC Config for Windows
 +CAPTION About TigerVNC Config for Windows
  FONT 8, MS

Re: [Tigervnc-devel] [Tigervnc-users] Some issues found with Tiger VNC 0.0.90 (Windows XP)

2009-08-25 Thread Peter Åstrand 

On Mon, 6 Jul 2009, Peter Åstrand wrote:


2. vnc viewer's About dialog box title About VNC Viewer for Windows
(should be about TigerVNC ...) [minor]


I agree. A patch that corrects this is attached.


If there are no objections, I'll commit this patch.


Regards, 
---

Peter Åstrand   ThinLinc Chief Developer
Cendio AB   http://www.cendio.com
Wallenbergs gata 4
583 30 LinköpingPhone: +46-13-21 46 00Index: unix/vncviewer/AboutDialog.h
===
--- unix/vncviewer/AboutDialog.h(revision 3864)
+++ unix/vncviewer/AboutDialog.h(arbetskopia)
@@ -35,7 +35,7 @@
 class AboutDialog : public TXMsgBox {
 public:
   AboutDialog(Display* dpy)
-: TXMsgBox(dpy, aboutText, MB_OK, _(About VNC Viewer)) {
+: TXMsgBox(dpy, aboutText, MB_OK, _(About TigerVNC Viewer)) {
   }
 };
 
Index: unix/vncviewer/CConn.cxx
===
--- unix/vncviewer/CConn.cxx(revision 3864)
+++ unix/vncviewer/CConn.cxx(arbetskopia)
@@ -454,7 +454,7 @@
   menu.addEntry(_(New connection...), ID_NEWCONN);
   menu.addEntry(_(Options...), ID_OPTIONS);
   menu.addEntry(_(Connection info...), ID_INFO);
-  menu.addEntry(_(About VNCviewer...), ID_ABOUT);
+  menu.addEntry(_(About TigerVNC viewer...), ID_ABOUT);
   menu.addEntry(0, 0);
   menu.addEntry(_(Dismiss menu), ID_DISMISS);
   menu.toplevel(_(VNC Menu), this);
Index: unix/po/tigervnc.pot
===
--- unix/po/tigervnc.pot(revision 3864)
+++ unix/po/tigervnc.pot(arbetskopia)
@@ -16,7 +16,7 @@
 Content-Type: text/plain; charset=CHARSET\n
 Content-Transfer-Encoding: 8bit\n
 
-msgid About VNC Viewer
+msgid About TigerVNC Viewer
 msgstr 
 
 msgid VNC authentication
Index: unix/po/pl.po
===
--- unix/po/pl.po   (revision 3864)
+++ unix/po/pl.po   (arbetskopia)
@@ -13,7 +13,7 @@
 Content-Type: text/plain; charset=UTF-8\n
 Content-Transfer-Encoding: 8bit\n
 
-msgid About VNC Viewer
+msgid About TigerVNC Viewer
 msgstr O Przeglądarce VNC
 
 msgid VNC authentication
Index: unix/po/sk.po
===
--- unix/po/sk.po   (revision 3864)
+++ unix/po/sk.po   (arbetskopia)
@@ -15,7 +15,7 @@
 Content-Type: text/plain; charset=utf-8\n
 Content-Transfer-Encoding: 8bit\n
 
-msgid About VNC Viewer
+msgid About TigerVNC Viewer
 msgstr O aplikácií VNC Viewer
 
 msgid VNC authentication
Index: unix/po/de.po
===
--- unix/po/de.po   (revision 3864)
+++ unix/po/de.po   (arbetskopia)
@@ -18,7 +18,7 @@
 Content-Transfer-Encoding: 8bit\n
 Plural-Forms: nplurals=2; plural=(n != 1);\n
 
-msgid About VNC Viewer
+msgid About TigerVNC Viewer
 msgstr Über VNC-Viewer
 
 msgid VNC authentication
Index: unix/po/sv.po
===
--- unix/po/sv.po   (revision 3864)
+++ unix/po/sv.po   (arbetskopia)
@@ -17,7 +17,7 @@
 Content-Transfer-Encoding: 8bit\n
 Plural-Forms: nplurals=2; plural=(n != 1);\n
 
-msgid About VNC Viewer
+msgid About TigerVNC Viewer
 msgstr Om VNC-visaren
 
 msgid VNC authentication
Index: win/winvnc/winvnc.rc
===
--- win/winvnc/winvnc.rc(revision 3864)
+++ win/winvnc/winvnc.rc(arbetskopia)
@@ -135,7 +135,7 @@
 IDD_ABOUT DIALOG DISCARDABLE  0, 0, 249, 92
 STYLE DS_MODALFRAME | DS_SETFOREGROUND | DS_CENTER | WS_POPUP | WS_CAPTION | 
 WS_SYSMENU
-CAPTION About VNC Server for Windows
+CAPTION About TigerVNC Server for Windows
 FONT 8, MS Sans Serif
 BEGIN
 DEFPUSHBUTTON   OK,IDOK,195,70,47,15
Index: win/vncviewer/vncviewer.rc
===
--- win/vncviewer/vncviewer.rc  (revision 3864)
+++ win/vncviewer/vncviewer.rc  (arbetskopia)
@@ -155,7 +155,7 @@
 IDD_ABOUT DIALOG DISCARDABLE  0, 0, 249, 92
 STYLE DS_MODALFRAME | DS_SETFOREGROUND | DS_CENTER | WS_POPUP | WS_CAPTION | 
 WS_SYSMENU
-CAPTION About VNC Viewer for Windows
+CAPTION About TigerVNC Viewer for Windows
 FONT 8, MS Sans Serif
 BEGIN
 DEFPUSHBUTTON   OK,IDOK,195,70,47,15
Index: win/vncconfig/vncconfig.rc
===
--- win/vncconfig/vncconfig.rc  (revision 3864)
+++ win/vncconfig/vncconfig.rc  (arbetskopia)
@@ -211,7 +211,7 @@
 IDD_ABOUT DIALOG DISCARDABLE  0, 0, 249, 92
 STYLE DS_MODALFRAME | DS_SETFOREGROUND | DS_CENTER | WS_POPUP | WS_CAPTION | 
 WS_SYSMENU
-CAPTION About VNC Config for Windows
+CAPTION About TigerVNC Config for Windows
 FONT 8, MS Sans Serif
 BEGIN
 DEFPUSHBUTTON   OK,IDOK,195,70,47,15
--
Let Crystal Reports handle the reporting - Free Crystal Reports

Re: [Tigervnc-devel] [Tigervnc-users] Some issues found with Tiger VNC 0.0.90 (Windows XP)

2009-07-06 Thread Peter Åstrand 


Hi, see comments inline.


1. Setup: when launched, asks This will install TigerVNC. Do you wish
to continue?  - could be omitted, as it adds nothing but another dialog
box to the installation experience. [minor]


I agree that it's quite pointless. We are using Inno Setup 3.0, which is 
fairly old. Perhaps it's possible to disable this screen; suggestions are 
welcome. Or, perhaps the problem goes away when we are switching to a 
newer installer.




2. vnc viewer's About dialog box title About VNC Viewer for Windows
(should be about TigerVNC ...) [minor]


I agree. A patch that corrects this is attached.



3. vnc viewer: 'server' dialog box cannot be reached using keyboard
shortcut (missing accelerator) [minor]
4. vnc viewer: options dialog box - lack keyboard shortcuts for some
options, and those that exist (such as *A*uto select in Colour
(Britsh?)  Encoding ) do not work[minor]
5. vnc viewer: options dialog box - no help available, not even bubble
help, for the various options. [minor]
6. vnc viewer: toolbar lacks any descriptions to the buttons. [minor]
7. vnc viewer: info dialog box is not modal, although it's not really
updating in real time. [minor]


I don't really know how the keyboard accelerators or tooltips works in the 
current viewer. It might be easier to wait with fixing these problems 
unless we have migrated to the new toolkit.



8. vnc viewer: ctrl and alt buttons are not 'sticky' [medium]


The effect is sticky, but this is not reflected in the GUI. Yes, this is a 
bug.




9. vnc viewer: from time to time, disconnects with 'Rect too big'
message [major]


Which VNC server are you using? Can you reproduce this easily? This 
problem is perhaps already fixed.



Best regards, 
---

Peter Åstrand   ThinLinc Chief Developer
Cendio AB   http://www.cendio.com
Wallenbergs gata 4
583 30 LinköpingPhone: +46-13-21 46 00Index: unix/vncviewer/AboutDialog.h
===
--- unix/vncviewer/AboutDialog.h(revision 3864)
+++ unix/vncviewer/AboutDialog.h(arbetskopia)
@@ -35,7 +35,7 @@
 class AboutDialog : public TXMsgBox {
 public:
   AboutDialog(Display* dpy)
-: TXMsgBox(dpy, aboutText, MB_OK, _(About VNC Viewer)) {
+: TXMsgBox(dpy, aboutText, MB_OK, _(About TigerVNC Viewer)) {
   }
 };
 
Index: unix/vncviewer/CConn.cxx
===
--- unix/vncviewer/CConn.cxx(revision 3864)
+++ unix/vncviewer/CConn.cxx(arbetskopia)
@@ -454,7 +454,7 @@
   menu.addEntry(_(New connection...), ID_NEWCONN);
   menu.addEntry(_(Options...), ID_OPTIONS);
   menu.addEntry(_(Connection info...), ID_INFO);
-  menu.addEntry(_(About VNCviewer...), ID_ABOUT);
+  menu.addEntry(_(About TigerVNC viewer...), ID_ABOUT);
   menu.addEntry(0, 0);
   menu.addEntry(_(Dismiss menu), ID_DISMISS);
   menu.toplevel(_(VNC Menu), this);
Index: unix/po/tigervnc.pot
===
--- unix/po/tigervnc.pot(revision 3864)
+++ unix/po/tigervnc.pot(arbetskopia)
@@ -16,7 +16,7 @@
 Content-Type: text/plain; charset=CHARSET\n
 Content-Transfer-Encoding: 8bit\n
 
-msgid About VNC Viewer
+msgid About TigerVNC Viewer
 msgstr 
 
 msgid VNC authentication
Index: unix/po/pl.po
===
--- unix/po/pl.po   (revision 3864)
+++ unix/po/pl.po   (arbetskopia)
@@ -13,7 +13,7 @@
 Content-Type: text/plain; charset=UTF-8\n
 Content-Transfer-Encoding: 8bit\n
 
-msgid About VNC Viewer
+msgid About TigerVNC Viewer
 msgstr O Przeglądarce VNC
 
 msgid VNC authentication
Index: unix/po/sk.po
===
--- unix/po/sk.po   (revision 3864)
+++ unix/po/sk.po   (arbetskopia)
@@ -15,7 +15,7 @@
 Content-Type: text/plain; charset=utf-8\n
 Content-Transfer-Encoding: 8bit\n
 
-msgid About VNC Viewer
+msgid About TigerVNC Viewer
 msgstr O aplikácií VNC Viewer
 
 msgid VNC authentication
Index: unix/po/de.po
===
--- unix/po/de.po   (revision 3864)
+++ unix/po/de.po   (arbetskopia)
@@ -18,7 +18,7 @@
 Content-Transfer-Encoding: 8bit\n
 Plural-Forms: nplurals=2; plural=(n != 1);\n
 
-msgid About VNC Viewer
+msgid About TigerVNC Viewer
 msgstr Über VNC-Viewer
 
 msgid VNC authentication
Index: unix/po/sv.po
===
--- unix/po/sv.po   (revision 3864)
+++ unix/po/sv.po   (arbetskopia)
@@ -17,7 +17,7 @@
 Content-Transfer-Encoding: 8bit\n
 Plural-Forms: nplurals=2; plural=(n != 1);\n
 
-msgid About VNC Viewer
+msgid About TigerVNC Viewer
 msgstr Om VNC-visaren
 
 msgid VNC authentication
Index: win/winvnc/winvnc.rc
===
--- win/winvnc/winvnc.rc(revision 3864)
+++ win/winvnc/winvnc.rc(arbetskopia)
@@ -135,7