Re: Corrupted Ouput - Tomcat 4.0.3
There seems to be a bug in the servlet output. I installed two versions of Tomcat freshly installed on my machine. All I did was change the port numbers and add 2 image files: Tomcat 3.2.4: http://24.202.111.74:8081/test.jpg Tomcat 4.0.3: http://24.202.111.74:8082/test.jpg Tomcat 4 does not corrupt images, binaries, or anything like that. This has been proven on and on by many people using it (like myself) on various websites. This has actually been proven by your own website, since when I actually tried the second link (I didn't even try the first one) the image came up fine. There is nothing which Tomcat can do to make the network stack behave the way you say it does. I assume there is something wrong somewhere in your network configuration, or something like that. If you still think there is a problem in Tomcat, I'm afaraid I cannot reproduce it (and I never experienced it) or help debug it, so you'll have to do the investigation. Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
[GUMP] Build Failure - Tomcat 3.x
This email is autogenerated from the output from:
http://jakarta.apache.org/builds/gump/2002-04-14/jakarta-tomcat.html
Buildfile: build.xml
detect:
msg.jdk12:
[echo] Detected JDK1.2
msg.jsse:
[echo] Detected JSSE
msg.puretls:
msg.commons-dbcp:
msg.jtc:
init:
prepare.dirs:
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/conf
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/conf/auto
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/classes
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/lib
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/lib/apps
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/lib/container
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/lib/common
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/logs
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/bin
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/doc
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/webapps
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/modules
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/native
[copy] Copying 10 files to /home/rubys/jakarta/jakarta-tomcat/build/tomcat/bin
[copy] Copying 1 file to /home/rubys/jakarta/jakarta-tomcat/build/tomcat/bin
[copy] Copying 18 files to /home/rubys/jakarta/jakarta-tomcat/build/tomcat/conf
[copy] Copying 44 files to /home/rubys/jakarta/jakarta-tomcat/build/tomcat/doc
[copy] Copying 85 files to /home/rubys/jakarta/jakarta-tomcat/build/tomcat/native
[copy] Copying 1 file to /home/rubys/jakarta/jakarta-tomcat/build/tomcat
[copy] Copying 1 file to /home/rubys/jakarta/jakarta-tomcat/build/tomcat
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat/build/tomcat/lib/container
[copy] Copying 1 file to /home/rubys/jakarta/jakarta-tomcat/build/tomcat/lib/apps
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat/build/tomcat/lib/common
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat/build/tomcat/lib/common
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat/build/tomcat/lib/common
prepare.jaxp101:
include.jaxp:
[echo] Including jaxp.jar
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat/build/tomcat/lib/container
prepare.jaxp11:
[echo] Installing JAXP-1.1
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat/build/tomcat/lib/container
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat/build/tomcat/lib/container
prepare.xerces:
prepare.jaxp:
prepare:
tomcat_util:
detect:
[available] DEPRECATED - available used to override an existing property.
Build file should not reuse the same property name for different values.
build-prepare:
build-main:
[echo] - Java-utils -
[echo] -- puretls.present = ${puretls.present}
[echo] -- jsse.present = true
[echo] -- commons-logging = true
[javac] Compiling 3 source files to
/home/rubys/jakarta/jakarta-tomcat-connectors/util/build/classes
[jar] Building jar:
/home/rubys/jakarta/jakarta-tomcat-connectors/util/build/lib/tomcat-util.jar
[javac] Compiling 46 source files to
/home/rubys/jakarta/jakarta-tomcat/build/tomcat/classes
[javac] An exception has occurred in the compiler (1.3.1_02). Please file a bug at
the Java Developer Connection (http://java.sun.com/cgi-bin/bugreport.cgi). Include
your program and the following diagnostic in your report. Thank you.
[javac] java.lang.InternalError: jzentry == 0
[javac] at java.util.zip.ZipFile$2.nextElement(ZipFile.java:297)
[javac] at
com.sun.tools.javac.v8.code.ClassReader.openArchive(ClassReader.java:893)
[javac] at com.sun.tools.javac.v8.code.ClassReader.list(ClassReader.java:1095)
[javac] at
com.sun.tools.javac.v8.code.ClassReader.listAll(ClassReader.java:1191)
[javac] at
com.sun.tools.javac.v8.code.ClassReader.fillIn(ClassReader.java:1213)
[javac] at
com.sun.tools.javac.v8.code.ClassReader.complete(ClassReader.java:955)
[javac] at com.sun.tools.javac.v8.code.Symbol.complete(Symbol.java:366)
[javac] at com.sun.tools.javac.v8.comp.Enter._case(Enter.java:424)
[javac] at com.sun.tools.javac.v8.tree.Tree$TopLevel.visit(Tree.java:349)
[javac] at com.sun.tools.javac.v8.comp.Enter.classEnter(Enter.java:392)
[javac] at com.sun.tools.javac.v8.comp.Enter.classEnter(Enter.java:410)
[javac] at com.sun.tools.javac.v8.comp.Enter.main(Enter.java:540)
[javac] at
RE : Corrupted Ouput - Tomcat 4.0.3
I guess you are right. I do not think Tomcat is responsible for this. I suspect that the reason v3 appears to be fine could be due to a different output buffer size. I may try to play with this to prove myself that the problem is in my network (clues on how to change output buffer size on V3 and V4 would be appreciated). Also, it seems that the problem only occurs when accessing the web site from inside my network using the external IP address. When accessing the same IP from the outside, the problem does not seem to occur (i.e. none of you should see corrupted images from the links below. But if you do, let me know please). Sorry for thinking tomcat was responsible... Shame on me ;-) Claude There seems to be a bug in the servlet output. I installed two versions of Tomcat freshly installed on my machine. All I did was change the port numbers and add 2 image files: Tomcat 3.2.4: http://24.202.111.74:8081/test.jpg Tomcat 4.0.3: http://24.202.111.74:8082/test.jpg Tomcat 4 does not corrupt images, binaries, or anything like that. This has been proven on and on by many people using it (like myself) on various websites. This has actually been proven by your own website, since when I actually tried the second link (I didn't even try the first one) the image came up fine. There is nothing which Tomcat can do to make the network stack behave the way you say it does. I assume there is something wrong somewhere in your network configuration, or something like that. If you still think there is a problem in Tomcat, I'm afaraid I cannot reproduce it (and I never experienced it) or help debug it, so you'll have to do the investigation. Remy -- To unsubscribe, e-mail: mailto:tomcat-dev- [EMAIL PROTECTED] For additional commands, e-mail: mailto:tomcat-dev- [EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat build.xml gump.xml
costin 02/04/14 09:04:52
Modified:.build.xml gump.xml
Log:
Hopefully this will fix next gump.
Revision ChangesPath
1.174 +28 -12jakarta-tomcat/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat/build.xml,v
retrieving revision 1.173
retrieving revision 1.174
diff -u -r1.173 -r1.174
--- build.xml 11 Apr 2002 02:05:12 - 1.173
+++ build.xml 14 Apr 2002 16:04:52 - 1.174
@@ -257,12 +257,24 @@
chmod perm=+x file=${tomcat.build}/bin/shutdown.sh/
/target
+ target name=deps description=Build repositoried that depends on. To be called
before main
+ant dir=${jakarta-tomcat-connectors}/util /
+ant dir=${jakarta-tomcat-connectors}/coyote
+property name=tomcat33.home value=${basedir}/build/tomcat/
+/ant
+
+ant dir=${jakarta-tomcat-connectors}/http11 /
+
+ant dir=${jakarta-tomcat-connectors}/jk target=build-jk
+property name=tomcat33.home value=${basedir}/build/tomcat/
+/ant
+ /target
+
+
!-- Tomcat util --
!-- Local Tomcat utilities --
target name=tomcat_util depends=prepare
-ant dir=${jakarta-tomcat-connectors}/util /
-
javac destdir=${tomcat.build}/classes
debug=${debug}
optimize=${optimize}
@@ -512,14 +524,10 @@
target name=coyote depends=prepare,tomcat_core,tomcat_modules
echo message=Building Coyote/
-!-- By now we have built the modules coyote needs --
-ant dir=${jakarta-tomcat-connectors}/coyote
-property name=tomcat33.home value=${basedir}/build/tomcat/
-/ant
-ant dir=${jakarta-tomcat-connectors}/http11 /
-
-ant dir=${jakarta-tomcat-connectors}/jk target=build-jk
+!-- This can't be compiled while j-t-c is built - tomcat is built
+ after, so files depending on 3.3 are ignored --
+ant dir=${jakarta-tomcat-connectors}/coyote target=compile.tomcat33
property name=tomcat33.home value=${basedir}/build/tomcat/
/ant
@@ -786,10 +794,13 @@
!-- Copy the files to distribution format --
- target name=dist depends=dist.prepare,javadoc,dist.war
+ target name=dist
depends=main,webapps,tomcat-jars,dist.prepare,javadoc,dist.war
+ /target
+
+ target name=dist-gump
depends=main-gump,webapps,tomcat-jars,dist.prepare,javadoc,dist.war
/target
- target name=dist.prepare depends=main,webapps,tomcat-jars
+ target name=dist.prepare
mkdir dir=${tomcat.dist}/
mkdir dir=${tomcat.dist}/webapps/
@@ -955,7 +966,12 @@
zip zipfile=${Name}-${version}.zip basedir=${tomcat.dist} includes=**/
/target
- target name=main depends=tomcat,webapps
+ target name=main depends=deps,tomcat,webapps
+ description=Built tomcat in build/, without packaging. Include all
dependent code
+ /target
+
+ target name=main-gump depends=tomcat,webapps
+ description=Build tomcat but not the code it depends on. For gump use
/target
1.2 +1 -1 jakarta-tomcat/gump.xml
Index: gump.xml
===
RCS file: /home/cvs/jakarta-tomcat/gump.xml,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- gump.xml 13 Apr 2002 17:05:45 - 1.1
+++ gump.xml 14 Apr 2002 16:04:52 - 1.2
@@ -10,7 +10,7 @@
project name=jakarta-tomcat
packageorg.apache.tomcat/package
-ant target=dist
+ant target=dist-gump
property name=jaxp.home reference=home project=jaxp/
property name=ant.home reference=home project=jakarta-ant/
property name=jsse.home reference=home project=jsse/
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Bug report for Tomcat 3 [2002/04/14]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=CriticalMAJ=Major | | | | MIN=Minor NOR=Normal ENH=Enhancement | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 258|Unc|Nor|2000-11-27|response.SendRedirect() resets/destroys Cookies th| | 2478|Opn|Cri|2001-07-06|Passing Session variables between JSP's and Servle| | 4380|New|Enh|2001-10-23|Multiple ISAPI redirectors on single IIS website | | 4551|Opn|Nor|2001-10-31|Ctx( /tt01 ): IOException in: R( /tt01 + /com/abc/| | 4893|Unc|Blk|2001-11-15|Tomcat dies with following error..| | 4915|New|Blk|2001-11-16|Relocation error while loading mod_jk when startin| | 4980|New|Min|2001-11-20|Startup message indicates incorrect log file | | 4994|New|Nor|2001-11-21|Tomcat needs a mechanism for clean and certain shu| | 5064|New|Cri|2001-11-25|Socket write error when include files is more than| | 5108|New|Maj|2001-11-26|Docs for Tomcat 3.2.x appear to be for Tomcat 3.3 | | 5137|New|Nor|2001-11-27|Null pointer in class loader after attempting to r| | 5160|Unc|Maj|2001-11-28|'IllegalStateException' | | 5231|New|Nor|2001-12-02|Tomcat 3.2.4 does not start due to error in classp| | 5261|New|Cri|2001-12-04|Directory Listing in Tomcat 3.2.4 | | 5331|New|Nor|2001-12-09|getPathInfo vs URL normalization | | 5411|Opn|Nor|2001-12-13|JSP session does not work with IE/IIS5/Tomcat 3.3 | | 5510|New|Blk|2001-12-19|How to call ejb deployed in JBoss from Tomcat serv| | 5511|New|Nor|2001-12-19|Error upload files| | 5581|New|Cri|2001-12-24|java.lang.ArrayIndexOutOfBoundsException | | 5756|New|Nor|2002-01-08|jspc.bat exits with wrong ERRORLEVEL | | 5797|New|Nor|2002-01-10|UnCatched ? StringIndexOutOfBoundsException: Strin| | 5925|New|Cri|2002-01-19|Apache server hangs up and consumes 100% CPU resou| | 6027|New|Maj|2002-01-25|Tomcat Automatically shuts down as service | | 6168|New|Blk|2002-02-01|double execution of java code in JSP | | 6324|New|Nor|2002-02-08|Invalid POST requests through ajp13 cause 'garbage| | 6451|New|Cri|2002-02-14|Stackoverflow | | 6478|New|Enh|2002-02-14|Default Tomcat Encoding | | 6488|Ver|Maj|2002-02-15|Error: 304. Apparent bug in default ErrorHandler c| | 6648|New|Nor|2002-02-25|jakarta-servletapi build with java 1.4 javadoc err| | 6702|New|Cri|2002-02-27|jk_nt_service.exe -i cannot work | | 6796|New|Cri|2002-03-01|Tomcat dies periodically | | 6989|New|Maj|2002-03-08|Unable to read tld file during parallel JSP compil| | 7008|Opn|Maj|2002-03-10|facade.HttpServletRequestFacade.getParameter(HttpS| | 7013|New|Cri|2002-03-10|Entering a servlet path with non-ISO8859-1 charact| | 7227|New|Nor|2002-03-19|error-code directive don't work | | 7236|New|Blk|2002-03-19|Permission denied to do thread.stop | | 7520|New|Min|2002-03-27|Tomcat starts with title 3.3 instead of 3.3.1 | | 7626|New|Nor|2002-03-29|classloader not working properly | | 7637|New|Cri|2002-03-30|Tomcat terminates after connecting to a database | | 7652|New|Cri|2002-04-01|Tomcat stalls periodically| | 7654|New|Min|2002-04-01|Exception in preInit - java.lang.ClassCastExceptio| | 7762|New|Enh|2002-04-05|stdout logfile handling | | 7770|New|Nor|2002-04-05|NPE in at session creation shortly after starting | | 7785|New|Blk|2002-04-06|tomcat bug in context reloading | | 7789|New|Maj|2002-04-06|JSP Cookie Read/Write Fails With DNS Names| | 7863|New|Maj|2002-04-09|I have a problem when running Tomcat with IIS | | 7904|New|Cri|2002-04-10|Tag Pool Manager - ClassCastException | +-+---+---+--+--+ | Total 47 bugs | +---+ -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands,
Bug report for Tomcat 4 [2002/04/14]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=CriticalMAJ=Major | | | | MIN=Minor NOR=Normal ENH=Enhancement | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 2820|Opn|Enh|2001-07-26|Implement GZIPOutput on HTTP 1.1 Connector| | 3509|Ass|Blk|2001-09-07|Apache 1.3.20 mod_webapp Tomcat 4b7 HANGS unde| | 3643|Ass|Enh|2001-09-16|Enable static-linking within Apache for WebApp mod| | 4042|Ass|Enh|2001-10-09|webapp component requires Port directive versus Li| | 4139|Ass|Enh|2001-10-12|mod_webapp build files for Win32 | | 4212|Ass|Enh|2001-10-16|How to configure Apache to serve static contents? | | 4350|Ass|Nor|2001-10-22|SSLAuthenticator did not associate SSO session| | 4352|Ass|Nor|2001-10-22|JDBCRealm does not work with CLIENT-CERT auth-meth| | 4371|Unc|Nor|2001-10-23|No responses on browsing root when using WarpConne| | 4386|Ass|Nor|2001-10-24|webapp1.0 will not install on Redhat 7.1 | | 4500|New|Nor|2001-10-29|isapi_redirect.dll does not pass Client certificat| | 4793|New|Blk|2001-11-11|mod_webapp connector doesn´t work | | 4829|Opn|Enh|2001-11-13|Automatic deployment of war files does not work pr| | 4930|New|Maj|2001-11-16|java.io.StreamCorruptedException: Type code out of| | 4961|New|Nor|2001-11-19|JDBCStore problems with Oracle, others(?) | | 4964|New|Maj|2001-11-20|popBody() is called before doEndTag() is called in| | 5040|New|Nor|2001-11-23|EOFException when talking from applet to servlet v| | 5143|New|Enh|2001-11-27|Please allow to specify the cipher set for HTTPS c| | 5166|New|Min|2001-11-28|CATALINA_BASE config issues for RUNNING.txt | | 5199|New|Nor|2001-11-30|jsp:param in jsp:include section not correct | | 5229|New|Blk|2001-12-02|Session cannot unbind if using DistributedManager | | 5329|New|Nor|2001-12-08|NT Service exits startup before Tomcat is finished| | 5383|New|Nor|2001-12-12|/etc/rc.d/init.d/tomcat4 on RedHat 6.1 fails | | 5402|New|Nor|2001-12-12|WarpConnection raise IOException | | 5405|New|Enh|2001-12-13|Powered by Tomcat | | 5446|Opn|Min|2001-12-16|Can't change webapp class loader (bug #5391 revisi| | 5507|New|Cri|2001-12-19|Swapping sessions causes exceptions and it doesn't| | 5547|New|Nor|2001-12-20|isapi_redirect.dll not work with ajp1.3? | | 5551|New|Enh|2001-12-21|MANAGER: add system information query | | 5585|Opn|Nor|2001-12-24|Error page not displayed | | 5603|New|Min|2001-12-28|ServletContext.getResourcePaths() returns extra sl| | 5647|Opn|Blk|2002-01-01|AJP13 connector will not pass authentication reque| | 5666|New|Min|2002-01-02|Implicit object _value on jsp pages | | 5704|Ass|Maj|2002-01-05|CgiServlet corrupting images? | | 5709|New|Nor|2002-01-06|HttpServletRequest.getHost returns web server addr| | 5758|New|Nor|2002-01-08|Server-side includes do not work properly | | 5759|Opn|Maj|2002-01-09|CGI servlet mapping by extension *.cgi does not wo| | 5762|Opn|Maj|2002-01-09|CGI servlet misses to include port number in HTTP_| | 5764|New|Enh|2002-01-09|Key Information Missing--Automatic Application Dep| | 5784|New|Min|2002-01-10|org.apache.catalina.WELCOME_FILES attribute replac| | 5793|New|Nor|2002-01-10|variable element in tld with TagExtraInfo class | | 5795|New|Enh|2002-01-10|Catalina Shutdown relies on localhost causing prob| | 5826|Opn|Min|2002-01-12|JSPC not recompiling modified files | | 5829|New|Nor|2002-01-13|StandardManager needs to cope with sessions throwi| | 5853|New|Maj|2002-01-14|Unable to get request parameters in the Error page| | 5858|New|Enh|2002-01-15|Add tomcat dir to java.library.path | | 5877|New|Min|2002-01-16|Facade of facade. | | 5895|New|Nor|2002-01-17|Not all sessions receives HttpSessionListener.sess| | 5899|New|Blk|2002-01-17|HTTP POST parameters ignored in CGIServlet.java | | 5903|New|Min|2002-01-17|version attribute in jsp:root | | 5952|New|Nor|2002-01-22|Refence to $JAVACMD in tomcat.conf incorrect in R| |
Re: Corrupted Ouput - Tomcat 4.0.3
Remy Maucherat wrote: There seems to be a bug in the servlet output. Tomcat 4 does not corrupt images, binaries, or anything like that. This has been proven on and on by many people using it (like myself) on various websites. That logic doesn't work. The fact that it works for some people, even the vast majority of people, is no proof at all that it works for everyone. Claude Montpetit wrote: I may try to play with this to prove myself that the problem is in my network (clues on how to change output buffer size on V3 and V4 would be appreciated). If you have a network analyzer (like ethereal) you might want to try to get a dump of the actual IP packets. Sometimes jumping down to the lowest possible level is easier than trying to debug things from the top down. This thread might be better over on tomcat-users, or if you're actively working on it, you might try the #tomcat channel on irc.openprojects.net. -- Christopher St. John [EMAIL PROTECTED] DistribuTopia http://www.distributopia.com -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Corrupted Ouput - Tomcat 4.0.3
Remy Maucherat wrote: There seems to be a bug in the servlet output. Tomcat 4 does not corrupt images, binaries, or anything like that. This has been proven on and on by many people using it (like myself) on various websites. That logic doesn't work. The fact that it works for some people, even the vast majority of people, is no proof at all that it works for everyone. Although I cannot mathematically prove it, there is not in the Tomcat codebase (o.a.catalina.* packages) any incorrect handling of binary output which would cause binary corruption. So I stand by my statement. I don't see any need for doubt when there should not be any. After that, the network stack of the VM is a black box, so anything can happen (for example, the connector is using TCP no delay set to true; maybe that could be causing problems). Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 8075] New: - Parameter parsing fails when the value has an '=' character in it
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8075.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8075
Parameter parsing fails when the value has an '=' character in it
Summary: Parameter parsing fails when the value has an '='
character in it
Product: Tomcat 4
Version: 4.0.4 Beta 2
Platform: All
OS/Version: All
Status: NEW
Severity: Major
Priority: Other
Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
The public static void parseParameters(Map map, byte[] data, String encoding)
method in org/apache/catalina/util/RequestUtil.java does not properly parse
strings like foo=abbar=cdfoobar=ef=gh^ij=kl. The parameter=value pairs
should be foo=ab, bar=cd and foobar=ef=gh^ij=kl. The fix is to change
the method so that it doesn't get tripped up on other '=' characters AFTER it
has found the key.
The following patch fixes this.
Index: RequestUtil.java
===
RCS file: /home/cvspublic/jakarta-tomcat-
4.0/catalina/src/share/org/apache/catalina/util/RequestUtil.java,v
retrieving revision 1.19
diff -u -r1.19 RequestUtil.java
--- RequestUtil.java21 Feb 2002 22:51:55 - 1.19
+++ RequestUtil.java14 Apr 2002 18:59:42 -
@@ -494,6 +494,7 @@
intox = 0;
String key = null;
String value = null;
+boolean keyFound = false;
while (ix data.length) {
byte c = data[ix++];
switch ((char) c) {
@@ -502,13 +503,10 @@
if (key != null) {
putMapEntry(map, key, value);
key = null;
+keyFound = false;
}
ox = 0;
break;
-case '=':
-key = new String(data, 0, ox, encoding);
-ox = 0;
-break;
case '+':
data[ox++] = (byte)' ';
break;
@@ -516,6 +514,16 @@
data[ox++] = (byte)((convertHexDigit(data[ix++]) 4)
+ convertHexDigit(data[ix++]));
break;
+case '=':
+if (keyFound == false) {
+ key = new String(data, 0, ox, encoding);
+ ox = 0;
+ keyFound = true;
+ break;
+}
+else {
+ // fall through and let the default statement handle it
+}
default:
data[ox++] = c;
}
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 8075] - Parameter parsing fails when the value has an '=' character in it
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8075. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8075 Parameter parsing fails when the value has an '=' character in it [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2002-04-14 22:11 --- While this particular case could be fixed, it will not be, as '=' is a reserved character in a URI which must be escaped (using %xx). -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 8079] New: - Tomcat cannot start if appBase directory is accessable but not readable.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8079. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8079 Tomcat cannot start if appBase directory is accessable but not readable. Summary: Tomcat cannot start if appBase directory is accessable but not readable. Product: Tomcat 4 Version: 4.0.3 Final Platform: PC OS/Version: Linux Status: NEW Severity: Normal Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I encounter a problem where my appBase is set to a directory, which only has the accessible permission (not readable) to the tomcat user. This cause tomcat to generate a NullExceptionPointer exception during its startup. After tracing trough the source code, the root cause is in HostConfig.java line 273 where a null file[] object that is referenced is null. This is because the code try to call the File.list() function to get a list of files in the appBase directory. Is this really neccessary? What happen if I do not want anyone to have readablity to my appBase except the directory's owner? -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Tomcat 4 target JDK is 1.2? but ShutdownHook is 1.3?
cvs HEAD o.a.c.startup.Catalina has a Runtime.addShutdownHook() call, but ShutdownHooks are a 1.3 thing. I was assuming (based on the website docs) that 4.1 was supposed to be JDK 1.2+. Is that incorrect? Is JDK 1.3 the target? In an amusing (and perhaps useless) twist, MinTC (embeddable servlet container based on the Tomcat 4 architecture) now appears to run under PersonalJava. PJ is a 1.1.8 variant (it has Collections classes, plus some other stuff). Catalina based servers expand to cover the entire gamut? Java Card anyone? -- Christopher St. John [EMAIL PROTECTED] DistribuTopia http://www.distributopia.com -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/util build.xml
larryi 02/04/14 21:07:01
Modified:util build.xml
Log:
Include in util/build/lib a copy of the actual commons-logging.jar used in
the build. Allows the choice of the logging jar to remain local, and an
external project can get this choice from a known location.
Revision ChangesPath
1.8 +4 -0 jakarta-tomcat-connectors/util/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-connectors/util/build.xml,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- build.xml 11 Apr 2002 19:21:02 - 1.7
+++ build.xml 15 Apr 2002 04:07:01 - 1.8
@@ -72,6 +72,10 @@
jar jarfile=${tomcat-util.build}/lib/tomcat-util.jar
basedir=${tomcat-util.build}/classes
/
+
+ !-- Include a copy of the commons-logging.jar that we built with --
+ copy tofile=${tomcat-util.build}/lib/commons-logging.jar
+ file=${commons-logging.jar}/
/target
!-- BUILD: Create Tomcat-Util Javadocs === --
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat build.xml
larryi 02/04/14 21:25:24
Modified:.build.xml
Log:
Note sure if this will be in time for tonight's Gump build. The tomcat-jar target
still included the coyote target, which would cause it to fail.
This also implements a different approach to keeping Gump happy. Rather
than to define separate Gump targets, add new targets at needed points
in the standard build flow. For this purpose, main.lite was added.
It relies on the use of uptodate to avoid rebuilding the J-T-C util project,
which causes problems for Gump.
Also, since jakarta-tomcat doesn't directly depend on commons-logging,
I have removed it from this build.xml. commons-logging.jar is now copied
from the results of the J-T-C util build.
These changes should get Gump working again with main and dist'
targets still including coyote. More changes are coming so that a
future Gump project can defined for jakarta-tomcat which will include
the J-T-C dependencies.
Revision ChangesPath
1.175 +29 -38jakarta-tomcat/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat/build.xml,v
retrieving revision 1.174
retrieving revision 1.175
diff -u -r1.174 -r1.175
--- build.xml 14 Apr 2002 16:04:52 - 1.174
+++ build.xml 15 Apr 2002 04:25:24 - 1.175
@@ -79,20 +79,6 @@
property name=jtc.http11.home location=${jakarta-tomcat-connectors}/http11/
property name=jtc.http11.lib location=${jtc.http11.home}/build/lib/
- !-- A binary copy of commons-logging.jar is checked in j-t-c.
- It can be overriden by gump or if you want to build jakarta-commons --
- !--
- property name=commons-logging.home
-location=${jakarta-commons}/logging/
- property name=commons-logging.lib
-location=${commons-logging.home}/dist/
- property name=commons-logging.jar
-location=${commons-logging.lib}/commons-logging.jar/
- --
-
- property name=commons-logging.jar
-location=${jakarta-tomcat-connectors}/lib/commons-logging.jar/
-
!-- Binaries checked in ( servlet.jar is not likely to change,
the 2.2 spec is final --
property name=servlet22.jar value=bin/servlet22.jar/
@@ -124,6 +110,12 @@
file=${jakarta-tomcat-connectors} /
/target
+ target name=uptodate
+uptodate property=tomcat-util.is.uptodate targetfile=${tomcat-util.jar}
+ srcfiles dir=${jtc.util.home} includes=java/**,build.xml/
+/uptodate
+ /target
+
target name=msg.jdk12 if=jdk12.present
echo message=Detected JDK1.2 /
/target
@@ -144,7 +136,12 @@
fail message=Jakarta-tomcat-connectors repository is required
${jakarta-tomcat-connectors}/
/target
- target name=init
depends=detect,msg.jdk12,msg.jsse,msg.puretls,msg.commons-dbcp,msg.jtc
+ target name=msg.jtc.util if=tomcat-util.is.uptodate
+echo message=tomcat-util.jar is up to date/
+ /target
+
+ target name=init
+
depends=detect,uptodate,msg.jdk12,msg.jsse,msg.puretls,msg.commons-dbcp,msg.jtc,msg.jtc.util
/target
target name=prepare.jaxp101 depends=detect if=jaxp10-present
@@ -239,9 +236,6 @@
copy file =src/build/readme/readme.common
tofile=${tomcat.build}/lib/common/README /
-copy tofile=${tomcat.build}/lib/common/commons-logging.jar
- file=${commons-logging.jar}/
-
!-- This act as a default, Tomcat3.3 will not load it in
classpath, just a hack to ease the transition
--
@@ -257,8 +251,12 @@
chmod perm=+x file=${tomcat.build}/bin/shutdown.sh/
/target
+ target name=dep.tomcat-util unless=tomcat-util.is.uptodate
+ description=Build j-t-c util which we depend on. To be called before
main
+ant dir=${jakarta-tomcat-connectors}/util /
+ /target
+
target name=deps description=Build repositoried that depends on. To be called
before main
-ant dir=${jakarta-tomcat-connectors}/util /
ant dir=${jakarta-tomcat-connectors}/coyote
property name=tomcat33.home value=${basedir}/build/tomcat/
/ant
@@ -307,16 +305,13 @@
/fileset
/jar
-!-- J-T-C utils - with tomcat_util.jar name --
-!--
-jar jarfile=${tomcat.build}/lib/common/tomcat_util.jar
- fileset dir=${jakarta-tomcat-connectors}/util/build/classes
-include name=org/apache/tomcat/util/**/
+!-- Add jakarta-tomcat-connectors utils --
+!-- Includes the tomcat-utils.jar and common-logging.jar --
+copy todir=${tomcat.build}/lib/common
+ fileset dir=${jakarta-tomcat-connectors}/util/build/lib
+include name=*.jar/
/fileset
-/jar
---
-copy file=${jakarta-tomcat-connectors}/util/build/lib/tomcat-util.jar
-
[PATCH] Small fix for StandardServer ctr
o.a.c.core.StandardServer's ctr calls super(), but the class does not extend anything. The call is legal, but misleading. The following patch removes it. The patch is against HEAD, but it's also an issue in 4.0.x. -- Christopher St. John [EMAIL PROTECTED] DistribuTopia http://www.distributopia.com stdsrvctr.patch Description: Binary data -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
