[REPORT] errors on some documents in jakarta-tomcat-5 repository
In jakarta-tomcat-5 repository on BUILDING.txt, the link http://jakarta.apache.org/builds/jakarta-tomcat-5/nightly/src/ doesn't work at all. on RUNNING.txt, http://jakarta.apache.org/builds/jakarta-tomcat-5/nightly/ also doesn't work at all. I hope these can be corrected as soon as possilbe for the readers not to be puzzled. IAS Independent Java Technical Evangelist Project Coordinator http://www.iasandcb.pe.kr -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
[PROPOSAL]Integral approach to request-response encoding with content type
Hi I'm Changshin Lee, a JCP individual member. I'm also a member of JSR-179 Location API for J2ME EG. I've always appreciated your work, Tomcat. In this message, I'd like to make a proposal on resolving localization issues on SRV-JSP technology and its reference implementation. Actually I have some experience which is very similar with this situation: the uploading module in com.oreilly.servlet(COS) package by Jason Hunter. I emailed to him about COS i18n(and l10n) around 2 years ago, and unfortunately got little attention. At that time I felt very sorry because not only Korean developers but also all the non-Latin-1-based developers faced that problem. I patched COS to COSI(COS I18n) by myself since COS showed no interest in i18n. COSI had around 2 years of lifetime for claiming the i18n of COS, and finally COS adopted the idea of COSI and I happily stopped maintaining COSI for people to prefer COS for the future. ( Due to the efforts, I could become the official Korean translator of Java Servlet Programming from O'Reilly. You can touch the fossil of COSI on following links English - http://www.iasandcb.pe.kr/English/cosi/index.html Japanese - http://www.iasandcb.pe.kr/Japanese/cosi/index.html Korean - http://www.iasandcb.pe.kr/Korean/cosi/index.html ) The reason why I wrote here a long and boring history about my private thing is simple and clear enough. We need to achieve complete and convenient i18n and l10n, and it really takes some time. The only one thing I hope for is that the time would be as short as people get happy. I've investigated these issues on tomcat mailing list and some suggested brilliant ways to overcome the current situation. About request encoding, http://www.mail-archive.com/tomcat-dev@jakarta.apache.org/msg13334.html Also about response encoding http://www.mail-archive.com/tomcat-dev@jakarta.apache.org/msg26720.html and more fundamentally, http://www.mail-archive.com/tomcat-dev@jakarta.apache.org/msg08912.html First, filter policy works fine for both SRV and JSP with respect to request. However, it doesn't work for JSP with respect to response. The reason is also mentioned at the link. About the changes(and possilby the improvements) of web.xml for l10n, I also wrote the following messages to JSP spec lead. The first message: I have requests about response and request configuration. Since Java Servlet Technology was born, its localization issues were discussed hard. Now we can set up response's content type and request's encoding, however, the processes need programmatic accesses. Servlet Developer must call the related methods whenever it is necessary. I know some specific web containers support some configurations for the default set-up, but I think Servlet Specification should standardize how it works through web.xml context. Probably Servlet Filtering can be a solution. But I wish that everyone can define them in web.xml for more convenience and avoid modifying a web container with source level such as tomcat localized patch. - The second message: I checked out locale-encoding-mapping-list element in SRV 2.4 DD (SRV 13.2 p116). I understand that the element maps a locale to an encoding, but doesn't specify the default locale(or encoding) for a given web application(context). According to JSP 2.0 PDF (Localization Issues), pageEncoding concept is introduced for more convenient localization. However, it just applies to JSP pages, not based servlet class codes. At this moment, I'd like to propose default request character encoding default response content type default response locale(or encoding) default response buffer size elements in SRV 2.4 DD. Many developers for non-Latin-1 services have long for the above settings. Moreover, nowadays many web applications are mainly provided as non-text/html pages such as WAP and XHTML. In some sites, web applications should generate a lot of contents in one page, so the current default buffer size of 8~16kb is not enough. (Heavy statistics or multimedia are such examples.) - Unfortunately, I had no answers for the second message. (The answer for the first one is understanding and effort briefly with the insufficient alternative locale-encoding-mapping-list.) So, I confirmed that we need something more and more. Actually the filter policy for SRV is very good, and I attached an integral version of the filter to this message. (In ias.zip, you can extract ContentFilter in ias/WEB-INF/classes directory) With ContentFilter and web.xml, you can configure all servlets' content type and response encoding and request encoding smoothly. The example Test servlet (you can invoke via http://localhost:8080/ias/servlet/Test by installing ias context) also displays correct settings for the configured web.xml. On JSP side, as you can guess, it gives a little different result. Conclusively, you can set up request encoding, but cannot do so to response encoding because of JSP's generation mechanism. In this case, JSP 2.0
Re: cvs commit: jakarta-tomcat-catalina/catalina build.xml
On 11 Sep 2002, [EMAIL PROTECTED] wrote:
+ property name=catalina.home value=${basedir}/../
As I've seen this explicit reference to basedir quite often. You
could also use
property name=catalina.home location=.. /
which is a more Anty way to do the same. Well, not quite,
${catalina.home} will be an absolute path instead of the absolute path
of basedir with the String /.. appended.
Requires Ant 1.2 or better, so it should probably be save.
Stefan
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 12503] - default servlet overrides welcome file
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12503. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12503 default servlet overrides welcome file [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2002-09-11 09:05 --- cite src=Java Servlet Specification version=2.3 topic=SRV.9.10 Welcome Files The purpose of this mechanism is to allow the deployer to specify an ordered list of partial URIs for the container to use for appending to URIs when there is a request for a URI that corresponds to a directory entry in the WAR not mapped to a web component. /cite keyPhrasenot mapped to a web component/keyPhrase -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 12434] - Version ID of 4.1.10 is wrong
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12434. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12434 Version ID of 4.1.10 is wrong [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID | --- Additional Comments From [EMAIL PROTECTED] 2002-09-11 09:09 --- I am using jakarta-tomcat-4.1.10.zip not the EXE installer. I am speeking of the version in the startup window of Tomcat ... see below ... 10.09.2002 09:30:44 org.apache.commons.modeler.Registry loadRegistry INFO: Loading registry information 10.09.2002 09:30:44 org.apache.commons.modeler.Registry getRegistry INFO: Creating new Registry instance 10.09.2002 09:30:45 org.apache.commons.modeler.Registry getServer INFO: Creating MBeanServer 10.09.2002 09:30:45 org.apache.coyote.http11.Http11Protocol init INFO: Initializing Coyote HTTP/1.1 on port 8080 Starting service Tomcat-Standalone Apache Tomcat/4.1.9 11.09.2002 11:06:04 org.apache.coyote.http11.Http11Protocol start INFO: Starting Coyote HTTP/1.1 on port 8080 -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 12514] New: - Etag not readable by certain browsers
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12514. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12514 Etag not readable by certain browsers Summary: Etag not readable by certain browsers Product: Tomcat 4 Version: 4.1.10 Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: Other Component: Connector:Coyote HTTP/1.1 AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Some browsers (IE 5.5 Win, IE 5.1 MAC) do not recognice the ETag send by Tomcat 4.1.x. (4.0 was ok) new e.g.: ETag: W/8006-1030711622000. They only accept something like ETag: W/8006-1030711622000. This leads to repeated download for static content and decreases performance significantly. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 12516] New: - form based auth / documentation
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12516. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12516 form based auth / documentation Summary: form based auth / documentation Product: Tomcat 4 Version: 4.1.9 Platform: All URL: http://jakarta.apache.org/tomcat/tomcat-4.1-doc/realm- howto.html OS/Version: All Status: NEW Severity: Normal Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] The documentation for form based authentication states (Realm HOW-TO, under JDBCRealm): # Once a user has been authenticated, the user (and his or her associated roles) are cached within Tomcat for the duration of the user's login. (For FORM-based authentication, that means until the session times out or is invalidated; for BASIC authentication, that means until the user closes their browser). Any changes to the database information for an already authenticated user will not be reflected until the next time that user logs on again. So it looks like the principal is stored in the session, and that it is persisted between server reloads, however the sources state the following: StandardSession.java: /** * The authenticated Principal associated with this session, if any. * bIMPLEMENTATION NOTE:/b This object is inot/i saved and * restored across session serializations! */ private transient Principal principal = null; So for some reason the principal is not persisted (why??). Apparently the implementation is not going to change, so maybe the documentation could state this behavior more clearly. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 12517] New: - JSP compilation error with nested scripting variable
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12517.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12517
JSP compilation error with nested scripting variable
Summary: JSP compilation error with nested scripting variable
Product: Tomcat 4
Version: 4.1.9
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: Major
Priority: Other
Component: Jasper 2
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
Hello
The actual version of Tomcat is 4.1.10, but there's no choice for it.
I've a JSP page extending TagSupport with a custom tag that defines a scripting
variable with a NESTED scope. Here's the extra info class:
public class WizardExtraInfo extends TagExtraInfo {
public VariableInfo[] getVariableInfo(TagData data) {
return new VariableInfo[] {
new VariableInfo(profiles,
browser.client.jsp.Profiles,
true,
VariableInfo.NESTED)
};
}
}
When referencing the scripting variable inside the tag body a
NullPointerException is thrown. Looking at the generated java code I see that
the variable is declared immediately after doStartTag() but synchronized only
after doAfterBody().
/* cb:wizard */
browser.client.jsp.tag.Wizard _jspx_th_cb_wizard_0 =
browser.client.jsp.tag.Wizard)
_jspx_tagPool_cb_wizard_undoAction_nextPage_nextAction_cancelAction.get
(browser.client.jsp.tag.Wizard.class);
_jspx_th_cb_wizard_0.setPageContext(pageContext);
_jspx_th_cb_wizard_0.setParent(null);
_jspx_th_cb_wizard_0.setXXX;
int _jspx_eval_cb_wizard_0 = _jspx_th_cb_wizard_0.doStartTag();
if (_jspx_eval_cb_wizard_0 != javax.servlet.jsp.tagext.Tag.SKIP_BODY) {
browser.client.jsp.Profiles profiles = null;
do {
/* body */
...
profiles.get(...); // throws NullPointerException
...
/* end body */
int evalDoAfterBody = _jspx_th_cb_wizard_0.doAfterBody();
profiles = (browser.client.jsp.Profiles) pageContext.findAttribute
(profiles);
if (evalDoAfterBody !=
javax.servlet.jsp.tagext.BodyTag.EVAL_BODY_AGAIN)
break;
} while (true);
}
if (_jspx_th_cb_wizard_0.doEndTag() ==
javax.servlet.jsp.tagext.Tag.SKIP_PAGE)
return;
_jspx_tagPool_cb_wizard_undoAction_nextPage_nextAction_cancelAction.reuse
(_jspx_th_cb_wizard_0);
The same page compiled with Tomcat 3.3.1 correctly translates to
int _jspx_eval_cb_wizard_0 = _jspx_th_cb_wizard_0.doStartTag();
if (_jspx_eval_cb_wizard_0 == javax.servlet.jsp.tagext.BodyTag.EVAL_BODY_TAG)
throw new JspTagException(Since tag handler...);
if (_jspx_eval_cb_wizard_0 != javax.servlet.jsp.tagext.Tag.SKIP_BODY) {
do {
browser.client.jsp.Profiles profiles = null;
profiles = (browser.client.jsp.Profiles) pageContext.findAttribute
(profiles);
Thanks in advance.
Daniele Gaffuri
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/webapps/admin/defaultcontext - New directory
amyroh 2002/09/11 03:53:44 jakarta-tomcat-4.0/webapps/admin/defaultcontext - New directory -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/defaultcontext - New directory
amyroh 2002/09/11 03:55:28 jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/defaultcontext - New directory -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 12521] New: - HTML Manager cannot deploy war file with path=/
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12521. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12521 HTML Manager cannot deploy war file with path=/ Summary: HTML Manager cannot deploy war file with path=/ Product: Tomcat 4 Version: 4.1.10 Platform: Other OS/Version: Solaris Status: NEW Severity: Normal Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] When deploying war file on default context with: http://localhost:8080/manager/deploy?war=jar:file:/path/to/app.war!/path=/ you get: OK - Installed application at context path / but if you try to use the application you get: HTTP Status 500 - No Context configured to process this request And if you try: http://localhost:8080/manager/undeploy?path=/ you get: FAIL - No context exists for path / -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 12521] - HTML Manager cannot deploy war file with path=/
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12521. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12521 HTML Manager cannot deploy war file with path=/ --- Additional Comments From [EMAIL PROTECTED] 2002-09-11 11:22 --- Created an attachment (id=3008) log without and with patch -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 12521] - HTML Manager cannot deploy war file with path=/
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12521. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12521 HTML Manager cannot deploy war file with path=/ --- Additional Comments From [EMAIL PROTECTED] 2002-09-11 11:23 --- Created an attachment (id=3009) pacth to ManagerServlet.java -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 12521] - HTML Manager cannot deploy war file with path=/
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12521. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12521 HTML Manager cannot deploy war file with path=/ --- Additional Comments From [EMAIL PROTECTED] 2002-09-11 11:32 --- Here are a couple of attachments that should help you solve the problem: attachment 3008 is the log with and without the patch, and attachment 3009 is a pacth to ManagerServlet.java that make the deploy work. I have not the resources to test if this may cause any side effect somewhere else, i count on you for this, but in my case it looks everything is working good. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 12517] - JSP compilation error with nested scripting variable
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12517.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12517
JSP compilation error with nested scripting variable
--- Additional Comments From [EMAIL PROTECTED] 2002-09-11 11:45 ---
I've tried to compile a page with a custom tag extending BodyTagSupport and
declaring a NESTED scripting variable named as the id attribute. In this case
the scripting variable is initialized after doInitBody() but is never declared.
It seems that another variable named _jspx_columnDescr_1, already declared at
the beginning of service method, is declared instead, and the result generates
two compilation errors.
/* cb:column */
browser.ViewColumn _jspx_columnDescr_1 = columnDescr;
browser.client.jsp.tag.Column _jspx_th_cb_column_1 =
(browser.client.jsp.tag.Column) _jspx_tagPool_cb_column_value_name_id.get
(browser.client.jsp.tag.Column.class);
_jspx_th_cb_column_1.setPageContext(pageContext);
_jspx_th_cb_column_1.setParent(_jspx_th_cb_column_0);
_jspx_th_cb_column_1.setId(columnDescr);
int _jspx_eval_cb_column_1 = _jspx_th_cb_column_1.doStartTag();
if (_jspx_eval_cb_column_1 != javax.servlet.jsp.tagext.Tag.SKIP_BODY) {
if (_jspx_eval_cb_column_1 != javax.servlet.jsp.tagext.Tag.EVAL_BODY_INCLUDE){
javax.servlet.jsp.tagext.BodyContent _bc = pageContext.pushBody();
_bc.clear();
out = _bc;
_jspx_th_cb_column_1.setBodyContent(_bc);
_jspx_th_cb_column_1.doInitBody();
columnDescr = (browser.ViewColumn) pageContext.findAttribute(columnDescr);
}
do {
/* body */
int evalDoAfterBody = _jspx_th_cb_column_1.doAfterBody();
columnDescr = (browser.ViewColumn) pageContext.findAttribute(columnDescr);
if (evalDoAfterBody != javax.servlet.jsp.tagext.BodyTag.EVAL_BODY_AGAIN)
break;
} while (true);
if (_jspx_eval_cb_column_1 != javax.servlet.jsp.tagext.Tag.EVAL_BODY_INCLUDE)
out = pageContext.popBody();
}
if (_jspx_th_cb_column_1.doEndTag() == javax.servlet.jsp.tagext.Tag.SKIP_PAGE)
return;
_jspx_tagPool_cb_column_value_name_id.reuse(_jspx_th_cb_column_1);
columnDescr = _jspx_columnDescr_1;
The generated errors are:
Generated servlet error:
[javac] Compiling 1 source file
D:\jakarta-tomcat-4.1.10
\work\Standalone\localhost\click\data\codes_jsp.java:514: _jspx_columnDescr_1
is already defined in _jspService
(javax.servlet.http.HttpServletRequest,javax.servlet.http.HttpServletResponse)
browser.ViewColumn _jspx_columnDescr_1 = columnDescr;
^
An error occurred at line: 84 in the jsp file: /data/codes.jsp
Generated servlet error:
D:\jakarta-tomcat-4.1.10
\work\Standalone\localhost\click\data\codes_jsp.java:514: cannot resolve symbol
symbol : variable columnDescr
location: class org.apache.jsp.codes_jsp
browser.ViewColumn _jspx_columnDescr_1 = columnDescr;
^
Don't know if the two problems are related, so I add a comment instead of
opening a new bug.
Thanks.
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup Catalina.java ContextConfig.java HostConfig.java
jfarcand2002/09/11 06:08:19
Modified:catalina/src/share/org/apache/catalina/startup Catalina.java
ContextConfig.java HostConfig.java
Log:
Change the log level for performance/debugging information. Replace log.info by
log.debug (not log.log). This time cleanup and then compile.
Revision ChangesPath
1.5 +7 -7
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/Catalina.java
Index: Catalina.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/Catalina.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- Catalina.java 11 Sep 2002 03:24:05 - 1.4
+++ Catalina.java 11 Sep 2002 13:08:18 - 1.5
@@ -363,7 +363,7 @@
parentClassLoader));
long t2=System.currentTimeMillis();
-log.info(Digester for server.xml created + ( t2-t1 ));
+log.debug(Digester for server.xml created + ( t2-t1 ));
return (digester);
}
@@ -456,7 +456,7 @@
System.exit(1);
}
long t2=System.currentTimeMillis();
-log.info( Server.xml processed + (t2-t1 ));
+log.debug( Server.xml processed + (t2-t1 ));
// Setting additional variables
if (!useNaming) {
@@ -515,7 +515,7 @@
server.initialize();
((Lifecycle) server).start();
long t4=System.currentTimeMillis();
-log.info( server.start + server + + (t4-t3 ));
+log.debug( server.start + server + + (t4-t3 ));
try {
// Register shutdown hook
Runtime.getRuntime().addShutdownHook(shutdownHook);
1.14 +6 -6
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/ContextConfig.java
Index: ContextConfig.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/ContextConfig.java,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -r1.13 -r1.14
--- ContextConfig.java11 Sep 2002 03:24:05 - 1.13
+++ ContextConfig.java11 Sep 2002 13:08:19 - 1.14
@@ -329,7 +329,7 @@
}
long t2=System.currentTimeMillis();
if( (t2-t1 ) 200 )
-log.info(Processed + url ++ ( t2-t1));
+log.debug(Processed + url ++ ( t2-t1));
}
@@ -663,7 +663,7 @@
}
long t2=System.currentTimeMillis();
if( (t2-t1) 200 )
-log.info(Processed default web.xml + file ++ ( t2-t1));
+log.debug(Processed default web.xml + file ++ ( t2-t1));
}
1.4 +7 -7
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/HostConfig.java
Index: HostConfig.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/HostConfig.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- HostConfig.java 21 Aug 2002 22:10:34 - 1.3
+++ HostConfig.java 11 Sep 2002 13:08:19 - 1.4
@@ -497,7 +497,7 @@
}
// Assume this is a configuration descriptor and deploy it
-log.info(sm.getString(hostConfig.deployDescriptor, files[i]));
+log.debug(sm.getString(hostConfig.deployDescriptor, files[i]));
try {
URL config =
new URL(file, null, dir.getCanonicalPath());
@@ -545,7 +545,7 @@
if (isUnpackWARs()) {
// Expand and deploy this application as a directory
-log.info(sm.getString(hostConfig.expand, files[i]));
+log.debug(sm.getString(hostConfig.expand, files[i]));
try {
URL url = new URL(jar:file: +
dir.getCanonicalPath() + !/);
@@ -627,7 +627,7 @@
}
long t2=System.currentTimeMillis();
if( (t2-t1) 200 )
-log.info(Deployed + files[i] + + (t2-t1));
+log.debug(Deployed + files[i] + + (t2-t1));
}
}
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 12521] - HTML Manager cannot deploy war file with path=/
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12521. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12521 HTML Manager cannot deploy war file with path=/ --- Additional Comments From [EMAIL PROTECTED] 2002-09-11 13:15 --- After a bit of rethinking, to be consistent with path attribute of Context element into server.xml, why do not allow to specify path= instead of path=/ parameter to manager commands when referring to default context? -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 10901] - Response#setLocale() does not set charset encoding
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10901. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10901 Response#setLocale() does not set charset encoding --- Additional Comments From [EMAIL PROTECTED] 2002-09-11 13:32 --- Created an attachment (id=3013) This is the patch which fixes this bug of the Coyote HTTP/1.1 Connector for Tomcat 4.x . -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 10901] - Response#setLocale() does not set charset encoding
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10901. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10901 Response#setLocale() does not set charset encoding [EMAIL PROTECTED] changed: What|Removed |Added Severity|Normal |Major Priority|Other |Medium --- Additional Comments From [EMAIL PROTECTED] 2002-09-11 14:11 --- This bug occurs in the latest distribution of Tomcat 4.1 invariably. So, I strongly hope that the patch will be applied before Tomcat 4.1's next release. Regards, OGAWA Kan -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans MBeanFactory.java MBeanUtils.java ServerLifecycleListener.java
amyroh 2002/09/11 07:19:33
Modified:catalina/src/share/org/apache/catalina/core
StandardServer.java
catalina/src/share/org/apache/catalina/mbeans
MBeanFactory.java MBeanUtils.java
ServerLifecycleListener.java
Log:
Initial check in for DefaultContext support in admin.
Still need to polish and add loader and manager info.
Revision ChangesPath
1.32 +4 -6
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardServer.java
Index: StandardServer.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardServer.java,v
retrieving revision 1.31
retrieving revision 1.32
diff -u -r1.31 -r1.32
--- StandardServer.java 13 Aug 2002 08:08:17 - 1.31
+++ StandardServer.java 11 Sep 2002 14:19:33 - 1.32
@@ -1344,12 +1344,10 @@
}
// Store nested naming resources elements
-/* FIXME - DefaultContext does not have a getNamingResources() method
NamingResources nresources = dcontext.getNamingResources();
if (nresources != null) {
storeNamingResources(writer, indent + 2, nresources);
}
-*/
// Store the ending of this element
for (int i = 0; i indent; i++) {
1.37 +16 -8
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/MBeanFactory.java
Index: MBeanFactory.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/MBeanFactory.java,v
retrieving revision 1.36
retrieving revision 1.37
diff -u -r1.36 -r1.37
--- MBeanFactory.java 9 Sep 2002 23:39:03 - 1.36
+++ MBeanFactory.java 11 Sep 2002 14:19:33 - 1.37
@@ -316,13 +316,19 @@
ObjectName pname = new ObjectName(parent);
String type = pname.getKeyProperty(type);
Server server = ServerFactory.getServer();
-Service service = server.findService(pname.getKeyProperty(service));
+String serviceName = pname.getKeyProperty(service);
+if (serviceName == null) {
+serviceName = pname.getKeyProperty(name);
+}
+Service service = server.findService(serviceName);
Engine engine = (Engine) service.getContainer();
String hostName = pname.getKeyProperty(host);
if (hostName == null) { //if DefaultContext is nested in Engine
+context.setParent(engine);
engine.addDefaultContext(context);
} else {// if DefaultContext is nested in Host
Host host = (Host) engine.findChild(hostName);
+context.setParent(host);
host.addDefaultContext(context);
}
@@ -826,13 +832,15 @@
Service service = server.findService(pname.getKeyProperty(service));
Engine engine = (Engine) service.getContainer();
Host host = (Host) engine.findChild(pname.getKeyProperty(host));
+context.setParent(host);
host.addChild(context);
// Return the corresponding MBean name
ManagedBean managed = registry.findManagedBean(StandardContext);
ObjectName oname =
MBeanUtils.createObjectName(managed.getDomain(), context);
-return (oname.toString());
+throw new Exception(oname.toString());
+//return (oname.toString());
}
@@ -885,8 +893,8 @@
*/
public String createStandardHost(String parent, String name,
String appBase, boolean autoDeploy,
- boolean deployXML, boolean liveDeploy,
- boolean unpackWARs)
+ boolean deployXML, boolean liveDeploy,
+ boolean unpackWARs)
throws Exception {
// Create a new StandardHost instance
1.43 +5 -5
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/MBeanUtils.java
Index: MBeanUtils.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/MBeanUtils.java,v
retrieving revision 1.42
retrieving revision 1.43
diff -u -r1.42 -r1.43
--- MBeanUtils.java 14 Jun 2002 13:29:48 - 1.42
+++ MBeanUtils.java 11 Sep 2002 14:19:33 - 1.43
@@ -1103,7 +1103,7 @@
} else if (container instanceof Engine) {
Engine engine = (Engine) container;
Service service = engine.getService();
-name = new ObjectName(domain +
cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves ErrorReportValve.java
amyroh 2002/09/11 07:44:45
Modified:catalina/src/share/org/apache/catalina/valves
ErrorReportValve.java
Log:
Fix to set response encoding for ErrorReportValve - submitted by OGAWA Kan
[EMAIL PROTECTED]
Revision ChangesPath
1.12 +8 -4
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/ErrorReportValve.java
Index: ErrorReportValve.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/ErrorReportValve.java,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- ErrorReportValve.java 10 May 2002 03:41:13 - 1.11
+++ ErrorReportValve.java 11 Sep 2002 14:44:45 - 1.12
@@ -72,6 +72,7 @@
import java.util.ArrayList;
import java.util.Enumeration;
import java.util.Iterator;
+import java.util.Locale;
import javax.servlet.ServletException;
import javax.servlet.ServletRequest;
import javax.servlet.ServletResponse;
@@ -349,8 +350,11 @@
if (writer != null) {
+Locale locale = Locale.getDefault();
+
try {
hres.setContentType(text/html);
+hres.setLocale(locale);
} catch (Throwable t) {
if (debug = 1)
log(status.setContentType, t);
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 3888] - WebappClassLoader: Lifecycle error : CL stopped
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=3888. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=3888 WebappClassLoader: Lifecycle error : CL stopped --- Additional Comments From [EMAIL PROTECTED] 2002-09-11 15:53 --- I couldn't find details about this bug in any release notes. Could you tell me which release note I should look into? Or copy the details here so that it is easier to find. Thanks. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina build.xml
bobh2002/09/11 08:56:29
Modified:catalina build.xml
Log:
Stefan Bodewig says this is the Anty way to do the same.
Revision ChangesPath
1.20 +1 -1 jakarta-tomcat-catalina/catalina/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/build.xml,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -r1.19 -r1.20
--- build.xml 11 Sep 2002 03:44:56 - 1.19
+++ build.xml 11 Sep 2002 15:56:29 - 1.20
@@ -10,7 +10,7 @@
property file=${user.home}/build.properties/--
!-- Build Defaults --
- property name=catalina.home value=${basedir}/../
+ property name=catalina.home location=../
property name=catalina.buildvalue=${catalina.home}/catalina/build/
property name=catalina.deploy value=${catalina.home}/build/
property name=catalina.dist value=${catalina.home}/dist/
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina build.xml
On 11 Sep 2002, Stefan Bodewig wrote:
Date: 11 Sep 2002 09:58:54 +0200
From: Stefan Bodewig [EMAIL PROTECTED]
Reply-To: Tomcat Developers List [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Subject: Re: cvs commit: jakarta-tomcat-catalina/catalina build.xml
On 11 Sep 2002, [EMAIL PROTECTED] wrote:
+ property name=catalina.home value=${basedir}/../
As I've seen this explicit reference to basedir quite often. You
could also use
property name=catalina.home location=.. /
which is a more Anty way to do the same. Well, not quite,
${catalina.home} will be an absolute path instead of the absolute path
of basedir with the String /.. appended.
Requires Ant 1.2 or better, so it should probably be save.
I've been bit using relative references like this, especially in cases
where you've got calls to build.xml scripts in nested directories -- the
problem is that relative paths are evaluated differently depending on
where you invoke Ant from. Using ${basedir} solves that nicely.
Stefan
Craig
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat build.xml
larryi 2002/09/11 10:23:07
Modified:.build.xml
Log:
Fix, I assume, cut paste error with jakarta-logging. Default to version
1.0.1 since this is the one that has commons-logging-api.jar.
Revision ChangesPath
1.187 +2 -2 jakarta-tomcat/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat/build.xml,v
retrieving revision 1.186
retrieving revision 1.187
diff -u -r1.186 -r1.187
--- build.xml 11 Sep 2002 05:36:42 - 1.186
+++ build.xml 11 Sep 2002 17:23:07 - 1.187
@@ -84,8 +84,8 @@
property name=commons-pool.lib location=${commons-pool.home}/dist/
property name=commons-pool.jar
location=${commons-pool.lib}/commons-pool.jar/
- property name=commons-logging.home
location=${jakarta-commons}/commons-logging-1.0 /
- property name=commons-logging.lib location=${jakarta-logging.home} /
+ property name=commons-logging.home
location=${jakarta-commons}/commons-logging-1.0.1 /
+ property name=commons-logging.lib location=${commons-logging.home} /
property name=commons-logging.jar
location=${commons-logging.lib}/commons-logging-api.jar /
property name=commons-collections.home
location=${jakarta-commons}/collections/
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat/src/doc serverxml.html
larryi 2002/09/11 10:35:26
Modified:src/doc serverxml.html
Log:
A correction for LogSetter I had lying around
Revision ChangesPath
1.26 +5 -3 jakarta-tomcat/src/doc/serverxml.html
Index: serverxml.html
===
RCS file: /home/cvs/jakarta-tomcat/src/doc/serverxml.html,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -r1.25 -r1.26
--- serverxml.html8 May 2002 02:27:54 - 1.25
+++ serverxml.html11 Sep 2002 17:35:26 - 1.26
@@ -2116,8 +2116,8 @@
tr valign=top
tdpath/td
tdPath to the desired log file. You may embed a
- codejava.text.SimpleDateFormat/code string enclosed within '{}'
- to create a path that encorporates the current date and or time./td
+ codejava.text.SimpleDateFormat/code string enclosed within quot;${}quot;
+ to create a path that encorporates the current date and/or time./td
tdnull, log output goes to stderr/td
/tr
tr valign=top
@@ -2144,6 +2144,8 @@
pre
lt;LogSetter name=quot;tc_logquot; verbosityLevel=quot;DEBUGquot; /gt;
+lt;LogSetter name=quot;servlet_logquot; timestamps=quot;truequot;
+verbosityLevel=quot;INFORMATIONquot;
path=quot;logs/servlet-${MMdd}.logquot; /gt;
/pre
hr size=5
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 12517] - JSP compilation error with nested scripting variable
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12517.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12517
JSP compilation error with nested scripting variable
--- Additional Comments From [EMAIL PROTECTED] 2002-09-11 18:04 ---
I had the same problem with the new 4.1.10 release.
Our custom tag simply implements 'Tag' interface and returns 'EVAL_BODY_INCLUDE'
in doStartTag(). The tag exports 'menuString' as following:
public VariableInfo [] getVariableInfo(TagData pData) {
return new VariableInfo[] {
new VariableInfo(menuString,
java.lang.String,
true,
VariableInfo.NESTED)
};
}
Compiled java code for jsp page when two 'menu' tags are used in different
blocks (which means different { } blocks)
/* ct:menu (first one) */
{
java.lang.String menuString = null;
com.ct.tags.ui.MenuTag _jspx_th_ct_menu_0 =
(com.ct.tags.ui.MenuTag)
_jspx_tagPool_ct_menu_whichMenu.get(com.ct.tags.ui.MenuTag.class);
_jspx_th_ct_menu_0.setPageContext(pageContext);
_jspx_th_ct_menu_0.setParent(null);
_jspx_th_ct_menu_0.setWhichMenu(global);
int _jspx_eval_ct_menu_0 = _jspx_th_ct_menu_0.doStartTag();
menuString = (java.lang.String)
pageContext.findAttribute(menuString);
if (_jspx_eval_ct_menu_0 !=
javax.servlet.jsp.tagext.Tag.SKIP_BODY) {
out.print( menuString );
}
if (_jspx_th_ct_menu_0.doEndTag() ==
javax.servlet.jsp.tagext.Tag.SKIP_PAGE)
return;
_jspx_tagPool_ct_menu_whichMenu.reuse(_jspx_th_ct_menu_0);
}
/* ct:menu (second one) */
com.ct.tags.ui.MenuTag _jspx_th_ct_menu_1 = (com.ct.tags.ui.MenuTag)
_jspx_tagPool_ct_menu_whichMenu.get(com.ct.tags.ui.MenuTag.class);
_jspx_th_ct_menu_1.setPageContext(pageContext);
_jspx_th_ct_menu_1.setParent(null);
_jspx_th_ct_menu_1.setWhichMenu(top);
int _jspx_eval_ct_menu_1 = _jspx_th_ct_menu_1.doStartTag();
menuString = (java.lang.String)
pageContext.findAttribute(menuString);
if (_jspx_eval_ct_menu_1 != javax.servlet.jsp.tagext.Tag.SKIP_BODY)
{
out.print( menuString );
}
java error msg:
Generated servlet error:
/home/xliu/Apache/jakarta-tomcat-4.1.10-
src/build/work/Standalone/localhost/cmbs/custom_ui_elements/inc_gnav_jsp.java:15
5:
cannot resolve symbol
symbol : variable menuString
location: class org.apache.jsp.inc_gnav_jsp
out.print( menuString );
Observations:
. this tag works on 4.1.9 release and 4.0.2 production.
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java
luehe 2002/09/11 11:07:13
Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java
Log:
Fixed 12466: Unable to call jsp:invoke in the body of a classic/simple
tag in a tag file.
Fixed 12467: Unable to call jsp:invoke withing a classic tag handler
in a tag file
Revision ChangesPath
1.98 +28 -9
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java
Index: Generator.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java,v
retrieving revision 1.97
retrieving revision 1.98
diff -u -r1.97 -r1.98
--- Generator.java10 Sep 2002 21:52:35 - 1.97
+++ Generator.java11 Sep 2002 18:07:13 - 1.98
@@ -1852,10 +1852,10 @@
String varAttr = n.getTextAttribute(var);
if (varReaderAttr != null || varAttr != null) {
out.printil(_jspx_sout = new java.io.StringWriter(););
- out.print(toGetterMethod(n.getTextAttribute(fragment)));
+ out.printin(toGetterMethod(n.getTextAttribute(fragment)));
out.println(.invoke(_jspx_sout, _jspx_params););
} else {
- out.print(toGetterMethod(n.getTextAttribute(fragment)));
+ out.printin(toGetterMethod(n.getTextAttribute(fragment)));
out.println(.invoke(null, _jspx_params););
}
@@ -2921,7 +2921,29 @@
out.println();
out.pushIndent();
- // Class body begins here
+ /*
+ * Class body begins here
+ */
+
+ // Declare parameter map for fragment/body invocation. This must be
+ // declared as an instance variable (as opposed to a local variable in
+ // doTag()), so that it is accessible:
+ //
+ // - from the JspFragmentHelper subclass specific to the automatically
+ // generated tag handler, in case the fragment/body invocation is
+ // contained in a fragment body, as in:
+ // my:simple
+ // jsp:invoke fragment=frag/
+ // /my:simple
+ //
+ // - from the invocation of a classic tag handler that is separated out
+// into its own method, if the fragment/body invocation is
+ // encapsulated in a custom action, as in:
+ // my:classic
+ // jsp:invoke fragment=frag/
+ // /my:classic
+ out.printil(private java.util.Map _jspx_params = null;);
+
generateDeclarations(tag);
// Static initializations here
@@ -2961,9 +2983,6 @@
out.printil(javax.servlet.ServletConfig config = +
pageContext.getServletConfig(););
- // Declare parameter map for fragment/body invocation
- out.printil(java.util.Map _jspx_params = null;);
-
// Declare writer used for storing result of fragment/body invocation
// if 'varReader' or 'var' attribute is specified
out.printil(java.io.Writer _jspx_sout = null;);
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 12466] - Unable to call jsp:invoke in the body of a classic/simple tag in a tag file.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12466. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12466 Unable to call jsp:invoke in the body of a classic/simple tag in a tag file. [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2002-09-11 18:08 --- Fixed. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 12467] - Unable to call jsp:invoke withing a classic tag handler in a tag file
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12467. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12467 Unable to call jsp:invoke withing a classic tag handler in a tag file [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2002-09-11 18:08 --- Fixed. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 12503] - default servlet overrides welcome file
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12503. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12503 default servlet overrides welcome file --- Additional Comments From [EMAIL PROTECTED] 2002-09-11 19:01 --- Here is the response from the Servlet 2.4 spec lead Yutaka: The bug might be valid --- I think you're right. What's the reason they invalidated? Ryan, Did you see any discussion in tomcat-dev about this? yuta Date: Wed, 11 Sep 2002 10:35:39 -0700 From: Jian (James) Cai [EMAIL PROTECTED] Hello Yutaka: I have filed a bug for the default servlet overrides welcome file problem. But some Tomcat developer invalided it. The quesion is when I have both default servlet and welcome file set for a path. For example: servlet-mapping servlet-namewebAdminPoint/servlet-name url-pattern//url-pattern /servlet-mapping The welcome file was set as: welcome-file-list welcome-fileindex.jsp/welcome-file /welcome- file-list Then if there is webcontext/index.jsp in my web application. When a request for http://server:8080/webcontext/ will give me the default servlet or the welcome file? My understanding is to give me the welcome file. If welcome file not there in the directory, it will response the default servlet (SRV 9.10 for Servlet 2.4). Please correct me if my understanding is wrong. Thanks James Jian Cai -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet JspServletWrapper.java
kinman 2002/09/11 12:07:33
Modified:jasper2/src/share/org/apache/jasper
JspCompilationContext.java
jasper2/src/share/org/apache/jasper/compiler Compiler.java
Generator.java TagFileProcessor.java
jasper2/src/share/org/apache/jasper/resources
messages.properties
jasper2/src/share/org/apache/jasper/servlet
JspServletWrapper.java
Log:
- Handle tag file compilations with circular dependencies.
Approach taken:
* Use a counter in JspServletWrapper for detection of circularities.
* Generate a skeleton tag handler (which has no dependency) from TagInfo
and use that to compile its clients. It is eventually replaced by
the real one.
Todo:
The compilation of tag files is now serialized. Can be made more
concurrent with more bookkeeping.
Revision ChangesPath
1.21 +20 -3
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspCompilationContext.java
Index: JspCompilationContext.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspCompilationContext.java,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -r1.20 -r1.21
--- JspCompilationContext.java6 Sep 2002 21:40:53 - 1.20
+++ JspCompilationContext.java11 Sep 2002 19:07:32 - 1.21
@@ -122,6 +122,7 @@
protected Class servletClass;
protected boolean isTagFile;
+protected boolean protoTypeMode;
protected TagInfo tagInfo;
protected TagData tagData;
@@ -235,6 +236,10 @@
return jspCompiler;
}
+public Compiler getCompiler() {
+ return jspCompiler;
+}
+
/** -- Access resources in the webapp -- */
/**
@@ -361,6 +366,18 @@
public TagInfo getTagInfo() {
return tagInfo;
+}
+
+/**
+ * True if we are compiling a tag file in prototype mode, i.e. we only
+ * Generate codes with class for the tag handler with empty method bodies.
+ */
+public boolean isPrototypeMode() {
+ return protoTypeMode;
+}
+
+public void setPrototypeMode(boolean pm) {
+ protoTypeMode = pm;
}
public TagData getTagData() {
1.32 +40 -3
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Compiler.java
Index: Compiler.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Compiler.java,v
retrieving revision 1.31
retrieving revision 1.32
diff -u -r1.31 -r1.32
--- Compiler.java 28 Aug 2002 23:00:18 - 1.31
+++ Compiler.java 11 Sep 2002 19:07:32 - 1.32
@@ -119,6 +119,7 @@
private ErrorDispatcher errDispatcher;
private PageInfo pageInfo;
private JspServletWrapper jsw;
+private TagFileProcessor tfp;
protected Project project=null;
@@ -256,6 +257,13 @@
ParserController parserCtl = new ParserController(ctxt, this);
pageNodes = parserCtl.parse(ctxt.getJspFile());
+ if (ctxt.isPrototypeMode()) {
+ // generate prototype .java file for the tag file
+ Generator.generate(writer, this, pageNodes);
+writer.close();
+ return;
+ }
+
// Validate and process attributes
Validator.validate(this, pageNodes);
@@ -268,7 +276,8 @@
// Compile (if necessary) and load the tag files referenced in
// this compilation unit.
- TagFileProcessor.loadTagFiles(this, pageNodes);
+ tfp = new TagFileProcessor();
+ tfp.loadTagFiles(this, pageNodes);
long t3=System.currentTimeMillis();
@@ -287,6 +296,14 @@
//JSR45 Support - note this needs to be checked by a JSR45 guru
SmapUtil.generateSmap(ctxt, pageNodes, true);
+
+ // If any proto type .java and .class files was generated,
+ // the prototype .java may have been replaced by the current
+ // compilation (if the tag file is self referencing), but the
+ // .class file need to be removed, to make sure that javac would
+ // generate .class again from the new .java file just generated.
+
+ tfp.removeProtoTypeFiles(ctxt.getClassFileName());
}
/**
@@ -368,6 +385,11 @@
if( t2-t1 500 ) {
log.info( Compiled + javaFileName + + (t2-t1));
}
+
+ if (ctxt.isPrototypeMode()) {
+ return;
+ }
+
//JSR45 Support - note this needs to be checked by a JSR45 guru
SmapUtil.installSmap(ctxt);
}
@@ -380,6 +402,9 @@
{
generateJava();
DO NOT REPLY [Bug 9629] - Fix ServletContext.getResourcePaths to match spec
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9629. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9629 Fix ServletContext.getResourcePaths to match spec --- Additional Comments From [EMAIL PROTECTED] 2002-09-11 19:18 --- Why is only the first directory level (sub paths as [4]) returned? As of Tomcat 4.0.4 this is a somewhat surprising result, since I would expect (from interpreting the Spec) that all paths recursively available are returned. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5 gump.xml
bobh2002/09/11 13:32:02 Modified:.gump.xml Log: - this brings us closer to gump working. Only jasper isn't set up quite right Revision ChangesPath 1.7 +4 -1 jakarta-tomcat-5/gump.xml Index: gump.xml === RCS file: /home/cvs/jakarta-tomcat-5/gump.xml,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- gump.xml 9 Sep 2002 01:00:49 - 1.6 +++ gump.xml 11 Sep 2002 20:32:02 - 1.7 @@ -11,6 +11,7 @@ packageorg.apache.catalina/package ant target=dist + property name=tomcat33.home value=/ property name=ant.home reference=home project=jakarta-ant/ property name=jsse.home reference=home project=jsse/ property name=jmx.home reference=home project=jmx/ @@ -39,7 +40,8 @@ depend property=servlet-api.jar project=jakarta-servletapi-5-servlet/ depend property=jsp-api.jar project=jakarta-servletapi-5-jsp/ - depend property=xerces.jar project=xml-xerces id=parser/ + depend property=xercesImpl.jar project=xml-xerces id=parser/ + depend property=xmlParserAPIs.jar project=xml-xerces id=parser/ depend property=tomcat-util.jar project=jakarta-tomcat-util/ depend property=commons-beanutils.jar project=commons-beanutils runtime=true/ @@ -66,6 +68,7 @@ option project=jakarta-avalon/ option project=jakarta-avalon-phoenix/ depend project=jakarta-tomcat-coyote_tc5/ +depend project=jakarta-tomcat-catalina/ depend project=jakarta-tomcat-util runtime=true/ depend project=jakarta-servletapi-5-servlet/ depend project=jakarta-servletapi-5-jsp/ -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources messages.properties messages_es.properties messages_ja.properties
luehe 2002/09/11 13:50:45
Modified:jasper2/src/share/org/apache/jasper/resources
messages.properties messages_es.properties
messages_ja.properties
Log:
Added localized message for jsp.error.tagdirective.badbodycontent error code
Revision ChangesPath
1.38 +2 -1
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages.properties
Index: messages.properties
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages.properties,v
retrieving revision 1.37
retrieving revision 1.38
diff -u -r1.37 -r1.38
--- messages.properties 11 Sep 2002 19:07:33 - 1.37
+++ messages.properties 11 Sep 2002 20:50:45 - 1.38
@@ -300,3 +300,4 @@
jsp.error.duplicate.name.jspattribute=The attribute {0} specified in the standard
or custom action also appears as the value of the name attribute in the enclosed
jsp:attribute
jsp.error.not.in.template=Not allowed in a template text body.
jsp.error.badaction=The action is not a recognizable standard action.
+jsp.error.tagdirective.badbodycontent=Invalid body-content ({0}) in tag directive
1.11 +2 -1
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages_es.properties
Index: messages_es.properties
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages_es.properties,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- messages_es.properties22 Aug 2002 21:31:28 - 1.10
+++ messages_es.properties11 Sep 2002 20:50:45 - 1.11
@@ -219,3 +219,4 @@
jsp.error.invoke.missingParam=
jsp.error.doBody.invalidParam=
jsp.error.jspelement.missing.name=
+jsp.error.tagdirective.badbodycontent=
1.10 +2 -1
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages_ja.properties
Index: messages_ja.properties
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages_ja.properties,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- messages_ja.properties22 Aug 2002 21:31:28 - 1.9
+++ messages_ja.properties11 Sep 2002 20:50:45 - 1.10
@@ -251,3 +251,4 @@
jsp.error.invoke.missingParam=
jsp.error.doBody.invalidParam=
jsp.error.jspelement.missing.name=
+jsp.error.tagdirective.badbodycontent=
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler TagFileProcessor.java
luehe 2002/09/11 13:52:44
Modified:jasper2/src/share/org/apache/jasper/compiler
TagFileProcessor.java
Log:
Added tag file and line number to exception message
Revision ChangesPath
1.25 +3 -3
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/TagFileProcessor.java
Index: TagFileProcessor.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/TagFileProcessor.java,v
retrieving revision 1.24
retrieving revision 1.25
diff -u -r1.24 -r1.25
--- TagFileProcessor.java 11 Sep 2002 19:07:32 - 1.24
+++ TagFileProcessor.java 11 Sep 2002 20:52:44 - 1.25
@@ -164,7 +164,7 @@
!bodycontent.equalsIgnoreCase(TagInfo.BODY_CONTENT_EMPTY)
!bodycontent.equalsIgnoreCase(TagInfo.BODY_CONTENT_TAG_DEPENDENT)
!bodycontent.equalsIgnoreCase(TagInfo.BODY_CONTENT_SCRIPTLESS))
{
-err.jspError(jsp.error.tagdirective.badbodycontent,
+err.jspError(n, jsp.error.tagdirective.badbodycontent,
bodycontent);
}
dynamicAttributes= JspUtil.booleanValue(
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Compiler.java
kinman 2002/09/11 14:07:53
Modified:jasper2/src/share/org/apache/jasper/compiler Compiler.java
Log:
- Applied Remy's fix from tomcat_4_branch.
Revision ChangesPath
1.33 +13 -7
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Compiler.java
Index: Compiler.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Compiler.java,v
retrieving revision 1.32
retrieving revision 1.33
diff -u -r1.32 -r1.33
--- Compiler.java 11 Sep 2002 19:07:32 - 1.32
+++ Compiler.java 11 Sep 2002 21:07:53 - 1.33
@@ -74,6 +74,7 @@
import org.apache.tools.ant.Project;
import org.apache.tools.ant.taskdefs.Javac;
import org.apache.tools.ant.types.Path;
+import org.apache.tools.ant.types.PatternSet;
import org.apache.jasper.JspCompilationContext;
import org.apache.jasper.Constants;
@@ -310,8 +311,8 @@
* Compile the jsp file from the current engine context
*/
public void generateClass()
-throws FileNotFoundException, JasperException, Exception
-{
+throws FileNotFoundException, JasperException, Exception {
+
long t1=System.currentTimeMillis();
String javaEncoding = UTF8;
String javaFileName = ctxt.getServletJavaFileName();
@@ -331,8 +332,13 @@
// Initializing classpath
Path path = new Path(project);
-path.setPath(System.getProperty(java.class.path) + sep
- + classpath);
+path.setPath(System.getProperty(java.class.path));
+StringTokenizer tokenizer = new StringTokenizer(classpath, sep);
+while (tokenizer.hasMoreElements()) {
+String pathElement = tokenizer.nextToken();
+File repository = new File(pathElement);
+path.setLocation(repository);
+}
if( log.isDebugEnabled() )
log.debug( Using classpath: + System.getProperty(java.class.path)
+ sep
@@ -340,12 +346,11 @@
// Initializing sourcepath
Path srcPath = new Path(project);
-srcPath.setPath(options.getScratchDir().getAbsolutePath());
+srcPath.setLocation(options.getScratchDir());
// Configure the compiler object
javac.setEncoding(javaEncoding);
javac.setClasspath(path);
-//javac.setDestdir(new File(options.getScratchDir().getAbsolutePath()));
javac.setDebug(ctxt.getOptions().getClassDebugInfo());
javac.setSrcdir(srcPath);
javac.setOptimize(! ctxt.getOptions().getClassDebugInfo() );
@@ -356,7 +361,8 @@
}
// Build includes path
-javac.setIncludes(ctxt.getJspPath());
+PatternSet.NameEntry includes = javac.createInclude();
+includes.setName(ctxt.getJspPath());
try {
synchronized(javacLock) {
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5 gump.xml
bobh2002/09/11 14:09:52 Modified:.gump.xml Log: - tc5 needs jasper Revision ChangesPath 1.8 +1 -0 jakarta-tomcat-5/gump.xml Index: gump.xml === RCS file: /home/cvs/jakarta-tomcat-5/gump.xml,v retrieving revision 1.7 retrieving revision 1.8 diff -u -r1.7 -r1.8 --- gump.xml 11 Sep 2002 20:32:02 - 1.7 +++ gump.xml 11 Sep 2002 21:09:52 - 1.8 @@ -69,6 +69,7 @@ option project=jakarta-avalon-phoenix/ depend project=jakarta-tomcat-coyote_tc5/ depend project=jakarta-tomcat-catalina/ +depend project=jakarta-tomcat-jasper_tc5/ depend project=jakarta-tomcat-util runtime=true/ depend project=jakarta-servletapi-5-servlet/ depend project=jakarta-servletapi-5-jsp/ -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper gump3.xml
bobh2002/09/11 14:14:12 Modified:.gump3.xml Log: - jasper should tell us about it's jars Revision ChangesPath 1.2 +4 -1 jakarta-tomcat-jasper/gump3.xml Index: gump3.xml === RCS file: /home/cvs/jakarta-tomcat-jasper/gump3.xml,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- gump3.xml 28 Aug 2002 21:53:03 - 1.1 +++ gump3.xml 11 Sep 2002 21:14:12 - 1.2 @@ -11,7 +11,10 @@ cvs repository=jakarta module=jakarta-tomcat-jasper/ project name=jakarta-tomcat-jasper_tc5 home nested=jasper2 / + jar name=build/shared/lib/jasper-compiler.jar / + jar name=build/shared/lib/jasper-runtime.jar / + jar name=build/shared/lib/jsp20el.jar / /project - + depend project=commons-logging/ /module -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 12549] New: - j_security_check is not handled correctly when authenticated
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12549.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12549
j_security_check is not handled correctly when authenticated
Summary: j_security_check is not handled correctly when
authenticated
Product: Tomcat 4
Version: 4.0.3 Final
Platform: All
OS/Version: All
Status: NEW
Severity: Normal
Priority: Other
Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
The problem occurs when someone attempts to access j_security_check but is
already authenticated.
From org.apache.catalina.authenticator.AuthenticatorBase:
// Special handling for form-based logins to deal with the case
// where the login form (and therefore the j_security_check URI
// to which it submits) might be outside the secured area
String contextPath = this.context.getPath();
String requestURI = hrequest.getDecodedRequestURI();
1: if (requestURI.startsWith(contextPath)
requestURI.endsWith(Constants.FORM_ACTION)) {
2: if (!authenticate(hrequest, hresponse, config)) {
if (debug = 1)
log( Failed authenticate() test);
3: return;
}
4:
}
In (1) the code matches any request to j_security_check, which triggers a call
to authenticate at (2).
In a new request to process a form login, authenticate() (in FormAuthenticator)
will process the login and (if succesful) it will set a redirect to the original
request (which had been saved) and return FALSE. This ends the processing at
(3), the redirect is later processed and all is well.
However, if the user is already authenticated authenticate() simply return TRUE
so the code reaches (4) where no action is taken and we fall out of the
special-case block for j_security_check. Then the request processing continues
as if it were a regular page request, which of course results in a 404.
(Note that the debug message is also incorrect after (2) since here FALSE can be
a success case).
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 12550] New: - webapps/MYWEBAPP/WEB-INF/lib not loading jars
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12550. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12550 webapps/MYWEBAPP/WEB-INF/lib not loading jars Summary: webapps/MYWEBAPP/WEB-INF/lib not loading jars Product: Tomcat 4 Version: 4.1.10 Platform: PC OS/Version: Windows NT/2K Status: NEW Severity: Normal Priority: Other Component: Unknown AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] When I put my application jars in the webapps/MYWEBAPP/WEB-INF/lib folder the application context is not started. But if I put those same jars in % CATALINA_HOME%\common\lib or %CATALINA_HOME%\shared\lib the applications start fine. I get the following error 2002-09-11 15:35:02 WebappLoader[/jobsurf20]: Reloading checks are enabled for this Context 2002-09-11 15:35:02 ContextConfig[/jobsurf20] Exception processing JAR at resource path /WEB-INF/lib/jconn2.jar javax.servlet.ServletException: Exception processing JAR at resource path /WEB- INF/lib/jconn2.jar at org.apache.catalina.startup.ContextConfig.tldScanJar (ContextConfig.java:930) at org.apache.catalina.startup.ContextConfig.tldScan (ContextConfig.java:868) at org.apache.catalina.startup.ContextConfig.start (ContextConfig.java:647) and more lines followed by - Root Cause - java.io.IOException: The system cannot find the path specified at java.io.WinNTFileSystem.createFileExclusively(Native Method) at java.io.File.checkAndCreate(File.java:1313) at java.io.File.createTempFile(File.java:1401) at java.io.File.createTempFile(File.java:1438) at sun.net.www.protocol.jar.URLJarFile$1.run(URLJarFile.java:169) at java.security.AccessController.doPrivileged(Native Method) at sun.net.www.protocol.jar.URLJarFile.retrieve(URLJarFile.java:164) at sun.net.www.protocol.jar.URLJarFile.getJarFile(URLJarFile.java:42) at sun.net.www.protocol.jar.JarFileFactory.get(JarFileFactory.java:78) at sun.net.www.protocol.jar.JarURLConnection.connect (JarURLConnection.java:85) at sun.net.www.protocol.jar.JarURLConnection.getJarFile (JarURLConnection.java:69) at org.apache.catalina.startup.ContextConfig.tldScanJar (ContextConfig.java:906) ... Thanks, -Atul. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler TagFileProcessor.java
kinman 2002/09/11 14:50:02
Modified:jasper2/src/share/org/apache/jasper/compiler
TagFileProcessor.java
Log:
- Add tag files that are referenced indirectly to the dependency list.
Revision ChangesPath
1.26 +13 -4
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/TagFileProcessor.java
Index: TagFileProcessor.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/TagFileProcessor.java,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -r1.25 -r1.26
--- TagFileProcessor.java 11 Sep 2002 20:52:44 - 1.25
+++ TagFileProcessor.java 11 Sep 2002 21:50:02 - 1.26
@@ -336,7 +336,7 @@
*/
private Class loadTagFile(Compiler compiler,
String tagFilePath, TagInfo tagInfo,
- TagData tagData)
+ TagData tagData, PageInfo parentPageInfo)
throws JasperException {
JspCompilationContext ctxt = compiler.getCompilationContext();
@@ -383,6 +383,15 @@
wrapper.decTripCount();
}
+ // Add the dependants for this tag file to its parent's
+ // dependant list.
+ PageInfo pageInfo = wrapper.getJspEngineContext().getCompiler().
+ getPageInfo();
+ Iterator iter = pageInfo.getDependants().iterator();
+ if (iter.hasNext()) {
+ parentPageInfo.addDependant((String)iter.next());
+ }
+
return tagClass;
}
}
@@ -409,7 +418,7 @@
String tagFilePath = tagFileInfo.getPath();
pageInfo.addDependant(tagFilePath);
Class c = loadTagFile(compiler, tagFilePath, n.getTagInfo(),
- n.getTagData());
+ n.getTagData(), pageInfo);
n.setTagHandlerClass(c);
}
visitBody(n);
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Fwd: tomcat 4.0.4 apache ssl 1.3.26 and mod_jk
Note: forwarded message attached.Yahoo! - We Remember 9-11: A tribute to the more than 3,000 lives lost---BeginMessage--- Hello, I have installed and configured Apache 1.3.26 with modssl and openssl + tomcat 4.0.4 with the corresponding Apache mod_jk. I started tomcat then apache and when I attempted to access the index.jsp under ROOT, the browser hangs and goes no where. the following error can be observed when info mode is set in httpd.conf INFO [Mon Sep 09 18:18:39 2002] [jk_ajp_common.c (652)]: ajp_connection_tcp_get_message: Error - jk_tcp_socket_recvfull failed [Mon Sep 09 18:18:39 2002] [jk_ajp_common.c (1013)]: Error reading reply [Mon Sep 09 18:18:39 2002] [jk_ajp_common.c (1150)]: In jk_endpoint_t::service, ajp_get_reply failed in send loop 0 [Mon Sep 09 18:18:39 2002] [jk_connect.c (151)]: jk_open_socket, connect() failed errno = 146 [Mon Sep 09 18:18:39 2002] [jk_ajp_common.c (599)]: In jk_endpoint_t::ajp_connect_to_endpoint, failed errno = 146 [Mon Sep 09 18:18:39 2002] [jk_ajp_common.c (844)]: Error connecting to the Tomcat process. [Mon Sep 09 18:18:39 2002] [jk_ajp_common.c (1153)]: In jk_endpoint_t::service, ajp_send_request failed in send loop 1 [Mon Sep 09 18:18:39 2002] [jk_connect.c (151)]: jk_open_socket, connect() failed errno = 146 [Mon Sep 09 18:18:39 2002] [jk_ajp_common.c (599)]: In jk_endpoint_t::ajp_connect_to_endpoint, failed errno = 146 [Mon Sep 09 18:18:39 2002] [jk_ajp_common.c (844)]: Error connecting to the Tomcat process. [Mon Sep 09 18:18:39 2002] [jk_ajp_common.c (1153)]: In jk_endpoint_t::service, ajp_send_request failed in send loop 2 And the followin is observed under DEBUG mode [Wed Sep 11 16:53:04 2002] [jk_uri_worker_map.c (460)]: Into jk_uri_worker_map_t::map_uri_to_worker [Wed Sep 11 16:53:04 2002] [jk_uri_worker_map.c (477)]: Attempting to map URI '/test.jsp' [Wed Sep 11 16:53:04 2002] [jk_uri_worker_map.c (558)]: jk_uri_worker_map_t::map_uri_to_worker, Found a suffix match jakarta-tomcat-4.0.4 - *.jsp [Wed Sep 11 16:53:04 2002] [jk_worker.c (132)]: Into wc_get_worker_for_name jakarta-tomcat-4.0.4 [Wed Sep 11 16:53:04 2002] [jk_worker.c (136)]: wc_get_worker_for_name, done found a worker [Wed Sep 11 16:53:04 2002] [jk_ajp_common.c (1355)]: Into jk_worker_t::get_endpoint [Wed Sep 11 16:53:04 2002] [jk_ajp_common.c (1079)]: Into jk_endpoint_t::service [Wed Sep 11 16:53:04 2002] [jk_ajp_common.c (280)]: Into ajp_marshal_into_msgb [Wed Sep 11 16:53:04 2002] [jk_ajp_common.c (413)]: ajp_marshal_into_msgb - Done [Wed Sep 11 16:53:04 2002] [jk_connect.c (116)]: Into jk_open_socket [Wed Sep 11 16:53:04 2002] [jk_connect.c (123)]: jk_open_socket, try to connect socket = 9 [Wed Sep 11 16:53:04 2002] [jk_connect.c (132)]: jk_open_socket, after connect ret = 0 [Wed Sep 11 16:53:04 2002] [jk_connect.c (140)]: jk_open_socket, set TCP_NODELAY to on [Wed Sep 11 16:53:04 2002] [jk_connect.c (148)]: jk_open_socket, return, sd = 9 [Wed Sep 11 16:53:04 2002] [jk_ajp_common.c (589)]: In jk_endpoint_t::ajp_connect_to_endpoint, connected sd = 9 [Wed Sep 11 16:53:04 2002] [jk_ajp_common.c (613)]: sending to ajp13 #379 [Wed Sep 11 16:53:04 2002] [jk_ajp_common.c (854)]: ajp_send_request 2: request body to send 0 - request body to resend 0 Why is the browser locking and what is happening? Thanks! - Yahoo! - We Remember 9-11: A tribute to the more than 3,000 lives lost ---End Message--- -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Catalina tester failure on JSP Document Parsing
I'm seeing the following error on catalina's tester app, running it under Tomcat 5: [echo] - JSP Document Parsing - [tester] EXPECTED: == [tester] atextb/b/aatextb/b/acdtext/d/ccdtext/d/cef/ftextf/f/eef/ftextf/f/e [tester] [tester] RECEIVED: == [tester] atextb//aatextb//acdtext/d/ccdtext/d/cef/textf//eef/textf//e [tester] [tester] FAIL [GET /tester/JspDoc01.jsp HTTP/1.0] Failed Golden File Comparison However, I'm not sure the test is actually correct. It's failing because of the empty elements being converted from b/b to b/, and from f/f to /f. But, under XML, those are identical ways of saying the same thing. If my analysis is correct, then the golden text needs to be changed, and here is a patch for it. Otherwise, there's a deeper problem. Index: golden/JspDoc01.txt === RCS file: /home/cvspublic/jakarta-tomcat-catalina/tester/web/golden/JspDoc01.txt,v retrieving revision 1.1.1.1 diff -u -w -r1.1.1.1 JspDoc01.txt --- golden/JspDoc01.txt 18 Jul 2002 16:47:25 - 1.1.1.1 +++ golden/JspDoc01.txt 11 Sep 2002 22:10:51 - @@ -1 +1 @@ -atextb/b/aatextb/b/acdtext/d/ccdtext/d/cef/ftextf/f/eef/ftextf/f/e +atextb//aatextb//acdtext/d/ccdtext/d/cef/textf//eef/textf//e \ No newline at end of file -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Contributing patches/enhancements?
Hello, I have a process question about how I could contribute Tomcat source patches/enhancements? Would I open a Bugzilla and attach a diff text file, then wait for an official Tomcat contributor to review it and add it into the source tree? Thanks, Eddie - Yahoo! - We Remember 9-11: A tribute to the more than 3,000 lives lost
DO NOT REPLY [Bug 12493] - Unable to create a variable scope to a fragment
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12493. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12493 Unable to create a variable scope to a fragment [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2002-09-11 22:19 --- I believe the currently implemented behaviour is compliant with the spec. According to JSP.5.12.3 (Passing Parameters), one jsp:param element must be present for each variable declared using the variable directive that has a 'fragment' attribute equal to the name of the fragment being invoked, or a translation error will result. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Catalina tester failure on JSP Document Parsing
I'd suggest that we remove this test. Jasper 2 and jasper produces different but correct XML view of the JSP document. If the golden file is fixed to pass in TC5, it would then fail in TC4.0. Date: Wed, 11 Sep 2002 18:10:59 -0400 From: Steve Downey [EMAIL PROTECTED] Subject: Catalina tester failure on JSP Document Parsing To: [EMAIL PROTECTED] I'm seeing the following error on catalina's tester app, running it under Tomcat 5: [echo] - JSP Document Parsing - [tester] EXPECTED: == [tester] atextb/b/aatextb/b/acdtext/d/ccdtext/d/cef/ ftextf/f/eef/ftextf/f/e [tester] [tester] RECEIVED: == [tester] atextb//aatextb//acdtext/d/ccdtext/d/cef/textf/ /eef/textf//e [tester] [tester] FAIL [GET /tester/JspDoc01.jsp HTTP/1.0] Failed Golden File Comparison However, I'm not sure the test is actually correct. It's failing because of the empty elements being converted from b/b to b/, and from f/f to /f. But, under XML, those are identical ways of saying the same thing. If my analysis is correct, then the golden text needs to be changed, and here is a patch for it. Otherwise, there's a deeper problem. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Contributing patches/enhancements?
On Wed, 11 Sep 2002, Eddie Ruvinsky wrote: Date: Wed, 11 Sep 2002 15:16:19 -0700 (PDT) From: Eddie Ruvinsky [EMAIL PROTECTED] Reply-To: Tomcat Developers List [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Contributing patches/enhancements? Hello, I have a process question about how I could contribute Tomcat source patches/enhancements? Would I open a Bugzilla and attach a diff text file, then wait for an official Tomcat contributor to review it and add it into the source tree? Short Answer: Yes. More Complete Answer: http://jakarta.apache.org/site/getinvolved.html Thanks, Eddie Craig -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Tomcat authenticating in JBoss ?
We have an application that must be run separately in two servers: the WebApp on Tomcat ( 4.1 ) and the J2EE App on JBoss. Each Webapp can access only the EJBs within a specific ear. In order to do this we are thinking in a way to authenticate each webapp in JBoss. We are thinking of using JAASRealm as the entry point to JAAS layer. When the webapp is first invoked, it will call the JBoss ClientLoginModule, that will pass username and password to be authenticated in JBoss. There are 2 major problems with this solution: first, JAASRealm is meant to authenticate and authorize users ( at least we think so... ) and it isn´t being used to do it, and second, the ClientLoginModule doesn´t return the expected subject to JAASRealm. A solution would be write a LoginModule to Tomcat that do exactly the same thing as ClientLoginModule and create a subject to JAASRealm which will be considered a succesfull authorization (i.e., cheat on JAASRealm). Did anybody do this ? Is this approach correct ? Thanks !! - Yahoo! - We Remember 9-11: A tribute to the more than 3,000 lives lost
DO NOT REPLY [Bug 12553] New: - Responses are truncated when served through mod_jk
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12553. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12553 Responses are truncated when served through mod_jk Summary: Responses are truncated when served through mod_jk Product: Tomcat 4 Version: 4.0.4 Final Platform: PC OS/Version: Windows NT/2K Status: NEW Severity: Major Priority: Other Component: Connector:JK/AJP (deprecated) AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I have a situation where some of my servlet responses are getting truncated when served through mod_jk. Apache 2.0.39 on NT4 Sp6a TC 4.04 final In one case I was filling the servlet output stream directly. Setting the content length header didn't make a difference. The system returned 2MB of an 8MB file (exactly 2^21 bytes) of the response to the client. The apache log showed the correct number of bytes. In the other case my servlet called RequestDispatcher.forward() to an html resource in the webapp. The response was truncated about 1/3 of the way through the html. The problem didn't occur for every client. In one case a client using IE6 got the truncated response in another case a client using IE6 got the complete response. The clients that fail always fail. The clients that succeed always succeed. In both cases the workaround was to use mod_proxy instead of mod_jk. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 12517] - JSP compilation error with nested scripting variable
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12517. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12517 JSP compilation error with nested scripting variable [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2002-09-11 23:30 --- Fixed. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Catalina tester failure on JSP Document Parsing
The tests for Tomcat4 are in jakarta-tomcat-4.0/tester, while the tests for tomcat 5 are in jakarta-tomcat-catalina/tester, so fixing them shouldn't be a problem in that sense. Howver, since tomcat 4 is now shipping with jasper2, isn't it a problem for tomcat 4, also? In any case, given the lack of depth in this test, I think the right answer is to change it to eliminate the empty tags. I think it's really trying just to see if JSP Document is there as a feature, not really checking the handling of XML. On Wednesday 11 September 2002 06:21 pm, Kin-Man Chung wrote: I'd suggest that we remove this test. Jasper 2 and jasper produces different but correct XML view of the JSP document. If the golden file is fixed to pass in TC5, it would then fail in TC4.0. Date: Wed, 11 Sep 2002 18:10:59 -0400 From: Steve Downey [EMAIL PROTECTED] Subject: Catalina tester failure on JSP Document Parsing To: [EMAIL PROTECTED] I'm seeing the following error on catalina's tester app, running it under Tomcat 5: [echo] - JSP Document Parsing - [tester] EXPECTED: == [tester] atextb/b/aatextb/b/acdtext/d/ccdtext/d/ce f/ ftextf/f/eef/ftextf/f/e [tester] [tester] RECEIVED: == [tester] atextb//aatextb//acdtext/d/ccdtext/d/cef/te xtf/ /eef/textf//e [tester] [tester] FAIL [GET /tester/JspDoc01.jsp HTTP/1.0] Failed Golden File Comparison However, I'm not sure the test is actually correct. It's failing because of the empty elements being converted from b/b to b/, and from f/f to /f. But, under XML, those are identical ways of saying the same thing. If my analysis is correct, then the golden text needs to be changed, and here is a patch for it. Otherwise, there's a deeper problem. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves ErrorDispatcherValve.java
amyroh 2002/09/11 17:09:28
Modified:catalina/src/share/org/apache/catalina/core
ApplicationDispatcher.java
ApplicationFilterFactory.java
StandardWrapperValve.java
catalina/src/share/org/apache/catalina/deploy FilterMap.java
catalina/src/share/org/apache/catalina/valves
ErrorDispatcherValve.java
Log:
Fix RequestDispatcher for ERROR and INCLUDE - bugzilla bugs 12456 and 12457.
Patch submitted by Greg Murray [EMAIL PROTECTED].
Revision ChangesPath
1.4 +60 -36
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationDispatcher.java
Index: ApplicationDispatcher.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationDispatcher.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- ApplicationDispatcher.java23 Aug 2002 23:01:05 - 1.3
+++ ApplicationDispatcher.java12 Sep 2002 00:09:27 - 1.4
@@ -360,7 +360,6 @@
private void doForward(ServletRequest request, ServletResponse response)
throws ServletException, IOException
{
-
// Reset any output that has been buffered, but keep headers/cookies
if (response.isCommitted()) {
if (debug = 1)
@@ -392,8 +391,18 @@
if (debug = 1)
log( Non-HTTP Forward);
-invoke(request, response, ApplicationFilterFactory.FORWARD);
-
+// only set the Dispatcher Type to Forward if it has not been set. It
will have
+// been set by the ErrorDispatcherValue in the case of an ERROR
+// it will be REQUEST coming in from the StandardWrapperValue and
+// ERROR coming from the ErrorDispatcherValue
+if (request.getAttribute(ApplicationFilterFactory.DISPATCHER_TYPE_ATTR)
!= null){
+Integer disInt =
(Integer)request.getAttribute(ApplicationFilterFactory.DISPATCHER_TYPE_ATTR);
+if (disInt.intValue() != ApplicationFilterFactory.ERROR) {
+
request.setAttribute(ApplicationFilterFactory.DISPATCHER_REQUEST_PATH_ATTR,
servletPath);
+
request.setAttribute(ApplicationFilterFactory.DISPATCHER_TYPE_ATTR, new
Integer(ApplicationFilterFactory.FORWARD));
+}
+}
+invoke(request, response);
}
// Handle an HTTP named dispatcher forward
@@ -401,7 +410,18 @@
if (debug = 1)
log( Named Dispatcher Forward);
-invoke(request, response, ApplicationFilterFactory.FORWARD);
+// only set the Dispatcher Type to Forward if it has not been set. It
will have
+// been set by the ErrorDispatcherValue in the case of an ERROR
+// it will be REQUEST coming in from the StandardWrapperValue and
+// ERROR coming from the ErrorDispatcherValue
+if (request.getAttribute(ApplicationFilterFactory.DISPATCHER_TYPE_ATTR)
!= null){
+Integer disInt =
(Integer)request.getAttribute(ApplicationFilterFactory.DISPATCHER_TYPE_ATTR);
+if (disInt.intValue() != ApplicationFilterFactory.ERROR) {
+
request.setAttribute(ApplicationFilterFactory.DISPATCHER_REQUEST_PATH_ATTR,
servletPath);
+
request.setAttribute(ApplicationFilterFactory.DISPATCHER_TYPE_ATTR, new
Integer(ApplicationFilterFactory.FORWARD));
+}
+}
+invoke(request, response);
}
@@ -429,7 +449,19 @@
wrequest.setQueryString(queryString);
wrequest.mergeParameters(queryString);
}
-invoke(outerRequest, response, ApplicationFilterFactory.FORWARD);
+
+// only set the Dispatcher Type to Forward if it has not been set. It
will have
+// been set by the ErrorDispatcherValue in the case of an ERROR
+// it will be REQUEST coming in from the StandardWrapperValue and
+// ERROR coming from the ErrorDispatcherValue
+if
(wrequest.getAttribute(ApplicationFilterFactory.DISPATCHER_TYPE_ATTR) != null){
+Integer disInt =
(Integer)request.getAttribute(ApplicationFilterFactory.DISPATCHER_TYPE_ATTR);
+if (disInt.intValue() != ApplicationFilterFactory.ERROR) {
+
wrequest.setAttribute(ApplicationFilterFactory.DISPATCHER_REQUEST_PATH_ATTR,
servletPath);
+
wrequest.setAttribute(ApplicationFilterFactory.DISPATCHER_TYPE_ATTR, new
Integer(ApplicationFilterFactory.FORWARD));
+}
+}
+
DO NOT REPLY [Bug 12456] - RequestDispatcher for ERROR value does not get filtered
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12456. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12456 RequestDispatcher for ERROR value does not get filtered [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2002-09-12 00:10 --- Fixed. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 12457] - Filter does not work when RequestDispatcher uses INCLUDE value
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12457. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12457 Filter does not work when RequestDispatcher uses INCLUDE value [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2002-09-12 00:10 --- Fixed. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Contributing patches/enhancements?
From my experience, it depends if it's a bug or an enhancement. If it's a bug, Bugzilla is your friend. Someone will eventually have to deal with it before a release. Just posting to the mailing list means that it's likely to get lost. And patches for bugs tend to be fairly stable over time. On the other hand, putting enhancements in Bugzilla isn't as effective. Bugzilla isn't very good for discussion. And enhancements often are more invasive to the code, so a patch isn't as likely to be effective later. Just my $0.02 On Wednesday 11 September 2002 06:16 pm, Eddie Ruvinsky wrote: Hello, I have a process question about how I could contribute Tomcat source patches/enhancements? Would I open a Bugzilla and attach a diff text file, then wait for an official Tomcat contributor to review it and add it into the source tree? Thanks, Eddie - Yahoo! - We Remember 9-11: A tribute to the more than 3,000 lives lost -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ssi SSIServlet.java
amyroh 2002/09/11 17:37:56
Modified:catalina/src/share/org/apache/catalina/core
StandardContextValve.java
catalina/src/share/org/apache/catalina/ssi SSIServlet.java
Log:
Servlet spec SRV 9.6 states :
any request to access the resources in META-INF directory must be returned
with a SC_FORBIDDEN(403) response.
The current tomcat was returning 404 instead.
Fixes bugzilla 12462.
Revision ChangesPath
1.2 +25 -5
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContextValve.java
Index: StandardContextValve.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContextValve.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- StandardContextValve.java 18 Jul 2002 16:48:12 - 1.1
+++ StandardContextValve.java 12 Sep 2002 00:37:56 - 1.2
@@ -165,7 +165,7 @@
relativeURI.equals(/WEB-INF) ||
relativeURI.startsWith(/META-INF/) ||
relativeURI.startsWith(/WEB-INF/)) {
-notFound(requestURI, (HttpServletResponse) response.getResponse());
+forbidden(requestURI, (HttpServletResponse) response.getResponse());
return;
}
@@ -216,6 +216,26 @@
}
}
+
+
+/**
+ * Report a forbidden error for the specified resource.
+ *
+ * @param requestURI The request URI for the requested resource
+ * @param response The response we are creating
+ */
+private void forbidden(String requestURI, HttpServletResponse response) {
+
+try {
+response.sendError(HttpServletResponse.SC_FORBIDDEN, requestURI);
+} catch (IllegalStateException e) {
+;
+} catch (IOException e) {
+;
+}
+
+}
+
/**
* Report a not found error for the specified resource. FIXME: We
1.2 +25 -25
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ssi/SSIServlet.java
Index: SSIServlet.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ssi/SSIServlet.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- SSIServlet.java 18 Jul 2002 16:47:50 - 1.1
+++ SSIServlet.java 12 Sep 2002 00:37:56 - 1.2
@@ -216,15 +216,15 @@
path.toUpperCase().startsWith(/WEB-INF) ||
path.toUpperCase().startsWith(/META-INF) ) {
-res.sendError(res.SC_NOT_FOUND, path);
- log( Can't serve file: + path );
+res.sendError(res.SC_FORBIDDEN, path);
+log( Can't serve file: + path );
return;
}
-
- URL resource = servletContext.getResource(path);
+
+URL resource = servletContext.getResource(path);
if (resource==null) {
res.sendError(res.SC_NOT_FOUND, path);
- log( Can't find file: + path );
+log( Can't find file: + path );
return;
}
@@ -235,36 +235,36 @@
new java.util.Date()).getTime() + expires.longValue() * 1000);
}
- processSSI( req, res, resource );
+processSSI( req, res, resource );
}
protected void processSSI( HttpServletRequest req,
-HttpServletResponse res,
-URL resource ) throws IOException {
- SSIExternalResolver ssiExternalResolver = new SSIServletExternalResolver(
this, req, res,
-
isVirtualWebappRelative,
-
debug );
- SSIProcessor ssiProcessor = new SSIProcessor( ssiExternalResolver, debug );
+ HttpServletResponse res,
+ URL resource ) throws IOException {
+SSIExternalResolver ssiExternalResolver = new SSIServletExternalResolver( this,
req, res,
+ isVirtualWebappRelative,
+ debug );
+SSIProcessor ssiProcessor = new SSIProcessor( ssiExternalResolver, debug );
PrintWriter printWriter = null;
- StringWriter stringWriter = null;
+StringWriter stringWriter = null;
if (buffered) {
- stringWriter = new StringWriter();
+stringWriter = new StringWriter();
printWriter = new PrintWriter( stringWriter );
} else {
printWriter = res.getWriter();
- }
+}
URLConnection
DO NOT REPLY [Bug 12462] - Request to META-INF return a 404 error
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12462. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12462 Request to META-INF return a 404 error [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2002-09-12 00:38 --- Fixed. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 4663] - Broken Pipe under some load
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4663. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4663 Broken Pipe under some load [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID | --- Additional Comments From [EMAIL PROTECTED] 2002-09-12 01:38 --- on my instance, this error occurs even when there are very few users and without much load. i am not sure if that incomplete request causes this error. but the web server perfomed better, when a alot of System.out s were removed. not sure why this is still occuring but the sad part is this error puts the whole server down and i have to restart the tomacat which is unpleasant and i would like to have a resolution soon if possible. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 12558] New: - Unable to capture fragment evaluation in a Writer if the fragment writes to the default 'out'
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12558. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12558 Unable to capture fragment evaluation in a Writer if the fragment writes to the default 'out' Summary: Unable to capture fragment evaluation in a Writer if the fragment writes to the default 'out' Product: Tomcat 5 Version: Nightly Build Platform: Other OS/Version: Other Status: NEW Severity: Major Priority: Other Component: Jasper2 AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Lets take the case when a Simple Tag evaluates its body and captures the evaluation in a StringWriter. The body in turn consists of a classic tag ( or simple tag) that writes some text to the default writer ( using pageContext.getOut().println() ) What happens is that the text gets written into the default out and is not captured by the StringWriter. st:SimpleTag att1=attvalue1 ct:classictag /ct:classictag /st:simpletag -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 12550] - webapps/MYWEBAPP/WEB-INF/lib not loading jars
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12550. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12550 webapps/MYWEBAPP/WEB-INF/lib not loading jars [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2002-09-12 02:59 --- The JVM temp directory must exist ($CATALINA_HOME/temp). It is created (but empty) unless you pick out the wrong archive (like tgz and unpack with winzip, or tweak winzip options). -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 12434] - Version ID of 4.1.10 is wrong
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12434. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12434 Version ID of 4.1.10 is wrong [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2002-09-12 03:05 --- I actually tried it. Please do not reopen the bug (or I'll ignore it). -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 12171] - jsp:param does not evaluate expression for value=%=expression%
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12171. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12171 jsp:param does not evaluate expression for value=%=expression% [EMAIL PROTECTED] changed: What|Removed |Added Severity|Normal |Major Version|4.1.9 |4.1.10 -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat gump.xml
billbarker2002/09/11 21:08:31 Modified:.gump.xml Log: Add commons-logging to gump, so that adding it to Util doesn't start nagging. Revision ChangesPath 1.17 +2 -0 jakarta-tomcat/gump.xml Index: gump.xml === RCS file: /home/cvs/jakarta-tomcat/gump.xml,v retrieving revision 1.16 retrieving revision 1.17 diff -u -r1.16 -r1.17 --- gump.xml 14 Aug 2002 23:35:21 - 1.16 +++ gump.xml 12 Sep 2002 04:08:31 - 1.17 @@ -18,6 +18,8 @@ property name=jakarta-tomcat-connectors reference=srcdir project=jakarta-tomcat-connectors/ + depend property=commons-logging.jar project=commons-logging +runtime=true id=api/ /ant depend project=xml-xerces/ depend project=jakarta-ant/ -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 12559] New: - setLocale gives wrong content type
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12559.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12559
setLocale gives wrong content type
Summary: setLocale gives wrong content type
Product: Tomcat 5
Version: Unknown
Platform: PC
OS/Version: Windows NT/2K
Status: NEW
Severity: Normal
Priority: Other
Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
The following entry in web.xml set a locale mapping to encoding.
locale-encoding-mapping-list
locale-encoding-mapping
localezh/locale
encodinggb2312/encoding
/locale-encoding-mapping
/locale-encoding-mapping-list
The servlet (AdminServlet) set the locale of response if the request parameter
has lan.
When access /admin?lan=zh, the broswer tried to save the file as a binary file.
When access /admin?lan=en, the broswer tried to save the file as a binary file.
When access /admin, the broswer shown the HTML file
When access /admin?lan=(other), the broswer shown the HTML file.
It seemed the setLocale() incorrectly changed the content_type of the response
when the locale to be set to zh or en.
public class AdminServlet extends HttpServlet {
String precedence=starting;
public void init(ServletConfig sc) throws ServletException {
}
public void service (ServletRequest request,ServletResponse response)
throws ServletException, IOException {
response.setContentType(text/html);
String languagepref = request.getParameter(lan);
if (languagepref!=null)
{
response.setLocale(new java.util.Locale
(languagepref));
}
//response.setContentType(text/html);
PrintWriter out = response.getWriter();
out.println(HTML\n);
out.println(Body\n);
out.println(pAdmin Servelt/p\n);
out.println(characterecoding: + response.getCharacterEncoding()
+ \n);
out.println(locale: + response.getLocale()+ \n);
// out.flush();
}
}
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/depend DependClassLoader.java DependClassLoader12.java DependManager.java
billbarker2002/09/11 21:38:37
Modified:src/share/org/apache/tomcat/util/depend
DependClassLoader.java DependClassLoader12.java
DependManager.java
Log:
Converting logging to use commons-logging.
First conversion to check that all the settings still work.
Revision ChangesPath
1.18 +11 -9
jakarta-tomcat/src/share/org/apache/tomcat/util/depend/DependClassLoader.java
Index: DependClassLoader.java
===
RCS file:
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/util/depend/DependClassLoader.java,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -r1.17 -r1.18
--- DependClassLoader.java11 Sep 2002 03:27:30 - 1.17
+++ DependClassLoader.java12 Sep 2002 04:38:37 - 1.18
@@ -84,6 +84,9 @@
*
*/
public class DependClassLoader extends ClassLoader {
+static org.apache.commons.logging.Log logger =
+ org.apache.commons.logging.LogFactory.getLog(DependClassLoader.class);
+
protected ClassLoader parent;
protected ClassLoader parent2;
@@ -126,11 +129,6 @@
this.pd=pd;
}
-// debug only
-final void log( String s ) {
- System.out.println(DependClassLoader: + s );
-}
-
/**
* Resolves the specified name to a Class. The method loadClass()
* is called by the virtual machine. As an abstract method,
@@ -156,7 +154,8 @@
protected Class loadClassInternal1( String name, boolean resolve )
throws ClassNotFoundException
{
- if( debug9) log( loadClass() + name + + resolve);
+ if( logger.isTraceEnabled() )
+ logger.trace( loadClass() + name + + resolve);
// The class object that will be returned.
Class c = null;
@@ -205,7 +204,8 @@
}
is.close();
} catch(IOException ex ) {
- if( debug 0 ) ex.printStackTrace();
+ if( logger.isDebugEnabled() )
+ logger.debug( error reading + name, ex);
data=null;
throw new ClassNotFoundException( name + error reading +
ex.toString());
}
@@ -242,7 +242,8 @@
File f=null;
if( file.equals( res.getProtocol() )) {
f=new File( res.getFile());
- if( debug 9 ) log( File dep +f );
+ if( logger.isTraceEnabled() )
+ logger.trace( File dep +f );
if( ! f.exists()) f=null;
}
if( jar.equals( res.getProtocol() )) {
@@ -257,7 +258,8 @@
if( fileN.startsWith( /file: ))
fileN=fileN.substring( 6 );
f=new File(fileN);
- if( debug 9 ) log( Jar dep +f + + f.exists() );
+ if( logger.isTraceEnabled() )
+ logger.trace( Jar dep +f + + f.exists() );
if( ! f.exists()) f=null;
}
1.13 +11 -9
jakarta-tomcat/src/share/org/apache/tomcat/util/depend/DependClassLoader12.java
Index: DependClassLoader12.java
===
RCS file:
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/util/depend/DependClassLoader12.java,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- DependClassLoader12.java 11 Sep 2002 03:27:30 - 1.12
+++ DependClassLoader12.java 12 Sep 2002 04:38:37 - 1.13
@@ -79,6 +79,9 @@
*/
class DependClassLoader12Impl extends URLClassLoader {
+static org.apache.commons.logging.Log logger =
+ org.apache.commons.logging.LogFactory.getLog(DependClassLoader12Impl.class);
+
private final static String FILE_PROTOCOL = file:;
private final static String BANG = !;
@@ -197,18 +200,14 @@
return parent.getResources(name);
}
-// debug only
-final void log( String s ) {
- System.out.println(DependClassLoader12: + s );
-}
-
/** Actual class loading. The name 'loadClassInternal' generates a warning,
* as a private method with the same name exists int ClassLoader in JDK1.1 (
Sun impl ).
*/
protected Class loadClassInternal1( String name, boolean resolve )
throws ClassNotFoundException
{
- if( debug9) log( loadClass() + name + + resolve);
+ if( logger.isTraceEnabled() )
+ logger.trace( loadClass() + name + + resolve);
// The class object that will be returned.
Class c = null;
@@ -257,7 +256,8 @@
}
is.close();
} catch(IOException ex ) {
- if( debug 0 ) ex.printStackTrace();
+ if( logger.isDebugEnabled() )
+ logger.debug(error reading + name, ex);
data=null;
throw new ClassNotFoundException( name + error reading +
cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteResponse.java
amyroh 2002/09/11 22:48:19
Modified:coyote/src/java/org/apache/coyote Response.java
coyote/src/java/org/apache/coyote/tomcat4
CoyoteResponse.java
Log:
Fix for Response.setLocale() to set charset encoding correctly - bugzilla 10901.
Patch submitted by OGAWA Kan [EMAIL PROTECTED].
Revision ChangesPath
1.14 +79 -74
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Response.java
Index: Response.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Response.java,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -r1.13 -r1.14
--- Response.java 9 Aug 2002 16:23:25 - 1.13
+++ Response.java 12 Sep 2002 05:48:18 - 1.14
@@ -168,7 +168,7 @@
}
public OutputBuffer getOutputBuffer() {
- return outputBuffer;
+return outputBuffer;
}
@@ -178,7 +178,7 @@
public MimeHeaders getMimeHeaders() {
- return headers;
+return headers;
}
@@ -196,12 +196,12 @@
public final void setNote(int pos, Object value) {
- notes[pos] = value;
+notes[pos] = value;
}
public final Object getNote(int pos) {
- return notes[pos];
+return notes[pos];
}
@@ -230,7 +230,7 @@
* Set the response status
*/
public void setStatus( int status ) {
- this.status = status;
+this.status = status;
}
@@ -251,12 +251,12 @@
public boolean isCommitted() {
- return commited;
+return commited;
}
public void setCommitted(boolean v) {
- this.commited = v;
+this.commited = v;
}
@@ -268,7 +268,7 @@
* request processing.
*/
public void setErrorException(Exception ex) {
- errorException = ex;
+errorException = ex;
}
@@ -277,12 +277,12 @@
* processing.
*/
public Exception getErrorException() {
- return errorException;
+return errorException;
}
public boolean isExceptionPresent() {
- return ( errorException != null );
+return ( errorException != null );
}
@@ -291,14 +291,14 @@
* request processing.
*/
public void setErrorURI(String uri) {
- errorURI = uri;
+errorURI = uri;
}
/** Get the request URI that caused the original error.
*/
public String getErrorURI() {
- return errorURI;
+return errorURI;
}
@@ -319,14 +319,14 @@
message = null;
headers.clear();
- // Force the PrintWriter to flush its data to the output
- // stream before resetting the output stream
- //
- // Reset the stream
- if (commited) {
- //String msg = sm.getString(servletOutputStreamImpl.reset.ise);
- throw new IllegalStateException();
- }
+// Force the PrintWriter to flush its data to the output
+// stream before resetting the output stream
+//
+// Reset the stream
+if (commited) {
+//String msg = sm.getString(servletOutputStreamImpl.reset.ise);
+throw new IllegalStateException();
+}
action(ActionCode.ACTION_RESET, this);
}
@@ -344,27 +344,27 @@
// Headers
public boolean containsHeader(String name) {
- return headers.getHeader(name) != null;
+return headers.getHeader(name) != null;
}
public void setHeader(String name, String value) {
- char cc=name.charAt(0);
- if( cc=='C' || cc=='c' ) {
- if( checkSpecialHeader(name, value) )
- return;
- }
- headers.setValue(name).setString( value);
+char cc=name.charAt(0);
+if( cc=='C' || cc=='c' ) {
+if( checkSpecialHeader(name, value) )
+return;
+}
+headers.setValue(name).setString( value);
}
public void addHeader(String name, String value) {
- char cc=name.charAt(0);
- if( cc=='C' || cc=='c' ) {
- if( checkSpecialHeader(name, value) )
- return;
- }
- headers.addValue(name).setString( value );
+char cc=name.charAt(0);
+if( cc=='C' || cc=='c' ) {
+if( checkSpecialHeader(name, value) )
+return;
+}
+headers.addValue(name).setString( value );
}
@@ -374,27 +374,27 @@
* Return true if the header is special, no need to set the header.
*/
private boolean checkSpecialHeader( String name, String value) {
- // XXX Eliminate redundant fields !!!
- // ( both header and in special fields )
DO NOT REPLY [Bug 10901] - Response#setLocale() does not set charset encoding
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10901. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10901 Response#setLocale() does not set charset encoding [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2002-09-12 05:49 --- Fixed. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
