DO NOT REPLY [Bug 20266] New: - Tomcat memory profiler
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20266. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20266 Tomcat memory profiler Summary: Tomcat memory profiler Product: Tomcat 4 Version: 4.1.18 Platform: PC OS/Version: Other Status: NEW Severity: Normal Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] When I run a memory profiler against Tomcat, I see that the number of String, char[], Object[], and short[] objects is increasing about one a second. All I did was start Tomcat. No web applications are running, and no HTTP requests are begin sent to the server. I even commented out all the Context entries in the server.conf file. The number of String instances grows from around 18,000 to 20,000, then eventually resets back to 18,000 (the garbage collector runs?) This seems like buggy behavior -- why are so many new Strings being created? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 20266] - Tomcat memory profiler
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20266. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20266 Tomcat memory profiler [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-05-27 16:16 --- Tomcat uses background processes to do a variety of stuff (context reloader, manager session expiration, host auto deployer, possibly server socket timeout, etc), and these allocate objects (btw, one String leads to the allocation of a variety of things, including, obviously, a char buffer). Most of that background stuff can be disabled if you need to. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/modules/cluster build.xml
remm2003/05/27 10:00:23
Modified:modules/cluster build.xml
Log:
- Enable building cluster.
Revision ChangesPath
1.5 +2 -2 jakarta-tomcat-catalina/modules/cluster/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-catalina/modules/cluster/build.xml,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- build.xml 14 Apr 2003 21:37:24 - 1.4
+++ build.xml 27 May 2003 17:00:23 - 1.5
@@ -76,13 +76,13 @@
target name=build-catalina-cluster depends=build-prepare
!-- Compile internal server components --
-javac srcdir=src/share destdir=${catalina.build}/classes
+javac srcdir=${basedir}/src/share destdir=${catalina.build}/classes
debug=${compile.debug} deprecation=${compile.deprecation}
optimize=${compile.optimize}
excludes=**/CVS/**
classpath refid=cluster.classpath /
/javac
-copy file=src/share/org/apache/catalina/cluster/LocalStrings.properties
+copy
file=${basedir}/src/share/org/apache/catalina/cluster/LocalStrings.properties
tofile=${catalina.build}/classes/org/apache/catalina/cluster/LocalStrings.properties/
/target
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/modules build.xml
remm2003/05/27 10:00:33 Modified:modules build.xml Log: - Enable building cluster. Revision ChangesPath 1.3 +1 -1 jakarta-tomcat-catalina/modules/build.xml Index: build.xml === RCS file: /home/cvs/jakarta-tomcat-catalina/modules/build.xml,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- build.xml 24 Apr 2003 04:23:59 - 1.2 +++ build.xml 27 May 2003 17:00:33 - 1.3 @@ -11,7 +11,7 @@ !-- === BUILD: Create Directories == -- target name=build-prepare - +available property=jdk1.4.present classname=java.nio.Buffer / /target - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm RealmBase.java
remm2003/05/27 10:02:36
Modified:catalina/src/share/org/apache/catalina/realm RealmBase.java
Log:
- Refactor without using SSL URLs, similar to what is done for sendRedirect.
Revision ChangesPath
1.13 +15 -22
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/RealmBase.java
Index: RealmBase.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/RealmBase.java,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- RealmBase.java23 Apr 2003 16:14:12 - 1.12
+++ RealmBase.java27 May 2003 17:02:36 - 1.13
@@ -72,8 +72,6 @@
import java.security.NoSuchAlgorithmException;
import java.security.cert.X509Certificate;
import java.io.IOException;
-import java.net.URL;
-import java.net.MalformedURLException;
import java.util.Set;
import javax.servlet.http.HttpServletRequest;
@@ -669,9 +667,15 @@
}
// Redirect to the corresponding SSL port
+StringBuffer file = new StringBuffer();
String protocol = https;
String host = hrequest.getServerName();
-StringBuffer file = new StringBuffer(hrequest.getRequestURI());
+// Protocol
+file.append(protocol).append(://);
+// Host with port
+file.append(host).append(:).append(redirectPort);
+// URI
+file.append(hrequest.getRequestURI());
String requestedSessionId = hrequest.getRequestedSessionId();
if ((requestedSessionId != null)
hrequest.isRequestedSessionIdFromURL()) {
@@ -683,21 +687,10 @@
file.append('?');
file.append(queryString);
}
-URL url = null;
-try {
-url = new URL(protocol, host, redirectPort, file.toString());
-if (log.isDebugEnabled())
-log.debug( Redirecting to + url.toString());
-hresponse.sendRedirect(url.toString());
-return (false);
-} catch (MalformedURLException e) {
-if (log.isDebugEnabled())
-log.debug( Cannot create new URL, e);
-hresponse.sendError
-(HttpServletResponse.SC_INTERNAL_SERVER_ERROR,
- hrequest.getRequestURI());
-return (false);
-}
+if (log.isDebugEnabled())
+log.debug( Redirecting to + file.toString());
+hresponse.sendRedirect(file.toString());
+return (false);
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5 TODO.txt
remm2003/05/27 10:03:15 Modified:.TODO.txt Log: - Update TODO. Revision ChangesPath 1.7 +5 -3 jakarta-tomcat-5/TODO.txt Index: TODO.txt === RCS file: /home/cvs/jakarta-tomcat-5/TODO.txt,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- TODO.txt 26 May 2003 12:07:16 - 1.6 +++ TODO.txt 27 May 2003 17:03:15 - 1.7 @@ -1,18 +1,20 @@ -* Casts removal for main pipeline (remm) * Deployer refactoring (remm) * Documentation updates for new user guide book (remm) * Split main catalina.jar (remm) -* Tag plugins for JSTL +* Casts removal for main pipeline (remm) +* Tag plugins for JSTL (kinman ?) * Optimization of BASIC authentication handling (remm) * (optional) Optimization of DIGEST authentication handling * (optional) Realm / auth refactoring (one of the goals would be to add better support for DIGEST) * (optional) GUI for the deployer * (optional) Stack size reduction (removal of valves to improve runtime - performance and ease debugging) + performance and ease debugging) (costin ?) +* (optional) Java load balancer / cache (?) for use with Tomcat clustering, or + with session affinity (remm ?, fhanik ?) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 20263] - Tomcat 5.0.2 service does not survive logoff
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20263. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20263 Tomcat 5.0.2 service does not survive logoff [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED --- Additional Comments From [EMAIL PROTECTED] 2003-05-27 17:55 --- The problem is with the console handler. I'll fix that ASAP. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 20266] - Tomcat memory profiler
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20266. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20266 Tomcat memory profiler --- Additional Comments From [EMAIL PROTECTED] 2003-05-27 18:01 --- How do I disable the background stuff? I already disabled context reloading, there is no manager app, etc. Why is Tomcat continuously creating new String objects? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 20268] New: - Tomcat 5.0.2 takes 100% CPU
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20268. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20268 Tomcat 5.0.2 takes 100% CPU Summary: Tomcat 5.0.2 takes 100% CPU Product: Tomcat 5 Version: 5.0.2 Platform: PC OS/Version: Windows XP Status: NEW Severity: Major Priority: Other Component: Unknown AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I have installed Tomcat 5.0.2 in Windows 2003 server as Administrator, and after I start it, it takes 100% CPU until I stop it. The process using the CPU is tomcatw.exe. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 20217] - restartContext doesn't work when a context configuration file maps a path to two levels.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20217. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20217 restartContext doesn't work when a context configuration file maps a path to two levels. [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 20263] - Tomcat 5.0.2 service does not survive logoff
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20263. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20263 Tomcat 5.0.2 service does not survive logoff [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||WORKSFORME --- Additional Comments From [EMAIL PROTECTED] 2003-05-27 18:57 --- The problem is with detached java.exe or javaw.exe. The solution is to add the '-Xrs' (to startp JVM options. Reducing signals doesnt installs java.exe's own console control handler, reather inherits one from parent process (procrun). Do not use tomcatw for //ES from 5.0.2, cause it is broken. Use the current binaries from CVS. Here is the explanation from MSDEV. For example, if you install a SIGBREAK handler via the C run-time function signal(), the function installs a handler which overrides the default handler. This causes the application to exit when receiving a CTRL_LOGOFF event even though it was launched from a service. The only solution for java.exe to survive the CTRL_LOGOFF signal is to use the mentioned '-Xrs' option. The Java Docs says: There are two consequences of specifying -Xrs: SIGQUIT thread dumps are not available. User code is responsible for causing shutdown hooks to run, for example by calling System.exit() when the JVM is to be terminated. Remmy does that bother us? If not consider adding '#-Xrs#' to --JavaOptions during install. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm RealmBase.java
- Original Message - From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Tuesday, May 27, 2003 10:02 AM Subject: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm RealmBase.java remm2003/05/27 10:02:36 Modified:catalina/src/share/org/apache/catalina/realm RealmBase.java Log: - Refactor without using SSL URLs, similar to what is done for sendRedirect. Revision ChangesPath 1.13 +15 -22 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/RealmBa se.java Index: RealmBase.java === RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/rea lm/RealmBase.java,v retrieving revision 1.12 retrieving revision 1.13 diff -u -r1.12 -r1.13 --- RealmBase.java 23 Apr 2003 16:14:12 - 1.12 +++ RealmBase.java 27 May 2003 17:02:36 - 1.13 @@ -72,8 +72,6 @@ import java.security.NoSuchAlgorithmException; import java.security.cert.X509Certificate; import java.io.IOException; -import java.net.URL; -import java.net.MalformedURLException; import java.util.Set; import javax.servlet.http.HttpServletRequest; @@ -669,9 +667,15 @@ } // Redirect to the corresponding SSL port +StringBuffer file = new StringBuffer(); String protocol = https; String host = hrequest.getServerName(); -StringBuffer file = new StringBuffer(hrequest.getRequestURI()); +// Protocol +file.append(protocol).append(://); +// Host with port +file.append(host).append(:).append(redirectPort); +// URI +file.append(hrequest.getRequestURI()); I really don't like the redirect to https:host:443/ The easiest fix would have been to simply change the import from java.net.URL to org.apache.catalina.util.URL (or org.apache.tomcat.util.net.URL, they are much the same). - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
checkInterval for loader and manager
Remy, We don't have checkInterval attribute for loader and manager after refactoring. Should I remove it from admin? I see it's broken since then. Thanks, Amy HTTP Status 500 - Error retrieving attribute checkInterval *type* Status report *message* _Error retrieving attribute checkInterval_ *description* _The server encountered an internal error (Error retrieving attribute checkInterval) that prevented it from fulfilling this request._ __ Do you Yahoo!? The New Yahoo! Search - Faster. Easier. Bingo. http://search.yahoo.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5 build.xml
jfarcand2003/05/27 12:37:19
Modified:.build.xml
Log:
Copy ant.jar to avoid having to copy it manually. That should fix the gump failure.
Revision ChangesPath
1.128 +3 -0 jakarta-tomcat-5/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-5/build.xml,v
retrieving revision 1.127
retrieving revision 1.128
diff -u -r1.127 -r1.128
--- build.xml 14 May 2003 17:46:39 - 1.127
+++ build.xml 27 May 2003 19:37:18 - 1.128
@@ -24,6 +24,7 @@
property name=catalina.project value=jakarta-tomcat-catalina /
property name=jtc.project value=jakarta-tomcat-connectors /
property name=jasper.projectvalue=jakarta-tomcat-jasper /
+ property name=ant.jar value=${ant.home}/lib/ant.jar/
property name=cvstagvalue= /
property name=cvs.base
value=${basedir}/../
@@ -149,6 +150,8 @@
--
copy todir=${tomcat.build}/server/lib file=${commons-logging.jar} /
copy todir=${tomcat.build}/server/lib file=${commons-modeler.jar} /
+
+copy todir=${tomcat.build}/common/lib file=${ant.jar}/
/target
!-- == Build all components === --
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 19879] - TOMCAT CONSUMES more than 200 % cpu in idle state
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19879. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19879 TOMCAT CONSUMES more than 200 % cpu in idle state --- Additional Comments From [EMAIL PROTECTED] 2003-05-27 20:55 --- I was going to open a new bug, but this seems to describe my issue very well. Although not the same platform. My issue is Tomcat consumes 100% cpu in idle state on a single processor machine. This is without making a single HTTP request to Tomcat. Basically I start Tomcat using startup.bat and then wait a few hours. Eventually it (java.exe) will start to consume 100% cpu. I have reproduced this on three different machines and I've been struggling with it for about a month now. I can reproduce this on a clean install of Tomcat with no added libraries and nothing but the default Contexts. My Platform: Tomcat 4.1.24 JDK 1.3.1_07 Windows 2000 SP3 I will be happy to try anything to assist in isolating the error, but I will need instructions on what to do. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 20268] - Tomcat 5.0.2 takes 100% CPU
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20268. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20268 Tomcat 5.0.2 takes 100% CPU [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-05-27 22:13 --- I don't know if this is specific to Windows 2003. If it is, you'll have to debug it yourself, or wait until we find a way to reproduce this, as this works for me on Win 2k and XP, with Sun JDK 1.4.x. Please do not reopen the report unless you can provide useful information. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realmRealmBase.java
Bill Barker wrote: remm2003/05/27 10:02:36 Modified:catalina/src/share/org/apache/catalina/realm RealmBase.java Log: - Refactor without using SSL URLs, similar to what is done for I really don't like the redirect to https:host:443/ The easiest fix would have been to simply change the import from java.net.URL to org.apache.catalina.util.URL (or org.apache.tomcat.util.net.URL, they are much the same). sendRedirect does the same (and I think it used to use java.net.URL, then org.apache.catalina.util.URL). Isn't there a reason for doing things like that ? It's a bit confusing ... Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 19879] - TOMCAT CONSUMES more than 200 % cpu in idle state
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19879. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19879 TOMCAT CONSUMES more than 200 % cpu in idle state [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-05-27 22:17 --- I will resolve that report according to my previous comments. You can easily get a view of threads which are running by using ctrl+break (on Windows). Do not reopen that report unless you can provide conclusive information about a flaw in Tomcat. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: checkInterval for loader and manager
Amy Roh wrote: Remy, We don't have checkInterval attribute for loader and manager after refactoring. Should I remove it from admin? I see it's broken since then. Ah, yes, sorry, I forgot to update admin :-( All containers should get the new backgroundProcessorDelay attribute (if it's 0, they'll spawn a background process thread which will be used for them and their children, unless they themselves have a 0 value). I have nothing against changing the backgroundProcessorDelay name (it's better than my first name, though ;-) ). Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/webapps/admin/context context.jsp
amyroh 2003/05/27 16:11:25
Modified:webapps/admin/WEB-INF/classes/org/apache/webapp/admin/context
AddContextAction.java EditContextAction.java
SaveContextAction.java
webapps/admin/context context.jsp
Log:
Remove checkInterval attribute since it no longer exists.
Revision ChangesPath
1.4 +6 -6
jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/context/AddContextAction.java
Index: AddContextAction.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/context/AddContextAction.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- AddContextAction.java 18 Mar 2003 10:48:15 - 1.3
+++ AddContextAction.java 27 May 2003 23:11:25 - 1.4
@@ -151,11 +151,11 @@
contextFm.setPath();
contextFm.setDebugLvl(0);
//loader initialization
-contextFm.setLdrCheckInterval(15);
+//contextFm.setLdrCheckInterval(15);
contextFm.setLdrDebugLvl(0);
contextFm.setLdrReloadable(false);
//manager initialization
-contextFm.setMgrCheckInterval(60);
+//contextFm.setMgrCheckInterval(60);
contextFm.setMgrDebugLvl(0);
contextFm.setMgrMaxSessions(-1);
contextFm.setMgrSessionIDInit();
1.5 +10 -10
jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/context/EditContextAction.java
Index: EditContextAction.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/context/EditContextAction.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- EditContextAction.java20 Mar 2003 05:40:09 - 1.4
+++ EditContextAction.java27 May 2003 23:11:25 - 1.5
@@ -257,9 +257,9 @@
attribute = debug;
contextFm.setLdrDebugLvl
(((Integer) mBServer.getAttribute(lname, attribute)).toString());
-attribute = checkInterval;
-contextFm.setLdrCheckInterval
-(((Integer) mBServer.getAttribute(lname, attribute)).toString());
+//attribute = checkInterval;
+//contextFm.setLdrCheckInterval
+//(((Integer) mBServer.getAttribute(lname, attribute)).toString());
attribute = reloadable;
contextFm.setLdrReloadable
(((Boolean) mBServer.getAttribute(lname, attribute)).toString());
@@ -274,9 +274,9 @@
attribute = maxActiveSessions;
contextFm.setMgrMaxSessions
(((Integer) mBServer.getAttribute(mname, attribute)).toString());
-attribute = checkInterval;
-contextFm.setMgrCheckInterval
-(((Integer) mBServer.getAttribute(mname, attribute)).toString());
+//attribute = checkInterval;
+//contextFm.setMgrCheckInterval
+//(((Integer) mBServer.getAttribute(mname, attribute)).toString());
} catch (Throwable t) {
getServlet().log
1.11 +21 -21
jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/context/SaveContextAction.java
Index: SaveContextAction.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/context/SaveContextAction.java,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- SaveContextAction.java13 May 2003 01:15:08 - 1.10
+++ SaveContextAction.java27 May 2003 23:11:25 - 1.11
@@ -404,15 +404,15 @@
mBServer.setAttribute(loname,
new Attribute(debug, new Integer(debug)));
-attribute = checkInterval;
-int checkInterval = 15;
-try {
-checkInterval = Integer.parseInt(cform.getLdrCheckInterval());
-} catch (Throwable t) {
-checkInterval = 15;
-}
-mBServer.setAttribute(loname,
- new Attribute(checkInterval, new
Integer(checkInterval)));
+//attribute = checkInterval;
+//int checkInterval = 15;
+//try {
+//checkInterval = Integer.parseInt(cform.getLdrCheckInterval());
+//} catch (Throwable t) {
+//checkInterval = 15;
+//}
+//mBServer.setAttribute(loname,
+// new
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/naming ContextBindings.java
amyroh 2003/05/27 16:15:06
Modified:catalina/src/share/org/apache/catalina/loader
mbeans-descriptors.xml
catalina/src/share/org/apache/catalina/session
mbeans-descriptors.xml
catalina/src/share/org/apache/naming ContextBindings.java
Log:
Remove checkInterval since it no longer exists. Also, check for NPE in
unblindClassLoader. It was thorwing NPE when newly added context was removed.
Revision ChangesPath
1.2 +1 -6
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/loader/mbeans-descriptors.xml
Index: mbeans-descriptors.xml
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/loader/mbeans-descriptors.xml,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- mbeans-descriptors.xml25 Apr 2003 21:14:35 - 1.1
+++ mbeans-descriptors.xml27 May 2003 23:15:06 - 1.2
@@ -7,12 +7,7 @@
domain=Catalina
group=Loader
type=org.apache.catalina.loader.WebappLoader
-
-attribute name=checkInterval
- description=The number of seconds between checks for modified
- classes
- type=int/
-
+
attribute name=className
description=Fully qualified class name of the managed object
type=java.lang.String
1.2 +0 -5
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/mbeans-descriptors.xml
Index: mbeans-descriptors.xml
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/mbeans-descriptors.xml,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- mbeans-descriptors.xml25 Apr 2003 21:14:36 - 1.1
+++ mbeans-descriptors.xml27 May 2003 23:15:06 - 1.2
@@ -17,11 +17,6 @@
description=File source of random - /dev/urandom or a pipe
type=java.lang.String/
-attribute name=checkInterval
- description=The interval (in seconds) between checks for expired
- sessions
- type=int/
-
attribute name=className
description=Fully qualified class name of the managed object
type=java.lang.String
1.2 +5 -6
jakarta-tomcat-catalina/catalina/src/share/org/apache/naming/ContextBindings.java
Index: ContextBindings.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/naming/ContextBindings.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- ContextBindings.java 18 Jul 2002 16:47:31 - 1.1
+++ ContextBindings.java 27 May 2003 23:15:06 - 1.2
@@ -347,7 +347,7 @@
ClassLoader classLoader) {
if (ContextAccessController.checkSecurityToken(name, token)) {
Object n = clNameBindings.get(classLoader);
-if (!(n.equals(name))) {
+if ((n==null) || !(n.equals(name))) {
return;
}
clBindings.remove(classLoader);
@@ -407,4 +407,3 @@
}
-
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: checkInterval for loader and manager
I have fixed admin so checkInterval is no longer on the context pages. I like your first name better than backgroundProcessorDelay ;-) Remy Maucherat [EMAIL PROTECTED] wrote: Amy Roh wrote: Remy, We don't have checkInterval attribute for loader and manager after refactoring. Should I remove it from admin? I see it's broken since then. Ah, yes, sorry, I forgot to update admin :-( All containers should get the new backgroundProcessorDelay attribute (if it's 0, they'll spawn a background process thread which will be used for them and their children, unless they themselves have a 0 value). I have nothing against changing the backgroundProcessorDelay name (it's better than my first name, though ;-) ). Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - Do you Yahoo!? The New Yahoo! Search - Faster. Easier. Bingo.
2 quick questions
I'm new to this mailing list. I'm trying to get some quick directions from the group. 1) I went to mail-archive.com to search for my problem below (#2) and found that all of the archives to this mailing list don't allow access. Who should I talk to about this? http://www.mail-archive.com appears to have empty todo and faq as well. 2) I'm seeing this bug: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12428 appear in 4.1.24. It works fine in 4.0.6. I suspect the problem is in the AuthenticatorBase. Can someone give me some direction as to what might be causing this problem so I can patch 4.1.24? Basically, this really screws up the authentication. Thank you. Brian - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
