RE: [VOTE] 4.1.26 stability rating
I hope it isn't too late to fix the problem Yaov pointed out for the 4.1.26 release. Here is the patch. Jason - --- tomcat/bin/setclasspath.sh 2003-07-15 04:56:10.0 -0400 +++ tomcat/bin/setclasspath.sh 2003-07-25 16:27:46.870053000 -0400 @@ -53,7 +53,7 @@ # Set standard commands for invoking Java. _RUNJAVA=$JAVA_HOME/bin/java -if ! $os400; then +if [ ! $os400 ]; then _RUNJDB=$JAVA_HOME/bin/jdb fi _RUNJAVAC=$JAVA_HOME/bin/javac - Howdy, Having been running it for a full week in our complete test environment, including JMeter scripts, I'm going to move my vote from Beta to Stable. There's still the one little thing as I posted a few days ago, in the catalina.sh scripts saying !: not found at the beginning. Startup and shutdown work OK though, as I described, and I haven't seen anyone else complain about this, so... Yoav Shapira Millennium ChemInformatics - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Tomcat Download and Installation
Hi, I have looked at the file Running.txt available at: http://jakarta.apache.org/tomcat/tomcat-4.0-doc/RUNNING.txt currently it says: Download a binary distribution of Tomcat from: http://jakarta.apache.org/builds/jakarta-tomcat-4.0/nightly/ On a Windows platform, you will need: jakarta-tomcat-4.0-MMDD.zip On a Unix platform, you will need: jakarta-tomcat-4.0-MMDD.zip I went to the site mentioned, it appeared to be empty. No matter, I managed to find a distribution after traversing the directory tree a bit. another bug in this statement I guess is the last part, surely it should say: On a Unix platform, you will need: jakarta-tomcat-4.0-MMDD.tar.gz -- all the bast, Bill. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: AW: AW: [5.0] Connector default configuration + connection timeout
Section 14.45 of HTTP 1.1 states: The Via general-header field MUST be used by gateways and proxies to indicate the intermediate protocols and recipients between the user agent and the server on requests, and between the origin server and the client on responses.. This means that if a proxy is involved there will be a Via header. Moreover there is the X-Forwarded-For header (NOT part of the standard) used for example by squid proxy, which indicates the original host issuing the request. Of course nothing prohibits a DoS host to insert these headers to fake a proxy!! Stefanos Fischer, Ilona wrote: IMHO it's the definition of a proxy to send/recive requests instead of client... that means only the proxy was talking with the webserver - in the HTTP-header was only the IP of the Proxy Regards :o) Ilona -Ursprüngliche Nachricht- Von: Henri Gomez [mailto:[EMAIL PROTECTED] Gesendet: Montag, 28. Juli 2003 18:01 An: Tomcat Developers List Betreff: Re: AW: [5.0] Connector default configuration + connection timeout Fischer, Ilona a écrit : Protection against DOS attack should also have some glues like : - Max clients from the same IP (ie DOS attack from the same host). How would you distinguish between users coming from big proxy and a DOS-attack? Our access.logs shows that approx. 30% acesses comes from t-online (a big ISP in germany) and AOL That's right (T-ONLINE and AOL) are big hackers ;) More seriously, in such case there must be the original IP somewhere in the HTTP header isn't it ? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- == Stefanos Karasavvidis Electronic Computer Engineer e-mail : [EMAIL PROTECTED] Multimedia Systems Center S.A. Kissamou 178 73100 Chania - Crete - Hellas http://www.msc.gr Tel : +30 2821 0 88447 Fax : +30 2821 0 88427 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21951] New: - Error while trying to call JSP containing PHP
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21951. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21951 Error while trying to call JSP containing PHP Summary: Error while trying to call JSP containing PHP Product: Tomcat 4 Version: 4.1.18 Platform: PC OS/Version: Windows NT/2K Status: NEW Severity: Major Priority: Other Component: Servlet JSP API AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Calling 3 times JSP that contains PHP script causes crash of Tomcat with following stack trace: An unexpected exception has been detected in native code outside the VM. Unexpected Signal : EXCEPTION_ACCESS_VIOLATION occurred at PC=0x11D2E84B Function=zend_hash_add_or_update+0xAB Library=C:\Programme\PHP4.3.2\php4ts.dll Current Java thread: at net.php.servlet.send(Native Method) at net.php.servlet.service(servlet.java:190) at net.php.servlet.service(servlet.java:214) at javax.servlet.http.HttpServlet.service(HttpServlet.java:853) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter (ApplicationFilterChain.java:247) at org.apache.catalina.core.ApplicationFilterChain.doFilter (ApplicationFilterChain.java:193) at org.apache.catalina.core.StandardWrapperValve.invoke (StandardWrapperValve.java:260) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:643) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:480) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995) at org.apache.catalina.core.StandardContextValve.invoke (StandardContextValve.java:191) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:643) at org.apache.catalina.authenticator.AuthenticatorBase.invoke (AuthenticatorBase.java:550) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:641) at org.apache.catalina.valves.CertificatesValve.invoke (CertificatesValve.java:246) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:641) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:480) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995) at org.apache.catalina.core.StandardContext.invoke (StandardContext.java:2415) at org.apache.catalina.core.StandardHostValve.invoke (StandardHostValve.java:180) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:643) at org.apache.catalina.valves.ErrorDispatcherValve.invoke (ErrorDispatcherValve.java:170) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:641) at org.apache.catalina.valves.ErrorReportValve.invoke (ErrorReportValve.java:172) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:641) at org.apache.catalina.valves.AccessLogValve.invoke (AccessLogValve.java:509) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:641) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:480) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995) at org.apache.catalina.core.StandardEngineValve.invoke (StandardEngineValve.java:174) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:643) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:480) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995) at org.apache.catalina.connector.http.HttpProcessor.process (HttpProcessor.java:1040) at org.apache.catalina.connector.http.HttpProcessor.run (HttpProcessor.java:1151) at java.lang.Thread.run(Thread.java:536) Dynamic libraries: 0x0040 - 0x00406000 C:\java\jdk\bin\java.exe 0x7788 - 0x77901000 C:\WINNT\System32\ntdll.dll 0x77DA - 0x77DFB000 C:\WINNT\system32\ADVAPI32.dll 0x77E7 - 0x77F32000 C:\WINNT\system32\KERNEL32.DLL 0x77D3 - 0x77DA C:\WINNT\system32\RPCRT4.DLL 0x7800 - 0x78046000 C:\WINNT\system32\MSVCRT.dll 0x6D45 - 0x6D6AD000 C:\java\jdk\jre\bin\server\jvm.dll 0x77E0 - 0x77E64000 C:\WINNT\system32\USER32.dll 0x77F4 - 0x77F7C000
Re: [VOTE] 4.1.26 stability rating
- Original Message - From: Jason Corley [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Friday, July 25, 2003 2:09 PM Subject: RE: [VOTE] 4.1.26 stability rating I hope it isn't too late to fix the problem Yaov pointed out for the 4.1.26 release. Here is the patch. Jason Well, the fix is in the HEAD of j-t-4.0, but not under the 4.1.26 tag, so by default, no. I'm guessing that it's going to depend on how much you want to bribe Remy to re-tag the file ;-). - --- tomcat/bin/setclasspath.sh 2003-07-15 04:56:10.0 -0400 +++ tomcat/bin/setclasspath.sh 2003-07-25 16:27:46.870053000 -0400 @@ -53,7 +53,7 @@ # Set standard commands for invoking Java. _RUNJAVA=$JAVA_HOME/bin/java -if ! $os400; then +if [ ! $os400 ]; then _RUNJDB=$JAVA_HOME/bin/jdb fi _RUNJAVAC=$JAVA_HOME/bin/javac - Howdy, Having been running it for a full week in our complete test environment, including JMeter scripts, I'm going to move my vote from Beta to Stable. There's still the one little thing as I posted a few days ago, in the catalina.sh scripts saying !: not found at the beginning. Startup and shutdown work OK though, as I described, and I haven't seen anyone else complain about this, so... Yoav Shapira Millennium ChemInformatics - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/coreContainerBase.java StandardContext.java StandardWrapper.java
[EMAIL PROTECTED] wrote: amyroh 2003/07/28 17:09:43 Modified:catalina/src/share/org/apache/catalina/core ContainerBase.java StandardContext.java StandardWrapper.java Log: Send JSR77 spec required notifications for J2EE mbeans. +new Notification(j2ee.state.stoping, this.getObjectName(), There's a typo here, I think. Duplicated because you did a cut paste. Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: AW: AW: [5.0] Connector default configuration + connection timeout
Fischer, Ilona a écrit : IMHO it's the definition of a proxy to send/recive requests instead of client... that means only the proxy was talking with the webserver - in the HTTP-header was only the IP of the Proxy And what about the Via: header ? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: AW: AW: [5.0] Connector default configuration + connection timeou t
- Original Message - From: Henri Gomez [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Tuesday, July 29, 2003 12:46 AM Subject: Re: AW: AW: [5.0] Connector default configuration + connection timeou t Fischer, Ilona a écrit : IMHO it's the definition of a proxy to send/recive requests instead of client... that means only the proxy was talking with the webserver - in the HTTP-header was only the IP of the Proxy And what about the Via: header ? It's unreliable at best: I routinely configure mod_proxy to suppress it. And, in any case, it only tells you the name of the Proxy (which you already know ;-). - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21956] New: - org.apache.coyote.tomcat4.CoyoteConnector cannot recognise keystoreType for Solaris only
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21956. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21956 org.apache.coyote.tomcat4.CoyoteConnector cannot recognise keystoreType for Solaris only Summary: org.apache.coyote.tomcat4.CoyoteConnector cannot recognise keystoreType for Solaris only Product: Tomcat 4 Version: 4.1.24 Platform: Sun OS/Version: Solaris Status: NEW Severity: Normal Priority: Other Component: Connector:Coyote HTTP/1.1 AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I'm running tomcat 4.1.24 on Solaris 8 org.apache.coyote.tomcat4.CoyoteServerSocketFactory seems to be ignoring the keystoreType attribute. I've generate a .keystore file in $CATALINA_HOME. I'm using the following in my server.xml. Connector className=org.apache.coyote.tomcat4.CoyoteConnector port=8443 minProcessors=5 maxProcessors=75 enableLookups=true acceptCount=100 debug=0 scheme=https secure=true useURIValidationHack=false disableUploadTimeout=true Factory className=org.apache.coyote.tomcat4.CoyoteServerSocketFactory clientAuth=false protocol=TLS keystoreFile=/usr/local/jakarta-tomcat-4.1.24/.keystore keystorePass=tomcat/ /Connector And I receive the following error in catalina.out. INFO: Creating new Registry instance Jul 25, 2003 4:20:56 PM org.apache.commons.modeler.Registry getServer INFO: Creating MBeanServer Jul 25, 2003 4:21:07 PM org.apache.coyote.http11.Http11Protocol init INFO: Initializing Coyote HTTP/1.1 on port 80 Jul 25, 2003 4:21:11 PM org.apache.coyote.http11.Http11Protocol init SEVERE: Error initializing endpoint java.io.IOException at org.apache.tomcat.util.net.jsse.JSSESocketFactory.initProxy (JSSESocketFactory.java:231) at org.apache.tomcat.util.net.jsse.JSSESocketFactory.createSocket (JSSESocketFactory.java:138) at org.apache.tomcat.util.net.PoolTcpEndpoint.initEndpoint (PoolTcpEndpoint.java:277) at org.apache.coyote.http11.Http11Protocol.init(Http11Protocol.java:150) at org.apache.coyote.tomcat4.CoyoteConnector.initialize (CoyoteConnector.java:1117) at org.apache.catalina.core.StandardService.initialize (StandardService.java:579) at org.apache.catalina.core.StandardServer.initialize (StandardServer.java:2246) at org.apache.catalina.startup.Catalina.start(Catalina.java:511) at org.apache.catalina.startup.Catalina.execute(Catalina.java:400) at org.apache.catalina.startup.Catalina.process(Catalina.java:180) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:324) at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:203) Catalina.start: LifecycleException: Protocol handler initialization failed: java.io.IOException LifecycleException: Protocol handler initialization failed: java.io.IOException at org.apache.coyote.tomcat4.CoyoteConnector.initialize (CoyoteConnector.java:1119) at org.apache.catalina.core.StandardService.initialize (StandardService.java:579) at org.apache.catalina.core.StandardServer.initialize (StandardServer.java:2246) at org.apache.catalina.startup.Catalina.start(Catalina.java:511) at org.apache.catalina.startup.Catalina.execute(Catalina.java:400) at org.apache.catalina.startup.Catalina.process(Catalina.java:180) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:324) at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:203) Catalina.stop: LifecycleException: This server has not yet been started LifecycleException: This server has not yet been started at org.apache.catalina.core.StandardServer.stop (StandardServer.java:2213) at org.apache.catalina.startup.Catalina.start(Catalina.java:543) at org.apache.catalina.startup.Catalina.execute(Catalina.java:400) at org.apache.catalina.startup.Catalina.process(Catalina.java:180) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:39) at
DO NOT REPLY [Bug 21951] - Error while trying to call JSP containing PHP
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21951. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21951 Error while trying to call JSP containing PHP [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-07-29 11:33 --- Its a PHP (or JVM)bug causing the crash, not a tomcat bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [5.0] Connector default configuration + connection timeout
Bill Barker wrote:
- Original Message -
From: Remy Maucherat [EMAIL PROTECTED]
To: Tomcat Developers List [EMAIL PROTECTED]
Sent: Monday, July 28, 2003 8:16 AM
Subject: [5.0] Connector default configuration + connection timeout
Hi,
What would be the best connector default configuration ?
I switched HTTP/1.1 to be:
maxThreads: 100
minSpare: 1
maxSpare: 10
That should be ok for a small/medium site, and bad for a large site. It
should be decent for benchmarking if there's a warmup period. Should the
default config be large site compliant ?
Jk-Coyote should probably match the Apache2 defaults, since with the
pre-fork MPM, connections are 1-1 with Apache2 children.
Also, in order to conserve processors for useful tasks when the load
increases (and also twart DoS attacks), I was thinking about introducing
dynamic scaling for the HTTP connection timeout for keepalive.
The formula would be something like this.
ratio = maxThreads / currentBusyThreads;
if (ratio between 0 and 0.33) {
normal timeout
} else if (ratio between 0.33 and 0.66) {
half timeout
} else if (ratio between 0.66 and 1) {
no keepalive (so only one request is processed per connection),
timeout / 4 (or maybe more)
}
No keepalive sounds like a bad idea: You are going to free-up connections
much faster if you get the image files out the pipe then if the browser is
immediately turning around and re-establishing a connection. It might also
be a good idea if there was an option to disable this, for the few cases
where you care more about the the connected user's experience then the
new-connection speed (Applet classloading comes to mind).
I found the opposite to be true, turning keepalive off is a better solution
for the server. There was a very good explanation why this is so at the
last ApacheCon in an Apache httpd performance tuning session.
Regards,
Glenn
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper Mapper.java
remm2003/07/29 05:15:47
Modified:util/java/org/apache/tomcat/util/http/mapper Mapper.java
Log:
- Fix a bug redirecting to a folder: the context path was lost.
(ex: /tomcat-docs/images - /tomcat-docs/images/ - previsouly, it would
get redirected to /images)
Revision ChangesPath
1.26 +8 -6
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper/Mapper.java
Index: Mapper.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper/Mapper.java,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -r1.25 -r1.26
--- Mapper.java 25 Jul 2003 19:25:06 - 1.25
+++ Mapper.java 29 Jul 2003 12:15:47 - 1.26
@@ -695,19 +695,21 @@
(path.getBuffer(), path.getStart(), path.getLength());
}
char[] buf = path.getBuffer();
-if( context.resources != null buf[pathEnd -1 ] != '/') {
+if (context.resources != null buf[pathEnd -1 ] != '/') {
Object file = null;
try {
file = context.resources.lookup(path.toString());
} catch(NamingException nex) {
// Swallow, since someone else handles the 404
}
-if(file != null file instanceof DirContext ) {
-CharChunk dirPath = path.getClone();
-dirPath.append('/');
+if (file != null file instanceof DirContext ) {
+// Note: this mutates the path: do not do any processing
+// after this (since we set the redirectPath, there
+// shouldn't be any)
+path.setOffset(pathOffset);
+path.append('/');
mappingData.redirectPath.setChars
-(dirPath.getBuffer(), dirPath.getStart(),
- dirPath.getLength());
+(path.getBuffer(), path.getStart(), path.getLength());
}
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves ErrorReportValve.java
remm2003/07/29 05:19:06
Modified:catalina/src/share/org/apache/catalina/servlets
DefaultServlet.java
catalina/src/share/org/apache/catalina/valves
ErrorReportValve.java
Added: catalina/src/share/org/apache/catalina/util TomcatCSS.java
Log:
- Put the CSS in a util class.
Revision ChangesPath
1.15 +5 -10
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java
Index: DefaultServlet.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -r1.14 -r1.15
--- DefaultServlet.java 25 Jul 2003 19:26:31 - 1.14
+++ DefaultServlet.java 29 Jul 2003 12:19:06 - 1.15
@@ -1504,12 +1504,7 @@
sb.append(sm.getString(directory.title, name));
sb.append(/title\r\n);
sb.append(STYLE!--);
-sb.append(H1{font-family : sans-serif,Arial,Tahoma;color :
white;background-color : #0086b2;} );
-sb.append(H3{font-family : sans-serif,Arial,Tahoma;color :
white;background-color : #0086b2;} );
-sb.append(BODY{font-family : sans-serif,Arial,Tahoma;color :
black;background-color : white;} );
-sb.append(B{color : white;background-color : #0086b2;} );
-sb.append(A{color : black;} );
-sb.append(HR{color : #0086b2;} );
+sb.append(org.apache.catalina.util.TomcatCSS.TOMCAT_CSS);
sb.append(--/STYLE );
sb.append(/head\r\n);
sb.append(body);
1.1
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util/TomcatCSS.java
Index: TomcatCSS.java
===
/*
* $Header:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util/TomcatCSS.java,v
1.1 2003/07/29 12:19:06 remm Exp $
* $Revision: 1.1 $
* $Date: 2003/07/29 12:19:06 $
*
*
*
* The Apache Software License, Version 1.1
*
* Copyright (c) 1999 The Apache Software Foundation. All rights
* reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* 1. Redistributions of source code must retain the above copyright
*notice, this list of conditions and the following disclaimer.
*
* 2. Redistributions in binary form must reproduce the above copyright
*notice, this list of conditions and the following disclaimer in
*the documentation and/or other materials provided with the
*distribution.
*
* 3. The end-user documentation included with the redistribution, if
*any, must include the following acknowlegement:
* This product includes software developed by the
*Apache Software Foundation (http://www.apache.org/).
*Alternately, this acknowlegement may appear in the software itself,
*if and wherever such third-party acknowlegements normally appear.
*
* 4. The names The Jakarta Project, Tomcat, and Apache Software
*Foundation must not be used to endorse or promote products derived
*from this software without prior written permission. For written
*permission, please contact [EMAIL PROTECTED]
*
* 5. Products derived from this software may not be called Apache
*nor may Apache appear in their names without prior written
*permission of the Apache Group.
*
* THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
* WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
* ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
* USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
* ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
* OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
*
* This software consists of voluntary contributions made by many
* individuals on behalf of the Apache Software Foundation. For more
* information on the Apache Software Foundation, please see
* http://www.apache.org/.
*
* [Additional notices, if required by prior licensing conditions]
*
*/
package
cvs commit: jakarta-tomcat-catalina/webapps/manager/WEB-INF/classes/org/apache/catalina/manager Constants.java
remm2003/07/29 05:19:27
Modified:webapps/manager/WEB-INF/classes/org/apache/catalina/manager
Constants.java
Log:
- Use the shared CSS.
Revision ChangesPath
1.4 +13 -36
jakarta-tomcat-catalina/webapps/manager/WEB-INF/classes/org/apache/catalina/manager/Constants.java
Index: Constants.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/webapps/manager/WEB-INF/classes/org/apache/catalina/manager/Constants.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- Constants.java28 Jul 2003 17:28:43 - 1.3
+++ Constants.java29 Jul 2003 12:19:27 - 1.4
@@ -73,37 +73,14 @@
html\n +
head\n +
style\n +
- P {\n +
-font-family:verdana,sans-serif;\n +
-background: white;\n +
-color: black;\n +
-font-size: 12px;\n +
- }\n +
- H1 {\n +
-font-family:verdana,sans-serif;\n +
-font-weight: bold;\n +
-font-size: 20px;\n +
-color: black;\n +
- }\n +
- H2 {\n +
-font-family:verdana,sans-serif;\n +
-font-weight: bold;\n +
-font-size: 14px;\n +
-color: black;\n +
- }\n +
- H3 {\n +
-font-family:verdana,sans-serif;\n +
-font-weight: bold;\n +
-font-size: 12px;\n +
-color: black;\n +
- }\n +
+org.apache.catalina.util.TomcatCSS.TOMCAT_CSS +
table {\n +
width: 100%;\n +
}\n +
td.page-title {\n +
text-align: center;\n +
vertical-align: top;\n +
-font-family:verdana,sans-serif;\n +
+font-family:sans-serif,Tahoma,Arial;\n +
font-weight: bold;\n +
background: white;\n +
color: black;\n +
@@ -111,7 +88,7 @@
td.title {\n +
text-align: left;\n +
vertical-align: top;\n +
-font-family:verdana,sans-serif;\n +
+font-family:sans-serif,Tahoma,Arial;\n +
font-style:italic;\n +
font-weight: bold;\n +
background: #D2A41C;\n +
@@ -119,49 +96,49 @@
td.header-left {\n +
text-align: left;\n +
vertical-align: top;\n +
-font-family:verdana,sans-serif;\n +
+font-family:sans-serif,Tahoma,Arial;\n +
font-weight: bold;\n +
background: #FFDC75;\n +
}\n +
td.header-center {\n +
text-align: center;\n +
vertical-align: top;\n +
-font-family:verdana,sans-serif;\n +
+font-family:sans-serif,Tahoma,Arial;\n +
font-weight: bold;\n +
background: #FFDC75;\n +
}\n +
td.row-left {\n +
text-align: left;\n +
vertical-align: middle;\n +
-font-family:verdana,sans-serif;\n +
+font-family:sans-serif,Tahoma,Arial;\n +
color: black;\n +
background: white;\n +
}\n +
td.row-center {\n +
text-align: center;\n +
vertical-align: middle;\n +
-font-family:verdana,sans-serif;\n +
+font-family:sans-serif,Tahoma,Arial;\n +
color: black;\n +
background: white;\n +
}\n +
td.row-right {\n +
text-align: right;\n +
vertical-align: middle;\n +
-font-family:verdana,sans-serif;\n +
+font-family:sans-serif,Tahoma,Arial;\n +
color: black;\n +
background: white;\n +
}\n +
TH {\n +
text-align: center;\n +
vertical-align: top;\n +
-font-family:verdana,sans-serif;\n +
+font-family:sans-serif,Tahoma,Arial;\n +
font-weight: bold;\n +
background: #FFDC75;\n +
}\n +
TD {\n +
text-align: center;\n +
vertical-align: middle;\n +
-font-family:verdana,sans-serif;\n +
+font-family:sans-serif,Tahoma,Arial;\n +
color: black;\n +
background: white;\n +
}\n +
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [5.0] Connector default configuration + connection timeout
Glenn Nielsen wrote: Bill Barker wrote: No keepalive sounds like a bad idea: You are going to free-up connections much faster if you get the image files out the pipe then if the browser is immediately turning around and re-establishing a connection. It might also be a good idea if there was an option to disable this, for the few cases where you care more about the the connected user's experience then the new-connection speed (Applet classloading comes to mind). I found the opposite to be true, turning keepalive off is a better solution for the server. There was a very good explanation why this is so at the last ApacheCon in an Apache httpd performance tuning session. Ok, but keepalive in general helps server performance IMO (through reduced bandwidth usage). When the number of available processors gets low, then it could be worth it to disable it (that's what I was proposing at least). Of course, I don't think it is the buisness of the TC HTTP/1.1 conector to implement stuff aimed at avoiding serious DoS attacks, so the idea right now is just to avoid minor problems and to handle traffic surges better. Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
securityManager in JasperLoader.java
Hi,
One of my colleague has problems in JasperLoader.java: The
System.getSecurityManager() is null when creating the class but not null later on.
Why do we have the following code? (from
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JasperLoader.java):
+++
if (System.getSecurityManager() != null) {
if (dot = 0) {
try {
securityManager.checkPackageAccess(name.substring(0,dot));
} catch (SecurityException se) {
String error = Security Violation, attempt to use +
Restricted Class: + name;
System.out.println(error);
throw new ClassNotFoundException(error);
}
}
}
+++
We test System.getSecurityManager() but use securityManager!
Cheers
Jean-Frederic
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java
remm2003/07/29 07:23:35
Modified:catalina/src/share/org/apache/catalina/servlets
DefaultServlet.java
Log:
- Normalizing the path here seems useless (note: this cannot cause any
security issues). If the path needs to be normalized during request dispatching,
then it should be done in the request dispatcher itself, not here (please send a
test case
where it breaks if there's a problem - or better, add one in the tester - so that
I can fix it).
Revision ChangesPath
1.16 +5 -5
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java
Index: DefaultServlet.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- DefaultServlet.java 29 Jul 2003 12:19:06 - 1.15
+++ DefaultServlet.java 29 Jul 2003 14:23:35 - 1.16
@@ -487,7 +487,7 @@
if ((result == null) || (result.equals())) {
result = /;
}
-return normalize(result);
+return (result);
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteAdapter.java
remm2003/07/29 07:24:27
Modified:catalina/src/share/org/apache/coyote/tomcat5
CoyoteAdapter.java
Log:
- Fix normalization bug.
Revision ChangesPath
1.10 +9 -7
jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteAdapter.java
Index: CoyoteAdapter.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteAdapter.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- CoyoteAdapter.java22 Jul 2003 21:02:07 - 1.9
+++ CoyoteAdapter.java29 Jul 2003 14:24:27 - 1.10
@@ -507,9 +507,11 @@
// Replace // with /
for (pos = start; pos (end - 1); pos++) {
-if ((b[pos] == (byte) '/') (b[pos + 1] == (byte) '/')) {
-copyBytes(b, pos, pos + 1, end - pos - 1);
-end--;
+if (b[pos] == (byte) '/') {
+while ((pos + 1 end) (b[pos + 1] == (byte) '/')) {
+copyBytes(b, pos, pos + 1, end - pos - 1);
+end--;
+}
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21967] New: - Custom tags defining scripting variables but not always
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21967.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21967
Custom tags defining scripting variables but not always
Summary: Custom tags defining scripting variables but not always
Product: Tomcat 4
Version: 4.1.24
Platform: PC
OS/Version: Windows NT/2K
Status: NEW
Severity: Normal
Priority: Other
Component: Jasper 2
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
When i have a tag defining scripting variables in my Jsp. If i choose to declare
with TagExtraInfo class this variable always this way :
public class FunctionTEI extends TagExtraInfo {
public VariableInfo[] getVariableInfo(TagData data) {
if (data.getId() != null)
return new VariableInfo[] {
new VariableInfo(
data.getId(),
String,
true, // ALWAYS TRUE !! SO IT SHOULD ALWAYS BE DECLARED ?!
VariableInfo.AT_BEGIN
)
};
return null;
}
}
Suppose we associate it with the function tag :
Then i suppose that two calls of the tag will declare twice my variables !
But this is not true.
ex1:
---
pref:mytag id=var value=ok /
pref:mytag id=var value=nok /
%= var %
This makes no compilation error and returns this result :
nok
ex2:
---
% int i = 0;
if (i = 0) { %
pref:mytag id=var value=ok /
%= var %
% } else { %
pref:mytag id=var value=nok /
%= var % This generate the error.
% } %
-
This makes a compilation error !
cannot resolve symbol var
This is due to the fact that var is not being declared in the else condition
whereas it is in the first condition.
For me example 1 should throws an error because 'var' has been already declared,
whereas example 2 should work because i declared in separate scope of the code
my 'var'.
However the behaviour is not well defined in JSP 1.2 but
jsp:useBean id=var class=String /
jsp:useBean id=var class=String /
Generates an error !) so i think custom tags defining scripting varibales should
be consistent with this behaviour.
The error is during translation not compilation.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21968] New: - jk2 connector build problem
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21968. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21968 jk2 connector build problem Summary: jk2 connector build problem Product: Tomcat 4 Version: 4.1.9 Platform: PC OS/Version: Linux Status: NEW Severity: Normal Priority: Other Component: Connector:Other AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Trying to build jakarta-tomcat-connectors-jk2-2.0.2-src jk2 connectors for apache2 using apxs2-prefork and ./configure is a bit confusing. using: make jk2-build-apxs I didn't locate mod_jk2.so until I found it in ./server/apache2/.libs. For some reason it is not copied to a more visible location. System: SuSE Linux 8.1 with apache 2.0.46 and tomcat 4.1.24. A pointer in the documentation or in the download to the build procedure would be helpful (or perhaps I failed to find it). - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21970] New: - URL's referencing directories without trailing slash redirected to ROOT context
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21970. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21970 URL's referencing directories without trailing slash redirected to ROOT context Summary: URL's referencing directories without trailing slash redirected to ROOT context Product: Tomcat 5 Version: 5.0.5 Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Given a typed URL such as: http://localhost:8080/tomcat-docs/appdev Expected redirection: http://localhost:8080/tomcat-docs/appdev/ Actual redirection: http://localhost:8080/appdev/ The context is being stripped off upon redirection. Jake - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21970] - URL's referencing directories without trailing slash redirected to ROOT context
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21970. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21970 URL's referencing directories without trailing slash redirected to ROOT context [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-07-29 15:16 --- I suppose it's easier to file the bug after seeing the corresponding commit. remm2003/07/29 05:15:47 Modified:util/java/org/apache/tomcat/util/http/mapper Mapper.java Log: - Fix a bug redirecting to a folder: the context path was lost. (ex: /tomcat-docs/images - /tomcat-docs/images/ - previsouly, it would get redirected to /images) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5 build.xml
remm2003/07/29 08:14:40
Modified:.build.xml
Log:
- Copy jk2.properties to conf.
Revision ChangesPath
1.146 +4 -0 jakarta-tomcat-5/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-5/build.xml,v
retrieving revision 1.145
retrieving revision 1.146
diff -u -r1.145 -r1.146
--- build.xml 23 Jul 2003 18:31:05 - 1.145
+++ build.xml 29 Jul 2003 15:14:39 - 1.146
@@ -201,6 +201,10 @@
property name=tomcat-jni.jar
value=${tomcat.build}/server/lib/tomcat-jni.jar /
/ant
+
+copy file=${jtc.home}/jk/conf/jk2.properties
+todir=${tomcat.build}/conf /
+
/target
target name=build-tomcatcoyote
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/conf server.xml
remm2003/07/29 08:26:44 Modified:catalina/src/conf server.xml Log: - Some JK parameters should be configured in jk2.properties. Revision ChangesPath 1.20 +1 -3 jakarta-tomcat-catalina/catalina/src/conf/server.xml Index: server.xml === RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/conf/server.xml,v retrieving revision 1.19 retrieving revision 1.20 diff -u -r1.19 -r1.20 --- server.xml28 Jul 2003 15:50:37 - 1.19 +++ server.xml29 Jul 2003 15:26:43 - 1.20 @@ -107,9 +107,7 @@ !-- Define a Coyote/JK2 AJP 1.3 Connector on port 8009 -- Connector port=8009 - maxThreads=100 minSpareThreads=1 maxSpareThreads=10 - enableLookups=false redirectPort=8443 - acceptCount=10 debug=0 + enableLookups=false redirectPort=8443 debug=0 protocol=AJP/1.3 / !-- Define a Proxied HTTP/1.1 Connector on port 8082 -- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5/resources/confinstall server_1.xml server_2.xml
remm2003/07/29 08:45:26 Modified:resources/confinstall server_1.xml server_2.xml Log: - Sync the server.xml used by the installer with the main one. (somebody please add a replace token feature in NSIS ;-) ) Revision ChangesPath 1.6 +3 -2 jakarta-tomcat-5/resources/confinstall/server_1.xml Index: server_1.xml === RCS file: /home/cvs/jakarta-tomcat-5/resources/confinstall/server_1.xml,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- server_1.xml 26 Jun 2003 00:11:14 - 1.5 +++ server_1.xml 29 Jul 2003 15:45:26 - 1.6 @@ -82,5 +82,6 @@ IP address of the remote client. -- -!-- Define a non-SSL Coyote HTTP/1.1 Connector on port 8081 -- -Connector className=org.apache.coyote.tomcat5.CoyoteConnector +!-- Define a non-SSL Coyote HTTP/1.1 Connector on the port specified + during installation -- +Connector 1.11 +120 -30 jakarta-tomcat-5/resources/confinstall/server_2.xml Index: server_2.xml === RCS file: /home/cvs/jakarta-tomcat-5/resources/confinstall/server_2.xml,v retrieving revision 1.10 retrieving revision 1.11 diff -u -r1.10 -r1.11 --- server_2.xml 26 Jun 2003 00:14:45 - 1.10 +++ server_2.xml 29 Jul 2003 15:45:26 - 1.11 @@ -1,35 +1,29 @@ - minProcessors=5 maxProcessors=100 - enableLookups=true redirectPort=8443 acceptCount=100 + maxThreads=150 minSpareThreads=25 maxSpareThreads=75 + enableLookups=false redirectPort=8443 acceptCount=100 debug=0 connectionTimeout=2 disableUploadTimeout=true / -!-- Note : To disable connection timeouts, set connectionTimeout value - to -1 -- !-- Define a SSL Coyote HTTP/1.1 Connector on port 8443 -- !-- -Connector className=org.apache.coyote.tomcat5.CoyoteConnector - port=8443 minProcessors=5 maxProcessors=75 - enableLookups=true disableUploadTimeout=true -acceptCount=100 debug=0 scheme=https secure=true - Factory className=org.apache.coyote.tomcat5.CoyoteServerSocketFactory - clientAuth=false protocol=TLS / +Connector port=8443 + maxThreads=150 minSpareThreads=25 maxSpareThreads=75 + enableLookups=false disableUploadTimeout=true + acceptCount=100 debug=0 scheme=https secure=true + Factory clientAuth=false protocol=TLS / /Connector -- !-- Define a Coyote/JK2 AJP 1.3 Connector on port 8009 -- -Connector className=org.apache.coyote.tomcat5.CoyoteConnector - port=8009 minProcessors=5 maxProcessors=75 - enableLookups=true redirectPort=8443 - acceptCount=10 debug=0 connectionTimeout=0 - useURIValidationHack=false - protocolHandlerClassName=org.apache.jk.server.JkCoyoteHandler/ +Connector port=8009 + enableLookups=false redirectPort=8443 debug=0 + protocol=AJP/1.3 / !-- Define a Proxied HTTP/1.1 Connector on port 8082 -- !-- See proxy documentation for more information about using this. -- !-- -Connector className=org.apache.coyote.tomcat5.CoyoteConnector - port=8082 minProcessors=5 maxProcessors=75 - enableLookups=true +Connector port=8082 + maxThreads=150 minSpareThreads=25 maxSpareThreads=75 + enableLookups=false acceptCount=100 debug=0 connectionTimeout=2 proxyPort=80 disableUploadTimeout=true / -- @@ -39,6 +33,10 @@ analyzes the HTTP headers included with the request, and passes them on to the appropriate Host (virtual host). -- +!-- You should set jvmRoute to support load-balancing via JK/JK2 ie : +Engine name=Standalone defaultHost=localhost debug=0 jmvRoute=jvm1 +-- + !-- Define the top level container in our container hierarchy -- Engine name=Catalina defaultHost=localhost debug=0 @@ -110,28 +108,120 @@ -- !-- Define the default virtual host -- - Host name=localhost debug=0 appBase=webapps + Host name=localhost debug=0 appBase=webapps unpackWARs=true autoDeploy=true !-- Add the following attributes if you want to turn XML validation on. Remember to comment the Host element above. - Note: XML Schema validation will work with Xerces 2.0.1 or + Note: XML Schema validationn will works with Xerces 2.0.1 or Xerces 2.1. Xerces 2.0.2 and
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java StandardWrapper.java
amyroh 2003/07/29 08:55:15
Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java StandardWrapper.java
Log:
Fix the obvious typos.
Revision ChangesPath
1.76 +3 -3
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java
Index: StandardContext.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
retrieving revision 1.75
retrieving revision 1.76
diff -u -r1.75 -r1.76
--- StandardContext.java 29 Jul 2003 00:09:42 - 1.75
+++ StandardContext.java 29 Jul 2003 15:55:15 - 1.76
@@ -4218,10 +4218,10 @@
// Notify our interested LifecycleListeners
lifecycle.fireLifecycleEvent(BEFORE_STOP_EVENT, null);
-// Send j2ee.state.stoping notification
+// Send j2ee.state.stopping notification
if (this.getObjectName() != null) {
Notification notification =
-new Notification(j2ee.state.stoping, this.getObjectName(),
+new Notification(j2ee.state.stopping, this.getObjectName(),
sequenceNumber++);
broadcaster.sendNotification(notification);
}
1.31 +7 -7
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapper.java
Index: StandardWrapper.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapper.java,v
retrieving revision 1.30
retrieving revision 1.31
diff -u -r1.30 -r1.31
--- StandardWrapper.java 29 Jul 2003 00:09:42 - 1.30
+++ StandardWrapper.java 29 Jul 2003 15:55:15 - 1.31
@@ -1567,10 +1567,10 @@
setAvailable(Long.MAX_VALUE);
-// Send j2ee.state.stoping notification
+// Send j2ee.state.stopping notification
if (this.getObjectName() != null) {
Notification notification =
-new Notification(j2ee.state.stoping, this.getObjectName(),
+new Notification(j2ee.state.stopping, this.getObjectName(),
sequenceNumber++);
broadcaster.sendNotification(notification);
}
@@ -1586,7 +1586,7 @@
// Shut down this component
super.stop();
-// Send j2ee.state.stopped notification
+// Send j2ee.state.stoppped notification
if (this.getObjectName() != null) {
Notification notification =
new Notification(j2ee.state.stopped, this.getObjectName(),
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteConnector.java
remm2003/07/29 09:29:57
Modified:catalina/src/share/org/apache/coyote/tomcat5
CoyoteConnector.java
Log:
- Remove some apparently unneeded fields.
Revision ChangesPath
1.17 +1 -23
jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteConnector.java
Index: CoyoteConnector.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteConnector.java,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -r1.16 -r1.17
--- CoyoteConnector.java 28 Jul 2003 11:19:11 - 1.16
+++ CoyoteConnector.java 29 Jul 2003 16:29:57 - 1.17
@@ -159,18 +159,6 @@
/**
- * The set of processors that have ever been created.
- */
-private Vector created = new Vector();
-
-
-/**
- * The current number of processors that have been created.
- */
-private int curProcessors = 0;
-
-
-/**
* The debugging detail level for this component.
*/
private int debug = 0;
@@ -648,16 +636,6 @@
public void setContainer(Container container) {
this.container = container;
-
-}
-
-
-/**
- * Return the current number of processors that have been created.
- */
-public int getCurProcessors() {
-
-return (curProcessors);
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/webapps/docs/config coyote.xml jk2.xml
remm2003/07/29 09:40:37 Modified:webapps/docs/config coyote.xml jk2.xml Log: - Update the connectors documentation. Revision ChangesPath 1.6 +26 -12jakarta-tomcat-catalina/webapps/docs/config/coyote.xml Index: coyote.xml === RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/config/coyote.xml,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- coyote.xml10 Feb 2003 19:36:44 - 1.5 +++ coyote.xml29 Jul 2003 16:40:36 - 1.6 @@ -56,12 +56,6 @@ attributes -attribute name=className required=true - pJava class name of the implementation to use. This class must - implement the codeorg.apache.catalina.Connector/code interface. - You must specify the standard value defined below./p -/attribute - attribute name=enableLookups required=false pSet to codetrue/code if you want calls to coderequest.getRemoteHost()/code to perform DNS lookups in @@ -166,18 +160,33 @@ this attribute is set to false./p /attribute -attribute name=maxProcessors required=false +attribute name=maxKeepAliveRequests required=false + pThe maximum number of HTTP requests which can be pipelined until + the connection is closed by the server. Setting this attribute to 1 will + disable HTTP/1.0 keep-alive, as well as HTTP/1.1 keep-alive and + pipelining. If + not specified, this attribute is set to 100./p +/attribute + +attribute name=maxSpareThreads required=false + pThe maximum number of unused request processing threads that + will be allowed to exist until the thread pool starts stopping the + unnecessary threads. The default value is 50./p +/attribute + +attribute name=maxThreads required=false pThe maximum number of request processing threads to be created by this strongConnector/strong, which therefore determines the maximum number of simultaneous requests that can be handled. If - not specified, this attribute is set to 20./p + not specified, this attribute is set to 200./p /attribute -attribute name=minProcessors required=false +attribute name=minSpareThreads required=false pThe number of request processing threads that will be created - when this strongConnector/strong is first started. This - attribute should be set to a value smaller than that set for - codemaxProcessors/code. The default value is 5./p + when this strongConnector/strong is first started. The connector + will also make sure it has the specified number of idle processing + threads available. This attribute should be set to a value smaller + than that set for codemaxThreads/code. The default value is 4./p /attribute attribute name=port required=true @@ -185,6 +194,11 @@ will create a server socket and await incoming connections. Your operating system will allow only one server application to listen to a particular port number on a particular IP address./p +/attribute + +attribute name=protocol required=false + pThis attribute value must be codeHTTP/1.1/code to use the HTTP + handler, which is the default./p /attribute attribute name=proxyName required=false 1.6 +6 -39 jakarta-tomcat-catalina/webapps/docs/config/jk2.xml Index: jk2.xml === RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/config/jk2.xml,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- jk2.xml 28 Jan 2003 18:24:42 - 1.5 +++ jk2.xml 29 Jul 2003 16:40:36 - 1.6 @@ -22,12 +22,7 @@ where you wish to invisibly integrate Tomcat 5 into an existing (or new) Apache installation, and you want Apache to handle the static content contained in the web application, and/or utilize Apache's SSL - processing. In many application environments, this will result in - better overall performance than running your applications under - Tomcat stand-alone using the a href=http11.htmlHTTP/1.1 Connector/a. - However, the only way to know for sure whether it will provide better - performance for strongyour/strong application is to try it both - ways./p + processing./p pThis connector supports load balancing when used in conjunction with the codejvmRoute/code attribute of the @@ -45,12 +40,6 @@ attributes -attribute name=className required=true - pJava class name of the implementation to use. This class must - implement the codeorg.apache.catalina.Connector/code interface. - You must specify the
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/coreContainerBase.java StandardContext.java StandardWrapper.java
[EMAIL PROTECTED] wrote: amyroh 2003/07/28 17:09:43 Modified:catalina/src/share/org/apache/catalina/core ContainerBase.java StandardContext.java StandardWrapper.java Log: Send JSR77 spec required notifications for J2EE mbeans. I like that feature, BTW (wether or not it is part of a spec). Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
SVG logo
Hi, Is there a Tomcat SVG logo somewhere ? (or a vector format which could be converted to SVG) I don't have any particular urgent need for it, but it could be useful eventually. Thanks, Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util TomcatCSS.java
remm2003/07/29 10:18:57
Modified:catalina/src/share/org/apache/catalina/util TomcatCSS.java
Log:
- The text was too small. (I think the style is rather ugly and probably getting
worse;
anyone with some artistic talent, please save me ;-) )
Revision ChangesPath
1.2 +7 -7
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util/TomcatCSS.java
Index: TomcatCSS.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util/TomcatCSS.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- TomcatCSS.java29 Jul 2003 12:19:06 - 1.1
+++ TomcatCSS.java29 Jul 2003 17:18:57 - 1.2
@@ -68,13 +68,13 @@
public class TomcatCSS {
public static final String TOMCAT_CSS =
-H1
{font-family:Tahoma,Arial,sans-serif;color:white;background-color:#D2A41C;font-size:20px;}
+
-H2
{font-family:Tahoma,Arial,sans-serif;color:white;background-color:#D2A41C;font-size:14px;}
+
-H3
{font-family:Tahoma,Arial,sans-serif;color:white;background-color:#D2A41C;font-size:12px;}
+
+H1
{font-family:Tahoma,Arial,sans-serif;color:white;background-color:#D2A41C;font-size:22px;}
+
+H2
{font-family:Tahoma,Arial,sans-serif;color:white;background-color:#D2A41C;font-size:16px;}
+
+H3
{font-family:Tahoma,Arial,sans-serif;color:white;background-color:#D2A41C;font-size:14px;}
+
BODY
{font-family:Tahoma,Arial,sans-serif;color:black;background-color:white;} +
B
{font-family:Tahoma,Arial,sans-serif;color:white;background-color:#D2A41C;} +
P
{font-family:Tahoma,Arial,sans-serif;background:white;color:black;font-size:12px;} +
-A{color : black;} +
+A {color : black;} +
HR {color : #D2A41C;};
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteAdapter.java
remm2003/07/29 10:19:29
Modified:coyote/src/java/org/apache/coyote/tomcat4 Tag: coyote_10
CoyoteAdapter.java
Log:
- Port patch.
Revision ChangesPath
No revision
No revision
1.13.2.5 +9 -7
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteAdapter.java
Index: CoyoteAdapter.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteAdapter.java,v
retrieving revision 1.13.2.4
retrieving revision 1.13.2.5
diff -u -r1.13.2.4 -r1.13.2.5
--- CoyoteAdapter.java23 Mar 2003 09:04:06 - 1.13.2.4
+++ CoyoteAdapter.java29 Jul 2003 17:19:29 - 1.13.2.5
@@ -549,9 +549,11 @@
// Replace // with /
for (pos = start; pos (end - 1); pos++) {
-if ((b[pos] == (byte) '/') (b[pos + 1] == (byte) '/')) {
-copyBytes(b, pos, pos + 1, end - pos - 1);
-end--;
+if (b[pos] == (byte) '/') {
+while ((pos + 1 end) (b[pos + 1] == (byte) '/')) {
+copyBytes(b, pos, pos + 1, end - pos - 1);
+end--;
+}
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
RE: SVG logo
Remy If no-one has a Vector or SVG format of the logo, I will gladly recreate the logo in Vector format as well as SVG. Let me know Kind Regards Schalk Neethling Volume4.Development.Multimedia.Branding emotionalize.conceptualize.visualize.realize Tel: +27125468436 Fax: +27125468436 email:[EMAIL PROTECTED] web: www.volume4.co.za :: -Original Message- :: From: Remy Maucherat [mailto:[EMAIL PROTECTED] :: Sent: Tuesday, July 29, 2003 6:50 PM :: To: Tomcat Developers List :: Subject: SVG logo :: :: Hi, :: :: Is there a Tomcat SVG logo somewhere ? (or a vector format which could :: be converted to SVG) :: I don't have any particular urgent need for it, but it could be useful :: eventually. :: :: Thanks, :: Remy :: :: :: :: - :: To unsubscribe, e-mail: [EMAIL PROTECTED] :: For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit:jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/coreContainerBase.java StandardContext.java StandardWrapper.java
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: amyroh 2003/07/28 17:09:43 Modified:catalina/src/share/org/apache/catalina/core ContainerBase.java StandardContext.java StandardWrapper.java Log: Send JSR77 spec required notifications for J2EE mbeans. I like that feature, BTW (wether or not it is part of a spec). Thanks for catching the typos. :-) Amy Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: securityManager in JasperLoader.java
Hi Jean-Frederic,
the current source have:
int dot = name.lastIndexOf('.');
if (securityManager != null) {
if (dot = 0) {
try {
// Do not call the security manager since by
default, we grant that package.
if
(!org.apache.jasper.runtime.equalsIgnoreCase(name.substring(0,dot))){
securityManager.checkPackageAccess(name.substring(0,dot));
}
} catch (SecurityException se) {
which is the correct way, althrough
int dot = name.lastIndexOf('.');
should be moved to be inside the if, because dot is not used outside
of it.
Thanks,
-- Jeanfrancois
jean-frederic clere wrote:
Hi,
One of my colleague has problems in JasperLoader.java: The
System.getSecurityManager() is null when creating the class but not
null later on.
Why do we have the following code? (from
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JasperLoader.java):
+++
if (System.getSecurityManager() != null) {
if (dot = 0) {
try {
securityManager.checkPackageAccess(name.substring(0,dot));
} catch (SecurityException se) {
String error = Security Violation, attempt to use
+
Restricted Class: + name;
System.out.println(error);
throw new ClassNotFoundException(error);
}
}
}
+++
We test System.getSecurityManager() but use securityManager!
Cheers
Jean-Frederic
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21978] New: - Certain tag file pathnames lead to compile errors
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21978. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21978 Certain tag file pathnames lead to compile errors Summary: Certain tag file pathnames lead to compile errors Product: Tomcat 5 Version: Nightly Build Platform: All OS/Version: All Status: NEW Severity: Minor Priority: Other Component: Jasper2 AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Tomcat can't compile certain tag files: 1) Tag files whose relative pathname contains a component (one of the directories, or the filename without the .tag suffix) which is not a legal Java identifier. Tomcat converts the relative pathname to a fully-qualified class name, and if the parts aren't all legal Java identifiers, the Java compiler will throw an error. 2) Tag files in /some_directories/immediate_parent_directory/ when there's a tag file in /some_directories/ with filename immediate_parent_directory.tag. Here the problem is that the package of the tag files in /some_directories/immediate_parent_directory/ clashes with the class of the immediate_parent_directory.tag tag file. For instance, the tag file /WEB-INF/tags/foo/bar.tag will have package name org.apache.jsp.tag.web.foo, which conflicts with the fully-qualified class name of the tag file /WEB-INF/tags/foo.tag. I will attach a patch that fixes this. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21978] - Certain tag file pathnames lead to compile errors
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21978. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21978 Certain tag file pathnames lead to compile errors --- Additional Comments From [EMAIL PROTECTED] 2003-07-29 18:45 --- Created an attachment (id=7563) Proposed patch - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21978] - Certain tag file pathnames lead to compile errors
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21978. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21978 Certain tag file pathnames lead to compile errors [EMAIL PROTECTED] changed: What|Removed |Added Keywords||PatchAvailable - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java
remm2003/07/29 11:53:20
Modified:http11/src/java/org/apache/coyote/http11
Http11Processor.java
Log:
- Reduce timeout and disable keepalive when the server starts running out
or processors (of course, if servlet processing times are too long, or is under
a DoS attack, it might still run out of processors).
- The policy is really simple, and could obviously be tweaked (and a flag can
be added to make it optional, etc).
Revision ChangesPath
1.72 +10 -0
jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Processor.java
Index: Http11Processor.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Processor.java,v
retrieving revision 1.71
retrieving revision 1.72
diff -u -r1.71 -r1.72
--- Http11Processor.java 13 Jul 2003 21:52:05 - 1.71
+++ Http11Processor.java 29 Jul 2003 18:53:20 - 1.72
@@ -589,6 +589,16 @@
int keepAliveLeft = maxKeepAliveRequests;
int soTimeout = socket.getSoTimeout();
+float threadRatio =
+(float) threadPool.getCurrentThreadsBusy()
+/ (float) threadPool.getMaxThreads();
+if ((threadRatio 0.33) (threadRatio = 0.66)) {
+soTimeout = soTimeout / 5;
+} else if (threadRatio 0.66) {
+soTimeout = soTimeout / 10;
+keepAliveLeft = 1;
+}
+
boolean keptAlive = false;
while (started !error keepAlive) {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 12183] - Setting unpack WARs flag not recognized after using Admintool
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12183. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12183 Setting unpack WARs flag not recognized after using Admintool --- Additional Comments From [EMAIL PROTECTED] 2003-07-29 19:02 --- Tomcat does not extract war file contents which are mentioned in server.xml. For example, add Context path=/SEA docBase=SEA debug=0/ in server.xml. Even unpackWars is still set to true, SEA.WAR won't be unpacked anymore. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler JspUtil.java
kinman 2003/07/29 16:22:23
Modified:jasper2/src/share/org/apache/jasper
JspCompilationContext.java
jasper2/src/share/org/apache/jasper/compiler JspUtil.java
Log:
- Fix bug 21978: Certain tag file pathnames lead to compile errors
Patch submitted by [EMAIL PROTECTED] (Eric Carmichael), with my
added check for Java keywords in package names.
Revision ChangesPath
1.41 +20 -78
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspCompilationContext.java
Index: JspCompilationContext.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspCompilationContext.java,v
retrieving revision 1.40
retrieving revision 1.41
diff -u -r1.40 -r1.41
--- JspCompilationContext.java21 May 2003 18:09:33 - 1.40
+++ JspCompilationContext.java29 Jul 2003 23:22:23 - 1.41
@@ -61,19 +61,24 @@
package org.apache.jasper;
-import java.io.*;
-import java.net.*;
-import java.util.*;
-import java.util.jar.JarFile;
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.net.MalformedURLException;
+import java.net.URL;
+import java.net.URLClassLoader;
+import java.util.Hashtable;
+import java.util.Set;
+
import javax.servlet.ServletContext;
import javax.servlet.jsp.tagext.TagInfo;
-import javax.servlet.jsp.tagext.TagData;
-import org.apache.jasper.compiler.JspRuntimeContext;
-import org.apache.jasper.compiler.ServletWriter;
+
import org.apache.jasper.compiler.Compiler;
+import org.apache.jasper.compiler.JspRuntimeContext;
+import org.apache.jasper.compiler.JspUtil;
import org.apache.jasper.compiler.Localizer;
-import org.apache.jasper.servlet.JspServletWrapper;
+import org.apache.jasper.compiler.ServletWriter;
import org.apache.jasper.servlet.JasperLoader;
+import org.apache.jasper.servlet.JspServletWrapper;
/**
* A place holder for various things that are used through out the JSP
@@ -128,19 +133,6 @@
private TagInfo tagInfo;
private URL tagFileJarUrl;
-private static final String javaKeywords[] = {
-abstract, boolean, break, byte, case,
-catch, char, class, const, continue,
-default, do, double, else, extends,
-final, finally, float, for, goto,
-if, implements, import, instanceof, int,
-interface, long, native, new, package,
-private, protected, public, return, short,
-static, strictfp, super, switch, synchronized,
-this, throws, transient, try, void,
-volatile, while };
-
-
// jspURI _must_ be relative to the context
public JspCompilationContext(String jspUri,
boolean isErrPage,
@@ -343,25 +335,8 @@
}
} else {
int iSep = jspUri.lastIndexOf('/') + 1;
-int iEnd = jspUri.length();
-StringBuffer modifiedClassName =
-new StringBuffer(jspUri.length() - iSep);
-if (!Character.isJavaIdentifierStart(jspUri.charAt(iSep))) {
-modifiedClassName.append('_');
-}
-for (int i = iSep; i iEnd; i++) {
-char ch = jspUri.charAt(i);
-if (Character.isJavaIdentifierPart(ch) ch != '_') {
-modifiedClassName.append(ch);
-} else if (ch == '.') {
-modifiedClassName.append('_');
-} else {
-modifiedClassName.append(mangleChar(ch));
-}
-}
-className = modifiedClassName.toString();
+className = JspUtil.makeJavaIdentifier(jspUri.substring(iSep));
}
-
return className;
}
@@ -436,17 +411,17 @@
if (Character.isJavaIdentifierPart(ch) ch != '_') {
modifiedPackageName.append(ch);
} else if (ch == '/') {
-if (isJavaKeyword(jspUri.substring(nameStart, i))) {
+if (JspUtil.isJavaKeyword(jspUri.substring(nameStart, i))) {
modifiedPackageName.append('_');
}
nameStart = i+1;
modifiedPackageName.append('.');
} else {
-modifiedPackageName.append(mangleChar(ch));
+modifiedPackageName.append(JspUtil.mangleChar(ch));
}
}
if (nameStart iSep
- isJavaKeyword(jspUri.substring(nameStart, iSep))) {
+ JspUtil.isJavaKeyword(jspUri.substring(nameStart, iSep))) {
modifiedPackageName.append('_');
}
DO NOT REPLY [Bug 21978] - Certain tag file pathnames lead to compile errors
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21978. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21978 Certain tag file pathnames lead to compile errors [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-07-29 23:26 --- Patch applied. I also added checks for Java keywords in the package names. Thanks. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/authenticator SingleSignOn.java
jfarcand2003/07/29 16:59:55
Modified:catalina/src/share/org/apache/catalina/authenticator
SingleSignOn.java
Log:
Make those methods protected so it is possible to extend that class and have a
customized version. There is no security issue since the package protection mechanism
doesn't allow access to those methods.
Revision ChangesPath
1.5 +12 -12
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/authenticator/SingleSignOn.java
Index: SingleSignOn.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/authenticator/SingleSignOn.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- SingleSignOn.java 24 Aug 2002 00:17:22 - 1.4
+++ SingleSignOn.java 29 Jul 2003 23:59:55 - 1.5
@@ -418,10 +418,10 @@
public String toString() {
StringBuffer sb = new StringBuffer(SingleSignOn[);
- if (container == null )
- sb.append(Container is null);
- else
- sb.append(container.getName());
+if (container == null )
+sb.append(Container is null);
+else
+sb.append(container.getName());
sb.append(]);
return (sb.toString());
@@ -438,7 +438,7 @@
* @param ssoId Single sign on identifier
* @param session Session to be associated
*/
-void associate(String ssoId, Session session) {
+protected void associate(String ssoId, Session session) {
if (debug = 1)
log(Associate sso id + ssoId + with session + session);
@@ -459,7 +459,7 @@
* @param ssoId Single sign on identifier
* @param session Session to be deregistered
*/
-private void deregister(String ssoId, Session session) {
+protected void deregister(String ssoId, Session session) {
synchronized (reverse) {
reverse.remove(session);
@@ -488,7 +488,7 @@
*
* @param ssoId Single sign on identifier to deregister
*/
-private void deregister(String ssoId) {
+protected void deregister(String ssoId) {
if (debug = 1)
log(Deregistering sso id ' + ssoId + ');
@@ -533,7 +533,7 @@
* @param username Username used to authenticate this user
* @param password Password used to authenticate this user
*/
-void register(String ssoId, Principal principal, String authType,
+protected void register(String ssoId, Principal principal, String authType,
String username, String password) {
if (debug = 1)
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21807] - Tomcat doesn't find JSTL .jar files in shared/lib/
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21807. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21807 Tomcat doesn't find JSTL .jar files in shared/lib/ [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2003-07-30 00:21 --- The Spec actually only requires that a taglib jar be placed under WEB-INF/lib. However, there has been some requests for sharing taglibs among web apps and changes were made in Tomcat 5 to also look for taglibs in the paths of the parent classloaders. There is currently no plans to port such changes to TC4, for stability reasons. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Tomcat under load problems - Use 'java -Xss' to increase default stack size
Hi - My apologies for posting on this but we really need some help on this. We have seen this problem showing up on Tomcat 4.1.24 (/JDK 1.4.2 from Sun/Linux) after running tomcat for a few hours. Fatal: Stack size too small. Use 'java -Xss' to increase default stack size. We have set the stack size to 1024k (and also 1536k) and we still get this error. Heap size is -Xms/Xmx 1.5 Gb. We are running RedHat 8.x (Linux 2.4.18-19.8.0smp #1 SMP Thu Dec 12 04:36:25 EST 2002 i686 i686 i386 GNU/Linu) Not sure if this is an application bug (recursion) or something to do with Tomcat. There is no other error message/exception in any of the tomcat log files. Is there a way to track this down by enabling verbose Tomcat logging ? Any pointers will be *very, very* helpful Thanks S Rau __ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21983] New: - Coyote JK2 connector ignores Accept count property
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21983.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21983
Coyote JK2 connector ignores Accept count property
Summary: Coyote JK2 connector ignores Accept count property
Product: Tomcat 4
Version: 4.1.24
Platform: Other
OS/Version: Other
Status: NEW
Severity: Major
Priority: Other
Component: Connector:Coyote JK 2
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
Coyote JK2 does not support accept count as documented in
http://jakarta.apache.org/tomcat/tomcat-4.1-doc/config/jk2.html
My observation is that once all the threads are busy processing request -
incoming requests are dropped and not queued as one would expect after setting
the accept count value on the connector. This means that if I need to have 100
requests processed concurrently I need to make my connector use 100 threads
since there is no queueing of requests.
In file org.apache.jk.common.ChannelSocket (Line 320), in the init method I see
that the server socket is created with a Zero backlog in all cases, I think it
should have been created with the accept count value as the backlog.
for( int i=startPort; i=maxPort; i++ ) {
try {
sSocket=new ServerSocket( i, 0, inet );
port=i;
break;
} catch( IOException ex ) {
log.info(Port busy + i + + ex.toString());
continue;
}
}
This is unlike the coyote HTTP 1.1 connector where the server socket is created
with the accept count as the backlog.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21984] New: - Apache Tomcat hangs for long time and server error 500 if ..%5c.. is included in request URL
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21984. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21984 Apache Tomcat hangs for long time and server error 500 if ..%5c.. is included in request URL Summary: Apache Tomcat hangs for long time and server error 500 if ..%5c.. is included in request URL Product: Tomcat 4 Version: 4.1.24 Platform: PC URL: http://www.jsp-servlet.net/..%5c../index.jsp or http://www.jspwiki.org/..%5c../Wiki.jsp?page=About OS/Version: Linux Status: NEW Severity: Major Priority: Other Component: Unknown AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] The problem occurs if Tomcat is connected through Apache Web server. My server environemnt is Apache 2.0.46, both mod_jk and mod_jk2, and Tomcat 4.1.24. Also found error log in Apache error log, i.e. mod_jk: Error flushing However, using the same environment with Tomcat 4.0.6 does not found any problem. Also no problem if 4.1.24 is used in Standalone mode. The problem is critical if a web server forwards all requests to Tomcat to handle. The ..%5c.. requests are generated by CodeRed or others to infect IIS. However, since tomcat cannot handle ..%5c.. requests properly, Tomcat will die after many such requests are received. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server JkCoyoteHandler.java
billbarker2003/07/29 19:25:54
Modified:jk/java/org/apache/jk/server JkCoyoteHandler.java
Log:
Make certain that we tell Apache that we have finished with the request.
If the Adapter throws an exception before entering the Pipeline, we end up with both
Apache and Tomcat trying to read the Channel and hence not serving requests.
Reported By: [EMAIL PROTECTED] Kwan, Kenneth Y
Revision ChangesPath
1.42 +3 -0
jakarta-tomcat-connectors/jk/java/org/apache/jk/server/JkCoyoteHandler.java
Index: JkCoyoteHandler.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/jk/server/JkCoyoteHandler.java,v
retrieving revision 1.41
retrieving revision 1.42
diff -u -r1.41 -r1.42
--- JkCoyoteHandler.java 17 May 2003 03:21:33 - 1.41
+++ JkCoyoteHandler.java 30 Jul 2003 02:25:53 - 1.42
@@ -295,6 +295,9 @@
} catch( Exception ex ) {
ex.printStackTrace();
}
+if(ep.getStatus() != JK_STATUS_CLOSED) {
+res.finish();
+}
ep.setStatus( JK_STATUS_NEW );
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server JkCoyoteHandler.java
billbarker2003/07/29 19:27:02
Modified:jk/java/org/apache/jk/server Tag: coyote_10
JkCoyoteHandler.java
Log:
Port Patch.
Revision ChangesPath
No revision
No revision
1.32.2.3 +3 -0
jakarta-tomcat-connectors/jk/java/org/apache/jk/server/JkCoyoteHandler.java
Index: JkCoyoteHandler.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/jk/server/JkCoyoteHandler.java,v
retrieving revision 1.32.2.2
retrieving revision 1.32.2.3
diff -u -r1.32.2.2 -r1.32.2.3
--- JkCoyoteHandler.java 17 May 2003 03:27:36 - 1.32.2.2
+++ JkCoyoteHandler.java 30 Jul 2003 02:27:01 - 1.32.2.3
@@ -264,6 +264,9 @@
} catch( Exception ex ) {
ex.printStackTrace();
}
+if(ep.getStatus() != JK_STATUS_CLOSED) {
+res.finish();
+}
ep.setStatus( JK_STATUS_NEW );
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Tomcat under load problems - Use 'java -Xss' to increase defaultstack size
I have been running Tomcat in production on serveral Solaris servers with -Xss reduced down to 128K for years. This is for jdk 1.3.1. We have had no problems with exceeding the stack size. I am not familiar enough with linux to get very specific. First thing is to see if it is application related. Try load testing Tomcat using some example applications to see if it still has stack problems. If there are no problems, then use OptimizeIt or JProbe to profile your application. That may give you some hints at what to look at. Is Tomcat being run as the http server or do you have it behind apache so apache can serve static content? You might try switching JVM's to see if that changes anything. Just a few stabs in the dark. Others who use linux may have more specific ideas on how to troubleshoot this. Regards, Glenn Rau NF wrote: Hi - My apologies for posting on this but we really need some help on this. We have seen this problem showing up on Tomcat 4.1.24 (/JDK 1.4.2 from Sun/Linux) after running tomcat for a few hours. Fatal: Stack size too small. Use 'java -Xss' to increase default stack size. We have set the stack size to 1024k (and also 1536k) and we still get this error. Heap size is -Xms/Xmx 1.5 Gb. We are running RedHat 8.x (Linux 2.4.18-19.8.0smp #1 SMP Thu Dec 12 04:36:25 EST 2002 i686 i686 i386 GNU/Linu) Not sure if this is an application bug (recursion) or something to do with Tomcat. There is no other error message/exception in any of the tomcat log files. Is there a way to track this down by enabling verbose Tomcat logging ? Any pointers will be *very, very* helpful Thanks S Rau __ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21978] - Certain tag file pathnames lead to compile errors
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21978. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21978 Certain tag file pathnames lead to compile errors [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Additional Comments From [EMAIL PROTECTED] 2003-07-30 02:51 --- Good catch on checking for Java keywords. That also makes it possible to refactor getDerivedPackageName and eliminate some duplicate code. I will attach a patch implementing this. No issues whatsoever with your commit fixing the bug I reported, so if you don't think the new patch makes the code cleaner, feel free to change this bug ticket back to Resolved/Fixed. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21978] - Certain tag file pathnames lead to compile errors
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21978. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21978 Certain tag file pathnames lead to compile errors --- Additional Comments From [EMAIL PROTECTED] 2003-07-30 02:52 --- Created an attachment (id=7574) Refactoring getDerivedPackageName() - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21983] - Coyote JK2 connector ignores Accept count property
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21983. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21983 Coyote JK2 connector ignores Accept count property [EMAIL PROTECTED] changed: What|Removed |Added Severity|Major |Minor --- Additional Comments From [EMAIL PROTECTED] 2003-07-30 03:24 --- Yes, it should allow you to set the acceptCount. However, the benefit of doing so is really really tiny. (I'm assuming the pre-fork MPM, because it is easier to explain: the other MPMs work similarly however.) What happens is that each Apache child is connected to a single Tomcat thread. When the Tomcat thread finishes the request, it won't go back to the ServerSocket: It will wait until it's Apache child sends it another request. The only thing that the acceptCount would help is the case where Apache suddenly needs to create a large number of new children (and even then, you'd probably need a pretty beefy box to see a failure). For what you want, you need to configure the backlog in Apache. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21984] - Apache Tomcat hangs for long time and server error 500 if ..%5c.. is included in request URL
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21984. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21984 Apache Tomcat hangs for long time and server error 500 if ..%5c.. is included in request URL [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-07-30 03:28 --- Fixed in the CVS, and will appear in 4.1.27. As a work-around, you can configure in httpd.conf: JkOptions ForwardURICompat Then Tomcat gets the un-escaped URI, which doesn't trigger the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21843] - error-page directive not working correctly for jsp compile exceptions
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21843. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21843 error-page directive not working correctly for jsp compile exceptions --- Additional Comments From [EMAIL PROTECTED] 2003-07-30 03:41 --- Also observed on Linux (RedHat 9.0) with Tomcat 4.1.24. JSP compile errors are printed directly to the output while other errors are correctly rendered by the error page. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0 RELEASE-NOTES-4.1.txt
billbarker2003/07/29 21:48:58 Modified:.RELEASE-NOTES-4.1.txt Log: Documenting patch Revision ChangesPath 1.78 +5 -1 jakarta-tomcat-4.0/RELEASE-NOTES-4.1.txt Index: RELEASE-NOTES-4.1.txt === RCS file: /home/cvs/jakarta-tomcat-4.0/RELEASE-NOTES-4.1.txt,v retrieving revision 1.77 retrieving revision 1.78 diff -u -r1.77 -r1.78 --- RELEASE-NOTES-4.1.txt 18 Jul 2003 07:35:57 - 1.77 +++ RELEASE-NOTES-4.1.txt 30 Jul 2003 04:48:58 - 1.78 @@ -986,6 +986,10 @@ Fix regression where connection is always dropped at the end of processing. +[4.1.27] #21984 + HandlerReqest: + Fix potential Dos condition when given a mal-formed URI. + Jasper Bug Fixes: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml
billbarker2003/07/29 21:55:37 Modified:webapps/docs changelog.xml Log: Documenting patch Revision ChangesPath 1.11 +4 -0 jakarta-tomcat-catalina/webapps/docs/changelog.xml Index: changelog.xml === RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v retrieving revision 1.10 retrieving revision 1.11 diff -u -r1.10 -r1.11 --- changelog.xml 25 Jul 2003 16:58:18 - 1.10 +++ changelog.xml 30 Jul 2003 04:55:37 - 1.11 @@ -812,6 +812,10 @@ scode Fix javadoc generation for the connectors (costin) /scode + fix + bug21984/bug: Fix potential DoS condition when processing a malformed + request URI using the Jk-Coyote Connector (billbarker) + /fix /changelog - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
