DO NOT REPLY [Bug 22328] - javax.management.ReflectionException: Cannot find method getClassName with this signature
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22328. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22328 javax.management.ReflectionException: Cannot find method getClassName with this signature [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-08-31 00:02 --- This is fixed and will be available in the next release. You can add missing className property for AccessLogValve mbean description as a patch. mbean name=AccessLogValve className=org.apache.catalina.mbeans.ClassNameMBean description=Valve that generates a web server access log domain=Catalina group=Valve type=org.apache.catalina.valves.AccessLogValve - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: DO NOT REPLY [Bug 22328] - javax.management.ReflectionException:Cannot find method getClassName with this signature
I have updated the bug report. Thanks for the reminder. Amy Tim Funk wrote: IIRC - I think Amy submitted a patch to fix this. Can I resolve this as fixed? -Tim - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: jk 1.2.5 and ipv6
Good morning. Found: intinet_pton( long af, const char *cp, void *ap ); in NetWare LibC...FWIW. Norm - Original Message - From: Henri Gomez [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Thursday, August 28, 2003 8:49 PM Subject: jk 1.2.5 and ipv6 Hi to all, Still working on finding why iSeries couldn't use Unix98 def in_addr_t. BTW, what about adding ipv6 support in jk_connect.c by using inet_pton instead of inet_addr ? I'd like to have replies from people who have differents OS to know if they have support for inet_pton... Regards - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [5] Infinite loop potential in processing error in StandardWrapperValve.java??
Tim Funk wrote:
When I added the code to use PropertyUtils.getProperty in determining
the root cause, I noticed it can cause an infinite loop.
// Extra aggressive rootCause finding
do {
try {
rootCauseCheck = (Throwable)PropertyUtils.getProperty
(rootCause, rootCause);
if (rootCauseCheck!=null)
rootCause = rootCauseCheck;
} catch (...) {
rootCauseCheck = null;
}
} while (rootCauseCheck != null);
--
If we have a malicious user who does this:
{
...
ServletException e = new ServletException();
throw new ServletException(e);
}
We can get a non-recursive infinite loop in the error handling logic.
Is this a cause for concern? I would guess so in shared environments but
this is not a problem in tightly controlled (enterprise/private)
environments.
Comments?
Yes, well, I had seen that flaw in the code. However, if there's a
malicious user out there, he can just add while (true) {
doSomethingStupid(); } in his code ;-) So I chose not to care about it.
Anyway, +1 to add a max recursion int (there are a few places that use
this type of code).
Remy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5 build.xml
remm2003/08/31 09:52:06
Modified:.build.xml
Log:
- Don't copy jmx-tools to embed.
Revision ChangesPath
1.155 +0 -1 jakarta-tomcat-5/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-5/build.xml,v
retrieving revision 1.154
retrieving revision 1.155
diff -u -r1.154 -r1.155
--- build.xml 30 Aug 2003 22:13:27 - 1.154
+++ build.xml 31 Aug 2003 16:52:05 - 1.155
@@ -612,7 +612,6 @@
copy todir=embed/lib file=${commons-beanutils.jar}/
copy todir=embed/lib file=${commons-collections.jar}/
copy todir=embed/lib file=${jmx.jar}/
-copy todir=embed/lib file=${jmx-tools.jar}/
copy todir=embed/lib
fileset dir=build/server/lib
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup SetDocBaseRule.java
remm2003/08/31 08:50:18
Modified:catalina/src/share/org/apache/catalina/startup
SetDocBaseRule.java
Log:
- Don't unpack if there's an overriding unpackWAR attribute on the context
itself. I plan to use this to run the tomcat-docs webapp from the WAR (it
simply uses too much HD space, and takes a while to unpack when
installing Tomcat, so I'll experiment with bundling it as a WAR).
Revision ChangesPath
1.5 +6 -3
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/SetDocBaseRule.java
Index: SetDocBaseRule.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/SetDocBaseRule.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- SetDocBaseRule.java 25 Jul 2003 16:43:53 - 1.4
+++ SetDocBaseRule.java 31 Aug 2003 15:50:18 - 1.5
@@ -133,6 +133,9 @@
if (!((StandardHost) host).isUnpackWARs()) {
return;
}
+if (false.equals(attributes.getValue(unpackWAR))) {
+return;
+}
File canonicalAppBase =
new File(System.getProperty(catalina.base), appBase)
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java
remm2003/08/31 08:51:14
Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java
Log:
- Add an unpackWAR field to allow saving the attribute to the XML.
Revision ChangesPath
1.87 +26 -1
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java
Index: StandardContext.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
retrieving revision 1.86
retrieving revision 1.87
diff -u -r1.86 -r1.87
--- StandardContext.java 21 Aug 2003 04:17:06 - 1.86
+++ StandardContext.java 31 Aug 2003 15:51:14 - 1.87
@@ -418,6 +418,12 @@
/**
+ * Unpack WAR property.
+ */
+private boolean unpackWAR = true;
+
+
+/**
* The DefaultContext override flag for this web application.
*/
private boolean override = false;
@@ -1394,6 +1400,25 @@
}
+
+/**
+ * Unpack WAR flag accessor.
+ */
+public boolean getUnpackWAR() {
+
+return (unpackWAR);
+
+}
+
+
+/**
+ * Unpack WAR flag mutator.
+ */
+public void setUnpackWAR(boolean unpackWAR) {
+
+this.unpackWAR = unpackWAR;
+
+}
/**
* Return the Java class name of the Wrapper implementation used
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Out of the office
I am out of the office until SEPT 4, 2003. I will deal with your message at that time. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardServer.java
remm2003/08/31 08:47:19
Modified:catalina/src/share/org/apache/catalina/core
StandardServer.java
Log:
- Don't save the config file attribute, as it is always useless (if read from the
config file, that means we know the config file path, obviously).
- Don't indent in context config files.
Revision ChangesPath
1.21 +7 -4
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardServer.java
Index: StandardServer.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardServer.java,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -r1.20 -r1.21
--- StandardServer.java 30 Aug 2003 18:19:38 - 1.20
+++ StandardServer.java 31 Aug 2003 15:47:19 - 1.21
@@ -163,6 +163,7 @@
{ org.apache.catalina.core.StandardEngine, domain },
{ org.apache.catalina.core.StandardHost, domain },
{ org.apache.catalina.core.StandardContext, available },
+{ org.apache.catalina.core.StandardContext, configFile },
{ org.apache.catalina.core.StandardContext, configured },
{ org.apache.catalina.core.StandardContext, distributable },
{ org.apache.catalina.core.StandardContext, domain },
@@ -1220,6 +1221,8 @@
}
throw (e);
}
+
+indent = 0;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22852] New: - JDK1.4 logging formatter class not being found
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22852. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22852 JDK1.4 logging formatter class not being found Summary: JDK1.4 logging formatter class not being found Product: Tomcat 4 Version: 4.0 Beta 1 Platform: PC OS/Version: Linux Status: NEW Severity: Normal Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I just upgraded from 4.1.24 to 4.1.27 and found that java now doesn't find my formatter class for JDK 1.4 logging. (Using 1.4.2) The configuration in the logging.properties file is picked up fine, I established since there are other formatter classes in JDK 1.4 which I have tested out and I can specify them and they work fine. So the problem is definitely that 4.1.27 is now mislaying the reference to my formatter class, presumably when it constructs the class path for java. Switching back to 4.1.24, it still works. I have the formatter class in tomcat's common/classes directory. I've tried placing my class in server/classes, in shared/classes and also in WEB-INF/classes for a particular webapp, with no joy. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler SmapStratum.java
ecarmich2003/08/30 20:46:29
Modified:jasper2/src/share/org/apache/jasper/compiler
SmapStratum.java
Log:
Don't combine LineInfos from different files
Revision ChangesPath
1.10 +4 -2
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/SmapStratum.java
Index: SmapStratum.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/SmapStratum.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- SmapStratum.java 30 Aug 2003 21:51:50 - 1.9
+++ SmapStratum.java 31 Aug 2003 03:46:29 - 1.10
@@ -216,7 +216,8 @@
while (i lineData.size() - 1) {
LineInfo li = (LineInfo)lineData.get(i);
LineInfo liNext = (LineInfo)lineData.get(i + 1);
-if (liNext.inputStartLine == li.inputStartLine
+if (!liNext.lineFileIDSet
+ liNext.inputStartLine == li.inputStartLine
liNext.inputLineCount == 1
li.inputLineCount == 1
liNext.outputStartLine
@@ -238,7 +239,8 @@
while (i lineData.size() - 1) {
LineInfo li = (LineInfo)lineData.get(i);
LineInfo liNext = (LineInfo)lineData.get(i + 1);
-if (liNext.inputStartLine == li.inputStartLine + li.inputLineCount
+if (!liNext.lineFileIDSet
+ liNext.inputStartLine == li.inputStartLine + li.inputLineCount
liNext.outputLineIncrement == li.outputLineIncrement
liNext.outputStartLine
== li.outputStartLine
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22848] - [PATCH] Fix typos/grammar in changelog.html
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22848. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22848 [PATCH] Fix typos/grammar in changelog.html --- Additional Comments From [EMAIL PROTECTED] 2003-08-31 12:33 --- Created an attachment (id=8013) Fix some typos in changelog.html - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startupSetDocBaseRule.java
[EMAIL PROTECTED] wrote: remm2003/08/31 08:50:18 Modified:catalina/src/share/org/apache/catalina/startup SetDocBaseRule.java Log: - Don't unpack if there's an overriding unpackWAR attribute on the context itself. I plan to use this to run the tomcat-docs webapp from the WAR (it simply uses too much HD space, and takes a while to unpack when installing Tomcat, so I'll experiment with bundling it as a WAR). I won't be doing that, BTW. It turns out it works great once TC is installed and it's a fancy setup (I put a META-INF/context.xml inside the .war telling TC not to unpack the WAR), but unfortunately, it makes the d/ls significantly bigger (a much as 3MB for the .exe distribution for Windows), so it's not a good tradeoff. I'll leave in the unpackWAR flag. It looks like a reasonably useful feature in some situations. Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Bug report for Tomcat 3 [2003/08/31]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=CriticalMAJ=Major | | | | MIN=Minor NOR=Normal ENH=Enhancement | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 258|Unc|Nor|2000-11-27|response.SendRedirect() resets/destroys Cookies th| | 2350|Ver|Nor|2001-06-27|ServletConfig.getInitParameter() requires url-patt| | 2478|Opn|Cri|2001-07-06|Passing Session variables between JSP's and Servle| | 4551|Opn|Nor|2001-10-31|Ctx( /tt01 ): IOException in: R( /tt01 + /com/abc/| | 4893|Unc|Blk|2001-11-15|Tomcat dies with following error..| | 4980|New|Min|2001-11-20|Startup message indicates incorrect log file | | 4994|New|Nor|2001-11-21|Tomcat needs a mechanism for clean and certain shu| | 5064|New|Cri|2001-11-25|Socket write error when include files is more than| | 5108|New|Maj|2001-11-26|Docs for Tomcat 3.2.x appear to be for Tomcat 3.3 | | 5137|New|Nor|2001-11-27|Null pointer in class loader after attempting to r| | 5160|Unc|Maj|2001-11-28|'IllegalStateException' | | 5331|New|Nor|2001-12-09|getPathInfo vs URL normalization | | 5510|New|Blk|2001-12-19|How to call ejb deployed in JBoss from Tomcat serv| | 5756|New|Nor|2002-01-08|jspc.bat exits with wrong ERRORLEVEL | | 5797|New|Nor|2002-01-10|UnCatched ? StringIndexOutOfBoundsException: Strin| | 6027|New|Maj|2002-01-25|Tomcat Automatically shuts down as service | | 6168|New|Blk|2002-02-01|IllegalStateException | | 6451|New|Cri|2002-02-14|Stackoverflow | | 6478|New|Enh|2002-02-14|Default Tomcat Encoding | | 6488|Ver|Maj|2002-02-15|Error: 304. Apparent bug in default ErrorHandler c| | 6648|New|Nor|2002-02-25|jakarta-servletapi build with java 1.4 javadoc err| | 6702|New|Cri|2002-02-27|win 2k services not working | | 6796|New|Cri|2002-03-01|Tomcat dies periodically | | 6989|New|Maj|2002-03-08|Unable to read tld file during parallel JSP compil| | 7008|Opn|Maj|2002-03-10|facade.HttpServletRequestFacade.getParameter(HttpS| | 7013|New|Cri|2002-03-10|Entering a servlet path with non-ISO8859-1 charact| | 7227|New|Nor|2002-03-19|error-code directive don't work | | 7236|New|Blk|2002-03-19|Permission denied to do thread.stop | | 7626|New|Nor|2002-03-29|classloader not working properly | | 7652|New|Cri|2002-04-01|Tomcat stalls periodically| | 7762|New|Enh|2002-04-05|stdout logfile handling | | 7785|New|Blk|2002-04-06|tomcat bug in context reloading | | 7789|New|Maj|2002-04-06|JSP Cookie Read/Write Fails With DNS Names| | 7863|New|Maj|2002-04-09|I have a problem when running Tomcat with IIS | | 8154|New|Nor|2002-04-16|logrotate script in RPM rotates non-existing file | | 8155|New|Nor|2002-04-16|Tomcat from RPM doesn't do logrotate | | 8187|New|Cri|2002-04-17|Errors when Tomcat used with MS Access database | | 8239|New|Cri|2002-04-18|Resource temporary unavailable| | 8263|New|Cri|2002-04-18|url-pattern easy to circumvent| | 8634|New|Nor|2002-04-30|no way to specify different modules.xml file | | 8992|New|Blk|2002-05-10|IE6/XP: Limitation of POST Area within HTTP reques| | 9086|New|Enh|2002-05-14|NPE org.apache.tomcat.core.ServerSession.setAttrib| | 9250|New|Maj|2002-05-20|outOfMemoryError | | 9362|New|Nor|2002-05-23|compiilation of JSP that includes a non-existant f| | 9367|New|Maj|2002-05-23|HttpSessionBindingEvent not thrown for HttpSession| | 9390|New|Nor|2002-05-24|jasper compilation error in tomcat| | 9480|New|Nor|2002-05-29|Data connection pooling | | 9607|New|Maj|2002-06-04|precompile JSP| | 9737|New|Nor|2002-06-10|ArrayIndexOutOfBoundsException when sending just p| |1|New|Cri|2002-06-19|IOException Broken Pipe when authenticating JDBCRe| |10039|New|Nor|2002-06-20|TimeStamp will not work correctly.|
DO NOT REPLY [Bug 22848] New: - [PATCH] Fix typos/grammar in changelog.html
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22848. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22848 [PATCH] Fix typos/grammar in changelog.html Summary: [PATCH] Fix typos/grammar in changelog.html Product: Tomcat 5 Version: Unknown Platform: Other URL: http://jakarta.apache.org/tomcat/tomcat-5.0- doc/changelog.html OS/Version: Other Status: NEW Severity: Enhancement Priority: Other Component: Webapps:Documentation AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Various minor grammar/spelling fixes, no content changes. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Bug report for Watchdog [2003/08/31]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=CriticalMAJ=Major | | | | MIN=Minor NOR=Normal ENH=Enhancement | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 278|Unc|Nor|2000-12-04|Bug in GetParameterValuesTestServlet.java file Bug| | 279|Unc|Nor|2000-12-04|Logical Error in GetParameterValuesTestServlet Bug| | 469|Unc|Nor|2001-01-17|in example-taglib.tld urn should be uri BugRat| | 470|Unc|Nor|2001-01-17|FAIL positiveForward.jsp and positiveInclude.jsp B| | 9634|New|Enh|2002-06-05|No tests exist for ServletContext.getResourcePaths| |10703|New|Enh|2002-07-11|Need to test getRequestURI after RequestDispatcher| |11336|New|Enh|2002-07-31|Test wrapped path methods with RD.foward()| |11663|New|Maj|2002-08-13|JSP precompile tests rely on Jasper specific behav| |11664|New|Maj|2002-08-13|A sweep is needed of all Watchdog 4.0 tag librarie| |11665|New|Maj|2002-08-13|ServletToJSPErrorPageTest and ServletToServletErro| |11666|New|Maj|2002-08-13|SetBufferSize_1TestServlet is invalid.| |14004|New|Maj|2002-10-28|Incorrent behaviour of all attribute-related lifec| |15504|New|Nor|2002-12-18|JSP positiveGetValues test relies on order preserv| +-+---+---+--+--+ | Total 13 bugs | +---+ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Bug report for Tomcat 4 [2003/08/31]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=CriticalMAJ=Major | | | | MIN=Minor NOR=Normal ENH=Enhancement | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 218|Unc|Nor|2000-11-02|IIS in-process tomcat BugRat Report#333 | | 3098|Opn|Maj|2001-08-11|RequestDispatcher on relative (to request path) | | 3614|Opn|Nor|2001-09-14|bug in manager webapp | | 3755|Opn|Nor|2001-09-20|freezes at shutdown | | 3888|Opn|Blk|2001-09-30|WebappClassLoader: Lifecycle error : CL stopped | | 4138|Opn|Nor|2001-10-12|Processor threads have inconsistent ClassLoader st| | 4350|Ass|Nor|2001-10-22|SSLAuthenticator did not associate SSO session| | 4352|Ass|Nor|2001-10-22|JDBCRealm does not work with CLIENT-CERT auth-meth| | 5329|New|Nor|2001-12-08|NT Service exits startup before Tomcat is finished| | 5598|Opn|Maj|2001-12-27|(JSP Problem) RequestDispatcher doesn't include HT| | 5704|Ass|Maj|2002-01-05|CgiServlet corrupting images? | | 5715|Opn|Nor|2002-01-07|response.setContentType() in Filter.doFilter not c| | 5759|Opn|Maj|2002-01-09|CGI servlet mapping by extension *.cgi does not wo| | 5762|Opn|Maj|2002-01-09|CGI servlet misses to include port number in HTTP_| | 5795|New|Enh|2002-01-10|Catalina Shutdown relies on localhost causing prob| | 5829|New|Enh|2002-01-13|StandardManager needs to cope with sessions throwi| | 5858|New|Enh|2002-01-15|Add tomcat dir to java.library.path | | 5952|Opn|Nor|2002-01-22|Refence to $JAVACMD in tomcat.conf incorrect in R| | 5985|New|Enh|2002-01-23|Tomcat should perform a more restrictive validatio| | 6218|Opn|Nor|2002-02-04|Relative links broken for servlets| | 6229|New|Enh|2002-02-04|Need way to specify where to write catalina.out | | 6399|New|Nor|2002-02-12|unknown protocol: https | | 6408|New|Enh|2002-02-12|Starting tomcat from a cygwin bash shell using 'st| | 6582|New|Min|2002-02-20|Sample code does not match behavior | | 6600|Opn|Enh|2002-02-20|enodeURL adds 'jsession' when 'isRequestedSessionI| | 6614|New|Enh|2002-02-21|Have Bootstrap and StandardClassLoader use the sam| | 6649|New|Nor|2002-02-25|jakarta-servletapi-4 build using java 1.4 javadoc | | 6659|New|Nor|2002-02-25|HttpUtils.getRequestURL gives incorrect URL with w| | 6671|New|Enh|2002-02-25|Simple custom tag example uses old declaration sty| | 7043|New|Enh|2002-03-12|database user and password for JDBC Based Store | | 7080|New|Maj|2002-03-13|Interbase JDBCRealm - Bug # 5564 - Have a safe fix| | 7190|New|Nor|2002-03-18|GenericServlet spurious log's in init(), destroy()| | 7207|New|Nor|2002-03-18|Redeployment Problem under Tomcat 4.0.2 | | 7360|New|Nor|2002-03-22|res-sharing-scope not supported | | 7366|New|Enh|2002-03-22|ISAPI Redirector Replacement | | 7374|New|Enh|2002-03-22|Apache Tomcat/4.0.1 message on standard output| | 7506|New|Nor|2002-03-27|Reading InputStream returned in the following sena| | 7571|New|Nor|2002-03-28|DataInputStream readLong() Problem| | 7588|New|Nor|2002-03-28|Session cannot be established if there are multipl| | 7676|New|Enh|2002-04-02|Allow name property to use match experssions in h| | 7689|New|Min|2002-04-02|Performance problem with Xerces parser| | 7702|New|Enh|2002-04-03|[PATCH] Speed up Tomcat a tiny bit| | 7723|New|Enh|2002-04-03|[patch] additional factory for org.apache.naming.f| | 7831|New|Nor|2002-04-08|[PATCH] JNDIRealm does not work with CLIENT-CERT a| | 7880|Ver|Cri|2002-04-09|If a TLV flags flags an error during the translati| | 8026|New|Enh|2002-04-12|Exceptions in StandardHostDeployer.addChild are lo| | 8079|New|Enh|2002-04-15|Tomcat cannot start if appBase directory is access| | 8100|New|Maj|2002-04-15|Session Tracking and HttpURLConnection| | 8200|New|Nor|2002-04-17|include (PageContext) does not throw IOException i| | 8217|New|Maj|2002-04-17|Documentation references workers. prefix| | 8275|Ver|Min|2002-04-18|ContextConfig.start() attempts to create a $CATALI| |
[5] Infinite loop potential in processing error in StandardWrapperValve.java??
When I added the code to use PropertyUtils.getProperty in determining the
root cause, I noticed it can cause an infinite loop.
// Extra aggressive rootCause finding
do {
try {
rootCauseCheck = (Throwable)PropertyUtils.getProperty
(rootCause, rootCause);
if (rootCauseCheck!=null)
rootCause = rootCauseCheck;
} catch (...) {
rootCauseCheck = null;
}
} while (rootCauseCheck != null);
--
If we have a malicious user who does this:
{
...
ServletException e = new ServletException();
throw new ServletException(e);
}
We can get a non-recursive infinite loop in the error handling logic.
Is this a cause for concern? I would guess so in shared environments but this
is not a problem in tightly controlled (enterprise/private) environments.
Comments?
-Tim
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/loader WebappClassLoader.java
remm2003/08/31 07:43:46 Modified:catalina/src/share/org/apache/catalina/loader WebappClassLoader.java Log: - Null out the reference to the resources. Revision ChangesPath 1.21 +2 -1 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/loader/WebappClassLoader.java Index: WebappClassLoader.java === RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/loader/WebappClassLoader.java,v retrieving revision 1.20 retrieving revision 1.21 diff -u -r1.20 -r1.21 --- WebappClassLoader.java29 Aug 2003 23:05:50 - 1.20 +++ WebappClassLoader.java31 Aug 2003 14:43:46 - 1.21 @@ -1513,6 +1513,7 @@ notFoundResources.clear(); resourceEntries.clear(); +resources = null; repositories = null; files = null; jarFiles = null; - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[PATCH] for bug 3098
A patch for the above is below. This patch addresses the issues raised by the
second test case attached to the bug report. The first test case was fixed
previously and the third test case works correctly with the current source.
I have checked the TC4 and TC5 code against the TC3 code (where the problem
does not occur) and it looks like the getPathInfo() call has been missed out. I
have also checked the specs and I can't see any reason why the implementation
should have changed. I also took the opportunity to remove some unused imports.
Mark
Index: catalina/src/share/org/apache/catalina/core/ApplicationHttpRequest.java
===
RCS file:
/home/cvspublic/jakarta-tomcat-catalina/catalina/src/share/org/apache/catali
na/core/ApplicationHttpRequest.java,v
retrieving revision 1.11
diff -u -r1.11 ApplicationHttpRequest.java
--- catalina/src/share/org/apache/catalina/core/ApplicationHttpRequest.java 5
Aug 2003 13:22:03 - 1.11
+++ catalina/src/share/org/apache/catalina/core/ApplicationHttpRequest.java 31
Aug 2003 18:02:06 -
@@ -70,7 +70,6 @@
import java.util.Enumeration;
import java.util.HashMap;
import java.util.Iterator;
-import java.util.Set;
import java.util.Map;
import javax.servlet.RequestDispatcher;
@@ -80,7 +79,6 @@
import org.apache.catalina.Context;
import org.apache.catalina.Globals;
-import org.apache.catalina.HttpRequest;
import org.apache.catalina.Session;
import org.apache.catalina.util.Enumerator;
import org.apache.catalina.util.RequestUtil;
@@ -343,13 +341,23 @@
if (servletPath == null)
servletPath = getServletPath();
-int pos = servletPath.lastIndexOf('/');
+// Add the path info, if there is any
+String pathInfo = getPathInfo();
+String requestPath = null;
+
+if (pathInfo == null) {
+requestPath = servletPath;
+} else {
+requestPath = servletPath + pathInfo;
+}
+
+int pos = requestPath.lastIndexOf('/');
String relative = null;
if (pos = 0) {
relative = RequestUtil.normalize
-(servletPath.substring(0, pos + 1) + path);
+(requestPath.substring(0, pos + 1) + path);
} else {
-relative = RequestUtil.normalize(servletPath + path);
+relative = RequestUtil.normalize(requestPath + path);
}
return (context.getServletContext().getRequestDispatcher(relative));
Index: catalina/src/share/org/apache/coyote/tomcat5/CoyoteRequest.java
===
RCS file:
/home/cvspublic/jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote
/tomcat5/CoyoteRequest.java,v
retrieving revision 1.14
diff -u -r1.14 CoyoteRequest.java
--- catalina/src/share/org/apache/coyote/tomcat5/CoyoteRequest.java 29 Aug 2003
17:18:14 - 1.14
+++ catalina/src/share/org/apache/coyote/tomcat5/CoyoteRequest.java 31 Aug 2003
18:01:10 -
@@ -66,17 +66,14 @@
import java.io.InputStream;
-import java.io.InputStreamReader;
import java.io.IOException;
import java.io.BufferedReader;
import java.io.UnsupportedEncodingException;
import java.net.InetAddress;
import java.net.Socket;
import java.security.Principal;
-import java.text.ParseException;
import java.text.SimpleDateFormat;
import java.util.ArrayList;
-import java.util.Date;
import java.util.Enumeration;
import java.util.HashMap;
import java.util.Iterator;
@@ -89,11 +86,8 @@
import javax.servlet.FilterChain;
import javax.servlet.RequestDispatcher;
import javax.servlet.ServletContext;
-import javax.servlet.ServletException;
import javax.servlet.ServletInputStream;
import javax.servlet.ServletRequest;
-import javax.servlet.ServletRequestEvent;
-import javax.servlet.ServletRequestListener;
import javax.servlet.ServletRequestAttributeEvent;
import javax.servlet.ServletRequestAttributeListener;
import javax.servlet.http.Cookie;
@@ -106,7 +100,6 @@
import org.apache.tomcat.util.http.FastHttpDateFormat;
import org.apache.tomcat.util.http.Parameters;
import org.apache.tomcat.util.http.mapper.MappingData;
-import org.apache.tomcat.util.net.SSLSupport;
import org.apache.coyote.ActionCode;
import org.apache.coyote.Request;
@@ -1307,13 +1300,23 @@
if (servletPath == null)
servletPath = getServletPath();
-int pos = servletPath.lastIndexOf('/');
+// Add the path info, if there is any
+String pathInfo = getPathInfo();
+String requestPath = null;
+
+if (pathInfo == null) {
+requestPath = servletPath;
+} else {
+requestPath = servletPath + pathInfo;
+}
+
+int pos = requestPath.lastIndexOf('/');
String relative = null;
if (pos = 0) {
relative = RequestUtil.normalize
-(servletPath.substring(0, pos + 1) + path);
+
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteRequest.java
remm2003/08/31 14:08:56
Modified:catalina/src/share/org/apache/catalina/core
ApplicationHttpRequest.java
catalina/src/share/org/apache/coyote/tomcat5
CoyoteRequest.java
Log:
- Include the patInfo when a relative path is used to get a request dispatcher.
- Submitted by Mark Thomas.
Revision ChangesPath
1.12 +17 -9
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationHttpRequest.java
Index: ApplicationHttpRequest.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationHttpRequest.java,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- ApplicationHttpRequest.java 5 Aug 2003 13:22:03 - 1.11
+++ ApplicationHttpRequest.java 31 Aug 2003 21:08:55 - 1.12
@@ -70,7 +70,6 @@
import java.util.Enumeration;
import java.util.HashMap;
import java.util.Iterator;
-import java.util.Set;
import java.util.Map;
import javax.servlet.RequestDispatcher;
@@ -80,7 +79,6 @@
import org.apache.catalina.Context;
import org.apache.catalina.Globals;
-import org.apache.catalina.HttpRequest;
import org.apache.catalina.Session;
import org.apache.catalina.util.Enumerator;
import org.apache.catalina.util.RequestUtil;
@@ -343,13 +341,23 @@
if (servletPath == null)
servletPath = getServletPath();
-int pos = servletPath.lastIndexOf('/');
+// Add the path info, if there is any
+String pathInfo = getPathInfo();
+String requestPath = null;
+
+if (pathInfo == null) {
+requestPath = servletPath;
+} else {
+requestPath = servletPath + pathInfo;
+}
+
+int pos = requestPath.lastIndexOf('/');
String relative = null;
if (pos = 0) {
relative = RequestUtil.normalize
-(servletPath.substring(0, pos + 1) + path);
+(requestPath.substring(0, pos + 1) + path);
} else {
-relative = RequestUtil.normalize(servletPath + path);
+relative = RequestUtil.normalize(requestPath + path);
}
return (context.getServletContext().getRequestDispatcher(relative));
1.15 +17 -14
jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteRequest.java
Index: CoyoteRequest.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteRequest.java,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -r1.14 -r1.15
--- CoyoteRequest.java29 Aug 2003 17:18:14 - 1.14
+++ CoyoteRequest.java31 Aug 2003 21:08:56 - 1.15
@@ -66,17 +66,14 @@
import java.io.InputStream;
-import java.io.InputStreamReader;
import java.io.IOException;
import java.io.BufferedReader;
import java.io.UnsupportedEncodingException;
import java.net.InetAddress;
import java.net.Socket;
import java.security.Principal;
-import java.text.ParseException;
import java.text.SimpleDateFormat;
import java.util.ArrayList;
-import java.util.Date;
import java.util.Enumeration;
import java.util.HashMap;
import java.util.Iterator;
@@ -89,11 +86,8 @@
import javax.servlet.FilterChain;
import javax.servlet.RequestDispatcher;
import javax.servlet.ServletContext;
-import javax.servlet.ServletException;
import javax.servlet.ServletInputStream;
import javax.servlet.ServletRequest;
-import javax.servlet.ServletRequestEvent;
-import javax.servlet.ServletRequestListener;
import javax.servlet.ServletRequestAttributeEvent;
import javax.servlet.ServletRequestAttributeListener;
import javax.servlet.http.Cookie;
@@ -106,7 +100,6 @@
import org.apache.tomcat.util.http.FastHttpDateFormat;
import org.apache.tomcat.util.http.Parameters;
import org.apache.tomcat.util.http.mapper.MappingData;
-import org.apache.tomcat.util.net.SSLSupport;
import org.apache.coyote.ActionCode;
import org.apache.coyote.Request;
@@ -1307,13 +1300,23 @@
if (servletPath == null)
servletPath = getServletPath();
-int pos = servletPath.lastIndexOf('/');
+// Add the path info, if there is any
+String pathInfo = getPathInfo();
+String requestPath = null;
+
+if (pathInfo == null) {
+requestPath = servletPath;
+} else {
+requestPath = servletPath + pathInfo;
+}
+
+int pos = requestPath.lastIndexOf('/');
String relative = null;
if (pos = 0) {
relative =
